René's URL Explorer Experiment


Title: Allow lifecycle hooks to be defined on a directive instance and not only on a prototype · Issue #38241 · angular/angular · GitHub

Open Graph Title: Allow lifecycle hooks to be defined on a directive instance and not only on a prototype · Issue #38241 · angular/angular

X Title: Allow lifecycle hooks to be defined on a directive instance and not only on a prototype · Issue #38241 · angular/angular

Description: We tend to get repeated requests for Angular to invoke lifecycle hooks defined on a directive / component instance (and not only ones defined on a prototype). Examples of such requests (actually, reported as bugs) would be #38043 or #380...

Open Graph Description: We tend to get repeated requests for Angular to invoke lifecycle hooks defined on a directive / component instance (and not only ones defined on a prototype). Examples of such requests (actually, r...

X Description: We tend to get repeated requests for Angular to invoke lifecycle hooks defined on a directive / component instance (and not only ones defined on a prototype). Examples of such requests (actually, r...

Opengraph URL: https://github.com/angular/angular/issues/38241

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Allow lifecycle hooks to be defined on a directive instance and not only on a prototype","articleBody":"We tend to get repeated requests for Angular to invoke lifecycle hooks defined on a directive / component instance (and not only ones defined on a prototype). Examples of such requests (actually, reported as bugs) would be #38043 or #38087 (but I'm sure that there are more as I've seen similar issues reported in the past.\r\n\r\nTo start with, the current Angular behaviour is the result of *deliberate design choices* and not a simple bug / omission that we can \"just fix\". The current design of taking lifecycle hooks from a prototype is based on the following:\r\n* performance considerations;\r\n* inheritance support.\r\n\r\n### Performance considerations\r\n\r\nAs of today Angular assumes that all directives created from a given class have the same set of lifecycle functions (taken from a prototype). This assumptions allows us to make 2 significant optimisations:\r\n* store lifecycle hooks only once for a given directive class, regardless of how many times it is instantiated (imagine a ngFor loop over hundreds of components / directives - as of today we need to store info about lifecycle hooks only one, regardless of the number of instances - if each instance could have different lifecycle hooks we would have to allocate memory for each instance, adding to GC pressure, consuming more memory and making the app slower overall);\r\n* invoke lifecycle hooks on all instances without worrying about checking if a given hook exists - basically we _know_ that all components / directives share the same set so we can iterate over all instances and call hooks, without doing any checks.\r\n\r\nThose things might sound like micr-optimisations but when you profile applications it has significant impact. Angular always worked this way as we made the assumption that the user experience (performance of a final app for the users) is more important that the developers experience here. \r\n \r\n### Inheritance\r\n\r\nWith the assumptions of a fixed set of lifecycle hooks for a directive it is easy for us to compute a new set of lifecycle hooks in the directives inheritance tree.  Again, we can do those calculations only once (per directive class), without checking each individual instance.\r\n\r\n## Possible work-arrounds \r\n\r\n@petebacondarwin [suggested](https://github.com/angular/angular/issues/38043#issuecomment-663475929) that one might work-arround the current design choices like so:\r\n\r\n```ts\r\n@Component({selector: 'app-root', template: ''})\r\nexport class AppComponent {\r\n  title = 'test-app';\r\n}\r\n\r\n(AppComponent.prototype as any).ngOnInit = () => {\r\n  console.log('init!');\r\n};\r\n```\r\n\r\nI'm opening this issue as a feature request, mostly to track interest and ideas for another implementation that wouldn't negatively impact performance. \r\n\r\n \r\n\r\n","author":{"url":"https://github.com/pkozlowski-opensource","@type":"Person","name":"pkozlowski-opensource"},"datePublished":"2020-07-27T10:27:24Z","url":"https://github.com/angular/angular/issues/38241"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:297de747-12ac-ced4-d3e1-032720ab7183
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC976:2D40DE:F6AA5C:1391194:6B014A58
html-safe-nonce95e99200f7e7acd97041b744c912ece2f095231db2dcf194393c79c4391cda04
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDOTc2OjJENDBERTpGNkFBNUM6MTM5MTE5NDo2QjAxNEE1OCIsInZpc2l0b3JfaWQiOiI0MzEyMTI3MDQ5MzUyNDMyMjE2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac9e555c84b62417cd8da6597d90699b0feb12e4d9d724324484859eef4b845cb4
hovercard-subject-tagissue:666178075
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/38241/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4ad8938a44864addae369f3655a52cc14e14154c43422330a16815f1fff93cfe/angular/angular/issues/38241
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4ad8938a44864addae369f3655a52cc14e14154c43422330a16815f1fff93cfe/angular/angular/issues/38241
og:image:altWe tend to get repeated requests for Angular to invoke lifecycle hooks defined on a directive / component instance (and not only ones defined on a prototype). Examples of such requests (actually, r...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamepkozlowski-opensource
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/38241#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38241
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38241
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/38241
Reloadhttps://github.com/angular/angular/issues/38241
Reloadhttps://github.com/angular/angular/issues/38241
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38241
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38241
Allow lifecycle hooks to be defined on a directive instance and not only on a prototypehttps://github.com/angular/angular/issues/38241#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Jul 27, 2020https://github.com/angular/angular/issues/38241#issue-666178075
#38043https://github.com/angular/angular/issues/38043
#38087https://github.com/angular/angular/issues/38087
@petebacondarwinhttps://github.com/petebacondarwin
suggestedhttps://github.com/angular/angular/issues/38043#issuecomment-663475929
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
on Jul 27, 2020https://github.com/angular/angular/issues/38241#event-3589194439
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jul 27, 2020https://github.com/angular/angular/issues/38241#event-3589194572
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Jul 27, 2020https://github.com/angular/angular/issues/38241#issuecomment-664602026
https://github.com/VagrantAI-c
VagrantAI-chttps://github.com/VagrantAI-c
on Aug 20, 2020https://github.com/angular/angular/issues/38241#issuecomment-677458582
atscotthttps://github.com/atscott
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Oct 19, 2020https://github.com/angular/angular/issues/38241#event-3894804152
https://github.com/arturovt
arturovthttps://github.com/arturovt
on Sep 29, 2026https://github.com/angular/angular/issues/38241#issuecomment-5899540606
@JeanMechehttps://github.com/JeanMeche
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/38241
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/38241
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.