Title: Arrow-style ngOnDestroy not called · Issue #38087 · angular/angular · GitHub
Open Graph Title: Arrow-style ngOnDestroy not called · Issue #38087 · angular/angular
X Title: Arrow-style ngOnDestroy not called · Issue #38087 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If ngOnDestroy is called like this: ngOnDestroy(...
Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If ngOnD...
X Description: 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If n...
Opengraph URL: https://github.com/angular/angular/issues/38087
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Arrow-style ngOnDestroy not called","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nThe issue is caused by package @angular/core\r\n\r\n\r\n### Is this a regression?\r\n\r\nNo\r\n\r\n\r\n### Description\r\n\r\nI'm looking for feedback on this issue as much as reporting a potential bug.\r\nIf ngOnDestroy is called like this:\r\n`ngOnDestroy() { [some code] }`\r\nThen it works as expected. If ngOnDestroy is called like this:\r\n`ngOnDestroy = () => [some code]`\r\nThen it is not called.\r\n\r\nNote that the Typescript linter is actually okay with either style, even though the interface uses:\r\n`ngOnDestroy(): void`\r\n\r\nIf you're like me, you would assume that an arrow style function can be used for a lifecycle hook without actually trying it. The issue would be undetectable until you notice that the hook isn't working.\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://stackblitz.com/edit/whynoarrowstyle\r\nTwo components meet in the woods, one using an arrow style function, and one not using that function type. Click 'Destroy the below'. Notice that the code written in ngOnDestroy is called for the funcStyleComponent, but not the arrowStyleComponent.\r\n\r\n## 🔥 Exception or Error\r\nNo error, more just looking for an explanation of the existing behavior, and whether more can be done to make it clear that using arrow style functions as lifecycle hooks will be invisibly undetectable.\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\r\n _ _ ____ _ ___ \r\n / \\ _ __ __ _ _ _| | __ _ _ __ / ___| | |_ _|\r\n / △ \\ | '_ \\ / _` | | | | |/ _` | '__| | | | | | |\r\n / ___ \\| | | | (_| | |_| | | (_| | | | |___| |___ | |\r\n /_/ \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_| \\____|_____|___|\r\n |___/\r\n \r\n\r\nAngular CLI: 9.1.7\r\nNode: 12.13.1\r\nOS: win32 x64\r\n\r\nAngular: 9.1.9\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.901.7\r\n@angular-devkit/build-angular 0.901.7\r\n@angular-devkit/build-optimizer 0.901.7\r\n@angular-devkit/build-webpack 0.901.7\r\n@angular-devkit/core 9.1.7\r\n@angular-devkit/schematics 9.1.7\r\n@angular/cli 9.1.7\r\n@angular/fire 6.0.0\r\n@ngtools/webpack 9.1.7\r\n@schematics/angular 9.1.7\r\n@schematics/update 0.901.7\r\nrxjs 6.5.5\r\ntypescript 3.8.3\r\nwebpack 4.42.0\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nngOnDestroy is often used to unsubscribe, and its code can often be reduced to one line. If lifecycle hooks were expressible as arrow style functions, then we could express it in one line, like so:\r\n`ngOnDestroy = () => this.subscriptions.unsubscribe();`\r\n(Granted, you can say the same thing using classic functions as `ngOnDestroy() { this.subscriptions.unsubscribe; }`, but formatters love to break that into multiple lines.)\r\n","author":{"url":"https://github.com/jzabinski","@type":"Person","name":"jzabinski"},"datePublished":"2020-07-15T21:50:02Z","url":"https://github.com/angular/angular/issues/38087"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c373c89f-06fb-bf49-07fe-cd5b9126857b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 808A:D5AA4:1A8A722:2358334:6B014D89 |
| html-safe-nonce | 9c2c8513ddd19f0997260ba0517b250f01bb664e8b753a23f75fc76c95920e02 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDhBOkQ1QUE0OjFBOEE3MjI6MjM1ODMzNDo2QjAxNEQ4OSIsInZpc2l0b3JfaWQiOiI4NjMyMDkwMDgwMDU3NTc2ODQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 05fec2de448f7669bf42902190780a9de10dbad9a921e685210c49c9fd94e7d6 |
| hovercard-subject-tag | issue:657681870 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/38087/issue_layout |
| twitter:image | https://opengraph.githubassets.com/069c4157a1e06213624b5573464499b63c9b5c06a85c246414ffe6c2abae0376/angular/angular/issues/38087 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/069c4157a1e06213624b5573464499b63c9b5c06a85c246414ffe6c2abae0376/angular/angular/issues/38087 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If ngOnD... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jzabinski |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width