René's URL Explorer Experiment


Title: Arrow-style ngOnDestroy not called · Issue #38087 · angular/angular · GitHub

Open Graph Title: Arrow-style ngOnDestroy not called · Issue #38087 · angular/angular

X Title: Arrow-style ngOnDestroy not called · Issue #38087 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If ngOnDestroy is called like this: ngOnDestroy(...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If ngOnD...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If n...

Opengraph URL: https://github.com/angular/angular/issues/38087

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Arrow-style ngOnDestroy not called","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nThe issue is caused by package @angular/core\r\n\r\n\r\n### Is this a regression?\r\n\r\nNo\r\n\r\n\r\n### Description\r\n\r\nI'm looking for feedback on this issue as much as reporting a potential bug.\r\nIf ngOnDestroy is called like this:\r\n`ngOnDestroy() { [some code] }`\r\nThen it works as expected. If ngOnDestroy is called like this:\r\n`ngOnDestroy = () => [some code]`\r\nThen it is not called.\r\n\r\nNote that the Typescript linter is actually okay with either style, even though the interface uses:\r\n`ngOnDestroy(): void`\r\n\r\nIf you're like me, you would assume that an arrow style function can be used for a lifecycle hook without actually trying it. The issue would be undetectable until you notice that the hook isn't working.\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://stackblitz.com/edit/whynoarrowstyle\r\nTwo components meet in the woods, one using an arrow style function, and one not using that function type. Click 'Destroy the below'. Notice that the code written in ngOnDestroy is called for the funcStyleComponent, but not the arrowStyleComponent.\r\n\r\n## 🔥 Exception or Error\r\nNo error, more just looking for an explanation of the existing behavior, and whether more can be done to make it clear that using arrow style functions as lifecycle hooks will be invisibly undetectable.\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\r\n     _                      _                 ____ _     ___ \r\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\r\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\r\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\r\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\r\n                |___/\r\n    \r\n\r\nAngular CLI: 9.1.7\r\nNode: 12.13.1\r\nOS: win32 x64\r\n\r\nAngular: 9.1.9\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.901.7\r\n@angular-devkit/build-angular     0.901.7\r\n@angular-devkit/build-optimizer   0.901.7\r\n@angular-devkit/build-webpack     0.901.7\r\n@angular-devkit/core              9.1.7\r\n@angular-devkit/schematics        9.1.7\r\n@angular/cli                      9.1.7\r\n@angular/fire                     6.0.0\r\n@ngtools/webpack                  9.1.7\r\n@schematics/angular               9.1.7\r\n@schematics/update                0.901.7\r\nrxjs                              6.5.5\r\ntypescript                        3.8.3\r\nwebpack                           4.42.0\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nngOnDestroy is often used to unsubscribe, and its code can often be reduced to one line. If lifecycle hooks were expressible as arrow style functions, then we could express it in one line, like so:\r\n`ngOnDestroy = () => this.subscriptions.unsubscribe();`\r\n(Granted, you can say the same thing using classic functions as `ngOnDestroy() { this.subscriptions.unsubscribe; }`, but formatters love to break that into multiple lines.)\r\n","author":{"url":"https://github.com/jzabinski","@type":"Person","name":"jzabinski"},"datePublished":"2020-07-15T21:50:02Z","url":"https://github.com/angular/angular/issues/38087"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c373c89f-06fb-bf49-07fe-cd5b9126857b
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id808A:D5AA4:1A8A722:2358334:6B014D89
html-safe-nonce9c2c8513ddd19f0997260ba0517b250f01bb664e8b753a23f75fc76c95920e02
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4MDhBOkQ1QUE0OjFBOEE3MjI6MjM1ODMzNDo2QjAxNEQ4OSIsInZpc2l0b3JfaWQiOiI4NjMyMDkwMDgwMDU3NTc2ODQxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac05fec2de448f7669bf42902190780a9de10dbad9a921e685210c49c9fd94e7d6
hovercard-subject-tagissue:657681870
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/38087/issue_layout
twitter:imagehttps://opengraph.githubassets.com/069c4157a1e06213624b5573464499b63c9b5c06a85c246414ffe6c2abae0376/angular/angular/issues/38087
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/069c4157a1e06213624b5573464499b63c9b5c06a85c246414ffe6c2abae0376/angular/angular/issues/38087
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/core Is this a regression? No Description I'm looking for feedback on this issue as much as reporting a potential bug. If ngOnD...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejzabinski
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/38087#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38087
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F38087
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/38087
Reloadhttps://github.com/angular/angular/issues/38087
Reloadhttps://github.com/angular/angular/issues/38087
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38087
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/38087
Arrow-style ngOnDestroy not calledhttps://github.com/angular/angular/issues/38087#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/jzabinski
jzabinskihttps://github.com/jzabinski
on Jul 15, 2020https://github.com/angular/angular/issues/38087#issue-657681870
https://stackblitz.com/edit/whynoarrowstylehttps://stackblitz.com/edit/whynoarrowstyle
AndrewKushnirhttps://github.com/AndrewKushnir
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Jul 15, 2020https://github.com/angular/angular/issues/38087#event-3550774337
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jul 15, 2020https://github.com/angular/angular/issues/38087#event-3550774392
https://github.com/Airblader
Airbladerhttps://github.com/Airblader
on Jul 16, 2020https://github.com/angular/angular/issues/38087#issuecomment-659235021
#38043https://github.com/angular/angular/issues/38043
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
on Jul 16, 2020https://github.com/angular/angular/issues/38087#event-3552152270
https://github.com/spock123
spock123https://github.com/spock123
on Jul 17, 2020https://github.com/angular/angular/issues/38087#issuecomment-660103695
@jzabinskihttps://github.com/jzabinski
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on Jul 27, 2020https://github.com/angular/angular/issues/38087#issuecomment-664284275
#38043https://github.com/angular/angular/issues/38043
@Airbladerhttps://github.com/Airblader
#38241https://github.com/angular/angular/issues/38241
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 27, 2020https://github.com/angular/angular/issues/38087#event-3589200903
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 27, 2020https://github.com/angular/angular/issues/38087#issuecomment-682049612
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 27, 2020https://github.com/angular/angular/issues/38087#event-3700421184
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/38087
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/38087
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.