René's URL Explorer Experiment


Title: Forms: refactor common validators used in unit tests and extract them to util file · Issue #37831 · angular/angular · GitHub

Open Graph Title: Forms: refactor common validators used in unit tests and extract them to util file · Issue #37831 · angular/angular

X Title: Forms: refactor common validators used in unit tests and extract them to util file · Issue #37831 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactoring around async validators in forms unit ...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactorin...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactorin...

Opengraph URL: https://github.com/angular/angular/issues/37831

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Forms: refactor common validators used in unit tests and extract them to util file","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/forms\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nNo, this is a refactor of the existing unit tests\r\n\r\n\r\n### Description\r\nFollowing https://github.com/angular/angular/pull/22575 , further refactoring around async validators in `forms` unit tests were suggested by @AndrewKushnir \r\nhttps://github.com/angular/angular/pull/22575#issuecomment-650664473\r\n\r\n> I was thinking if we can extract common validators code into a new `packages/forms/test/util.ts` file (we can store more functions there later). Some validators that are used across many tests (may be you can find more):\r\n> \r\n> * function asyncValidator\r\n> * function asyncValidatorReturningObservable\r\n> * may be `simpleAsyncValidator` added in this test can use some common code from `asyncValidator`\r\n> * I also see a value of moving the `currentStateOf` function (added in this PR) into the `util.ts` file, so we can reuse it for other validators-related tests in other files\r\n\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nN/A\r\n\r\n## 🔥 Exception or Error\r\nN/A\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n`master` branch\r\n\r\n**Anything else relevant?**\r\nNo","author":{"url":"https://github.com/benbraou","@type":"Person","name":"benbraou"},"datePublished":"2020-06-29T19:51:53Z","url":"https://github.com/angular/angular/issues/37831"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:d32756e9-6ee0-e32c-f92c-87b6d2c4c64d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idD380:1D86C4:1C04E5B:23901D2:6B0155CB
html-safe-nonce8fa224bac4f0d63b9113aebeec0116bc37d5eae00a2865a7b3f95deb5ee951d9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzgwOjFEODZDNDoxQzA0RTVCOjIzOTAxRDI6NkIwMTU1Q0IiLCJ2aXNpdG9yX2lkIjoiNDkxNDg0NTg0NDQyOTE2NjAyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca6a668bfa85f81be6ebd9c9a1573f27603448c11818a69875e4cd9b3a610e27d
hovercard-subject-tagissue:647623352
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37831/issue_layout
twitter:imagehttps://opengraph.githubassets.com/15f2e676d6620c08692abbdc8781ca21f5f68aa474243b206a2366d912a06486/angular/angular/issues/37831
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/15f2e676d6620c08692abbdc8781ca21f5f68aa474243b206a2366d912a06486/angular/angular/issues/37831
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactorin...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebenbraou
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/37831#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37831
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37831
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/37831
Reloadhttps://github.com/angular/angular/issues/37831
Reloadhttps://github.com/angular/angular/issues/37831
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37831
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37831
Forms: refactor common validators used in unit tests and extract them to util filehttps://github.com/angular/angular/issues/37831#top
https://github.com/benbraou
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/benbraou
benbraouhttps://github.com/benbraou
on Jun 29, 2020https://github.com/angular/angular/issues/37831#issue-647623352
#22575https://github.com/angular/angular/pull/22575
@AndrewKushnirhttps://github.com/AndrewKushnir
#22575 (comment)https://github.com/angular/angular/pull/22575#issuecomment-650664473
https://github.com/benbraou
benbraouhttps://github.com/benbraou
on Jun 29, 2020https://github.com/angular/angular/issues/37831#issuecomment-651325181
@AndrewKushnirhttps://github.com/AndrewKushnir
#22575 (comment)https://github.com/angular/angular/pull/22575#issuecomment-649779853
AndrewKushnirhttps://github.com/AndrewKushnir
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
on Jun 29, 2020https://github.com/angular/angular/issues/37831#event-3494280256
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jun 29, 2020https://github.com/angular/angular/issues/37831#event-3494280350
AndrewKushnirhttps://github.com/AndrewKushnir
benbraouhttps://github.com/benbraou
on Jun 29, 2020https://github.com/angular/angular/issues/37831#event-3494281282
benbraouhttps://github.com/benbraou
on Jul 22, 2020https://github.com/angular/angular/issues/37831#event-3576923653
refactor(forms): refactor common validators used in unit testshttps://github.com/benbraou/angular/commit/78ad78da79db42ff338fa481f4ca5325062faf90
https://docs.github.com/articles/closing-issues-via-commit-messages
78ad78dhttps://github.com/benbraou/angular/commit/78ad78da79db42ff338fa481f4ca5325062faf90
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
062b8d9https://github.com/angular/angular/commit/062b8d90afaf60e0066568d64188ca074001986f
on Jul 23, 2020https://github.com/angular/angular/issues/37831#event-3578319582
mheveryhttps://github.com/mhevery
on Jul 23, 2020https://github.com/angular/angular/issues/37831#event-3578328983
refactor(forms): refactor common validators used in unit tests (angul…https://github.com/mhevery/angular/commit/a94cade595e1c99d39985bfda7256238ec91340c
angul…https://github.com/angular/angular/pull/38020
https://docs.github.com/articles/closing-issues-via-commit-messages
a94cadehttps://github.com/mhevery/angular/commit/a94cade595e1c99d39985bfda7256238ec91340c
Splaktarhttps://github.com/Splaktar
on Aug 8, 2020https://github.com/angular/angular/issues/37831#event-3635258219
refactor(forms): refactor common validators used in unit tests (angul…https://github.com/angular-hispano/angular/commit/8a05f311b97d4f06c0f99b22f7e43a9d219af6c8
angul…https://github.com/angular/angular/pull/38020
https://docs.github.com/articles/closing-issues-via-commit-messages
8a05f31https://github.com/angular-hispano/angular/commit/8a05f311b97d4f06c0f99b22f7e43a9d219af6c8
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 23, 2020https://github.com/angular/angular/issues/37831#issuecomment-678793660
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 23, 2020https://github.com/angular/angular/issues/37831#event-3682946741
profanishttps://github.com/profanis
on Sep 5, 2020https://github.com/angular/angular/issues/37831#event-3732916601
refactor(forms): refactor common validators used in unit tests (angul…https://github.com/profanis/angular/commit/ddbd1a5df92c3aa5f9604267139a1b74df7ef55f
angul…https://github.com/angular/angular/pull/38020
https://docs.github.com/articles/closing-issues-via-commit-messages
ddbd1a5https://github.com/profanis/angular/commit/ddbd1a5df92c3aa5f9604267139a1b74df7ef55f
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/37831
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/37831
benbraouhttps://github.com/benbraou
area: formshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20forms%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.