Title: Forms: refactor common validators used in unit tests and extract them to util file · Issue #37831 · angular/angular · GitHub
Open Graph Title: Forms: refactor common validators used in unit tests and extract them to util file · Issue #37831 · angular/angular
X Title: Forms: refactor common validators used in unit tests and extract them to util file · Issue #37831 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactoring around async validators in forms unit ...
Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactorin...
X Description: 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactorin...
Opengraph URL: https://github.com/angular/angular/issues/37831
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Forms: refactor common validators used in unit tests and extract them to util file","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/forms\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nNo, this is a refactor of the existing unit tests\r\n\r\n\r\n### Description\r\nFollowing https://github.com/angular/angular/pull/22575 , further refactoring around async validators in `forms` unit tests were suggested by @AndrewKushnir \r\nhttps://github.com/angular/angular/pull/22575#issuecomment-650664473\r\n\r\n> I was thinking if we can extract common validators code into a new `packages/forms/test/util.ts` file (we can store more functions there later). Some validators that are used across many tests (may be you can find more):\r\n> \r\n> * function asyncValidator\r\n> * function asyncValidatorReturningObservable\r\n> * may be `simpleAsyncValidator` added in this test can use some common code from `asyncValidator`\r\n> * I also see a value of moving the `currentStateOf` function (added in this PR) into the `util.ts` file, so we can reuse it for other validators-related tests in other files\r\n\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nN/A\r\n\r\n## 🔥 Exception or Error\r\nN/A\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n`master` branch\r\n\r\n**Anything else relevant?**\r\nNo","author":{"url":"https://github.com/benbraou","@type":"Person","name":"benbraou"},"datePublished":"2020-06-29T19:51:53Z","url":"https://github.com/angular/angular/issues/37831"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:d32756e9-6ee0-e32c-f92c-87b6d2c4c64d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D380:1D86C4:1C04E5B:23901D2:6B0155CB |
| html-safe-nonce | 8fa224bac4f0d63b9113aebeec0116bc37d5eae00a2865a7b3f95deb5ee951d9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMzgwOjFEODZDNDoxQzA0RTVCOjIzOTAxRDI6NkIwMTU1Q0IiLCJ2aXNpdG9yX2lkIjoiNDkxNDg0NTg0NDQyOTE2NjAyNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | a6a668bfa85f81be6ebd9c9a1573f27603448c11818a69875e4cd9b3a610e27d |
| hovercard-subject-tag | issue:647623352 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37831/issue_layout |
| twitter:image | https://opengraph.githubassets.com/15f2e676d6620c08692abbdc8781ca21f5f68aa474243b206a2366d912a06486/angular/angular/issues/37831 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/15f2e676d6620c08692abbdc8781ca21f5f68aa474243b206a2366d912a06486/angular/angular/issues/37831 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by package @angular/forms Is this a regression? No, this is a refactor of the existing unit tests Description Following #22575 , further refactorin... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | benbraou |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width