Title: Library decorator metadata ReferenceError with SSR · Issue #37472 · angular/angular · GitHub
Open Graph Title: Library decorator metadata ReferenceError with SSR · Issue #37472 · angular/angular
X Title: Library decorator metadata ReferenceError with SSR · Issue #37472 · angular/angular
Description: 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reproduce the same behavior with a clean works...
Open Graph Description: 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reprod...
X Description: 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reprod...
Opengraph URL: https://github.com/angular/angular/issues/37472
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Library decorator metadata ReferenceError with SSR","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nI suspect `@angular/compiler-cli`. But it might also affect `@angular/compiler`, `ng-packagr` or `@angular-devkit/build-ng-packagr`.\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nYes, I cannot reproduce the same behavior with a clean workspace created with `@angular/cli` version 8.0.2\r\n\r\n\r\n### Description\r\n\r\nThere is an open issue #30586 and a related PR #37382 that describe the error I am facing very well. However, if I am reading those descriptions correctly, that issue should not occur when using the CLI or `ng-packagr`. Please see https://github.com/angular/angular/issues/30586#issue-446511402:\r\n\r\n> Everything currently works as expected within the CLI [...]\r\n\r\nand https://github.com/angular/angular/issues/30586#issuecomment-591336925:\r\n\r\n> In the current state, where libraries still publish in View Engine, the CLI, ng-packagr, and angular/components have custom tooling that fix this issue [...]\r\n\r\nIn my case the error does happen with a published View Engine library and SSR, so I wanted to make you aware that there might be an additional issue. This could also be already fixed in an upcoming patch (see https://github.com/angular/angular/pull/37382#issuecomment-637854045), if I am not reading too much into the part about re-enabling tsickle.\r\n\r\nAs mentioned in the linked issue https://github.com/angular/angular/issues/30586#issuecomment-494898597, this only happens when `emitDecoratorMetadata` is enabled. Also, when building the library the compiler throws an error with `strictMetadataEmit` enabled. With the current library schematic you have to change both defaults to reproduce the runtime error.\r\n\r\nThe mentioned defaults are in place since https://github.com/angular/angular-cli/commit/6b28d3ac51f226f6f7fc6065de9d5f2db72302d1 for `emitDecoratorMetadata` and at least since https://github.com/angular/angular-cli/commit/44086c60ff1d6c26d30850bef125120f6c498ac1#diff-5c9bd7887460d6be81e59d58f93ec849 for `strictMetadataEmit`.\r\n\r\nI don't know how common the use cases for enabling `emitDecoratorMetadata` in the current state are or how many older libraries just never changed this option, so I am not sure how common this issue is. I got here via https://github.com/manfredsteyer/angular-oauth2-oidc/issues/773, but I don't know of other popular libraries having the same problem.\r\n\r\nIf documentation of the issue makes more sense than supporting this in version 9, I am happy to provide a PR for the docs.\r\n\r\nPlease feel free to close this issue, if I am only telling you things you already know :slightly_smiling_face:\r\n\r\n## 🔬 Minimal Reproduction \r\nSee [Repo](https://github.com/JohannesHuster/decorator-metadata-error). I have added the dist folder, in case you don't even need to pull the repo that way.\r\n\r\n- `ng build my-lib --prod`\r\n- `ng run my-app:serve-ssr` (Same behavior with `-c production`)\r\n\r\n#### Reproduction of the repo above\r\n\r\n- `ng new my-workspace`\r\n- `ng g library my-lib`\r\n- `ng g application my-app`\r\n- `ng add @nguniversal/express-engine --clientProject my-app`\r\n- Apply something like https://github.com/JohannesHuster/decorator-metadata-error/commit/713fc1e46225cbb4b74759a6308e40c9f25ad43a\r\n- Apply https://github.com/JohannesHuster/decorator-metadata-error/commit/3d6ad423d66476aa0b4233bc2b7b7a1147d0ebd9\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\n.../dist/my-app/server/main.js:140435\r\n Object(tslib__WEBPACK_IMPORTED_MODULE_0__[\"__metadata\"])(\"design:paramtypes\", [Document])\r\n ^\r\n\r\nReferenceError: Document is not defined\r\n at Module.../../node_modules/my-lib-published/__ivy_ngcc__/fesm2015/my-lib.js (.../dist/my-app/server/main.js:140435:84)\r\n at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n at Object../src/app/app.component.ts (.../dist/my-app/server/main.js:161543:12)\r\n at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n at Object../src/app/app.module.ts (.../dist/my-app/server/main.js:161909:25)\r\n at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n at Object../src/app/app.server.module.ts (.../dist/my-app/server/main.js:161949:22)\r\n at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n at Object../src/main.server.ts (.../dist/my-app/server/main.js:162019:27)\r\n at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n\r\nA server error has occurred.\r\nnode exited with 1 code.\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.1.7\r\nNode: 12.16.1\r\nOS: darwin x64\r\n\r\nAngular: 9.1.9\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... platform-browser, platform-browser-dynamic, platform-server\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect 0.901.7\r\n@angular-devkit/build-angular 0.901.7\r\n@angular-devkit/build-ng-packagr 0.901.7\r\n@angular-devkit/build-optimizer 0.901.7\r\n@angular-devkit/build-webpack 0.901.7\r\n@angular-devkit/core 9.1.7\r\n@angular-devkit/schematics 9.1.7\r\n@angular/cli 9.1.7\r\n@ngtools/webpack 9.1.7\r\n@nguniversal/builders 9.1.1\r\n@nguniversal/common 9.1.1\r\n@nguniversal/express-engine 9.1.1\r\n@schematics/angular 9.1.7\r\n@schematics/update 0.901.7\r\nng-packagr 9.1.5\r\nrxjs 6.5.5\r\ntypescript 3.8.3\r\nwebpack 4.42.0\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n\r\nThank you for the great work!","author":{"url":"https://github.com/JohannesHuster","@type":"Person","name":"JohannesHuster"},"datePublished":"2020-06-06T15:51:12Z","url":"https://github.com/angular/angular/issues/37472"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c1b49ba3-0821-908a-e821-fae2ec5db40a |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B500:785A9:274B53F:31D97DF:6B0196D0 |
| html-safe-nonce | 58fdf0b199c20d50a4aa70ef20567fce9eece4d839e4adb0ca19a0fcb63fed3a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTAwOjc4NUE5OjI3NEI1M0Y6MzFEOTdERjo2QjAxOTZEMCIsInZpc2l0b3JfaWQiOiI2MzM5MTUyNjQ4NzA0NDY0NTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 0200433c98e76431527d9cd7279af9ce2e39a216b00d8cb0b26baccf33f37d27 |
| hovercard-subject-tag | issue:632547178 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37472/issue_layout |
| twitter:image | https://opengraph.githubassets.com/960735fb442cad78b5f29d6c7a3106488e359cf7cb16e7826f57697d7be33853/angular/angular/issues/37472 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/960735fb442cad78b5f29d6c7a3106488e359cf7cb16e7826f57697d7be33853/angular/angular/issues/37472 |
| og:image:alt | 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reprod... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | JohannesHuster |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width