René's URL Explorer Experiment


Title: Library decorator metadata ReferenceError with SSR · Issue #37472 · angular/angular · GitHub

Open Graph Title: Library decorator metadata ReferenceError with SSR · Issue #37472 · angular/angular

X Title: Library decorator metadata ReferenceError with SSR · Issue #37472 · angular/angular

Description: 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reproduce the same behavior with a clean works...

Open Graph Description: 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reprod...

X Description: 🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reprod...

Opengraph URL: https://github.com/angular/angular/issues/37472

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Library decorator metadata ReferenceError with SSR","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nI suspect `@angular/compiler-cli`. But it might also affect `@angular/compiler`, `ng-packagr` or `@angular-devkit/build-ng-packagr`.\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nYes, I cannot reproduce the same behavior with a clean workspace created with `@angular/cli` version 8.0.2\r\n\r\n\r\n### Description\r\n\r\nThere is an open issue #30586 and a related PR #37382 that describe the error I am facing very well. However, if I am reading those descriptions correctly, that issue should not occur when using the CLI or `ng-packagr`. Please see https://github.com/angular/angular/issues/30586#issue-446511402:\r\n\r\n> Everything currently works as expected within the CLI [...]\r\n\r\nand https://github.com/angular/angular/issues/30586#issuecomment-591336925:\r\n\r\n> In the current state, where libraries still publish in View Engine, the CLI, ng-packagr, and angular/components have custom tooling that fix this issue [...]\r\n\r\nIn my case the error does happen with a published View Engine library and SSR, so I wanted to make you aware that there might be an additional issue. This could also be already fixed in an upcoming patch (see https://github.com/angular/angular/pull/37382#issuecomment-637854045), if I am not reading too much into the part about re-enabling tsickle.\r\n\r\nAs mentioned in the linked issue https://github.com/angular/angular/issues/30586#issuecomment-494898597, this only happens when `emitDecoratorMetadata` is enabled. Also, when building the library the compiler throws an error with `strictMetadataEmit` enabled. With the current library schematic you have to change both defaults to reproduce the runtime error.\r\n\r\nThe mentioned defaults are in place since https://github.com/angular/angular-cli/commit/6b28d3ac51f226f6f7fc6065de9d5f2db72302d1 for `emitDecoratorMetadata` and at least since https://github.com/angular/angular-cli/commit/44086c60ff1d6c26d30850bef125120f6c498ac1#diff-5c9bd7887460d6be81e59d58f93ec849 for `strictMetadataEmit`.\r\n\r\nI don't know how common the use cases for enabling `emitDecoratorMetadata` in the current state are or how many older libraries just never changed this option, so I am not sure how common this issue is. I got here via https://github.com/manfredsteyer/angular-oauth2-oidc/issues/773, but I don't know of other popular libraries having the same problem.\r\n\r\nIf documentation of the issue makes more sense than supporting this in version 9, I am happy to provide a PR for the docs.\r\n\r\nPlease feel free to close this issue, if I am only telling you things you already know :slightly_smiling_face:\r\n\r\n## 🔬 Minimal Reproduction \r\nSee [Repo](https://github.com/JohannesHuster/decorator-metadata-error). I have added the dist folder, in case you don't even need to pull the repo that way.\r\n\r\n- `ng build my-lib --prod`\r\n- `ng run my-app:serve-ssr` (Same behavior with `-c production`)\r\n\r\n#### Reproduction of the repo above\r\n\r\n- `ng new my-workspace`\r\n- `ng g library my-lib`\r\n- `ng g application my-app`\r\n- `ng add @nguniversal/express-engine --clientProject my-app`\r\n- Apply something like https://github.com/JohannesHuster/decorator-metadata-error/commit/713fc1e46225cbb4b74759a6308e40c9f25ad43a\r\n- Apply https://github.com/JohannesHuster/decorator-metadata-error/commit/3d6ad423d66476aa0b4233bc2b7b7a1147d0ebd9\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\n.../dist/my-app/server/main.js:140435\r\n    Object(tslib__WEBPACK_IMPORTED_MODULE_0__[\"__metadata\"])(\"design:paramtypes\", [Document])\r\n                                                                                   ^\r\n\r\nReferenceError: Document is not defined\r\n    at Module.../../node_modules/my-lib-published/__ivy_ngcc__/fesm2015/my-lib.js (.../dist/my-app/server/main.js:140435:84)\r\n    at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n    at Object../src/app/app.component.ts (.../dist/my-app/server/main.js:161543:12)\r\n    at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n    at Object../src/app/app.module.ts (.../dist/my-app/server/main.js:161909:25)\r\n    at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n    at Object../src/app/app.server.module.ts (.../dist/my-app/server/main.js:161949:22)\r\n    at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n    at Object../src/main.server.ts (.../dist/my-app/server/main.js:162019:27)\r\n    at __webpack_require__ (.../dist/my-app/server/main.js:20:30)\r\n\r\nA server error has occurred.\r\nnode exited with 1 code.\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.1.7\r\nNode: 12.16.1\r\nOS: darwin x64\r\n\r\nAngular: 9.1.9\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... platform-browser, platform-browser-dynamic, platform-server\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                            Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect          0.901.7\r\n@angular-devkit/build-angular      0.901.7\r\n@angular-devkit/build-ng-packagr   0.901.7\r\n@angular-devkit/build-optimizer    0.901.7\r\n@angular-devkit/build-webpack      0.901.7\r\n@angular-devkit/core               9.1.7\r\n@angular-devkit/schematics         9.1.7\r\n@angular/cli                       9.1.7\r\n@ngtools/webpack                   9.1.7\r\n@nguniversal/builders              9.1.1\r\n@nguniversal/common                9.1.1\r\n@nguniversal/express-engine        9.1.1\r\n@schematics/angular                9.1.7\r\n@schematics/update                 0.901.7\r\nng-packagr                         9.1.5\r\nrxjs                               6.5.5\r\ntypescript                         3.8.3\r\nwebpack                            4.42.0\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n\r\nThank you for the great work!","author":{"url":"https://github.com/JohannesHuster","@type":"Person","name":"JohannesHuster"},"datePublished":"2020-06-06T15:51:12Z","url":"https://github.com/angular/angular/issues/37472"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c1b49ba3-0821-908a-e821-fae2ec5db40a
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB500:785A9:274B53F:31D97DF:6B0196D0
html-safe-nonce58fdf0b199c20d50a4aa70ef20567fce9eece4d839e4adb0ca19a0fcb63fed3a
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTAwOjc4NUE5OjI3NEI1M0Y6MzFEOTdERjo2QjAxOTZEMCIsInZpc2l0b3JfaWQiOiI2MzM5MTUyNjQ4NzA0NDY0NTkzIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac0200433c98e76431527d9cd7279af9ce2e39a216b00d8cb0b26baccf33f37d27
hovercard-subject-tagissue:632547178
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37472/issue_layout
twitter:imagehttps://opengraph.githubassets.com/960735fb442cad78b5f29d6c7a3106488e359cf7cb16e7826f57697d7be33853/angular/angular/issues/37472
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/960735fb442cad78b5f29d6c7a3106488e359cf7cb16e7826f57697d7be33853/angular/angular/issues/37472
og:image:alt🐞 bug report Affected Package I suspect @angular/compiler-cli. But it might also affect @angular/compiler, ng-packagr or @angular-devkit/build-ng-packagr. Is this a regression? Yes, I cannot reprod...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameJohannesHuster
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/37472#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37472
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37472
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/37472
Reloadhttps://github.com/angular/angular/issues/37472
Reloadhttps://github.com/angular/angular/issues/37472
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37472
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37472
Library decorator metadata ReferenceError with SSRhttps://github.com/angular/angular/issues/37472#top
https://github.com/devversion
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/JohannesHuster
JohannesHusterhttps://github.com/JohannesHuster
on Jun 6, 2020https://github.com/angular/angular/issues/37472#issue-632547178
#30586https://github.com/angular/angular/issues/30586
#37382https://github.com/angular/angular/pull/37382
#30586 (comment)https://github.com/angular/angular/issues/30586#issue-446511402
#30586 (comment)https://github.com/angular/angular/issues/30586#issuecomment-591336925
#37382 (comment)https://github.com/angular/angular/pull/37382#issuecomment-637854045
#30586 (comment)https://github.com/angular/angular/issues/30586#issuecomment-494898597
angular/angular-cli@6b28d3ahttps://github.com/angular/angular-cli/commit/6b28d3ac51f226f6f7fc6065de9d5f2db72302d1
angular/angular-cli@44086c6#diff-5c9bd7887460d6be81e59d58f93ec849https://github.com/angular/angular-cli/commit/44086c60ff1d6c26d30850bef125120f6c498ac1#diff-5c9bd7887460d6be81e59d58f93ec849
manfredsteyer/angular-oauth2-oidc#773https://github.com/manfredsteyer/angular-oauth2-oidc/issues/773
Repohttps://github.com/JohannesHuster/decorator-metadata-error
JohannesHuster/decorator-metadata-error@713fc1ehttps://github.com/JohannesHuster/decorator-metadata-error/commit/713fc1e46225cbb4b74759a6308e40c9f25ad43a
JohannesHuster/decorator-metadata-error@3d6ad42https://github.com/JohannesHuster/decorator-metadata-error/commit/3d6ad423d66476aa0b4233bc2b7b7a1147d0ebd9
https://github.com/devversion
devversionhttps://github.com/devversion
on Jun 6, 2020https://github.com/angular/angular/issues/37472#issuecomment-640090015
@JohannesHusterhttps://github.com/JohannesHuster
#37382https://github.com/angular/angular/pull/37382
devversionhttps://github.com/devversion
on Jun 6, 2020https://github.com/angular/angular/issues/37472#event-3415024952
devversionhttps://github.com/devversion
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
on Jun 6, 2020https://github.com/angular/angular/issues/37472#event-3415025148
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jun 6, 2020https://github.com/angular/angular/issues/37472#event-3415025171
https://github.com/JohannesHuster
JohannesHusterhttps://github.com/JohannesHuster
on Jun 6, 2020https://github.com/angular/angular/issues/37472#issuecomment-640094067
@devversionhttps://github.com/devversion
JohannesHusterhttps://github.com/JohannesHuster
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jun 6, 2020https://github.com/angular/angular/issues/37472#event-3415067443
https://github.com/devversion
devversionhttps://github.com/devversion
on Jun 10, 2020https://github.com/angular/angular/issues/37472#issuecomment-641868850
@JohannesHusterhttps://github.com/JohannesHuster
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 11, 2020https://github.com/angular/angular/issues/37472#issuecomment-657088036
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 11, 2020https://github.com/angular/angular/issues/37472#event-3536404865
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/37472
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/37472
devversionhttps://github.com/devversion
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.