Title: Refactor component_benchmark · Issue #37445 · angular/angular · GitHub
Open Graph Title: Refactor component_benchmark · Issue #37445 · angular/angular
X Title: Refactor component_benchmark · Issue #37445 · angular/angular
Description: Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change List Asset injection Better error handling...
Open Graph Description: Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change Li...
X Description: Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change Li...
Opengraph URL: https://github.com/angular/angular/issues/37445
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor component_benchmark","articleBody":"### Context\r\nThere are a few changes that need to be made to the `component_benchmark` macro. The \r\n\r\n\r\n# 🚀 Desired changes\r\n\r\n### Relevant Package\r\nThis feature request is for `@angular/dev-infra-private-builds`\r\n\r\n\r\n### Change List\r\n\r\n- [ ] Asset injection\r\n- [ ] Better error handling\r\n- [x] More nuanced static asset args\r\n\r\n### Describe the solution you'd like\r\n\r\n#### Asset injection\r\nThis deals with the issue of providing a theme to a page. The components team would like to be able to provide a theme as a label to `component_benchmark` and have those styles be applied to the default index.html.\r\n\r\nI will complete this description once I have a conversation with @devversion.\r\n\r\n#### Better error handling\r\nCurrently there aren't any descriptive errors provided when `component_benchmark` is used improperly.\r\n\r\nIn particular, there is no explicit error message for when `assets` are provided without an `index.html`, which results in no `index.html` since the default one is provided as a default through the `assets` arg.\r\n\r\n#### More nuanced static asset args\r\nThe way that static assets are provided can be improved upon by allowing more specific and commonly provided static assets to be their own args. Right now if you want to provide a single static asset you must also provide your own `index.html` and cannot use the default one.\r\n\r\nSpecifically, it would make sense to add an arg to separate `index.html` from `assets`.\r\n\r\n### Describe alternatives you've considered\r\n\r\n#### Asset Injection\r\n* Use `genrule` to create `styles.css` so that you can use the transitive `styles.css`.\r\n* Provide a theme through a components `stylesUrls` and setting the component's view encapsulation to none.","author":{"url":"https://github.com/wagnermaciel","@type":"Person","name":"wagnermaciel"},"datePublished":"2020-06-04T22:51:39Z","url":"https://github.com/angular/angular/issues/37445"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e76c6462-8d3f-84fb-2b80-da60338fcf06 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9BAC:17FB7:D75E95:11025B8:6B013B7F |
| html-safe-nonce | f36f1ef2f78d332d0e1b5ec32a2e889267d3831045aaba6814f4ed09a41bff9f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkFDOjE3RkI3OkQ3NUU5NToxMTAyNUI4OjZCMDEzQjdGIiwidmlzaXRvcl9pZCI6IjgzODE1ODYwMTgwMjkwOTE3MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | ae1376d8016cf45ed113ec738d8147b83b50b9bd45dbf0edce4bfb74b62f90c7 |
| hovercard-subject-tag | issue:631195104 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37445/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f34607b20bec4b3e8dad22fcbaf737f9dd16015bd91ee8058a1ff6d84c9137f9/angular/angular/issues/37445 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f34607b20bec4b3e8dad22fcbaf737f9dd16015bd91ee8058a1ff6d84c9137f9/angular/angular/issues/37445 |
| og:image:alt | Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change Li... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | wagnermaciel |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width