René's URL Explorer Experiment


Title: Refactor component_benchmark · Issue #37445 · angular/angular · GitHub

Open Graph Title: Refactor component_benchmark · Issue #37445 · angular/angular

X Title: Refactor component_benchmark · Issue #37445 · angular/angular

Description: Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change List Asset injection Better error handling...

Open Graph Description: Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change Li...

X Description: Context There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change Li...

Opengraph URL: https://github.com/angular/angular/issues/37445

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Refactor component_benchmark","articleBody":"### Context\r\nThere are a few changes that need to be made to the `component_benchmark` macro. The \r\n\r\n\r\n# 🚀  Desired changes\r\n\r\n### Relevant Package\r\nThis feature request is for `@angular/dev-infra-private-builds`\r\n\r\n\r\n### Change List\r\n\r\n- [ ]  Asset injection\r\n- [ ]  Better error handling\r\n- [x]  More nuanced static asset args\r\n\r\n### Describe the solution you'd like\r\n\r\n#### Asset injection\r\nThis deals with the issue of providing a theme to a page. The components team would like to be able to provide a theme as a label to `component_benchmark` and have those styles be applied to the default index.html.\r\n\r\nI will complete this description once I have a conversation with @devversion.\r\n\r\n#### Better error handling\r\nCurrently there aren't any descriptive errors provided when `component_benchmark` is used improperly.\r\n\r\nIn particular, there is no explicit error message for when `assets` are provided without an `index.html`, which results in no `index.html` since the default one is provided as a default through the `assets` arg.\r\n\r\n#### More nuanced static asset args\r\nThe way that static assets are provided can be improved upon by allowing more specific and commonly provided static assets to be their own args. Right now if you want to provide a single static asset you must also provide your own `index.html` and cannot use the default one.\r\n\r\nSpecifically, it would make sense to add an arg to separate `index.html` from `assets`.\r\n\r\n### Describe alternatives you've considered\r\n\r\n#### Asset Injection\r\n* Use `genrule` to create `styles.css` so that you can use the transitive `styles.css`.\r\n* Provide a theme through a components `stylesUrls` and setting the component's view encapsulation to none.","author":{"url":"https://github.com/wagnermaciel","@type":"Person","name":"wagnermaciel"},"datePublished":"2020-06-04T22:51:39Z","url":"https://github.com/angular/angular/issues/37445"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e76c6462-8d3f-84fb-2b80-da60338fcf06
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id9BAC:17FB7:D75E95:11025B8:6B013B7F
html-safe-noncef36f1ef2f78d332d0e1b5ec32a2e889267d3831045aaba6814f4ed09a41bff9f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QkFDOjE3RkI3OkQ3NUU5NToxMTAyNUI4OjZCMDEzQjdGIiwidmlzaXRvcl9pZCI6IjgzODE1ODYwMTgwMjkwOTE3MTEiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacae1376d8016cf45ed113ec738d8147b83b50b9bd45dbf0edce4bfb74b62f90c7
hovercard-subject-tagissue:631195104
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37445/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f34607b20bec4b3e8dad22fcbaf737f9dd16015bd91ee8058a1ff6d84c9137f9/angular/angular/issues/37445
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f34607b20bec4b3e8dad22fcbaf737f9dd16015bd91ee8058a1ff6d84c9137f9/angular/angular/issues/37445
og:image:altContext There are a few changes that need to be made to the component_benchmark macro. The 🚀 Desired changes Relevant Package This feature request is for @angular/dev-infra-private-builds Change Li...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamewagnermaciel
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/37445#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37445
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37445
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/37445
Reloadhttps://github.com/angular/angular/issues/37445
Reloadhttps://github.com/angular/angular/issues/37445
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37445
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37445
Refactor component_benchmarkhttps://github.com/angular/angular/issues/37445#top
https://github.com/wagnermaciel
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: dev-infraIssues related to Angular's own dev infra (build, test, CI, releasing)https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20dev-infra%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/wagnermaciel
wagnermacielhttps://github.com/wagnermaciel
on Jun 4, 2020https://github.com/angular/angular/issues/37445#issue-631195104
@devversionhttps://github.com/devversion
wagnermacielhttps://github.com/wagnermaciel
on Jun 4, 2020https://github.com/angular/angular/issues/37445#event-3409032356
jelbournhttps://github.com/jelbourn
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
area: dev-infraIssues related to Angular's own dev infra (build, test, CI, releasing)https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20dev-infra%22
on Jun 4, 2020https://github.com/angular/angular/issues/37445#event-3409063576
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jun 4, 2020https://github.com/angular/angular/issues/37445#event-3409063853
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
needsTriagehttps://github.com/angular/angular/milestone/83
on Nov 28, 2021https://github.com/angular/angular/issues/37445#event-5681245409
alxhubhttps://github.com/alxhub
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Nov 16, 2022https://github.com/angular/angular/issues/37445#event-7825639010
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Nov 16, 2022https://github.com/angular/angular/issues/37445#event-7825639608
wagnermacielhttps://github.com/wagnermaciel
not plannedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Anot-planned
on Mar 31, 2024https://github.com/angular/angular/issues/37445#event-12304222872
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 1, 2024https://github.com/angular/angular/issues/37445#issuecomment-2087749257
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 1, 2024https://github.com/angular/angular/issues/37445#event-12665372314
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/37445
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/37445
wagnermacielhttps://github.com/wagnermaciel
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: dev-infraIssues related to Angular's own dev infra (build, test, CI, releasing)https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20dev-infra%22
refactoringIssue that involves refactoring or code-cleanuphttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22refactoring%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.