René's URL Explorer Experiment


Title: ZoneJS: legacy Object.defineProperty patch breaks configurable descriptor attribute · Issue #37432 · angular/angular · GitHub

Open Graph Title: ZoneJS: legacy Object.defineProperty patch breaks configurable descriptor attribute · Issue #37432 · angular/angular

X Title: ZoneJS: legacy Object.defineProperty patch breaks configurable descriptor attribute · Issue #37432 · angular/angular

Description: bug report Affected Package zone.js Is this a regression? Yes, but super back in the past! It broke with v0.6.24. Description ZoneJS has this super old legacy Object.defineProperty patch that basically partially re-implements the Object....

Open Graph Description: bug report Affected Package zone.js Is this a regression? Yes, but super back in the past! It broke with v0.6.24. Description ZoneJS has this super old legacy Object.defineProperty patch that basic...

X Description: bug report Affected Package zone.js Is this a regression? Yes, but super back in the past! It broke with v0.6.24. Description ZoneJS has this super old legacy Object.defineProperty patch that basic...

Opengraph URL: https://github.com/angular/angular/issues/37432

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ZoneJS: legacy Object.defineProperty patch breaks configurable descriptor attribute","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# bug report\r\n\r\n### Affected Package\r\n\r\nzone.js\r\n\r\n### Is this a regression?\r\n\r\nYes, but super back in the past! It broke with v0.6.24.\r\n\r\n### Description\r\n\r\nZoneJS has this super old legacy `Object.defineProperty` patch that basically partially re-implements\r\nthe `Object.defineProperty` functionality in order to resolve some custom elements issue. I'm confident that these issues are no longer surfacing and patching `Object.defineProperty` is not the right solution these days.\r\n\r\nThe issue is that this overwritten `Object.defineProperty` function behaves different to the native implementation. i.e. by default defined properties are not configurable. In ZoneJS, with the patched version, properties are _always_ configurable. This means that:\r\n\r\n1. The default `configurable` property descriptor attribute is not respected.\r\n2. Defined properties are by default always `configurable: true`. This doesn't match the native implementation.\r\n\r\nDue to these inconsistencies, ZoneJS could potentially hide app issues that would usually cause errors in production. e.g. when using differential loading, legacy patches might be used in tests, but not always in production. So, calling `defineProperty` multiple times in your app might work with the legacy patches in tests and legacy browsers, but otherwise cause a `Uncaught TypeError: Cannot redefine property: X` error in evergreen browsers.\r\n\r\nWe saw this issue in the Angular Material test harnesses: https://github.com/angular/components/issues/19440\r\n\r\nHere is the commit that introduced this logic back in the old repository:\r\nhttps://github.com/angular/zone.js/commit/383b47905d0a55c0fd87983fa6effd0278cf70f1. And here is the commit that caused the incorrect `configurable` default, and the flag to be not respected at all: https://github.com/angular/zone.js/commit/7b7258b9bf0b4ffd944b2ae015bfb5cb045e3c05.\r\n\r\n## Minimal Reproduction\r\n\r\n```ts\r\nconst x = {}\r\nObject.defineProperty(x, 'defaultPrevented', { get: () => true, configurable: false });\r\nconsole.error(Object.getOwnPropertyDescriptor(x, 'defaultPrevented'));\r\n```\r\n\r\nThis prints `configurable: false` for the `defaultPrevented` property without ZoneJS. If the ZoneJS legacy patches are loaded, this is not the case though and `configurable` is always `true`.\r\n\r\n## Exception or Error\r\n\r\n`Object.defineProperty` behaves different depending on whether ZoneJS legacy patches are loaded or not. ZoneJS could **hide app failures** in tests as `Object.defineProperty` never sets `configurable: false` while in reality, defining a non-configurable property again, causes a `Cannot redeclare property X` runtime error in browsers.\r\n\r\n##  Your Environment\r\n\r\n**Angular Version:**\r\n\r\nAngular v10.0.0-rc.2.\r\nzonejs: 0.10.\r\n\r\n**Anything else relevant?**\r\n\r\nWe should audit if we still need this legacy patch. I'm confident, we wouldn't. I'm hoping we can remove this as it's prone to inconsistencies with the native `Object.defineProperty` behavior. ","author":{"url":"https://github.com/devversion","@type":"Person","name":"devversion"},"datePublished":"2020-06-04T08:56:27Z","url":"https://github.com/angular/angular/issues/37432"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0bc67ce0-39d5-a9a1-f83f-1aa9a8684aec
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA7AA:4D9F2:18DA0DF:20F92F2:6B0213AE
html-safe-noncef59d85a8ab380a927dec9ec916f97034389a093c87396f75e32ec26a911b4ad1
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBN0FBOjREOUYyOjE4REEwREY6MjBGOTJGMjo2QjAyMTNBRSIsInZpc2l0b3JfaWQiOiI4NjcyMjA0NjIyNjA4NTE2MzAiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacb4a19c25d8069f5107084d9877e8adf64c2bf3b2ba5651feac8a36b05f645de6
hovercard-subject-tagissue:630639918
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37432/issue_layout
twitter:imagehttps://opengraph.githubassets.com/86a361e4f4d25afddb7163dfa6a2e155cc4d37ac22ceb28a514883c9e6250482/angular/angular/issues/37432
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/86a361e4f4d25afddb7163dfa6a2e155cc4d37ac22ceb28a514883c9e6250482/angular/angular/issues/37432
og:image:altbug report Affected Package zone.js Is this a regression? Yes, but super back in the past! It broke with v0.6.24. Description ZoneJS has this super old legacy Object.defineProperty patch that basic...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevversion
hostnamegithub.com
expected-hostnamegithub.com
None87e774ee7c6b3bee0490394e4d3e57ec9dbc956f74b87ea685dc8996c1676456
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release423dbb54c5e7bfecc838eb387c1435eb3d0e760d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/37432#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37432
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37432
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/37432
Reloadhttps://github.com/angular/angular/issues/37432
Reloadhttps://github.com/angular/angular/issues/37432
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37432
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37432
kubikowski/inanity#26https://github.com/kubikowski/inanity/pull/26
ZoneJS: legacy Object.defineProperty patch breaks configurable descriptor attributehttps://github.com/angular/angular/issues/37432#top
kubikowski/inanity#26https://github.com/kubikowski/inanity/pull/26
https://github.com/JeanMeche
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
hotlist: components teamRelated to Angular CDK or Angular Materialhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20components%20team%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
workaround2: non-obvioushttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/devversion
devversionhttps://github.com/devversion
on Jun 4, 2020https://github.com/angular/angular/issues/37432#issue-630639918
angular/components#19440https://github.com/angular/components/issues/19440
angular/zone.js@383b479https://github.com/angular/zone.js/commit/383b47905d0a55c0fd87983fa6effd0278cf70f1
angular/zone.js@7b7258bhttps://github.com/angular/zone.js/commit/7b7258b9bf0b4ffd944b2ae015bfb5cb045e3c05
Nexthttps://github.com/angular/angular/issues/37432?timeline_page=1
devversionhttps://github.com/devversion
hotlist: components teamRelated to Angular CDK or Angular Materialhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20components%20team%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
workaround2: non-obvioushttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
on Jun 4, 2020https://github.com/angular/angular/issues/37432#event-3405821372
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jun 4, 2020https://github.com/angular/angular/issues/37432#event-3405821495
JiaLiPassionhttps://github.com/JiaLiPassion
on Jun 4, 2020https://github.com/angular/angular/issues/37432#event-3405891592
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
45a73ddhttps://github.com/angular/angular/commit/45a73dddfdf3f32ad4203c71c06b6a4be50f4a31
on Sep 8, 2020https://github.com/angular/angular/issues/37432#event-3742542754
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
on Sep 9, 2020https://github.com/angular/angular/issues/37432#issuecomment-689252518
#37582https://github.com/angular/angular/pull/37582
JiaLiPassionhttps://github.com/JiaLiPassion
on Sep 9, 2020https://github.com/angular/angular/issues/37432#event-3743523614
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
on Oct 1, 2020https://github.com/angular/angular/issues/37432#event-3830232676
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Oct 1, 2020https://github.com/angular/angular/issues/37432#event-3830232773
jelbournhttps://github.com/jelbourn
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/37432#event-3830826541
https://github.com/dinbtechit
dinbtechithttps://github.com/dinbtechit
on Jul 13, 2022https://github.com/angular/angular/issues/37432#issuecomment-1183347284
#37582https://github.com/angular/angular/pull/37582
#46822https://github.com/angular/angular/issues/46822
https://github.com/spsinghats
spsinghatshttps://github.com/spsinghats
on Aug 2, 2022https://github.com/angular/angular/issues/37432#issuecomment-1202395194
#37582https://github.com/angular/angular/pull/37582
@JiaLiPassionhttps://github.com/JiaLiPassion
crapStonehttps://github.com/crapStone
on Nov 11, 2022https://github.com/angular/angular/issues/37432#event-7793859934
Update angular monorepo (#1632)https://github.com/Calciumdibromid/CaBr2/commit/f4031dfc68f31729257928963599ec899e91363a
f4031dfhttps://github.com/Calciumdibromid/CaBr2/commit/f4031dfc68f31729257928963599ec899e91363a
JeanMechehttps://github.com/JeanMeche
JeanMechehttps://github.com/JeanMeche
JiaLiPassionhttps://github.com/JiaLiPassion
on Oct 2, 2025https://github.com/angular/angular/issues/37432#event-20063387546
JeanMechehttps://github.com/JeanMeche
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 16, 2025https://github.com/angular/angular/issues/37432#event-20329642539
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 16, 2025https://github.com/angular/angular/issues/37432#issuecomment-3537153351
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 16, 2025https://github.com/angular/angular/issues/37432#event-20965615414
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/37432
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/37432
JeanMechehttps://github.com/JeanMeche
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
hotlist: components teamRelated to Angular CDK or Angular Materialhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22hotlist%3A%20components%20team%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
workaround2: non-obvioushttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22workaround2%3A%20non-obvious%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.