René's URL Explorer Experiment


Title: Regression - Decorators · Issue #37068 · angular/angular · GitHub

Open Graph Title: Regression - Decorators · Issue #37068 · angular/angular

X Title: Regression - Decorators · Issue #37068 · angular/angular

Description: Currently, we cannot upgrade to Angular 9.0 Ivy because of the regressions introduced by the Ivy compiler. If #35464 is not merged, we will have to stop upgrading Angular and leave it at version 9.0 indefinitely. I am sharing this issue ...

Open Graph Description: Currently, we cannot upgrade to Angular 9.0 Ivy because of the regressions introduced by the Ivy compiler. If #35464 is not merged, we will have to stop upgrading Angular and leave it at version 9....

X Description: Currently, we cannot upgrade to Angular 9.0 Ivy because of the regressions introduced by the Ivy compiler. If #35464 is not merged, we will have to stop upgrading Angular and leave it at version 9....

Opengraph URL: https://github.com/angular/angular/issues/37068

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Regression - Decorators","articleBody":"Currently, we cannot upgrade to Angular 9.0 Ivy because of the regressions introduced by the Ivy compiler. If #35464 is not merged, we will have to stop upgrading Angular and leave it at version 9.0 indefinitely.\r\n\r\nI am sharing this issue primarily so the Angular team can see how users are using Custom Decorators in the wild. I suspect I'm not the only one doing something like this.\r\n\r\n### Description\r\n\r\nWe develop an `Nx` workspace app, with multiple shared libraries powering both a Desktop, and Mobile application - responsive design doesn't cut it for our use case. In addition, we also have separate administrator views, and client libraries which are all generated from the same source code.\r\n\r\nAs such, dependency injection doesn't always meet our use case, even with the `@Optonal` decorator. Many of our components end up being shared between Mobile and Desktop, User and Administrator contexts, and as much as we can simplify their logic, we try to do so.\r\n\r\nCurrently, we use custom decorators to wire components in to pieces of the application which may, or may not be present. A great example is how we integrate with the map; In the Desktop application, a large on-screen map is available to most components. When users are entering addresses, they can click on the map, drag the pin around, etc. When on the Mobile application, this is not available.\r\n\r\nThe following code is how we connect the pin to the map in our application:\r\n\r\n````ts\r\n\r\n@Component({\r\n    selector: 'app-foo',\r\n    template: `\r\nThe origin pin is at {{orig?.lat}}, {{orig?.lng}}.\r\n\u003cbutton (click)=\"centerOnEmpireStateBuilding()\">Center\u003c/button>\r\n\u003cbutton (click)=\"removePin()\">Hide Pin\u003c/button>\r\n`\r\n})\r\n// Wires up necesary parts, Object.defineProperty etc. on `ngOnInit`\r\n@MapConnectedComponent()\r\nexport class FooComponent {\r\n    \r\n     // Actually connects this property to the map in a two-way databinding\r\n    @MapConnectedAddress('orig')\r\n    pin: {lat:number; lng: number;}\r\n\r\n   centerOnEmpireStateBuilding() {\r\n      // This will move the pin on the map to the appropriate location as well.\r\n      this.pin = {lat: 40.7484, lng:-73.9857};\r\n   }\r\n\r\n  removePin() {\r\n      // This will remove the pin\r\n    this.pin = null;\r\n  }\r\n}\r\n\r\n````\r\n\r\nBecause we have a small team of mostly junior developers, we try to focus on our developer experience heavily. Custom Decorators like this provide many benefits, chiefly among them:\r\n\r\n 1. Declarative vs. Imperative programming\r\n 2. Easy instruction for Jr developers - practically self documenting code.\r\n 3. Free adherence to the Open / Closed principle, without need for inheritence.\r\n\r\n\r\n### Conclusion\r\n\r\n#35464 is a blocker for us; We really don't want to unravel all the custom decorators we've developed (this is just one of the examples) just so that Angular can have a minuscule benefit in start up performance. \r\n\r\nWith Angular 8.0 I was able to achieve a very concise, easy to explain process. Before the decorators, each address which needed to be connected to the map, required 8 - 10 lines of code, not to mention injecting the right service, etc. Now, it's two decorators.\r\n\r\nI hope this has been illuminating in how Metaprogramming is used in the wild, and helps you understand the user base better.\r\n\r\n","author":{"url":"https://github.com/bryanrideshark","@type":"Person","name":"bryanrideshark"},"datePublished":"2020-05-12T14:06:59Z","url":"https://github.com/angular/angular/issues/37068"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:80a9e7a5-0ded-022b-7aec-028234e90d2e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idEBA2:1F4E:20A051:2B0FA3:6B01451B
html-safe-nonceede4deb7440a1da7e5628de0dab4c45d3974763e630f78c853dab180e2e83350
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQkEyOjFGNEU6MjBBMDUxOjJCMEZBMzo2QjAxNDUxQiIsInZpc2l0b3JfaWQiOiI4NjA0MjI5NjQwODIwNzA0NTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac58f7d9fe0450d403f0430bcd7ab7f48e9a23104e5c5741d15a4c3ef8a16bef7a
hovercard-subject-tagissue:616686232
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/37068/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e3c6d34d167de850cfa9c26e718b3b62357da905341a65260e23baa40ab1a36a/angular/angular/issues/37068
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e3c6d34d167de850cfa9c26e718b3b62357da905341a65260e23baa40ab1a36a/angular/angular/issues/37068
og:image:altCurrently, we cannot upgrade to Angular 9.0 Ivy because of the regressions introduced by the Ivy compiler. If #35464 is not merged, we will have to stop upgrading Angular and leave it at version 9....
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamebryanrideshark
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/37068#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37068
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F37068
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/37068
Reloadhttps://github.com/angular/angular/issues/37068
Reloadhttps://github.com/angular/angular/issues/37068
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37068
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/37068
Regression - Decoratorshttps://github.com/angular/angular/issues/37068#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/bryanrideshark
bryanridesharkhttps://github.com/bryanrideshark
on May 12, 2020https://github.com/angular/angular/issues/37068#issue-616686232
#35464https://github.com/angular/angular/pull/35464
#35464https://github.com/angular/angular/pull/35464
https://github.com/bbarry
bbarryhttps://github.com/bbarry
on May 12, 2020https://github.com/angular/angular/issues/37068#issuecomment-627404324
https://github.com/ngneat/until-destroyhttps://github.com/ngneat/until-destroy
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
on May 13, 2020https://github.com/angular/angular/issues/37068#event-3330633781
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on May 13, 2020https://github.com/angular/angular/issues/37068#event-3330633861
https://github.com/pkozlowski-opensource
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
on May 15, 2020https://github.com/angular/angular/issues/37068#issuecomment-629173336
@bryanridesharkhttps://github.com/bryanrideshark
#31495https://github.com/angular/angular/issues/31495
#31495https://github.com/angular/angular/issues/31495
#35464https://github.com/angular/angular/pull/35464
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 15, 2020https://github.com/angular/angular/issues/37068#event-3340438908
https://github.com/bryanrideshark
bryanridesharkhttps://github.com/bryanrideshark
on May 15, 2020https://github.com/angular/angular/issues/37068#issuecomment-629504116
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
#35464https://github.com/angular/angular/pull/35464
https://github.com/acn-masatadakurihara
acn-masatadakuriharahttps://github.com/acn-masatadakurihara
on May 20, 2020https://github.com/angular/angular/issues/37068#issuecomment-631273132
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 20, 2020https://github.com/angular/angular/issues/37068#issuecomment-647014652
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 20, 2020https://github.com/angular/angular/issues/37068#event-3464814117
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/37068
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/37068
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.