René's URL Explorer Experiment


Title: Zone.js attempts to patch "fetch" even when "common/fetch" is not imported. · Issue #36588 · angular/angular · GitHub

Open Graph Title: Zone.js attempts to patch "fetch" even when "common/fetch" is not imported. · Issue #36588 · angular/angular

X Title: Zone.js attempts to patch "fetch" even when "common/fetch" is not imported. · Issue #36588 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? Based on previous issue history, no. Description I am using angular in a web extension injected content script context. When the script i...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? Based on previous issue history, no. Description I am using angular in a web extension injected c...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? Based on previous issue history, no. Description I am using angular in a web extension injected c...

Opengraph URL: https://github.com/angular/angular/issues/36588

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Zone.js attempts to patch \"fetch\" even when \"common/fetch\" is not imported.","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nThe issue is caused by package @angular/zone.js\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nBased on previous issue history, no.\r\n\r\n\r\n### Description\r\n\r\nI am using angular in a web extension injected content script context. When the script is injected by the background page, the following error appears in Firefox:\r\n\r\n![image](https://user-images.githubusercontent.com/715484/79068689-c9c08f00-7c96-11ea-8aa5-bb01774ec6ae.png)\r\n\r\nThis looks to be the same issue tracked by: https://github.com/angular/zone.js/issues/1115 which was resolved by them through configuring `NgZone: 'noop'` and manually implementing change detection. The issue was closed as \"resolved in angular 7\" but that doesn't appear to be the case.\r\n\r\n## 🔬 Minimal Reproduction\r\nHere is my abbreviated `polyfills.ts`:\r\n\r\n```typescript\r\nimport 'zone.js/lib/zone';\r\nimport 'zone.js/lib/common/promise';\r\n```\r\n\r\nThe application is delivered from the background script to the tab via:\r\n\r\n```\r\nbrowser.tabs.executeScript({\r\n      file: 'content-script/polyfills.js',\r\n      allFrames: true\r\n});\r\n```\r\n\r\nRepo with readme to recreate this issue locally: https://github.com/spaceribs/zonejs-angular-issue\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\nERROR Error: \"\"fetch\" is read-only\" core.js:6189:19\r\n    Angular 2\r\n        defaultErrorLogger\r\n        handleError\r\n    error app.component.ts:145\r\n    RxJS 13\r\n        __tryOrUnsub\r\n        error\r\n        _error\r\n        error\r\n        _error\r\n        error\r\n        notifyError\r\n        _error\r\n        error\r\n        notifyError\r\n        _error\r\n        error\r\n        subscribeToPromise\r\n    Angular 10\r\n        invoke\r\n        onInvoke\r\n        invoke\r\n        run\r\n        scheduleResolveOrReject\r\n        invokeTask\r\n        onInvokeTask\r\n        invokeTask\r\n        runTask\r\n        drainMicroTaskQueue\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.900.7\r\n@angular-devkit/build-angular     0.901.1\r\n@angular-devkit/build-optimizer   0.901.1\r\n@angular-devkit/build-webpack     0.901.1\r\n@angular-devkit/core              9.0.7\r\n@angular-devkit/schematics        9.0.7\r\n@angular/cdk                      9.2.0\r\n@ngtools/webpack                  9.1.1\r\n@schematics/angular               9.1.1\r\n@schematics/update                0.901.1\r\nrxjs                              6.5.5\r\ntypescript                        3.8.3\r\nwebpack                           4.42.0\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nThis is on Firefox 75\r\n\r\nI decided to dig a little deeper as well as compile zone.js myself in order to understand it a little better 😄.\r\n\r\nThe following lines appear to be the culprit, but I have little knowledge as to why fetch is being patched in `common/promise` rather than `common/fetch` by @JiaLiPassion :\r\nhttps://github.com/angular/zone.js/commit/ac3851ee31193a608a5bd12fbba90079e7328aca#diff-c87353777ac53dcde41fac9008e56425R492-R496\r\nnow at: https://github.com/angular/angular/blob/bf8ba89394ffd6d2047261e89d9f41e6ef66be3e/packages/zone.js/lib/common/promise.ts#L510-L514\r\n\r\nFor now in my project, I'm planning to copy this file and remove those lines.","author":{"url":"https://github.com/spaceribs","@type":"Person","name":"spaceribs"},"datePublished":"2020-04-12T12:46:18Z","url":"https://github.com/angular/angular/issues/36588"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2cae12cb-f1d9-e046-b2f1-d4fa45e069c8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA694:1087D4:1B44F31:2464626:6B0161B1
html-safe-nonce00ba1c4536d445e514f8a39aa0d5b97f890165286489f6c93cd418c2427cba7c
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjk0OjEwODdENDoxQjQ0RjMxOjI0NjQ2MjY6NkIwMTYxQjEiLCJ2aXNpdG9yX2lkIjoiODg5MjU2MjU1NTAyMTY0ODMwNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac59beeb2bebae56463c67c056adcfe5210ce26fb61a662aa20490c5bf580b7d77
hovercard-subject-tagissue:598477025
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/36588/issue_layout
twitter:imagehttps://opengraph.githubassets.com/ee21819ea184412eefe5bca1b3a57875392e35414f76d4e854e4a7236cec816b/angular/angular/issues/36588
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/ee21819ea184412eefe5bca1b3a57875392e35414f76d4e854e4a7236cec816b/angular/angular/issues/36588
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? Based on previous issue history, no. Description I am using angular in a web extension injected c...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamespaceribs
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/36588#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36588
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36588
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/36588
Reloadhttps://github.com/angular/angular/issues/36588
Reloadhttps://github.com/angular/angular/issues/36588
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36588
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36588
Zone.js attempts to patch "fetch" even when "common/fetch" is not imported.https://github.com/angular/angular/issues/36588#top
https://github.com/JiaLiPassion
https://github.com/spaceribs
spaceribshttps://github.com/spaceribs
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issue-598477025
https://user-images.githubusercontent.com/715484/79068689-c9c08f00-7c96-11ea-8aa5-bb01774ec6ae.png
angular/zone.js#1115https://github.com/angular/zone.js/issues/1115
https://github.com/spaceribs/zonejs-angular-issuehttps://github.com/spaceribs/zonejs-angular-issue
@JiaLiPassionhttps://github.com/JiaLiPassion
angular/zone.js@ac3851e#diff-c87353777ac53dcde41fac9008e56425R492-R496https://github.com/angular/zone.js/commit/ac3851ee31193a608a5bd12fbba90079e7328aca#diff-c87353777ac53dcde41fac9008e56425R492-R496
angular/packages/zone.js/lib/common/promise.tshttps://github.com/angular/angular/blob/bf8ba89394ffd6d2047261e89d9f41e6ef66be3e/packages/zone.js/lib/common/promise.ts#L510-L514
bf8ba89https://github.com/angular/angular/commit/bf8ba89394ffd6d2047261e89d9f41e6ef66be3e
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612612057
@spaceribshttps://github.com/spaceribs
JiaLiPassionhttps://github.com/JiaLiPassion
on Apr 12, 2020https://github.com/angular/angular/issues/36588#event-3225070704
https://github.com/spaceribs
spaceribshttps://github.com/spaceribs
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612613054
@JiaLiPassionhttps://github.com/JiaLiPassion
https://github.com/spaceribs
spaceribshttps://github.com/spaceribs
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612613780
@JiaLiPassionhttps://github.com/JiaLiPassion
https://github.com/spaceribs
spaceribshttps://github.com/spaceribs
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612624298
https://github.com/spaceribs/zonejs-angular-issuehttps://github.com/spaceribs/zonejs-angular-issue
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612637837
@spaceribshttps://github.com/spaceribs
#36311https://github.com/angular/angular/pull/36311
https://github.com/spaceribs
spaceribshttps://github.com/spaceribs
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612639584
@JiaLiPassionhttps://github.com/JiaLiPassion
https://github.com/JiaLiPassion
JiaLiPassionhttps://github.com/JiaLiPassion
on Apr 12, 2020https://github.com/angular/angular/issues/36588#issuecomment-612641973
@spaceribshttps://github.com/spaceribs
https://github.com/angular/angular/tree/master/packages/zone.js/lib/browserhttps://github.com/angular/angular/tree/master/packages/zone.js/lib/browser
https://github.com/spaceribs
spaceribshttps://github.com/spaceribs
on Apr 13, 2020https://github.com/angular/angular/issues/36588#issuecomment-612918114
spaceribshttps://github.com/spaceribs
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 13, 2020https://github.com/angular/angular/issues/36588#event-3227230303
https://github.com/SerkanSipahi
SerkanSipahihttps://github.com/SerkanSipahi
on Apr 23, 2020https://github.com/angular/angular/issues/36588#issuecomment-618244039
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 24, 2020https://github.com/angular/angular/issues/36588#issuecomment-633253848
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 24, 2020https://github.com/angular/angular/issues/36588#event-3368082166
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/36588
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/36588
JiaLiPassionhttps://github.com/JiaLiPassion
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.