Title: Avoid calling abort on XMLHttpRequest · Issue #36537 · angular/angular · GitHub
Open Graph Title: Avoid calling abort on XMLHttpRequest · Issue #36537 · angular/angular
X Title: Avoid calling abort on XMLHttpRequest · Issue #36537 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem was previously reported (#33822), but it ...
Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem w...
X Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem w...
Opengraph URL: https://github.com/angular/angular/issues/36537
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Avoid calling abort on XMLHttpRequest","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/common/http\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> Yes, the previous version in which this bug was not present was: *\r\n\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️-->\r\nThis problem was previously reported (https://github.com/angular/angular/issues/33822), but it was closed and locked... so I'm opening a new one.\r\n\r\nThe issue was closed because it was reported in the deprecated http module, but the issue is still present in the new `HttpClientModule`\r\nhttps://github.com/angular/angular/blob/27997a16c0e87dea01562267f8207c2ab79cd18e/packages/common/http/src/xhr.ts#L326-L339\r\n\r\nAs https://github.com/angular/angular/issues/33822 says:\r\n> it makes it hard for other libraries that instruments XMLHttpRequest, to keep track of the XHR correctly\r\n\r\nI'm having this issue using the package `miragejs`, causing this issue https://github.com/miragejs/miragejs/issues/329, because on abort the `request` object is reset. It breaks this package and I guess any other that track the `request` (https://github.com/miragejs/miragejs/issues/329#issuecomment-611447910)\r\n\r\nI think it should call `abort` only when really it has been aborted, and avoid calling it when server already has replied.\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\u003c!-- ✍️--> I think it isn't needed, otherway I can create one :+1:\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\n## 🔥 Exception or Error\r\nNo exception on Angular side, but it breaks third-party packages that rely on xhr request object.\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\u003c!-- run `ng version` and paste output below -->\r\n\u003c!-- ✍️-->\r\nAngular CLI: 9.1.1\r\nNode: 13.7.0\r\nOS: linux x64\r\n\r\nAngular: 9.1.1\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, localize, platform-browser\r\n... platform-browser-dynamic, router\r\nIvy Workspace: Yes\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.901.1\r\n@angular-devkit/build-angular 0.901.1\r\n@angular-devkit/build-optimizer 0.901.1\r\n@angular-devkit/build-webpack 0.901.1\r\n@angular-devkit/core 8.3.25\r\n@angular-devkit/schematics 8.3.25\r\n@angular/cdk 9.2.0\r\n@ngtools/webpack 9.1.1\r\n@schematics/angular 9.1.1\r\n@schematics/update 0.901.1\r\nrxjs 6.5.5\r\ntypescript 3.8.3\r\nwebpack 4.42.0\r\n \r\nDone in 0.46s.\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\nNope, keep doing this good job :+1:\r\n","author":{"url":"https://github.com/tonivj5","@type":"Person","name":"tonivj5"},"datePublished":"2020-04-09T10:18:01Z","url":"https://github.com/angular/angular/issues/36537"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:2d37262d-711a-3186-9a6d-d90e89d5dab2 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | CD04:1F7384:11A1573:175375D:6B01151F |
| html-safe-nonce | db1777971797f78fe0296c54efc6660f948bd4bb1fa3551416111c00b569f1bb |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDA0OjFGNzM4NDoxMUExNTczOjE3NTM3NUQ6NkIwMTE1MUYiLCJ2aXNpdG9yX2lkIjoiNzM3MjAyNjEyMzcxNjIwMzgwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 987baa3be7fe31578752c0a84729514327870ba4d2b4ce891eed240bcbce6033 |
| hovercard-subject-tag | issue:597177834 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/36537/issue_layout |
| twitter:image | https://opengraph.githubassets.com/015e1dd68c3e80ffbf26e247090e11d9296078dee4cdd0e377faaaf7c91e588c/angular/angular/issues/36537 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/015e1dd68c3e80ffbf26e247090e11d9296078dee4cdd0e377faaaf7c91e588c/angular/angular/issues/36537 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | tonivj5 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width