René's URL Explorer Experiment


Title: Avoid calling abort on XMLHttpRequest · Issue #36537 · angular/angular · GitHub

Open Graph Title: Avoid calling abort on XMLHttpRequest · Issue #36537 · angular/angular

X Title: Avoid calling abort on XMLHttpRequest · Issue #36537 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem was previously reported (#33822), but it ...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem w...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem w...

Opengraph URL: https://github.com/angular/angular/issues/36537

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Avoid calling abort on XMLHttpRequest","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/common/http\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> Yes, the previous version in which this bug was not present was: *\r\n\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️-->\r\nThis problem was previously reported (https://github.com/angular/angular/issues/33822), but it was closed and locked... so I'm opening a new one.\r\n\r\nThe issue was closed because it was reported in the deprecated http module, but the issue is still present in the new `HttpClientModule`\r\nhttps://github.com/angular/angular/blob/27997a16c0e87dea01562267f8207c2ab79cd18e/packages/common/http/src/xhr.ts#L326-L339\r\n\r\nAs https://github.com/angular/angular/issues/33822 says:\r\n> it makes it hard for other libraries that instruments XMLHttpRequest, to keep track of the XHR correctly\r\n\r\nI'm having this issue using the package `miragejs`, causing this issue https://github.com/miragejs/miragejs/issues/329, because on abort the `request` object is reset. It breaks this package and I guess any other that track the `request` (https://github.com/miragejs/miragejs/issues/329#issuecomment-611447910)\r\n\r\nI think it should call `abort` only when really it has been aborted, and avoid calling it when server already has replied.\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\u003c!-- ✍️--> I think it isn't needed, otherway I can create one :+1:\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\n## 🔥 Exception or Error\r\nNo exception on Angular side, but it breaks third-party packages that rely on xhr request object.\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\u003c!-- run `ng version` and paste output below -->\r\n\u003c!-- ✍️-->\r\nAngular CLI: 9.1.1\r\nNode: 13.7.0\r\nOS: linux x64\r\n\r\nAngular: 9.1.1\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, localize, platform-browser\r\n... platform-browser-dynamic, router\r\nIvy Workspace: Yes\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.901.1\r\n@angular-devkit/build-angular     0.901.1\r\n@angular-devkit/build-optimizer   0.901.1\r\n@angular-devkit/build-webpack     0.901.1\r\n@angular-devkit/core              8.3.25\r\n@angular-devkit/schematics        8.3.25\r\n@angular/cdk                      9.2.0\r\n@ngtools/webpack                  9.1.1\r\n@schematics/angular               9.1.1\r\n@schematics/update                0.901.1\r\nrxjs                              6.5.5\r\ntypescript                        3.8.3\r\nwebpack                           4.42.0\r\n    \r\nDone in 0.46s.\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\nNope, keep doing this good job :+1:\r\n","author":{"url":"https://github.com/tonivj5","@type":"Person","name":"tonivj5"},"datePublished":"2020-04-09T10:18:01Z","url":"https://github.com/angular/angular/issues/36537"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:2d37262d-711a-3186-9a6d-d90e89d5dab2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCD04:1F7384:11A1573:175375D:6B01151F
html-safe-noncedb1777971797f78fe0296c54efc6660f948bd4bb1fa3551416111c00b569f1bb
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDA0OjFGNzM4NDoxMUExNTczOjE3NTM3NUQ6NkIwMTE1MUYiLCJ2aXNpdG9yX2lkIjoiNzM3MjAyNjEyMzcxNjIwMzgwNyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac987baa3be7fe31578752c0a84729514327870ba4d2b4ce891eed240bcbce6033
hovercard-subject-tagissue:597177834
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/36537/issue_layout
twitter:imagehttps://opengraph.githubassets.com/015e1dd68c3e80ffbf26e247090e11d9296078dee4cdd0e377faaaf7c91e588c/angular/angular/issues/36537
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/015e1dd68c3e80ffbf26e247090e11d9296078dee4cdd0e377faaaf7c91e588c/angular/angular/issues/36537
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/common/http Is this a regression? Yes, the previous version in which this bug was not present was: * Description This problem w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametonivj5
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/36537#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36537
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36537
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/36537
Reloadhttps://github.com/angular/angular/issues/36537
Reloadhttps://github.com/angular/angular/issues/36537
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36537
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36537
Avoid calling abort on XMLHttpRequesthttps://github.com/angular/angular/issues/36537#top
area: common/httpIssues related to HTTP and HTTP Clienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%2Fhttp%22
open for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22open%20for%20contributions%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/tonivj5
tonivj5https://github.com/tonivj5
on Apr 9, 2020https://github.com/angular/angular/issues/36537#issue-597177834
#33822https://github.com/angular/angular/issues/33822
angular/packages/common/http/src/xhr.tshttps://github.com/angular/angular/blob/27997a16c0e87dea01562267f8207c2ab79cd18e/packages/common/http/src/xhr.ts#L326-L339
27997a1https://github.com/angular/angular/commit/27997a16c0e87dea01562267f8207c2ab79cd18e
#33822https://github.com/angular/angular/issues/33822
miragejs/miragejs#329https://github.com/miragejs/miragejs/issues/329
miragejs/miragejs#329 (comment)https://github.com/miragejs/miragejs/issues/329#issuecomment-611447910
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: common/httpIssues related to HTTP and HTTP Clienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%2Fhttp%22
on Apr 9, 2020https://github.com/angular/angular/issues/36537#event-3217726500
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Apr 9, 2020https://github.com/angular/angular/issues/36537#event-3217726570
alxhubhttps://github.com/alxhub
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
open for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22open%20for%20contributions%22
on May 29, 2020https://github.com/angular/angular/issues/36537#event-3388157750
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on May 29, 2020https://github.com/angular/angular/issues/36537#issuecomment-636095280
https://github.com/tonivj5
tonivj5https://github.com/tonivj5
on May 29, 2020https://github.com/angular/angular/issues/36537#issuecomment-636154024
demohttps://codesandbox.io/s/great-surf-f7bi5?file=/src/index.ts
@alxhubhttps://github.com/alxhub
dmkubahttps://github.com/dmkuba
on May 31, 2020https://github.com/angular/angular/issues/36537#event-3390661347
fix(http): avoid abort a request when fetch operation is completedhttps://github.com/dimakuba/angular/commit/6fb6b31432158d300c4231928643170d6f193005
6fb6b31https://github.com/dimakuba/angular/commit/6fb6b31432158d300c4231928643170d6f193005
fix(http): avoid abort a request when fetch operation is completedhttps://github.com/dimakuba/angular/commit/ad387f5ae5eeacad92317825665a34080f3b2a3d
ad387f5https://github.com/dimakuba/angular/commit/ad387f5ae5eeacad92317825665a34080f3b2a3d
AndrewKushnirhttps://github.com/AndrewKushnir
on Jun 25, 2020https://github.com/angular/angular/issues/36537#event-3483764500
fix(http): avoid abort a request when fetch operation is completed (#…https://github.com/angular/angular/commit/a5d5f67be7407be0e6eb2c059356c23e83049b13
#…https://github.com/angular/angular/pull/37367
a5d5f67https://github.com/angular/angular/commit/a5d5f67be7407be0e6eb2c059356c23e83049b13
AndrewKushnirhttps://github.com/AndrewKushnir
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
8a74508https://github.com/angular/angular/commit/8a745081307c16644796c333531edcb4591ce235
on Jun 25, 2020https://github.com/angular/angular/issues/36537#event-3483764622
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 26, 2020https://github.com/angular/angular/issues/36537#issuecomment-664007607
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 26, 2020https://github.com/angular/angular/issues/36537#event-3587201552
profanishttps://github.com/profanis
on Sep 5, 2020https://github.com/angular/angular/issues/36537#event-3732916258
fix(http): avoid abort a request when fetch operation is completed (a…https://github.com/profanis/angular/commit/9a59992ee94d6844757ea7e6a3206b5ff0cfc0a5
a…https://github.com/angular/angular/pull/37367
9a59992https://github.com/profanis/angular/commit/9a59992ee94d6844757ea7e6a3206b5ff0cfc0a5
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/36537
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/36537
area: common/httpIssues related to HTTP and HTTP Clienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%2Fhttp%22
open for contributionsAn issue that is suitable for a community contributor (based on its complexity/scope).https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22open%20for%20contributions%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.