René's URL Explorer Experiment


Title: LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy) · Issue #36230 · angular/angular · GitHub

Open Graph Title: LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy) · Issue #36230 · angular/angular

X Title: LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy) · Issue #36230 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/core. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using Ivy) This also works if @angular/core is not processed b...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/core. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using Ivy) This also w...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/core. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using Ivy) This also w...

Opengraph URL: https://github.com/angular/angular/issues/36230

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy)","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nThe issue is caused by package @angular/core.\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nYes, the previous version in which this bug was not present was: ^8.2.0 (not using Ivy)\r\n\r\nThis also works if @angular/core is not processed by `ngcc` (when the tests use ViewEngine instead of Ivy) - we use jest, which does not call `ngcc` automatically like the default Angular CLI setup with karma, so we can test both scenarios easily in our private project repository.\r\n\r\n\r\n### Description\r\nThere was a pull request (#34830) that ensured all `APP_INITIALIZER` functions are executed before `LOCALE_ID` is first accessed. This works correctly when the application is served (whether the initializer is synchronous or asynchronous).\r\n\r\nBut when running tests, this is not happening. The `LOCALE_ID` is accessed before `APP_INITIALIZER` functions are executed, thus ending in the locale being undefined.\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/IgorAufricht/angular-locale-id-test-repro\r\n\r\nThe steps are included in the readme, but for clarity, here they are:\r\n* `git clone https://github.com/IgorAufricht/angular-locale-id-test-repro`\r\n* `npm install`\r\n* `ng serve` (application loads correctly, console confirms that `LOCALE_ID = fr-FR`)\r\n* `ng test` (fails, `Error: Expected '' to equal 'fr-FR'`)\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.7\r\nNode: 12.13.1\r\nOS: win32 x64\r\n\r\nAngular: 9.0.7\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.900.7\r\n@angular-devkit/build-angular     0.900.7\r\n@angular-devkit/build-optimizer   0.900.7\r\n@angular-devkit/build-webpack     0.900.7\r\n@angular-devkit/core              9.0.7\r\n@angular-devkit/schematics        9.0.7\r\n@ngtools/webpack                  9.0.7\r\n@schematics/angular               9.0.7\r\n@schematics/update                0.900.7\r\nrxjs                              6.5.4\r\ntypescript                        3.7.5\r\nwebpack                           4.41.2\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nRelated to #34830.","author":{"url":"https://github.com/IgorAufricht","@type":"Person","name":"IgorAufricht"},"datePublished":"2020-03-24T15:41:28Z","url":"https://github.com/angular/angular/issues/36230"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:5cd0d28a-b094-cdc4-21fb-497ec37db661
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE5D6:3A347:13E770D:1A5FE02:6B0123BB
html-safe-nonce59ae0154e1e2f2b10eb1a8864e091a87c0893cc8db4640bc5197f5c98885987e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFNUQ2OjNBMzQ3OjEzRTc3MEQ6MUE1RkUwMjo2QjAxMjNCQiIsInZpc2l0b3JfaWQiOiI0MDU5ODM1MjMyOTU2Nzg1NTk1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac1502169ae26daa9f60890916a56f6dc60a5a50c790c299e0a62d6e218b88be5b
hovercard-subject-tagissue:587056894
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/36230/issue_layout
twitter:imagehttps://opengraph.githubassets.com/7d45e9054e5e4ef5b6f5a1c593201c91d2428f5cfbd6eb4d5b67ab49ebad9ecb/angular/angular/issues/36230
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/7d45e9054e5e4ef5b6f5a1c593201c91d2428f5cfbd6eb4d5b67ab49ebad9ecb/angular/angular/issues/36230
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/core. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using Ivy) This also w...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameIgorAufricht
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/36230#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36230
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36230
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/36230
Reloadhttps://github.com/angular/angular/issues/36230
Reloadhttps://github.com/angular/angular/issues/36230
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36230
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36230
LOCALE_ID accessed in tests before APP_INITIALIZER runs (with Ivy)https://github.com/angular/angular/issues/36230#top
https://github.com/AndrewKushnir
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/IgorAufricht
IgorAufrichthttps://github.com/IgorAufricht
on Mar 24, 2020https://github.com/angular/angular/issues/36230#issue-587056894
#34830https://github.com/angular/angular/pull/34830
https://github.com/IgorAufricht/angular-locale-id-test-reprohttps://github.com/IgorAufricht/angular-locale-id-test-repro
#34830https://github.com/angular/angular/pull/34830
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
on Mar 24, 2020https://github.com/angular/angular/issues/36230#issuecomment-603371585
@IgorAufrichthttps://github.com/IgorAufricht
angular/packages/core/testing/src/r3_test_bed_compiler.tshttps://github.com/angular/angular/blob/4419907b08948b9f7b3b835658d319a4573ea374/packages/core/testing/src/r3_test_bed_compiler.ts#L260-L266
4419907https://github.com/angular/angular/commit/4419907b08948b9f7b3b835658d319a4573ea374
test_bed.tshttps://github.com/angular/angular/blob/master/packages/core/testing/src/test_bed.ts#L413
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
on Mar 24, 2020https://github.com/angular/angular/issues/36230#event-3160659107
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 24, 2020https://github.com/angular/angular/issues/36230#event-3160659214
AndrewKushnirhttps://github.com/AndrewKushnir
on Mar 24, 2020https://github.com/angular/angular/issues/36230#event-3160659323
AndrewKushnirhttps://github.com/AndrewKushnir
on Mar 25, 2020https://github.com/angular/angular/issues/36230#event-3162025752
fix(core): run `APP_INITIALIZER`s before accessing `LOCALE_ID` token …https://github.com/AndrewKushnir/angular/commit/359c56bc332a0849b5f7a7c0e6c03ba6977469ca
https://docs.github.com/articles/closing-issues-via-commit-messages
359c56bhttps://github.com/AndrewKushnir/angular/commit/359c56bc332a0849b5f7a7c0e6c03ba6977469ca
AndrewKushnirhttps://github.com/AndrewKushnir
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Mar 25, 2020https://github.com/angular/angular/issues/36230#event-3162034903
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Mar 25, 2020https://github.com/angular/angular/issues/36230#event-3162034921
alxhubhttps://github.com/alxhub
on Mar 27, 2020https://github.com/angular/angular/issues/36230#event-3173529101
fix(core): run `APP_INITIALIZER`s before accessing `LOCALE_ID` token …https://github.com/angular/angular/commit/5c28af0e74ba96800c5f151ae772b3b13f9fc228
https://docs.github.com/articles/closing-issues-via-commit-messages
5c28af0https://github.com/angular/angular/commit/5c28af0e74ba96800c5f151ae772b3b13f9fc228
alxhubhttps://github.com/alxhub
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
1649743https://github.com/angular/angular/commit/16497438d6656c044c4974cbbe4ed32a9127f392
on Mar 27, 2020https://github.com/angular/angular/issues/36230#event-3173529227
https://github.com/AndrewKushnir
AndrewKushnirhttps://github.com/AndrewKushnir
on Mar 27, 2020https://github.com/angular/angular/issues/36230#issuecomment-605197914
@IgorAufrichthttps://github.com/IgorAufricht
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 27, 2020https://github.com/angular/angular/issues/36230#issuecomment-620080922
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 27, 2020https://github.com/angular/angular/issues/36230#event-3276504230
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/36230
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/36230
AndrewKushnirhttps://github.com/AndrewKushnir
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.