René's URL Explorer Experiment


Title: `firstChange` not set properly in `ngOnChanges` for pre-bound properties · Issue #36130 · angular/angular · GitHub

Open Graph Title: `firstChange` not set properly in `ngOnChanges` for pre-bound properties · Issue #36130 · angular/angular

X Title: `firstChange` not set properly in `ngOnChanges` for pre-bound properties · Issue #36130 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? No. Description When a property is set on an element prior to it being attached to the DOM, the initial call to ngOnChanges does not hav...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? No. Description When a property is set on an element prior to it being attached to the DOM, the ...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? No. Description When a property is set on an element prior to it being attached to the DOM, the ...

Opengraph URL: https://github.com/angular/angular/issues/36130

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`firstChange` not set properly in `ngOnChanges` for pre-bound properties","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\nThe issue is caused by package @angular/elements\r\n\r\n### Is this a regression?\r\nNo.\r\n\r\n### Description\r\nWhen a property is set on an element prior to it being attached to the DOM, the initial call to `ngOnChanges` does not have `firstChange` properties set to `true`.\r\n\r\nThis requires code from #36114, to fix #30848 in order for `ngOnChanges` to fire at all -- this is a follow-on issue.\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/antch/angular-elements-lifecycle-hooks\r\nYou can look at console logs to see lifecycle events for both the Native Angular element, and the Custom Element. The reproduction uses artifacts from a [CI build](https://circleci.com/gh/angular/angular/657041#artifacts/containers/0) associated with #36114.\r\n\r\nThere is a secondary issue here, that is -- event listeners on component outputs won't fire during `ngOnInit`, `ngOnChanges`, `ngAfterViewInit`, and `ngAfterContentInit`. This is in contrast to the native element which does fire the callback during these hooks. You can see this by examining the `ul` and `li` elements in each section.\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n*Warning:* This is a build off of CI assets, so this isn't entirely accurate.\r\n\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.6\r\nNode: 10.14.2\r\nOS: darwin x64\r\n\r\nAngular: 9.1.0-next.4\r\n... animations, common, compiler, compiler-cli, core, elements\r\n... forms, language-service, platform-browser\r\n... platform-browser-dynamic, router\r\nIvy Workspace: Yes\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.900.6\r\n@angular-devkit/build-angular     0.900.6\r\n@angular-devkit/build-optimizer   0.900.6\r\n@angular-devkit/build-webpack     0.900.6\r\n@angular-devkit/core              9.0.6\r\n@angular-devkit/schematics        9.0.6\r\n@angular/cli                      9.0.6\r\n@ngtools/webpack                  9.0.6\r\n@schematics/angular               9.0.6\r\n@schematics/update                0.900.6\r\nrxjs                              6.5.4\r\ntypescript                        3.6.5\r\nwebpack                           4.41.2\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/antch","@type":"Person","name":"antch"},"datePublished":"2020-03-18T20:01:22Z","url":"https://github.com/angular/angular/issues/36130"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:abf32bc5-69e8-1586-7887-d189b3cb7866
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCDDC:24ACB9:E98A86:1345BC4:6B00FD78
html-safe-nonce44e3cfc9b5e8352cf2950f01844fbd3a0995f60bd0399aec3f826eead91c3296
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRERDOjI0QUNCOTpFOThBODY6MTM0NUJDNDo2QjAwRkQ3OCIsInZpc2l0b3JfaWQiOiI3OTUyNDk1NTMyMjA1NzM1Mjg4IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac6443acd345007c0a6c721f6d08eddb3feac55d6802cb8d935cabc33226f3dfd6
hovercard-subject-tagissue:583970446
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/36130/issue_layout
twitter:imagehttps://opengraph.githubassets.com/504b6b7a733ae46fb26f7d9aae459c90ffc724c4a9118be3eb3ef1d8263effe7/angular/angular/issues/36130
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/504b6b7a733ae46fb26f7d9aae459c90ffc724c4a9118be3eb3ef1d8263effe7/angular/angular/issues/36130
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/elements Is this a regression? No. Description When a property is set on an element prior to it being attached to the DOM, the ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameantch
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/36130#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36130
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F36130
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/36130
Reloadhttps://github.com/angular/angular/issues/36130
Reloadhttps://github.com/angular/angular/issues/36130
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36130
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/36130
firstChange not set properly in ngOnChanges for pre-bound propertieshttps://github.com/angular/angular/issues/36130#top
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
effort1: hourshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/antch
antchhttps://github.com/antch
on Mar 18, 2020https://github.com/angular/angular/issues/36130#issue-583970446
#36114https://github.com/angular/angular/pull/36114
#30848https://github.com/angular/angular/issues/30848
https://github.com/antch/angular-elements-lifecycle-hookshttps://github.com/antch/angular-elements-lifecycle-hooks
CI buildhttps://circleci.com/gh/angular/angular/657041#artifacts/containers/0
#36114https://github.com/angular/angular/pull/36114
AndrewKushnirhttps://github.com/AndrewKushnir
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
on Mar 18, 2020https://github.com/angular/angular/issues/36130#event-3143088799
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 18, 2020https://github.com/angular/angular/issues/36130#event-3143088901
gkalpakhttps://github.com/gkalpak
effort1: hourshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Mar 19, 2020https://github.com/angular/angular/issues/36130#event-3145304751
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Mar 19, 2020https://github.com/angular/angular/issues/36130#event-3145304825
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Mar 19, 2020https://github.com/angular/angular/issues/36130#issuecomment-601148407
@antchhttps://github.com/antch
#36140https://github.com/angular/angular/pull/36140
gkalpakhttps://github.com/gkalpak
on Mar 19, 2020https://github.com/angular/angular/issues/36130#event-3145383069
fix(elements): correctly set `SimpleChange#firstChange` for pre-exist…https://github.com/gkalpak/angular/commit/30d980fecd8cb3a6dd3ae81cf40a8468c665fa24
https://docs.github.com/articles/closing-issues-via-commit-messages
30d980fhttps://github.com/gkalpak/angular/commit/30d980fecd8cb3a6dd3ae81cf40a8468c665fa24
https://github.com/antch
antchhttps://github.com/antch
on Mar 19, 2020https://github.com/angular/angular/issues/36130#issuecomment-601173628
#36141https://github.com/angular/angular/issues/36141
https://github.com/antch
antchhttps://github.com/antch
on Mar 19, 2020https://github.com/angular/angular/issues/36130#issuecomment-601391790
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Mar 20, 2020https://github.com/angular/angular/issues/36130#issuecomment-601602706
@antchhttps://github.com/antch
mheveryhttps://github.com/mhevery
on Mar 24, 2020https://github.com/angular/angular/issues/36130#event-3160786488
fix(elements): correctly set `SimpleChange#firstChange` for pre-exist…https://github.com/angular/angular/commit/447a60047763c56adcfa382b911addac79a936f7
https://docs.github.com/articles/closing-issues-via-commit-messages
447a600https://github.com/angular/angular/commit/447a60047763c56adcfa382b911addac79a936f7
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
b14ac96https://github.com/angular/angular/commit/b14ac967501c494dec04a749a0b4ac29201f3626
on Mar 24, 2020https://github.com/angular/angular/issues/36130#event-3160786808
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 24, 2020https://github.com/angular/angular/issues/36130#issuecomment-619102863
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 24, 2020https://github.com/angular/angular/issues/36130#event-3270078160
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/36130
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/36130
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
effort1: hourshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22effort1%3A%20hours%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.