René's URL Explorer Experiment


Title: NGCC async mode master issue · Issue #35717 · angular/angular · GitHub

Open Graph Title: NGCC async mode master issue · Issue #35717 · angular/angular

X Title: NGCC async mode master issue · Issue #35717 · angular/angular

Description: This is a master issue of issues/improvements needed for NGCC async mode to be more successful with the CLI integration. Allow termination (CTRL+C) - Currently it is not possible to terminate NGCC async process. Clustering issue - Fork c...

Open Graph Description: This is a master issue of issues/improvements needed for NGCC async mode to be more successful with the CLI integration. Allow termination (CTRL+C) - Currently it is not possible to terminate NGCC ...

X Description: This is a master issue of issues/improvements needed for NGCC async mode to be more successful with the CLI integration. Allow termination (CTRL+C) - Currently it is not possible to terminate NGCC ...

Opengraph URL: https://github.com/angular/angular/issues/35717

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NGCC async mode master issue","articleBody":"This is a master issue of issues/improvements needed for NGCC async mode to be more successful with the CLI integration.\r\n\r\n1) Allow termination (CTRL+C) - Currently it is not possible to terminate NGCC async process. \r\n2) Clustering issue - Fork clustering without properly setting up the master is not ideal when used via the API. More context in: TOOL-1339 (Can be solved by using `cluster.setupMaster`)\r\n3) Unable to provide a custom logger. As a workaround and interim for the issue 2. In the CLI we will most likely setup the cluster master ourselves in the webpack plugin. However with this approach we cannot use a custom logger\r\n\r\n```ts\r\ncluster.setupMaster({\r\n  exec: require.resolve('@angular/compiler-cli/ngcc/main-ngcc.js'),\r\n  args: [\r\n    '--basePath',\r\n    this._nodeModulesDirectory,\r\n    '--propertiesToConsider',\r\n    ...this.propertiesToConsider,\r\n    '--compileAllFormats',\r\n    'false',\r\n    '--async',\r\n  ],\r\n});\r\n```\r\n3) Reduce worker code path - Reduce workers by pointing the cluster workers to start from a different entrypoint (Can use `cluster.setupMaster()`), this should speed up the worker boot time.\r\n4) ~~Don't spawn unneeded workers - Spawning workers is expensive and currently we are spawning unwanted workers, when 1, there are no packages to process, 2, when we need to process a number of packages which is less than the available CPU count - 1~~. Addressed in #35719\r\n5) Running the new integration NGCC async as opposed to NGCC sync during module resolution causes a build time regression of 8/10 seconds on an `ng new` application with Angular Material when all modules have been processed previously. (Seems to be related to `analyzeEntryPoints`) Note: in my app I am importing all material entrypoints. \r\n```ts\r\nimport { BrowserModule } from '@angular/platform-browser';\r\nimport { NgModule } from '@angular/core';\r\n\r\nimport { AppRoutingModule } from './app-routing.module';\r\nimport { AppComponent } from './app.component';\r\nimport { BrowserAnimationsModule } from '@angular/platform-browser/animations';\r\n\r\n\r\nimport { MatExpansionModule } from '@angular/material/expansion';\r\nimport { MatGridListModule } from '@angular/material/grid-list';\r\nimport { MatTreeModule } from '@angular/material/tree';\r\nimport { MatBottomSheetModule } from '@angular/material/bottom-sheet';\r\nimport { MatButtonModule } from '@angular/material/button';\r\nimport { MatButtonToggleModule } from '@angular/material/button-toggle';\r\nimport { MatCardModule } from '@angular/material/card';\r\nimport { MatCheckboxModule } from '@angular/material/checkbox';\r\nimport { MatToolbarModule } from '@angular/material/toolbar';\r\nimport { MatDialogModule } from '@angular/material/dialog';\r\nimport { MatIconModule } from '@angular/material/icon';\r\nimport { MatSortModule } from '@angular/material/sort';\r\nimport { MatTabsModule } from '@angular/material/tabs';\r\nimport { MatSliderModule } from '@angular/material/slider';\r\nimport { MatSlideToggleModule } from '@angular/material/slide-toggle';\r\nimport { MatDividerModule } from '@angular/material/divider';\r\nimport { MatFormFieldModule } from '@angular/material/form-field';\r\nimport { MatBadgeModule } from '@angular/material/badge';\r\nimport { MatSidenavModule } from '@angular/material/sidenav';\r\nimport { MatMenuModule } from '@angular/material/menu';\r\nimport { MatRadioModule } from '@angular/material/radio';\r\nimport { MatTooltipModule } from '@angular/material/tooltip';\r\nimport { MatProgressSpinnerModule } from '@angular/material/progress-spinner';\r\nimport { MatProgressBarModule } from '@angular/material/progress-bar';\r\nimport { MatSelectModule } from '@angular/material/select';\r\nimport { MatListModule } from '@angular/material/list';\r\nimport { MatSnackBarModule } from '@angular/material/snack-bar';\r\nimport { MatStepperModule } from '@angular/material/stepper';\r\nimport { MatChipsModule } from '@angular/material/chips';\r\nimport { MatAutocompleteModule } from '@angular/material/autocomplete';\r\nimport { MatPaginatorModule } from '@angular/material/paginator';\r\nimport { MatInputModule } from '@angular/material/input';\r\nimport { MatDatepickerModule } from '@angular/material/datepicker';\r\n\r\n@NgModule({\r\n  declarations: [\r\n    AppComponent\r\n  ],\r\n  imports: [\r\n    BrowserModule,\r\n    AppRoutingModule,\r\n    BrowserAnimationsModule,\r\n    MatExpansionModule,\r\n    MatGridListModule,\r\n    MatTreeModule,\r\n    MatBottomSheetModule,\r\n    MatButtonModule,\r\n    MatButtonToggleModule,\r\n    MatCardModule,\r\n    MatCheckboxModule,\r\n    MatToolbarModule,\r\n    MatDialogModule,\r\n    MatIconModule,\r\n    MatSortModule,\r\n    MatTabsModule,\r\n    MatSliderModule,\r\n    MatSlideToggleModule,\r\n    MatDividerModule,\r\n    MatFormFieldModule,\r\n    MatBadgeModule,\r\n    MatSidenavModule,\r\n    MatMenuModule,\r\n    MatRadioModule,\r\n    MatTooltipModule,\r\n    MatProgressSpinnerModule,\r\n    MatProgressBarModule,\r\n    MatSelectModule,\r\n    MatListModule,\r\n    MatSnackBarModule,\r\n    MatStepperModule,\r\n    MatChipsModule,\r\n    MatAutocompleteModule,\r\n    MatPaginatorModule,\r\n    MatInputModule,\r\n    MatDatepickerModule\r\n  ],\r\n  providers: [],\r\n  bootstrap: [AppComponent]\r\n})\r\nexport class AppModule { }\r\n```\r\n\r\n6. NGCC Aync will process known packages that we know that they are not compiled using Angular. for instance `@babel/`, `@rollup/`, `postcss-`, `@webassemblyjs` just these amount to approximately 200 packages. While we can add these to the internal NGCC config https://github.com/angular/angular/blob/3cc812711bfcf27feadf4227f5664d6044e3769f/packages/compiler-cli/ngcc/src/packages/configuration.ts#L85-L105 it seems that there are still a lot of IO operations for these packages. Due to the following logic; https://github.com/angular/angular/blob/3cc812711bfcf27feadf4227f5664d6044e3769f/packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.ts#L44-L73\r\n\r\nWhen an entrypoint is ignored the `entryPoints.length` will be `0` and we fallback to the code path of reading it's sub directories.\r\n\r\n7) We are traversing sub node_modules of dependencies that are not Angular packages. - We shouldn't try to process node_modules if the parent is not an Angular library. It is unlikely that an non Angular library has Angular dependencies. Addressed by #35756\r\n\r\n8) NGCC keep traversing the sub directory tree to find sub entry points, when the parent is not an entrypoint. Addressed by #35756\r\n\r\nExample: \r\n```\r\nreaddir /node_modules/@schematics/angular  -> This contains a `package.json`\r\nreaddir /node_modules/@schematics/angular/module -> This doesn't contain a `package.json` we should bail\r\nreaddir /node_modules/@schematics/angular/module/files\r\nreaddir /node_modules/@schematics/angular/module/files/__name@dasherize@if-flat__\r\n```\r\n\r\n//cc @gkalpak & @petebacondarwin","author":{"url":"https://github.com/alan-agius4","@type":"Person","name":"alan-agius4"},"datePublished":"2020-02-27T12:05:58Z","url":"https://github.com/angular/angular/issues/35717"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0fc1a1a3-1f63-b03c-8b83-e669416681e5
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id93A6:172B92:15ED76B:1D452AF:6B013975
html-safe-noncee744ed32a5dc1d416917f4ac93daaceb2d5aadc6fbaf59408071657706349822
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0E2OjE3MkI5MjoxNUVENzZCOjFENDUyQUY6NkIwMTM5NzUiLCJ2aXNpdG9yX2lkIjoiMTcwNTk5NTUxNjUxMTAxMDQ1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc8f41d1766badde021872df715af74e91540d7bafefa89192afbfe7e88b8d761
hovercard-subject-tagissue:572037836
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/35717/issue_layout
twitter:imagehttps://opengraph.githubassets.com/715d98f5363d9d00b6e2a32716db0f2e66bae10ebb0156745c078b97b6badb34/angular/angular/issues/35717
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/715d98f5363d9d00b6e2a32716db0f2e66bae10ebb0156745c078b97b6badb34/angular/angular/issues/35717
og:image:altThis is a master issue of issues/improvements needed for NGCC async mode to be more successful with the CLI integration. Allow termination (CTRL+C) - Currently it is not possible to terminate NGCC ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealan-agius4
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/35717#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35717
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35717
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/35717
Reloadhttps://github.com/angular/angular/issues/35717
Reloadhttps://github.com/angular/angular/issues/35717
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35717
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35717
NGCC async mode master issuehttps://github.com/angular/angular/issues/35717#top
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Feb 27, 2020https://github.com/angular/angular/issues/35717#issue-572037836
perf(ngcc): spawn workers eagerly #35719https://github.com/angular/angular/pull/35719
angular/packages/compiler-cli/ngcc/src/packages/configuration.tshttps://github.com/angular/angular/blob/3cc812711bfcf27feadf4227f5664d6044e3769f/packages/compiler-cli/ngcc/src/packages/configuration.ts#L85-L105
3cc8127https://github.com/angular/angular/commit/3cc812711bfcf27feadf4227f5664d6044e3769f
angular/packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.tshttps://github.com/angular/angular/blob/3cc812711bfcf27feadf4227f5664d6044e3769f/packages/compiler-cli/ngcc/src/entry_point_finder/directory_walker_entry_point_finder.ts#L44-L73
3cc8127https://github.com/angular/angular/commit/3cc812711bfcf27feadf4227f5664d6044e3769f
perf(ngcc): reduce directory traversing #35756https://github.com/angular/angular/pull/35756
perf(ngcc): reduce directory traversing #35756https://github.com/angular/angular/pull/35756
@gkalpakhttps://github.com/gkalpak
@petebacondarwinhttps://github.com/petebacondarwin
alan-agius4https://github.com/alan-agius4
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Feb 27, 2020https://github.com/angular/angular/issues/35717#event-3077622425
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 27, 2020https://github.com/angular/angular/issues/35717#event-3077622491
atscotthttps://github.com/atscott
on Mar 2, 2020https://github.com/angular/angular/issues/35717#event-3088634634
perf(ngcc): spawn workers lazily (#35719)https://github.com/angular/angular/commit/dc40a93317e762540d8a5ca162c92ad5913db80e
#35719https://github.com/angular/angular/pull/35719
dc40a93https://github.com/angular/angular/commit/dc40a93317e762540d8a5ca162c92ad5913db80e
perf(ngcc): spawn workers lazily (#35719) (#35832)https://github.com/angular/angular/commit/525dc6a036c20475ce82c2992ddad148142f46cc
#35719https://github.com/angular/angular/pull/35719
#35832https://github.com/angular/angular/pull/35832
525dc6ahttps://github.com/angular/angular/commit/525dc6a036c20475ce82c2992ddad148142f46cc
matskohttps://github.com/matsko
on Mar 5, 2020https://github.com/angular/angular/issues/35717#event-3102880168
perf(ngcc): reduce directory traversing (#35756)https://github.com/angular/angular/commit/e0a35e13d57f5c4ba3d6c87231e0dd6e0cafd923
#35756https://github.com/angular/angular/pull/35756
e0a35e1https://github.com/angular/angular/commit/e0a35e13d57f5c4ba3d6c87231e0dd6e0cafd923
perf(ngcc): reduce directory traversing (#35756)https://github.com/angular/angular/commit/2eaf420bdfc7fa7e41d41bfbcb75503e16c1603e
#35756https://github.com/angular/angular/pull/35756
2eaf420https://github.com/angular/angular/commit/2eaf420bdfc7fa7e41d41bfbcb75503e16c1603e
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Mar 9, 2020https://github.com/angular/angular/issues/35717#issuecomment-596511859
alan-agius4https://github.com/alan-agius4
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 9, 2020https://github.com/angular/angular/issues/35717#event-3110524245
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 9, 2020https://github.com/angular/angular/issues/35717#issuecomment-611610896
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Apr 9, 2020https://github.com/angular/angular/issues/35717#event-3218961957
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/35717
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/35717
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.