René's URL Explorer Experiment


Title: ES6 template literal expressions not working past v9 · Issue #35584 · angular/angular · GitHub

Open Graph Title: ES6 template literal expressions not working past v9 · Issue #35584 · angular/angular

X Title: ES6 template literal expressions not working past v9 · Issue #35584 · angular/angular

Description: 🐞 bug report Is this a regression? Yes, the previous version in which this bug was not present was: ^8 Description Using a template literal expression used to work until Angular 9, for as long as the template lived in the TS source not i...

Open Graph Description: 🐞 bug report Is this a regression? Yes, the previous version in which this bug was not present was: ^8 Description Using a template literal expression used to work until Angular 9, for as long as t...

X Description: 🐞 bug report Is this a regression? Yes, the previous version in which this bug was not present was: ^8 Description Using a template literal expression used to work until Angular 9, for as long as t...

Opengraph URL: https://github.com/angular/angular/issues/35584

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ES6 template literal expressions not working past v9","articleBody":"# 🐞 bug report\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> Yes, the previous version in which this bug was not present was: ^8\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️-->\r\n\r\nUsing a template literal expression used to work until Angular 9, for as long as the template lived in the TS source not in HTML (_obviously_).\r\n\r\nSince Angular 9 that does not work any longer in one scenario. I am mostly focusing on library builds here:\r\n\r\n**Working**\r\n- build library with Angular 9 Ivy & serve the Angular 9 application\r\n- build library with Angular 8 View Engine & serve the Angular 8 application\r\n- build library with Angular 8 View Engine & serve the Angular 9 application (`ngcc`)\r\n\r\n**Not working**\r\n- build library with Angular 9 View Engine (`ng build lib --prod`) & serve the Angular 9 application (`ngcc`)\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nIn any Angular workspace create a library and do the following:\r\n\r\n```ts\r\nconst enum Demo {\r\n  First\r\n}\r\n\r\n@Component({\r\n  template: `\r\n    Static variable: ${ Demo.First  }\r\n  `\r\n})\r\nexport class DemoComponent {}\r\n```\r\n\r\n## 🔥 Exception or Error\r\n```\r\nerror NG1010: template must be a string\r\n```\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n```\r\nAngular CLI: 9.0.3\r\nNode: 12.15.0\r\nOS: darwin x64\r\n\r\nAngular: 9.0.2\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                            Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect          0.900.3\r\n@angular-devkit/build-angular      0.900.3\r\n@angular-devkit/build-ng-packagr   0.900.3\r\n@angular-devkit/build-optimizer    0.900.3\r\n@angular-devkit/build-webpack      0.900.3\r\n@angular-devkit/core               9.0.3\r\n@angular-devkit/schematics         9.0.3\r\n@angular/cdk                       9.0.1\r\n@angular/cli                       9.0.3\r\n@angular/material                  9.0.1\r\n@ngtools/webpack                   9.0.3\r\n@schematics/angular                9.0.3\r\n@schematics/update                 0.900.3\r\nng-packagr                         9.0.1\r\nrxjs                               6.5.4\r\ntypescript                         3.7.5\r\nwebpack                            4.41.2\r\n```\r\n\r\n**Anything else relevant?**\r\n\r\nI am not 100% sure this was ever officially supported, even though I would have hoped so, since it is native ES6 feature. If it wasn't supported, please close the issue.\r\n\r\nInteresting observation is, that View Engine compiled library from Angular 8 is correctly processed by `ngcc`, while View Engine from Angular 9 surprisingly fails.\r\n\r\n---\r\n\r\n**EDIT**: Seems like an easy reproduction mentioned above is not reproducible any more. I can still reproduce it, if I use literal expressions while binding to input, e.g.: `[title]=\"${variable}\"`.\r\n\r\nReproduction:\r\n- Clone: https://github.com/klemenoslaj/template-literal-expressions-issue\r\n- Execute: `yarn && yarn reproduce`\r\n\r\nResulting in error:\r\n\r\n```\r\ndist/example/fesm2015/example.js:29:19 - error NG1010: template must be a string\r\n\r\n29         template: `\r\n                     ~\r\n30     \u003cbutton [title]=\"${ButtonType.Button}\">Button\u003c/button>\r\n   ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n31   `\r\n   ~~~\r\ndist/example/fesm2015/example.js:39:24 - error NG6001: The class 'ExampleComponent' is listed in the declarations of the NgModule 'ExampleModule', but is not a directive, a component, or a pipe.\r\n```","author":{"url":"https://github.com/klemenoslaj","@type":"Person","name":"klemenoslaj"},"datePublished":"2020-02-20T15:06:04Z","url":"https://github.com/angular/angular/issues/35584"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:55377d15-fcfc-b786-0563-e672ed9a24ad
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id940C:23CF06:136AE45:18E1731:6B01149C
html-safe-nonce8f72481438ec6e101a58fb0fb7f93f2cc39dc3adb078ffcdfe338ac4dd1f0b91
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5NDBDOjIzQ0YwNjoxMzZBRTQ1OjE4RTE3MzE6NkIwMTE0OUMiLCJ2aXNpdG9yX2lkIjoiOTAyOTYwNDI3MDI0MDYxNTk2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacf1b7dca1cc26b84c27efb460d40a38a7f246f0926adf82f6db72dc2231e05139
hovercard-subject-tagissue:568363922
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/35584/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d642a8bb278e448ddf1c47ea47b0341c26024e743748bffa2cbdbbdc879562bd/angular/angular/issues/35584
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d642a8bb278e448ddf1c47ea47b0341c26024e743748bffa2cbdbbdc879562bd/angular/angular/issues/35584
og:image:alt🐞 bug report Is this a regression? Yes, the previous version in which this bug was not present was: ^8 Description Using a template literal expression used to work until Angular 9, for as long as t...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameklemenoslaj
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetcanary-2
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/35584#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35584
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35584
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/35584
Reloadhttps://github.com/angular/angular/issues/35584
Reloadhttps://github.com/angular/angular/issues/35584
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35584
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35584
ES6 template literal expressions not working past v9https://github.com/angular/angular/issues/35584#top
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Feb 20, 2020https://github.com/angular/angular/issues/35584#issue-568363922
https://github.com/klemenoslaj/template-literal-expressions-issuehttps://github.com/klemenoslaj/template-literal-expressions-issue
Nexthttps://github.com/angular/angular/issues/35584?timeline_page=1
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
on Feb 20, 2020https://github.com/angular/angular/issues/35584#event-3056652500
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 20, 2020https://github.com/angular/angular/issues/35584#event-3056652692
https://github.com/paresh-bhave
paresh-bhavehttps://github.com/paresh-bhave
on Feb 26, 2020https://github.com/angular/angular/issues/35584#issuecomment-591359002
@klemenoslajhttps://github.com/klemenoslaj
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Feb 26, 2020https://github.com/angular/angular/issues/35584#issuecomment-591364424
@paresh-bhavehttps://github.com/paresh-bhave
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Feb 27, 2020https://github.com/angular/angular/issues/35584#issuecomment-591815435
@paresh-bhavehttps://github.com/paresh-bhave
@paresh-bhavehttps://github.com/paresh-bhave
https://github.com/paresh-bhave
paresh-bhavehttps://github.com/paresh-bhave
on Mar 2, 2020https://github.com/angular/angular/issues/35584#issuecomment-593468173
@klemenoslajhttps://github.com/klemenoslaj
petebacondarwinhttps://github.com/petebacondarwin
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Mar 2, 2020https://github.com/angular/angular/issues/35584#event-3088657487
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Mar 2, 2020https://github.com/angular/angular/issues/35584#issuecomment-593486905
https://github.com/paresh-bhave
paresh-bhavehttps://github.com/paresh-bhave
on Mar 2, 2020https://github.com/angular/angular/issues/35584#issuecomment-593501995
@petebacondarwinhttps://github.com/petebacondarwin
@klemenoslajhttps://github.com/klemenoslaj
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Mar 2, 2020https://github.com/angular/angular/issues/35584#issuecomment-593520004
petebacondarwinhttps://github.com/petebacondarwin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Mar 2, 2020https://github.com/angular/angular/issues/35584#event-3088927063
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Mar 2, 2020https://github.com/angular/angular/issues/35584#issuecomment-593521613
@petebacondarwinhttps://github.com/petebacondarwin
@paresh-bhavehttps://github.com/paresh-bhave
@petebacondarwinhttps://github.com/petebacondarwin
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Apr 12, 2020https://github.com/angular/angular/issues/35584#issuecomment-612596574
@distributevhttps://github.com/distributev
#36550https://github.com/angular/angular/pull/36550
https://github.com/distributev
distributevhttps://github.com/distributev
on Apr 12, 2020https://github.com/angular/angular/issues/35584#issuecomment-612599101
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Apr 12, 2020https://github.com/angular/angular/issues/35584#issuecomment-612604464
@distributevhttps://github.com/distributev
https://github.com/flowkraft
flowkrafthttps://github.com/flowkraft
on Apr 12, 2020https://github.com/angular/angular/issues/35584#issuecomment-612605390
@JoostKhttps://github.com/JoostK
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Apr 12, 2020https://github.com/angular/angular/issues/35584#issuecomment-612635879
@distributevhttps://github.com/distributev
AndrewKushnirhttps://github.com/AndrewKushnir
on Apr 28, 2020https://github.com/angular/angular/issues/35584#event-3282433628
fix(ngcc): recognize enum declarations emitted in JavaScript (#36550)https://github.com/angular/angular/commit/c440165384893775083798a6f649893b0f687f52
#36550https://github.com/angular/angular/pull/36550
https://docs.github.com/articles/closing-issues-via-commit-messages
c440165https://github.com/angular/angular/commit/c440165384893775083798a6f649893b0f687f52
AndrewKushnirhttps://github.com/AndrewKushnir
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
89c5890https://github.com/angular/angular/commit/89c589085d89205223c440f003dbea43c6523928
on Apr 28, 2020https://github.com/angular/angular/issues/35584#event-3282433763
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 29, 2020https://github.com/angular/angular/issues/35584#issuecomment-636057248
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 29, 2020https://github.com/angular/angular/issues/35584#event-3387866170
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/35584
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/35584
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.