René's URL Explorer Experiment


Title: Zone.js should patch EventEmitter.prototype.off · Issue #35473 · angular/angular · GitHub

Open Graph Title: Zone.js should patch EventEmitter.prototype.off · Issue #35473 · angular/angular

X Title: Zone.js should patch EventEmitter.prototype.off · Issue #35473 · angular/angular

Description: Affected Package The issue is caused by package zone.js Is this a regression? Not to my knowledge. Description When running in Node, and with patching enabled (the default), Zone does not completely patch EventEmitter. Zone patches Event...

Open Graph Description: Affected Package The issue is caused by package zone.js Is this a regression? Not to my knowledge. Description When running in Node, and with patching enabled (the default), Zone does not completel...

X Description: Affected Package The issue is caused by package zone.js Is this a regression? Not to my knowledge. Description When running in Node, and with patching enabled (the default), Zone does not completel...

Opengraph URL: https://github.com/angular/angular/issues/35473

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Zone.js should patch EventEmitter.prototype.off","articleBody":"### Affected Package\r\nThe issue is caused by package zone.js\r\n\r\n### Is this a regression?\r\nNot to my knowledge.\r\n\r\n### Description\r\n\r\nWhen running in Node, and with patching enabled (the default), Zone does not completely patch `EventEmitter`.\r\n\r\nZone patches `EventEmitter.prototype.on` just like it patches `EventEmitter.prototoype.addListener` because `on` is an alias for `addListener`.\r\n\r\nHowever, though `off` is an alias for `removeListener` (added in Node 10.0.0), Zone patches `EventEmitter.prototoype.removeListener` but fails to patch `EventEmitter.prototype.off`.\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nClone this repo: https://github.com/lddubeau/zone-bug1-should-patch-off\r\n\r\nThen run:\r\n\r\n```\r\nnpm install\r\nnode index.js\r\n```\r\n\r\n### Expected Output\r\n\r\n> handler got prior to off\r\n\r\n### Actual Output\r\n\r\n> handler got prior to off\r\n> handler got after off\r\n\r\n### Discussion\r\n\r\nThe after ``off`` is called to remove the handler, the handler is still there. If the ``patch`` variable is set to true to execute the ``if`` branch, then we get the expected results.\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:** I'm just using Zone.js\r\n**Zone.js version:** 0.10.2\r\n**Node.js version:** 12.15.0","author":{"url":"https://github.com/lddubeau","@type":"Person","name":"lddubeau"},"datePublished":"2020-02-15T19:46:25Z","url":"https://github.com/angular/angular/issues/35473"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:32cfa479-f0f6-0631-1ba0-50c495727d51
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC1BE:2F9718:1ADAAC7:23FCE90:6B0165D3
html-safe-nonceea5fba3de1c3f498b83c032d773d8e5fccffd4b5a5bee93260637c2650fe66a2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMUJFOjJGOTcxODoxQURBQUM3OjIzRkNFOTA6NkIwMTY1RDMiLCJ2aXNpdG9yX2lkIjoiMjg1OTMyNDYzMTcxNjgxNjMzOSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac11b92fd19f5bb58bbcd7de5066ea5837d35396c9f1a035b841e09af710648262
hovercard-subject-tagissue:565799564
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/35473/issue_layout
twitter:imagehttps://opengraph.githubassets.com/4b6f6bfb14e3d50f769d130192a9050d16b753be52ad7c97bc85c5ad47f242d1/angular/angular/issues/35473
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/4b6f6bfb14e3d50f769d130192a9050d16b753be52ad7c97bc85c5ad47f242d1/angular/angular/issues/35473
og:image:altAffected Package The issue is caused by package zone.js Is this a regression? Not to my knowledge. Description When running in Node, and with patching enabled (the default), Zone does not completel...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamelddubeau
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/35473#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35473
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35473
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/35473
Reloadhttps://github.com/angular/angular/issues/35473
Reloadhttps://github.com/angular/angular/issues/35473
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35473
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35473
Zone.js should patch EventEmitter.prototype.offhttps://github.com/angular/angular/issues/35473#top
https://github.com/JiaLiPassion
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/lddubeau
lddubeauhttps://github.com/lddubeau
on Feb 15, 2020https://github.com/angular/angular/issues/35473#issue-565799564
https://github.com/lddubeau/zone-bug1-should-patch-offhttps://github.com/lddubeau/zone-bug1-should-patch-off
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
on Feb 15, 2020https://github.com/angular/angular/issues/35473#event-3041177765
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 15, 2020https://github.com/angular/angular/issues/35473#event-3041177773
JiaLiPassionhttps://github.com/JiaLiPassion
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on May 27, 2020https://github.com/angular/angular/issues/35473#event-3377040921
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on May 27, 2020https://github.com/angular/angular/issues/35473#event-3377040994
JiaLiPassionhttps://github.com/JiaLiPassion
on May 27, 2020https://github.com/angular/angular/issues/35473#event-3377041022
mheveryhttps://github.com/mhevery
on Jul 24, 2020https://github.com/angular/angular/issues/35473#event-3585681287
fix(zone.js): patch nodejs EventEmtter.prototype.off (#37863)https://github.com/angular/angular/commit/c4e6f585c513d5dd964e33f39827bef712360c46
#37863https://github.com/angular/angular/pull/37863
https://docs.github.com/articles/closing-issues-via-commit-messages
c4e6f58https://github.com/angular/angular/commit/c4e6f585c513d5dd964e33f39827bef712360c46
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
1822cbchttps://github.com/angular/angular/commit/1822cbcd46653ef1507a5a5be831431f2560b289
on Jul 24, 2020https://github.com/angular/angular/issues/35473#event-3585681361
Splaktarhttps://github.com/Splaktar
on Aug 8, 2020https://github.com/angular/angular/issues/35473#event-3635258255
fix(zone.js): patch nodejs EventEmtter.prototype.off (angular#37863)https://github.com/angular-hispano/angular/commit/f1a92872a4e6ffaf53736bd6e3c7f8294165bf2a
angular#37863https://github.com/angular/angular/pull/37863
https://docs.github.com/articles/closing-issues-via-commit-messages
f1a9287https://github.com/angular-hispano/angular/commit/f1a92872a4e6ffaf53736bd6e3c7f8294165bf2a
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 24, 2020https://github.com/angular/angular/issues/35473#issuecomment-679226127
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 24, 2020https://github.com/angular/angular/issues/35473#event-3686211962
profanishttps://github.com/profanis
on Sep 5, 2020https://github.com/angular/angular/issues/35473#event-3732916622
fix(zone.js): patch nodejs EventEmtter.prototype.off (angular#37863)https://github.com/profanis/angular/commit/5ed1648e03e2c4a063e947c20ea4af6b66db3bca
angular#37863https://github.com/angular/angular/pull/37863
https://docs.github.com/articles/closing-issues-via-commit-messages
5ed1648https://github.com/profanis/angular/commit/5ed1648e03e2c4a063e947c20ea4af6b66db3bca
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/35473
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/35473
JiaLiPassionhttps://github.com/JiaLiPassion
area: zonesIssues related to zone.jshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20zones%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.