René's URL Explorer Experiment


Title: Incorrect NgModule resolution with library and npm link · Issue #35447 · angular/angular · GitHub

Open Graph Title: Incorrect NgModule resolution with library and npm link · Issue #35447 · angular/angular

X Title: Incorrect NgModule resolution with library and npm link · Issue #35447 · angular/angular

Description: 🐞 bug report Affected Package The issue is probably caused by package @angular/compiler-cli. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using Ivy) Description For our project we are...

Open Graph Description: 🐞 bug report Affected Package The issue is probably caused by package @angular/compiler-cli. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using...

X Description: 🐞 bug report Affected Package The issue is probably caused by package @angular/compiler-cli. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using...

Opengraph URL: https://github.com/angular/angular/issues/35447

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Incorrect NgModule resolution with library and npm link","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is probably caused by package @angular/compiler-cli.\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> Yes, the previous version in which this bug was not present was:\r\n^8.2.0 (not using Ivy)\r\n\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️-->\r\nFor our project we are using Angular workspace combined with [lerna](https://github.com/lerna/lerna) (we use lerna mainly to handle versioning and release of our libraries as npm packages). We have a single application and multiple packages. After upgrading to Angular 9, we are getting the following error when trying to build the application:\r\n> Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class\r\n\r\nBecause we use lerna, our libraries are linked inside `node_modules`, which seems to be the problem (and possibly makes this different from the other github issues with the same error). If we remove the link in `node_modules`, the app builds as expected.\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/IgorAufricht/angular-import-not-resolved-repro\r\n\r\nThe steps are included in the readme, but for clarity, here they are:\r\n* `git clone https://github.com/IgorAufricht/angular-import-not-resolved-repro.git && cd angular-import-not-resolved-repro`\r\n* `npm install`\r\n* `ng build lib1 --prod && ng build --prod` (builds correctly)\r\n* `cd projects/lib1 && npm link && cd ../.. && npm link lib1` (1)\r\n* `ng build lib1 --prod && ng build --prod` (fails)\r\n\r\n(1) With our lerna setup we use yarn workspaces, but it creates the links in `node_modules` in the same way.\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>ERROR in dist/lib1/lib/lib1.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class\r\n\r\n1 export declare class Lib1Module {\r\n                       ~~~~~~~~~~\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>Angular CLI: 9.0.2\r\nNode: 12.13.1\r\nOS: win32 x64\r\n\r\nAngular: 9.0.1\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                            Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect          0.900.2\r\n@angular-devkit/build-angular      0.900.2\r\n@angular-devkit/build-ng-packagr   0.900.2\r\n@angular-devkit/build-optimizer    0.900.2\r\n@angular-devkit/build-webpack      0.900.2\r\n@angular-devkit/core               9.0.2\r\n@angular-devkit/schematics         9.0.2\r\n@angular/cli                       9.0.2\r\n@ngtools/webpack                   9.0.2\r\n@schematics/angular                9.0.2\r\n@schematics/update                 0.900.2\r\nng-packagr                         9.0.0\r\nrxjs                               6.5.4\r\ntypescript                         3.7.5\r\nwebpack                            4.41.2\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nRelated issue: #35255\r\n","author":{"url":"https://github.com/IgorAufricht","@type":"Person","name":"IgorAufricht"},"datePublished":"2020-02-14T16:03:21Z","url":"https://github.com/angular/angular/issues/35447"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:33a5db58-57ca-36ee-6641-f0824e964749
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB19A:31E99C:1419EBA:1AD6B34:6B012CD9
html-safe-nonceb881eab93785334a15048c89b8198d72e426d519b0663925ae0ed271dda521d4
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTlBOjMxRTk5QzoxNDE5RUJBOjFBRDZCMzQ6NkIwMTJDRDkiLCJ2aXNpdG9yX2lkIjoiNzQ2NDg3MDEyNjgxMTE2Mzg2NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac8bb844adc2b9e1a8ab1dd4a060df255375c4ef52d6e91404c2ce385a2bdbcc7d
hovercard-subject-tagissue:565416853
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/35447/issue_layout
twitter:imagehttps://opengraph.githubassets.com/a4809d2fd05ca2578828c29a0dee984b4f1b43ea61807d61f656bc9df72563f5/angular/angular/issues/35447
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/a4809d2fd05ca2578828c29a0dee984b4f1b43ea61807d61f656bc9df72563f5/angular/angular/issues/35447
og:image:alt🐞 bug report Affected Package The issue is probably caused by package @angular/compiler-cli. Is this a regression? Yes, the previous version in which this bug was not present was: ^8.2.0 (not using...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameIgorAufricht
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/35447#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35447
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F35447
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/35447
Reloadhttps://github.com/angular/angular/issues/35447
Reloadhttps://github.com/angular/angular/issues/35447
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35447
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/35447
Incorrect NgModule resolution with library and npm linkhttps://github.com/angular/angular/issues/35447#top
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/IgorAufricht
IgorAufrichthttps://github.com/IgorAufricht
on Feb 14, 2020https://github.com/angular/angular/issues/35447#issue-565416853
lernahttps://github.com/lerna/lerna
https://github.com/IgorAufricht/angular-import-not-resolved-reprohttps://github.com/IgorAufricht/angular-import-not-resolved-repro
#35255https://github.com/angular/angular/issues/35255
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Feb 14, 2020https://github.com/angular/angular/issues/35447#issuecomment-586360814
#33395https://github.com/angular/angular/issues/33395
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
on Feb 15, 2020https://github.com/angular/angular/issues/35447#event-3040768892
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Feb 15, 2020https://github.com/angular/angular/issues/35447#event-3040768903
https://github.com/FranzZemen
FranzZemenhttps://github.com/FranzZemen
on Feb 16, 2020https://github.com/angular/angular/issues/35447#issuecomment-586734378
https://github.com/IgorAufricht
IgorAufrichthttps://github.com/IgorAufricht
on Feb 17, 2020https://github.com/angular/angular/issues/35447#issuecomment-586878367
@FranzZemenhttps://github.com/FranzZemen
https://github.com/okko
okkohttps://github.com/okko
on Feb 18, 2020https://github.com/angular/angular/issues/35447#issuecomment-587418056
https://angular.io/guide/ivy#speeding-up-ngcc-compilationhttps://angular.io/guide/ivy#speeding-up-ngcc-compilation
https://github.com/andreialecu
andreialecuhttps://github.com/andreialecu
on Feb 28, 2020https://github.com/angular/angular/issues/35447#issuecomment-592397975
#35747https://github.com/angular/angular/issues/35747
https://github.com/PrizmaticAtmos
PrizmaticAtmoshttps://github.com/PrizmaticAtmos
on Mar 24, 2020https://github.com/angular/angular/issues/35447#issuecomment-603554173
@okkohttps://github.com/okko
petebacondarwinhttps://github.com/petebacondarwin
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Mar 25, 2020https://github.com/angular/angular/issues/35447#event-3164453506
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on May 24, 2020https://github.com/angular/angular/issues/35447#issuecomment-633282587
#33395https://github.com/angular/angular/issues/33395
petebacondarwinhttps://github.com/petebacondarwin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 24, 2020https://github.com/angular/angular/issues/35447#event-3368230860
petebacondarwinhttps://github.com/petebacondarwin
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
on May 24, 2020https://github.com/angular/angular/issues/35447#event-3368230952
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 24, 2020https://github.com/angular/angular/issues/35447#issuecomment-648916743
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 24, 2020https://github.com/angular/angular/issues/35447#event-3478253117
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/35447
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/35447
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.