René's URL Explorer Experiment


Title: ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths · Issue #34755 · angular/angular · GitHub

Open Graph Title: ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths · Issue #34755 · angular/angular

X Title: ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths · Issue #34755 · angular/angular

Description: 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two libraries. One library gets published an...

Open Graph Description: 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two ...

X Description: 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two ...

Opengraph URL: https://github.com/angular/angular/issues/34755

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\nProbably `@angular-devkit/build-angular` or `@angular/compiler`.\r\n\r\n### Is this a regression?\r\nWorks with v8.\r\n\r\n### Description\r\nWe are using a monorepo setup with 1 application and two libraries. One library gets published and one is private. In short:\r\n* lib1 component library published to internal nexus\r\n* lib2 private to the monorepo consuming lib1\r\n* documentation app for lib1 consuming both lib1 and lib2, in the reproduction sample it only consumes lib2 for simplicity\r\n* for the application build we point to the build artifacts in the `dist` folder via tsconfig paths\r\n\r\nI created a simple reproduction repository:\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/rc6\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/master with RC8\r\n\r\nLib1 has a secondary entry point for a button component. Lib2 uses the button in a component. Both libraries build correctly but then ngcc fails during the application build.\r\n\r\nRun `npm run build:all` which will build the libraries and then the application, all in production mode meaning the libraries with view engine.\r\n\r\nIn the rc6 branch the error is\r\n```\r\nERROR in Failed to compile entry-point lib2 due to compilation errors:\r\ndist/lib1/button/button.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of Lib2Module, but could not be resolved to an NgModule class\r\n\r\n1 export declare class ButtonModule {\r\n```\r\n\r\nOn the master branch with rc8:\r\n`ERROR in Cannot read property 'injectorImports' of undefined`\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/rc6\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/master\r\n\r\nRun `npm ci` and `npm run build:all` on both branches to see the errors.\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\nERROR in Failed to compile entry-point lib2 due to compilation errors:\r\ndist/lib1/button/button.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of Lib2Module, but could not be resolved to an NgModule class\r\n\r\n1 export declare class ButtonModule {\r\n\u003c/code>\u003c/pre>\r\n\r\n\u003cpre>\u003ccode>\r\nERROR in Cannot read property 'injectorImports' of undefined\r\n\u003c/code>\u003c/pre>\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-rc.8\r\nNode: 12.13.0\r\nOS: darwin x64\r\n\r\nAngular: 9.0.0-rc.8\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage                            Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect          0.900.0-rc.8\r\n@angular-devkit/build-angular      0.900.0-rc.8\r\n@angular-devkit/build-ng-packagr   0.900.0-rc.8\r\n@angular-devkit/build-optimizer    0.900.0-rc.8\r\n@angular-devkit/build-webpack      0.900.0-rc.8\r\n@angular-devkit/core               9.0.0-rc.8\r\n@angular-devkit/schematics         9.0.0-rc.8\r\n@ngtools/webpack                   9.0.0-rc.8\r\n@schematics/angular                9.0.0-rc.8\r\n@schematics/update                 0.900.0-rc.8\r\nng-packagr                         9.0.0-rc.3\r\nrxjs                               6.5.3\r\ntypescript                         3.6.4\r\nwebpack                            4.41.2\r\n\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/Phil147","@type":"Person","name":"Phil147"},"datePublished":"2020-01-13T12:48:08Z","url":"https://github.com/angular/angular/issues/34755"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:19f03df0-ff28-d2de-c6e5-07f980c4f204
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB190:B1B84:50163F:655255:6B010DE3
html-safe-nonce4bd37a37d362a32436dd06016031245bdcc9837a7f03bf422f1c46cdea62c3be
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTkwOkIxQjg0OjUwMTYzRjo2NTUyNTU6NkIwMTBERTMiLCJ2aXNpdG9yX2lkIjoiMzc1NDQ2MjQ0ODMyNTgyMzk3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac0169bd4a2da8fff5e9ce6f9419e1262c9d2d66f80b2cb532ed5a3ed80ce57d59
hovercard-subject-tagissue:548908337
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34755/issue_layout
twitter:imagehttps://opengraph.githubassets.com/9b7853d3e7e6ff992f770cc5f62d1031d425006811e1243cbd8a354a04a9514e/angular/angular/issues/34755
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/9b7853d3e7e6ff992f770cc5f62d1031d425006811e1243cbd8a354a04a9514e/angular/angular/issues/34755
og:image:alt🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamePhil147
hostnamegithub.com
expected-hostnamegithub.com
Nonecb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/34755#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34755
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34755
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/34755
Reloadhttps://github.com/angular/angular/issues/34755
Reloadhttps://github.com/angular/angular/issues/34755
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34755
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34755
ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig pathshttps://github.com/angular/angular/issues/34755#top
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/Phil147
Phil147https://github.com/Phil147
on Jan 13, 2020https://github.com/angular/angular/issues/34755#issue-548908337
https://github.com/Phil147/ngcc-monorepo/tree/rc6https://github.com/Phil147/ngcc-monorepo/tree/rc6
https://github.com/Phil147/ngcc-monorepo/tree/masterhttps://github.com/Phil147/ngcc-monorepo/tree/master
https://github.com/Phil147/ngcc-monorepo/tree/rc6https://github.com/Phil147/ngcc-monorepo/tree/rc6
https://github.com/Phil147/ngcc-monorepo/tree/masterhttps://github.com/Phil147/ngcc-monorepo/tree/master
https://github.com/mlakmal
mlakmalhttps://github.com/mlakmal
on Jan 13, 2020https://github.com/angular/angular/issues/34755#issuecomment-573684885
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Jan 13, 2020https://github.com/angular/angular/issues/34755#event-2944897132
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jan 13, 2020https://github.com/angular/angular/issues/34755#event-2944897236
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Jan 14, 2020https://github.com/angular/angular/issues/34755#issuecomment-574419410
#34500https://github.com/angular/angular/issues/34500
alxhubhttps://github.com/alxhub
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jan 14, 2020https://github.com/angular/angular/issues/34755#event-2948964818
https://github.com/Phil147
Phil147https://github.com/Phil147
on Jan 14, 2020https://github.com/angular/angular/issues/34755#issuecomment-574421740
@alxhubhttps://github.com/alxhub
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Jan 14, 2020https://github.com/angular/angular/issues/34755#issuecomment-574424451
@Phil147https://github.com/Phil147
#34500https://github.com/angular/angular/issues/34500
#34508https://github.com/angular/angular/pull/34508
https://github.com/Phil147
Phil147https://github.com/Phil147
on Feb 2, 2020https://github.com/angular/angular/issues/34755#issuecomment-581148205
@alxhubhttps://github.com/alxhub
https://github.com/Phil147/ngcc-monorepo/tree/masterhttps://github.com/Phil147/ngcc-monorepo/tree/master
alxhubhttps://github.com/alxhub
on Feb 6, 2020https://github.com/angular/angular/issues/34755#event-3015842199
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Feb 7, 2020https://github.com/angular/angular/issues/34755#issuecomment-583347618
#35188 (comment)https://github.com/angular/angular/issues/35188#issuecomment-583290309
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Feb 7, 2020https://github.com/angular/angular/issues/34755#issuecomment-583412107
#35227https://github.com/angular/angular/pull/35227
petebacondarwinhttps://github.com/petebacondarwin
fix(ngcc): ensure that path-mapped secondary entry-points are processed correctly #35227https://github.com/angular/angular/pull/35227
on Feb 7, 2020https://github.com/angular/angular/issues/34755#event-3017841202
petebacondarwinhttps://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Feb 7, 2020https://github.com/angular/angular/issues/34755#event-3017844997
https://github.com/Phil147
Phil147https://github.com/Phil147
on Feb 8, 2020https://github.com/angular/angular/issues/34755#issuecomment-583749260
@petebacondarwinhttps://github.com/petebacondarwin
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Feb 8, 2020https://github.com/angular/angular/issues/34755#issuecomment-583754053
https://github.com/angular/compiler-cli-builds#be5a9df8d5759975533849e268b4191c5465efechttps://github.com/angular/compiler-cli-builds#be5a9df8d5759975533849e268b4191c5465efec
https://github.com/Phil147
Phil147https://github.com/Phil147
on Feb 8, 2020https://github.com/angular/angular/issues/34755#issuecomment-583770932
@petebacondarwinhttps://github.com/petebacondarwin
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Feb 8, 2020https://github.com/angular/angular/issues/34755#issuecomment-583779534
https://github.com/ARTWINPRO
ARTWINPROhttps://github.com/ARTWINPRO
on Feb 10, 2020https://github.com/angular/angular/issues/34755#issuecomment-584031021
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Feb 10, 2020https://github.com/angular/angular/issues/34755#issuecomment-584033484
@ARTWINPROhttps://github.com/ARTWINPRO
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Feb 10, 2020https://github.com/angular/angular/issues/34755#issuecomment-584033766
#35227https://github.com/angular/angular/pull/35227
petebacondarwinhttps://github.com/petebacondarwin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Feb 10, 2020https://github.com/angular/angular/issues/34755#event-3021942935
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 12, 2020https://github.com/angular/angular/issues/34755#issuecomment-598272941
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Mar 12, 2020https://github.com/angular/angular/issues/34755#event-3123499734
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/34755
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/34755
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.