Title: ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths · Issue #34755 · angular/angular · GitHub
Open Graph Title: ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths · Issue #34755 · angular/angular
X Title: ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths · Issue #34755 · angular/angular
Description: 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two libraries. One library gets published an...
Open Graph Description: 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two ...
X Description: 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two ...
Opengraph URL: https://github.com/angular/angular/issues/34755
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngcc fails in monorepo setup with libraries built with view engine and consumed with tsconfig paths","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\nProbably `@angular-devkit/build-angular` or `@angular/compiler`.\r\n\r\n### Is this a regression?\r\nWorks with v8.\r\n\r\n### Description\r\nWe are using a monorepo setup with 1 application and two libraries. One library gets published and one is private. In short:\r\n* lib1 component library published to internal nexus\r\n* lib2 private to the monorepo consuming lib1\r\n* documentation app for lib1 consuming both lib1 and lib2, in the reproduction sample it only consumes lib2 for simplicity\r\n* for the application build we point to the build artifacts in the `dist` folder via tsconfig paths\r\n\r\nI created a simple reproduction repository:\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/rc6\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/master with RC8\r\n\r\nLib1 has a secondary entry point for a button component. Lib2 uses the button in a component. Both libraries build correctly but then ngcc fails during the application build.\r\n\r\nRun `npm run build:all` which will build the libraries and then the application, all in production mode meaning the libraries with view engine.\r\n\r\nIn the rc6 branch the error is\r\n```\r\nERROR in Failed to compile entry-point lib2 due to compilation errors:\r\ndist/lib1/button/button.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of Lib2Module, but could not be resolved to an NgModule class\r\n\r\n1 export declare class ButtonModule {\r\n```\r\n\r\nOn the master branch with rc8:\r\n`ERROR in Cannot read property 'injectorImports' of undefined`\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/rc6\r\nhttps://github.com/Phil147/ngcc-monorepo/tree/master\r\n\r\nRun `npm ci` and `npm run build:all` on both branches to see the errors.\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\nERROR in Failed to compile entry-point lib2 due to compilation errors:\r\ndist/lib1/button/button.module.d.ts:1:22 - error NG6002: Appears in the NgModule.imports of Lib2Module, but could not be resolved to an NgModule class\r\n\r\n1 export declare class ButtonModule {\r\n\u003c/code>\u003c/pre>\r\n\r\n\u003cpre>\u003ccode>\r\nERROR in Cannot read property 'injectorImports' of undefined\r\n\u003c/code>\u003c/pre>\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-rc.8\r\nNode: 12.13.0\r\nOS: darwin x64\r\n\r\nAngular: 9.0.0-rc.8\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\nIvy Workspace: Yes\r\n\r\nPackage Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect 0.900.0-rc.8\r\n@angular-devkit/build-angular 0.900.0-rc.8\r\n@angular-devkit/build-ng-packagr 0.900.0-rc.8\r\n@angular-devkit/build-optimizer 0.900.0-rc.8\r\n@angular-devkit/build-webpack 0.900.0-rc.8\r\n@angular-devkit/core 9.0.0-rc.8\r\n@angular-devkit/schematics 9.0.0-rc.8\r\n@ngtools/webpack 9.0.0-rc.8\r\n@schematics/angular 9.0.0-rc.8\r\n@schematics/update 0.900.0-rc.8\r\nng-packagr 9.0.0-rc.3\r\nrxjs 6.5.3\r\ntypescript 3.6.4\r\nwebpack 4.41.2\r\n\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/Phil147","@type":"Person","name":"Phil147"},"datePublished":"2020-01-13T12:48:08Z","url":"https://github.com/angular/angular/issues/34755"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:19f03df0-ff28-d2de-c6e5-07f980c4f204 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B190:B1B84:50163F:655255:6B010DE3 |
| html-safe-nonce | 4bd37a37d362a32436dd06016031245bdcc9837a7f03bf422f1c46cdea62c3be |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTkwOkIxQjg0OjUwMTYzRjo2NTUyNTU6NkIwMTBERTMiLCJ2aXNpdG9yX2lkIjoiMzc1NDQ2MjQ0ODMyNTgyMzk3MSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 0169bd4a2da8fff5e9ce6f9419e1262c9d2d66f80b2cb532ed5a3ed80ce57d59 |
| hovercard-subject-tag | issue:548908337 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34755/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9b7853d3e7e6ff992f770cc5f62d1031d425006811e1243cbd8a354a04a9514e/angular/angular/issues/34755 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b7853d3e7e6ff992f770cc5f62d1031d425006811e1243cbd8a354a04a9514e/angular/angular/issues/34755 |
| og:image:alt | 🐞 bug report Affected Package Probably @angular-devkit/build-angular or @angular/compiler. Is this a regression? Works with v8. Description We are using a monorepo setup with 1 application and two ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | Phil147 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cb7fa109eca7d4156c889f474306b0e91336055e9adf8fd4684b61e49094d124 |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 2b59d31a4e44f08b7af67a4b67f8fd0af3befe2a |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width