René's URL Explorer Experiment


Title: incorrect component passed to canDeactivate guard · Issue #34614 · angular/angular · GitHub

Open Graph Title: incorrect component passed to canDeactivate guard · Issue #34614 · angular/angular

X Title: incorrect component passed to canDeactivate guard · Issue #34614 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/router Description For some reason CanDeactivate guard gets called with an incorrect component instance. In this case it should get called with a component that is mou...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/router Description For some reason CanDeactivate guard gets called with an incorrect component instance. In this case it should...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/router Description For some reason CanDeactivate guard gets called with an incorrect component instance. In this case it should...

Opengraph URL: https://github.com/angular/angular/issues/34614

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"incorrect component passed to canDeactivate guard ","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/router\r\n\r\n\r\n### Description\r\n\r\nFor some reason CanDeactivate guard gets called with an incorrect component instance.\r\nIn this case it should get called with a component that is mounted in a named outlet, but gets called with one from primary outlet. See example in stackblitz.\r\n\r\nI'd expect that with configuration like below:\r\n![image](https://user-images.githubusercontent.com/1985429/71674645-0b7a9900-2d7c-11ea-96d6-671a8b7aeb89.png)\r\nThe guard should only be called when `AdminHeaderComponent` is being deactivated and only with this component instance.\r\n\r\nOne notable thing is that the `currentRoute` param is correct!\r\n![image](https://user-images.githubusercontent.com/1985429/71675799-e8051d80-2d7e-11ea-8259-64dbe9015af0.png)\r\n\r\n\r\nEDIT: found a workaround:\r\n```\r\ncanDeactivate(component: HasComponentPendingChanges, currentRoute: ActivatedRouteSnapshot, currentState: RouterStateSnapshot) {\r\n    if (currentRoute.outlet === OVERLAY_OUTLET && this.router['rootContexts'] && this.router['rootContexts'].getContext) {\r\n        const context: OutletContext = this.router['rootContexts'].getContext(OVERLAY_OUTLET);\r\n        if (context && context.outlet && context.outlet.isActivated && context.outlet['activated'].instance) {\r\n            component = context.outlet['activated'].instance;\r\n        }\r\n    }\r\n```\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\r\nhttps://stackblitz.com/edit/angular-named-outlet-yfgsip?file=app%2Fadmin%2Fadmin.module.ts\r\n\r\n\r\n- Open the link\r\n- Open the console\r\n- Click on `admin` link\r\n- Click on `create user` link\r\n- Observe that following message is printed:\r\n```\r\ndeactivating UsersListComponent {}\r\n```\r\n- Now click on `hide navbar` link\r\n![image](https://user-images.githubusercontent.com/1985429/71674811-9065b280-2d7c-11ea-8e51-1b345075419d.png)\r\n\r\n- Observe that following messages are printed:\r\n```\r\ndeactivating CreateUserComponent {}\r\ndeactivating AdminHeaderComponent {}\r\n```\r\n^ all good\r\n- Now the fun begins, click on `admin` and `create user` links again\r\n- Click on `Component 2`\r\n- Observe that following messages are printed:\r\n```\r\ndeactivating UsersListComponent {}\r\ndeactivating CreateUserComponent {}\r\ndeactivating CreateUserComponent {}\r\n```\r\nI'd argue that the last message should state `AdminHeaderComponent`\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n8.2.14\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n","author":{"url":"https://github.com/FDIM","@type":"Person","name":"FDIM"},"datePublished":"2020-01-02T15:28:51Z","url":"https://github.com/angular/angular/issues/34614"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:26755f18-42c6-fee6-4aa5-e2002a0becf4
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idED12:34CAB:1B7E661:2312063:6B015A5B
html-safe-noncef838d65af8c5bc49c5732876bf4e60ff95b5020cd99e9eeba96baf63a4bbad94
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDEyOjM0Q0FCOjFCN0U2NjE6MjMxMjA2Mzo2QjAxNUE1QiIsInZpc2l0b3JfaWQiOiIyODYxNDM3ODI0MzQ1OTIyMTM5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac67f958b4c8b777e41804c2b78ff40bdc676b209524c0b98385661cc71ce45746
hovercard-subject-tagissue:544624529
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34614/issue_layout
twitter:imagehttps://opengraph.githubassets.com/8912382bd377f136a1041e72672189871ad9cf9cd2955996348a675254019204/angular/angular/issues/34614
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/8912382bd377f136a1041e72672189871ad9cf9cd2955996348a675254019204/angular/angular/issues/34614
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/router Description For some reason CanDeactivate guard gets called with an incorrect component instance. In this case it should...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameFDIM
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/34614#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34614
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34614
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/34614
Reloadhttps://github.com/angular/angular/issues/34614
Reloadhttps://github.com/angular/angular/issues/34614
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34614
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34614
#69591https://github.com/angular/angular/pull/69591
incorrect component passed to canDeactivate guard https://github.com/angular/angular/issues/34614#top
#69591https://github.com/angular/angular/pull/69591
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
router: guards/resolvershttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22router%3A%20guards%2Fresolvers%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/FDIM
FDIMhttps://github.com/FDIM
on Jan 2, 2020https://github.com/angular/angular/issues/34614#issue-544624529
https://user-images.githubusercontent.com/1985429/71674645-0b7a9900-2d7c-11ea-96d6-671a8b7aeb89.png
https://user-images.githubusercontent.com/1985429/71675799-e8051d80-2d7e-11ea-8259-64dbe9015af0.png
https://stackblitz.com/edit/angular-named-outlet-yfgsip?file=app%2Fadmin%2Fadmin.module.tshttps://stackblitz.com/edit/angular-named-outlet-yfgsip?file=app%2Fadmin%2Fadmin.module.ts
https://user-images.githubusercontent.com/1985429/71674811-9065b280-2d7c-11ea-8e51-1b345075419d.png
Nexthttps://github.com/angular/angular/issues/34614?timeline_page=1
AndrewKushnirhttps://github.com/AndrewKushnir
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Jan 3, 2020https://github.com/angular/angular/issues/34614#event-2921275730
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jan 3, 2020https://github.com/angular/angular/issues/34614#event-2921275775
atscotthttps://github.com/atscott
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jan 15, 2020https://github.com/angular/angular/issues/34614#event-2949050778
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Jan 15, 2020https://github.com/angular/angular/issues/34614#event-2949050825
https://github.com/martinsik
martinsikhttps://github.com/martinsik
on Mar 28, 2020https://github.com/angular/angular/issues/34614#issuecomment-605526320
https://stackblitz.com/edit/angular-named-outlet-enygni?file=app%2Fapp.component.htmlhttps://stackblitz.com/edit/angular-named-outlet-enygni?file=app%2Fapp.component.html
atscotthttps://github.com/atscott
on Apr 9, 2020https://github.com/angular/angular/issues/34614#event-3219039354
fix(router): pass correct component to canDeactivate checks when usin…https://github.com/martinsik/angular/commit/65775d1f1b702a8f2c81df4217476871117a413f
https://docs.github.com/articles/closing-issues-via-commit-messages
65775d1https://github.com/martinsik/angular/commit/65775d1f1b702a8f2c81df4217476871117a413f
fix(router): pass correct component to canDeactivate checks when usin…https://github.com/angular/angular/commit/8e7f9033a36a105026f8599da2dc9fd6f0d06b0f
https://docs.github.com/articles/closing-issues-via-commit-messages
8e7f903https://github.com/angular/angular/commit/8e7f9033a36a105026f8599da2dc9fd6f0d06b0f
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
80e6c07https://github.com/angular/angular/commit/80e6c07d89d74d71956fb1299c54f5353e255370
on Apr 9, 2020https://github.com/angular/angular/issues/34614#event-3219207445
atscotthttps://github.com/atscott
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
on Jul 8, 2020https://github.com/angular/angular/issues/34614#event-3527430981
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/34614#event-3830234174
https://github.com/krilllind
krilllindhttps://github.com/krilllind
on Nov 19, 2020https://github.com/angular/angular/issues/34614#issuecomment-730562876
https://stackblitz.com/edit/angular-ivy-efvmyh?file=src/app/can-deactivate-page.guard.tshttps://stackblitz.com/edit/angular-ivy-efvmyh?file=src/app/can-deactivate-page.guard.ts
https://github.com/reinvanleirsberghe
reinvanleirsberghehttps://github.com/reinvanleirsberghe
on Jan 8, 2021https://github.com/angular/angular/issues/34614#issuecomment-756617075
@krilllindhttps://github.com/krilllind
https://user-images.githubusercontent.com/4301574/103990885-3323ee80-5192-11eb-853d-e41858c3adb8.png
https://github.com/martinsik
martinsikhttps://github.com/martinsik
on Feb 23, 2022https://github.com/angular/angular/issues/34614#issuecomment-1048766149
https://stackblitz.com/edit/angular-ivy-71zp9t?file=src%2Fapp%2Fapp.module.tshttps://stackblitz.com/edit/angular-ivy-71zp9t?file=src%2Fapp%2Fapp.module.ts
#36302https://github.com/angular/angular/pull/36302
#36302https://github.com/angular/angular/pull/36302
https://github.com/ckorherr
ckorherrhttps://github.com/ckorherr
on May 13, 2022https://github.com/angular/angular/issues/34614#issuecomment-1126551828
https://github.com/ckorherr
ckorherrhttps://github.com/ckorherr
on May 15, 2022https://github.com/angular/angular/issues/34614#issuecomment-1126982852
https://github.com/annervisser
annervisserhttps://github.com/annervisser
on Jul 7, 2022https://github.com/angular/angular/issues/34614#issuecomment-1177205984
https://github.com/annervisser/angular-named-outlet-candeactivate-bug-reprohttps://github.com/annervisser/angular-named-outlet-candeactivate-bug-repro
thePunderWomanhttps://github.com/thePunderWoman
on Aug 18, 2026https://github.com/angular/angular/issues/34614#event-29643102851
fix(router): pass correct component to canDeactivate for named outlet…https://github.com/arturovt/angular/commit/5645428baccb770a9a54cc38fd5ba04fc7155f97
5645428https://github.com/arturovt/angular/commit/5645428baccb770a9a54cc38fd5ba04fc7155f97
fix(router): pass correct component to canDeactivate for named outlet…https://github.com/angular/angular/commit/f1a4c8521296d7414a1eab84352ca7db966f35e2
f1a4c85https://github.com/angular/angular/commit/f1a4c8521296d7414a1eab84352ca7db966f35e2
thePunderWomanhttps://github.com/thePunderWoman
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
#69591https://github.com/angular/angular/pull/69591
on Aug 18, 2026https://github.com/angular/angular/issues/34614#event-29647951021
thePunderWomanhttps://github.com/thePunderWoman
on Aug 18, 2026https://github.com/angular/angular/issues/34614#event-29647953193
fix(router): pass correct component to canDeactivate for named outlet…https://github.com/angular/angular/commit/abe019d5050532c87179cf46e840965e70a78b1b
abe019dhttps://github.com/angular/angular/commit/abe019d5050532c87179cf46e840965e70a78b1b
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 21, 2026https://github.com/angular/angular/issues/34614#issuecomment-6304790358
automatic conversation locking policyhttps://github.com/angular/angular/blob/f0fbced1c55bc8b8ed9df01cea99df42f3e7eae3/contributing-docs/auto-issue-locking.md
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 21, 2026https://github.com/angular/angular/issues/34614#event-33797817295
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/34614
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/34614
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
router: guards/resolvershttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22router%3A%20guards%2Fresolvers%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.