Title: Zone.js doesn't monkey patch MessagePort#onmessage · Issue #34581 · angular/angular · GitHub
Open Graph Title: Zone.js doesn't monkey patch MessagePort#onmessage · Issue #34581 · angular/angular
X Title: Zone.js doesn't monkey patch MessagePort#onmessage · Issue #34581 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? No, I don't think so. Description MessagePort is a native browser API used to asynchronously pass messages between different JS execution...
Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? No, I don't think so. Description MessagePort is a native browser API used to asynchronously pass...
X Description: 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? No, I don't think so. Description MessagePort is a native browser API used to asynchronously ...
Opengraph URL: https://github.com/angular/angular/issues/34581
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Zone.js doesn't monkey patch MessagePort#onmessage","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/zone.js\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> No, I don't think so.\r\n\r\n\r\n### Description\r\n\r\n[MessagePort](https://developer.mozilla.org/en-US/docs/Web/API/MessagePort) is a native browser API used to asynchronously pass messages between different JS execution contexts, which my team uses for communicating across frames.\r\n\r\nWe discovered today that MessagePort is only partially monkey patched. Because MessagePort extends from EventTarget, [zone.js](https://github.com/angular/angular/blob/master/packages/zone.js/STANDARD-APIS.md#browser) does correctly monkeypatch `MessagePort.prototype.addEventListener`, however it doesn't monkeypatch the `onmessage` property.\r\n\r\nMy team is using an internal package within google3 for iframe communication which uses `onmessage` instead of `addEventListener`. We could use `addEventListener` instead of `onmessage` however it's slightly cumbersome because then we need to call [MessagePort#start](https://developer.mozilla.org/en-US/docs/Web/API/MessagePort/start). `onmessage` implicitly calls MessagePort#start and I would guess most people using MessagePort would prefer to use `onmessage` because of this reason.\r\n\r\nGiven that `onmessage` can be monkey-patchable, it would be nice to fill in this hole in zone.js so other folks won't get confused. It took a while to debug this issue and at the very least, it would be good to [document](https://github.com/angular/angular/blob/master/packages/zone.js/STANDARD-APIS.md#browser) this limitation in zone.js (e.g. it only monkey-patches certain asynchronous APIs in MessagePort).\r\n\r\nThanks for your time.\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\ngoogle3 cl/286903174\r\n","author":{"url":"https://github.com/wwwillchen","@type":"Person","name":"wwwillchen"},"datePublished":"2019-12-27T23:09:04Z","url":"https://github.com/angular/angular/issues/34581"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:29567976-d162-1544-1182-23a8509aaf62 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D7AE:31E99C:1A40C39:230242B:6B015605 |
| html-safe-nonce | ca983812598adb05ce1b0ee12b7f1cd6edd237cfec22ccc3ebcfa3e91096232d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEN0FFOjMxRTk5QzoxQTQwQzM5OjIzMDI0MkI6NkIwMTU2MDUiLCJ2aXNpdG9yX2lkIjoiNzg4NjE4NTA3MjU2MTMxMzI4NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 9e74926b5ca8f79702519d41b76679d6b0f65a4b52d026268759e79cd714940d |
| hovercard-subject-tag | issue:543015821 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34581/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f4b236a800b7a274770379f93b0148bd8b813977797211516571121046fb156d/angular/angular/issues/34581 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f4b236a800b7a274770379f93b0148bd8b813977797211516571121046fb156d/angular/angular/issues/34581 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by package @angular/zone.js Is this a regression? No, I don't think so. Description MessagePort is a native browser API used to asynchronously pass... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | wwwillchen |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width