René's URL Explorer Experiment


Title: ngcc: processed umd bundles fail with syntax errors in IE11 · Issue #34525 · angular/angular · GitHub

Open Graph Title: ngcc: processed umd bundles fail with syntax errors in IE11 · Issue #34525 · angular/angular

X Title: ngcc: processed umd bundles fail with syntax errors in IE11 · Issue #34525 · angular/angular

Description: 🐞 bug report Affected Package @angular/compiler-cli - ngcc Is this a regression? Yes, this doesn't seem to happen in Angular v9.0.0-rc.6 Description Processed UMD bundles sometimes seem to have superfluous comma tokens that break evaluat...

Open Graph Description: 🐞 bug report Affected Package @angular/compiler-cli - ngcc Is this a regression? Yes, this doesn't seem to happen in Angular v9.0.0-rc.6 Description Processed UMD bundles sometimes seem to have sup...

X Description: 🐞 bug report Affected Package @angular/compiler-cli - ngcc Is this a regression? Yes, this doesn't seem to happen in Angular v9.0.0-rc.6 Description Processed UMD bundles sometimes seem to have...

Opengraph URL: https://github.com/angular/angular/issues/34525

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngcc: processed umd bundles fail with syntax errors in IE11","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\r\n@angular/compiler-cli - ngcc\r\n\r\n### Is this a regression?\r\n\r\nYes, this doesn't seem to happen in Angular v9.0.0-rc.6\r\n\r\n### Description\r\n\r\nProcessed UMD bundles sometimes seem to have superfluous comma tokens that break evaluation of the file in IE11.\r\n\r\n```js\r\n// First broken code                                           ↓  \r\n... factory(exports, require('rxjs'), require('rxjs/operators'),) :\r\n\r\n// Second superfluous comma                                     ↓  \r\n... define('@angular/core', ['exports', 'rxjs', 'rxjs/operators',]\r\n\r\n// Third broken code                       ↓  \r\n}(this, (function (exports, rxjs, operators,) { 'use strict';\r\n```\r\n\r\nNote: This all seems to happen in the canonical AMD module header. It seems to happen three times per bundle. Basically every time the dependencies of the AMD module are specified.\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nhttps://github.com/devversion/ie11-ngcc-compat\r\n\r\n## 🔥 Exception or Error\r\n```\r\nSCRIPT1002: Syntax Error\r\ncore.umd.js (8,128)\r\n```\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\r\nAngular v9.0.0-rc.7","author":{"url":"https://github.com/devversion","@type":"Person","name":"devversion"},"datePublished":"2019-12-21T11:28:51Z","url":"https://github.com/angular/angular/issues/34525"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:069c3ec9-82f2-b42c-55f6-e80e1e1a120f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id8386:38E318:B83915:E8317D:6B013145
html-safe-nonce2e8f2efa5ce7e0e506c6f2ee535e8ce0724b478ce410427acbeadca232015a68
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4Mzg2OjM4RTMxODpCODM5MTU6RTgzMTdEOjZCMDEzMTQ1IiwidmlzaXRvcl9pZCI6IjM0Njc1ODI1OTQ1NzU1Nzc0MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac67efedded0916db5cb2e8a4434aa71bf88ce1a7a732fea557ddf1eee84836d1c
hovercard-subject-tagissue:541316727
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34525/issue_layout
twitter:imagehttps://opengraph.githubassets.com/29b6aafc17f7b06cb4f9cdbb54792f512e7e65e4c6231c19528a8849c7671fb8/angular/angular/issues/34525
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/29b6aafc17f7b06cb4f9cdbb54792f512e7e65e4c6231c19528a8849c7671fb8/angular/angular/issues/34525
og:image:alt🐞 bug report Affected Package @angular/compiler-cli - ngcc Is this a regression? Yes, this doesn't seem to happen in Angular v9.0.0-rc.6 Description Processed UMD bundles sometimes seem to have sup...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamedevversion
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/34525#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34525
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34525
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/34525
Reloadhttps://github.com/angular/angular/issues/34525
Reloadhttps://github.com/angular/angular/issues/34525
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34525
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34525
ngcc: processed umd bundles fail with syntax errors in IE11https://github.com/angular/angular/issues/34525#top
https://github.com/gkalpak
v9.x-candidateshttps://github.com/angular/angular/milestone/89
https://github.com/devversion
devversionhttps://github.com/devversion
on Dec 21, 2019https://github.com/angular/angular/issues/34525#issue-541316727
https://github.com/devversion/ie11-ngcc-compathttps://github.com/devversion/ie11-ngcc-compat
devversionhttps://github.com/devversion
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Dec 21, 2019https://github.com/angular/angular/issues/34525#event-2902650762
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Dec 21, 2019https://github.com/angular/angular/issues/34525#event-2902650775
devversionhttps://github.com/devversion
needsTriagehttps://github.com/angular/angular/milestone/83
v9-candidateshttps://github.com/angular/angular/milestone/89
on Dec 21, 2019https://github.com/angular/angular/issues/34525#event-2902651554
gkalpakhttps://github.com/gkalpak
on Dec 21, 2019https://github.com/angular/angular/issues/34525#event-2902745016
alxhubhttps://github.com/alxhub
on Jan 7, 2020https://github.com/angular/angular/issues/34525#event-2928652866
fix(ngcc): do not add trailing commas in UMD imports (#34545)https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
#34545https://github.com/angular/angular/pull/34545
https://docs.github.com/articles/closing-issues-via-commit-messages
e6850a3https://github.com/angular/angular/commit/e6850a3c519846d2742f29707a910e977edd5997
alxhubhttps://github.com/alxhub
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
10e2935https://github.com/angular/angular/commit/10e29355db1864ba89cf5695dfc9c1e4017afc98
on Jan 7, 2020https://github.com/angular/angular/issues/34525#event-2928652955
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Feb 7, 2020https://github.com/angular/angular/issues/34525#issuecomment-583471685
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Feb 7, 2020https://github.com/angular/angular/issues/34525#event-3018193412
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/34525
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/34525
gkalpakhttps://github.com/gkalpak
v9.x-candidateshttps://github.com/angular/angular/milestone/89
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.