René's URL Explorer Experiment


Title: Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD · Issue #34191 · angular/angular · GitHub

Open Graph Title: Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD · Issue #34191 · angular/angular

X Title: Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD · Issue #34191 · angular/angular

Description: 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/arturovt/ivy-ngxs-router-plugin-umd-repro c...

Open Graph Description: 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/art...

X Description: 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/art...

Opengraph URL: https://github.com/angular/angular/issues/34191

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Ivy: NGCC incorrectly compiles the \"@ngxs/router-plugin\" as UMD","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n@angular/compiler-cli\r\n\r\n\r\n### Is this a regression?\r\n\r\nYes\r\n\r\n\r\n### Description\r\n\r\nThe NGCC incorrectly compiles the `@ngxs/router-plugin` as UMD.\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/arturovt/ivy-ngxs-router-plugin-umd-repro\r\n\r\n* clone and install dependencies\r\n* check the `postinstall` script\r\n\r\nOr open the `node_modules/@ngxs/router-plugin/bundles/ngxs-router-plugin.umd` file in your IDE and see the generated code at the end of the `factory(....)` function. This has to be something like `global...modules.ngxsFeature.module`.\r\n\r\nProviding screenshot below (this is how it looks like on my PC):\r\n\r\n![image](https://user-images.githubusercontent.com/7337691/69987873-25407a80-1549-11ea-8935-eda123d432c9.png)\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-rc.4\r\nNode: 12.11.1\r\nOS: linux x64\r\n\r\nAngular: 9.0.0-rc.4\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... platform-browser, platform-browser-dynamic, router\r\nIvy Workspace: Yes\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.900.0-rc.4\r\n@angular-devkit/build-angular     0.900.0-rc.4\r\n@angular-devkit/build-optimizer   0.900.0-rc.4\r\n@angular-devkit/build-webpack     0.900.0-rc.4\r\n@angular-devkit/core              9.0.0-rc.4\r\n@angular-devkit/schematics        9.0.0-rc.4\r\n@ngtools/webpack                  9.0.0-rc.4\r\n@schematics/angular               9.0.0-rc.4\r\n@schematics/update                0.900.0-rc.4\r\nrxjs                              6.5.3\r\ntypescript                        3.6.4\r\nwebpack                           4.41.2\r\n\u003c/code>\u003c/pre>\r\n\r\n---\r\n\r\n**UPD**\r\n\r\nI could guess that it emits such code due to the inability to compile this package at all. The compiler behaves differently, because:\r\n\r\n* in 80% of cases it compiles without errors and generates such code\r\n* in 20% of cases it throws during compilation with:\r\n```\r\nError: Error on worker #1: Error: Failed to compile entry-point @ngxs/router-plugin due to compilation errors:\r\nnode_modules/@ngxs/router-plugin/bundles/ngxs-router-plugin.umd.js(1034,34): error TS-991010: Value at position 0 in the NgModule.imports of NgxsRouterPluginModule is not a reference: [object Object]\r\n```","author":{"url":"https://github.com/arturovt","@type":"Person","name":"arturovt"},"datePublished":"2019-12-02T19:18:34Z","url":"https://github.com/angular/angular/issues/34191"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:18c095e1-3e62-700d-e2b5-6373f76ac2ec
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAF44:1087D4:19F3068:22A810A:6B0158FD
html-safe-nonce3589bab25c646bba91aace7452a41fe7600c7c92c239560f776a5ad63bcd8e89
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRjQ0OjEwODdENDoxOUYzMDY4OjIyQTgxMEE6NkIwMTU4RkQiLCJ2aXNpdG9yX2lkIjoiMzIzOTU0MTk4ODg5NDI2NzY0NSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmaca57317356ae84060ab9384ddd7ef21a01b964fc9f754c581ad42f6e1598a3756
hovercard-subject-tagissue:531479410
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34191/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5c21d1f7fea7e6741e94b9b65e3c19ce026b3f28d467e3f01afc60be272fa425/angular/angular/issues/34191
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c21d1f7fea7e6741e94b9b65e3c19ce026b3f28d467e3f01afc60be272fa425/angular/angular/issues/34191
og:image:alt🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/art...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamearturovt
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/34191#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34191
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34191
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/34191
Reloadhttps://github.com/angular/angular/issues/34191
Reloadhttps://github.com/angular/angular/issues/34191
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34191
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34191
Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMDhttps://github.com/angular/angular/issues/34191#top
https://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
v9.x-candidateshttps://github.com/angular/angular/milestone/89
https://github.com/arturovt
arturovthttps://github.com/arturovt
on Dec 2, 2019https://github.com/angular/angular/issues/34191#issue-531479410
https://github.com/arturovt/ivy-ngxs-router-plugin-umd-reprohttps://github.com/arturovt/ivy-ngxs-router-plugin-umd-repro
https://user-images.githubusercontent.com/7337691/69987873-25407a80-1549-11ea-8935-eda123d432c9.png
https://github.com/arturovt
arturovthttps://github.com/arturovt
on Dec 2, 2019https://github.com/angular/angular/issues/34191#issuecomment-560540775
@JoostKhttps://github.com/JoostK
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Dec 2, 2019https://github.com/angular/angular/issues/34191#event-2847269329
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Dec 2, 2019https://github.com/angular/angular/issues/34191#event-2847269365
https://github.com/arturovt
arturovthttps://github.com/arturovt
on Dec 4, 2019https://github.com/angular/angular/issues/34191#issuecomment-561789290
angular/packages/compiler-cli/src/ngtsc/reflection/src/typescript.tshttps://github.com/angular/angular/blob/44623a116158c8048ce61a873ed63a290c039202/packages/compiler-cli/src/ngtsc/reflection/src/typescript.ts#L553-L556
44623a1https://github.com/angular/angular/commit/44623a116158c8048ce61a873ed63a290c039202
https://github.com/markwhitfeld
markwhitfeldhttps://github.com/markwhitfeld
on Dec 5, 2019https://github.com/angular/angular/issues/34191#issuecomment-562253436
@mgechevhttps://github.com/mgechev
https://github.com/markwhitfeld
markwhitfeldhttps://github.com/markwhitfeld
on Dec 5, 2019https://github.com/angular/angular/issues/34191#issuecomment-562253864
petebacondarwinhttps://github.com/petebacondarwin
on Dec 9, 2019https://github.com/angular/angular/issues/34191#event-2865531605
https://github.com/splincode
splincodehttps://github.com/splincode
on Dec 9, 2019https://github.com/angular/angular/issues/34191#issuecomment-563176252
@petebacondarwinhttps://github.com/petebacondarwin
https://circleci.com/gh/ngxs/store/23968?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-linkhttps://circleci.com/gh/ngxs/store/23968?utm_campaign=vcs-integration-link&utm_medium=referral&utm_source=github-build-link
https://user-images.githubusercontent.com/12021443/70429681-27935f00-1a8a-11ea-8dcc-4a5d8aa62521.png
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 9, 2019https://github.com/angular/angular/issues/34191#issuecomment-563202072
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 10, 2019https://github.com/angular/angular/issues/34191#issuecomment-564004308
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Dec 10, 2019https://github.com/angular/angular/issues/34191#issuecomment-564009086
#34169https://github.com/angular/angular/pull/34169
https://github.com/arturovt
arturovthttps://github.com/arturovt
on Dec 10, 2019https://github.com/angular/angular/issues/34191#issuecomment-564267064
@petebacondarwinhttps://github.com/petebacondarwin
https://user-images.githubusercontent.com/7337691/70570530-c01e0200-1ba4-11ea-9b87-e72b47e35c37.png
#34191 (comment)https://github.com/angular/angular/issues/34191#issuecomment-561789290
https://github.com/markwhitfeld
markwhitfeldhttps://github.com/markwhitfeld
on Dec 11, 2019https://github.com/angular/angular/issues/34191#issuecomment-564423158
@arturovthttps://github.com/arturovt
@splincodehttps://github.com/splincode
@gkalpakhttps://github.com/gkalpak
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Dec 11, 2019https://github.com/angular/angular/issues/34191#issuecomment-564491056
#34191 (comment)https://github.com/angular/angular/issues/34191#issuecomment-563176252
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 11, 2019https://github.com/angular/angular/issues/34191#issuecomment-564509312
@arturovthttps://github.com/arturovt
#34254https://github.com/angular/angular/pull/34254
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 11, 2019https://github.com/angular/angular/issues/34191#issuecomment-564520274
https://github.com/arturovt/ivy-ngxs-router-plugin-umd-reprohttps://github.com/arturovt/ivy-ngxs-router-plugin-umd-repro
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 11, 2019https://github.com/angular/angular/issues/34191#issuecomment-564527584
#34254https://github.com/angular/angular/pull/34254
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 11, 2019https://github.com/angular/angular/issues/34191#issuecomment-564698636
#34356https://github.com/angular/angular/pull/34356
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 12, 2019https://github.com/angular/angular/issues/34191#issuecomment-564906499
#34356https://github.com/angular/angular/pull/34356
#34254https://github.com/angular/angular/pull/34254
petebacondarwinhttps://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Dec 12, 2019https://github.com/angular/angular/issues/34191#event-2877402276
petebacondarwinhttps://github.com/petebacondarwin
needsTriagehttps://github.com/angular/angular/milestone/83
v9-candidateshttps://github.com/angular/angular/milestone/89
on Dec 12, 2019https://github.com/angular/angular/issues/34191#event-2877403011
https://github.com/splincode
splincodehttps://github.com/splincode
on Dec 21, 2019https://github.com/angular/angular/issues/34191#issuecomment-568198958
@petebacondarwinhttps://github.com/petebacondarwin
ngxs/store#1506https://github.com/ngxs/store/pull/1506
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 22, 2019https://github.com/angular/angular/issues/34191#issuecomment-568246291
petebacondarwinhttps://github.com/petebacondarwin
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Dec 22, 2019https://github.com/angular/angular/issues/34191#event-2903111387
https://github.com/mgechev
mgechevhttps://github.com/mgechev
on Jan 6, 2020https://github.com/angular/angular/issues/34191#issuecomment-571304573
@splincodehttps://github.com/splincode
angular/ngcc-validationhttps://github.com/angular/ngcc-validation
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Feb 6, 2020https://github.com/angular/angular/issues/34191#issuecomment-582976674
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Feb 6, 2020https://github.com/angular/angular/issues/34191#event-3014480524
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/34191
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/34191
petebacondarwinhttps://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
v9.x-candidateshttps://github.com/angular/angular/milestone/89
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.