Title: Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD · Issue #34191 · angular/angular · GitHub
Open Graph Title: Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD · Issue #34191 · angular/angular
X Title: Ivy: NGCC incorrectly compiles the "@ngxs/router-plugin" as UMD · Issue #34191 · angular/angular
Description: 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/arturovt/ivy-ngxs-router-plugin-umd-repro c...
Open Graph Description: 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/art...
X Description: 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/art...
Opengraph URL: https://github.com/angular/angular/issues/34191
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Ivy: NGCC incorrectly compiles the \"@ngxs/router-plugin\" as UMD","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n@angular/compiler-cli\r\n\r\n\r\n### Is this a regression?\r\n\r\nYes\r\n\r\n\r\n### Description\r\n\r\nThe NGCC incorrectly compiles the `@ngxs/router-plugin` as UMD.\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nhttps://github.com/arturovt/ivy-ngxs-router-plugin-umd-repro\r\n\r\n* clone and install dependencies\r\n* check the `postinstall` script\r\n\r\nOr open the `node_modules/@ngxs/router-plugin/bundles/ngxs-router-plugin.umd` file in your IDE and see the generated code at the end of the `factory(....)` function. This has to be something like `global...modules.ngxsFeature.module`.\r\n\r\nProviding screenshot below (this is how it looks like on my PC):\r\n\r\n\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-rc.4\r\nNode: 12.11.1\r\nOS: linux x64\r\n\r\nAngular: 9.0.0-rc.4\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... platform-browser, platform-browser-dynamic, router\r\nIvy Workspace: Yes\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.900.0-rc.4\r\n@angular-devkit/build-angular 0.900.0-rc.4\r\n@angular-devkit/build-optimizer 0.900.0-rc.4\r\n@angular-devkit/build-webpack 0.900.0-rc.4\r\n@angular-devkit/core 9.0.0-rc.4\r\n@angular-devkit/schematics 9.0.0-rc.4\r\n@ngtools/webpack 9.0.0-rc.4\r\n@schematics/angular 9.0.0-rc.4\r\n@schematics/update 0.900.0-rc.4\r\nrxjs 6.5.3\r\ntypescript 3.6.4\r\nwebpack 4.41.2\r\n\u003c/code>\u003c/pre>\r\n\r\n---\r\n\r\n**UPD**\r\n\r\nI could guess that it emits such code due to the inability to compile this package at all. The compiler behaves differently, because:\r\n\r\n* in 80% of cases it compiles without errors and generates such code\r\n* in 20% of cases it throws during compilation with:\r\n```\r\nError: Error on worker #1: Error: Failed to compile entry-point @ngxs/router-plugin due to compilation errors:\r\nnode_modules/@ngxs/router-plugin/bundles/ngxs-router-plugin.umd.js(1034,34): error TS-991010: Value at position 0 in the NgModule.imports of NgxsRouterPluginModule is not a reference: [object Object]\r\n```","author":{"url":"https://github.com/arturovt","@type":"Person","name":"arturovt"},"datePublished":"2019-12-02T19:18:34Z","url":"https://github.com/angular/angular/issues/34191"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:eec766ed-ca71-8ecd-3968-7ff25a7dde16 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9330:213839:1595A46:1BAA68C:6B01227E |
| html-safe-nonce | d614e615ed560b78737c640401ea965efbd2bd2082de53e9b2683bd092c6e51a |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5MzMwOjIxMzgzOToxNTk1QTQ2OjFCQUE2OEM6NkIwMTIyN0UiLCJ2aXNpdG9yX2lkIjoiNTIyMzc0NTkyNjc4NjUyMzc3NCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 96ef54eef64f23ceb1b777578411371a861ce6f01c8e3ada3728eb416cb44258 |
| hovercard-subject-tag | issue:531479410 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34191/issue_layout |
| twitter:image | https://opengraph.githubassets.com/5c21d1f7fea7e6741e94b9b65e3c19ce026b3f28d467e3f01afc60be272fa425/angular/angular/issues/34191 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/5c21d1f7fea7e6741e94b9b65e3c19ce026b3f28d467e3f01afc60be272fa425/angular/angular/issues/34191 |
| og:image:alt | 🐞 bug report Affected Package @angular/compiler-cli Is this a regression? Yes Description The NGCC incorrectly compiles the @ngxs/router-plugin as UMD. 🔬 Minimal Reproduction https://github.com/art... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | arturovt |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width