René's URL Explorer Experiment


Title: ngcc cannot handle UMD factory without parameters ( renderFactoryParameters ) · Issue #34138 · angular/angular · GitHub

Open Graph Title: ngcc cannot handle UMD factory without parameters ( renderFactoryParameters ) · Issue #34138 · angular/angular

X Title: ngcc cannot handle UMD factory without parameters ( renderFactoryParameters ) · Issue #34138 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? Don't know Description As part of our internal library, we have simple module that has no dependencies (two of them actually, but he...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? Don't know Description As part of our internal library, we have simple module that has no de...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? Don't know Description As part of our internal library, we have simple module that has n...

Opengraph URL: https://github.com/angular/angular/issues/34138

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngcc cannot handle UMD factory without parameters ( renderFactoryParameters )","articleBody":"\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\nThe issue is caused by package @angular/compiler-cli\r\n\r\n### Is this a regression?\r\n\r\nDon't know\r\n\r\n### Description\r\n\r\nAs part of our internal library, we have simple module that has no dependencies (two of them actually, but here I'll pick the primitive one). When compiled, the UMD bundle looks something like this:\r\n\u003cpre>\u003ccode>\r\n(function (global, factory) {\r\n\ttypeof exports === 'object' && typeof module !== 'undefined' ? module.exports = factory() :\r\n\ttypeof define === 'function' && define.amd ? define('us.test', factory) :\r\n\t(global = global || self, (global.us = global.us || {}, global.us.test = factory()));\r\n}(this, (function () { 'use strict';\r\n\r\n\t/**\r\n\t * @fileoverview added by tsickle\r\n\t * @suppress {checkTypes,extraRequire,missingOverride,missingReturn,unusedPrivateMembers,uselessCode} checked by tsc\r\n\t */\r\n\tvar index = \"\";\r\n\r\n\treturn index;\r\n\r\n}))); \r\n\u003c/code>\u003c/pre>\r\n\r\nYou'll  notice that the factory function has no parameters. When calling ngcc on our library (included in another project), the compiler crashes with the error:\r\n\r\n\u003cpre>\r\nCannot read property 'getEnd' of undefined\r\nat renderFactoryParameters (C:\\Test\\node_modules\\@angular\\compiler-cli\\ngcc\\src\\rendering\\umd_rendering_formatter.js:175:64)\r\n    at UmdRenderingFormatter.addImports (C:\\Test\\node_modules\\@angular\\compiler-cli\\ngcc\\src\\rendering\\umd_rendering_formatter.js:50:13)\r\n    at Renderer.renderFile (C:\\Test\\node_modules\\@angular\\compiler-cli\\ngcc\\src\\rendering\\renderer.js:91:35)\r\n    at C:\\Test\\node_modules\\@angular\\compiler-cli\\ngcc\\src\\rendering\\renderer.js:50:84\r\n...\r\n\u003c/pre>\r\nIt would seem, that renderFactoryParameters has no test for parameters.length being zero.\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-rc.4\r\nNode: 10.15.3\r\nOS: win32 x64\r\n\r\nAngular: 9.0.0-rc.4\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... platform-browser, platform-browser-dynamic, router\r\nIvy Workspace: Yes\r\n\r\nPackage                            Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect          0.900.0-rc.4\r\n@angular-devkit/build-angular      0.900.0-rc.4\r\n@angular-devkit/build-ng-packagr   0.900.0-rc.4\r\n@angular-devkit/build-optimizer    0.900.0-rc.4\r\n@angular-devkit/build-webpack      0.900.0-rc.4\r\n@angular-devkit/core               9.0.0-rc.4\r\n@angular-devkit/schematics         9.0.0-rc.4\r\n@angular/cdk                       8.1.2\r\n@angular/http                      \u003cerror>\r\n@ngtools/webpack                   9.0.0-rc.4\r\n@schematics/angular                9.0.0-rc.4\r\n@schematics/update                 0.900.0-rc.4\r\nrxjs                               6.5.3\r\ntypescript                         3.6.4\r\nwebpack                            4.41.2\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/Wintermoose","@type":"Person","name":"Wintermoose"},"datePublished":"2019-11-28T19:26:03Z","url":"https://github.com/angular/angular/issues/34138"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:4979ed94-f628-4189-18b4-a4e3e2ffd9d3
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id87A6:CC1A4:15D5DED:1BC4BCB:6B013118
html-safe-nonce35b508eb2fab19e935226171d20849f91cf742c562d29a62a63291d61f564e29
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4N0E2OkNDMUE0OjE1RDVERUQ6MUJDNEJDQjo2QjAxMzExOCIsInZpc2l0b3JfaWQiOiI4MDk0NTY0NDYwNDIyODM2NTA0IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac65ca3975eee96c3f109ac9292ea4b03e2e77dfcff85fdb33c7a293b7d9369ded
hovercard-subject-tagissue:530054543
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/34138/issue_layout
twitter:imagehttps://opengraph.githubassets.com/078d156b70bc5f9ed810f7be3460d21665fedb50ef095f3693aa80b246b55024/angular/angular/issues/34138
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/078d156b70bc5f9ed810f7be3460d21665fedb50ef095f3693aa80b246b55024/angular/angular/issues/34138
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? Don't know Description As part of our internal library, we have simple module that has no de...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameWintermoose
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/34138#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34138
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F34138
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/34138
Reloadhttps://github.com/angular/angular/issues/34138
Reloadhttps://github.com/angular/angular/issues/34138
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34138
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/34138
ngcc cannot handle UMD factory without parameters ( renderFactoryParameters )https://github.com/angular/angular/issues/34138#top
https://github.com/petebacondarwin
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/Wintermoose
Wintermoosehttps://github.com/Wintermoose
on Nov 28, 2019https://github.com/angular/angular/issues/34138#issue-530054543
mheveryhttps://github.com/mhevery
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Dec 3, 2019https://github.com/angular/angular/issues/34138#event-2852016199
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Dec 3, 2019https://github.com/angular/angular/issues/34138#event-2852016242
alxhubhttps://github.com/alxhub
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Dec 5, 2019https://github.com/angular/angular/issues/34138#event-2859664275
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Dec 5, 2019https://github.com/angular/angular/issues/34138#event-2859664840
alxhubhttps://github.com/alxhub
petebacondarwinhttps://github.com/petebacondarwin
gkalpakhttps://github.com/gkalpak
on Dec 5, 2019https://github.com/angular/angular/issues/34138#event-2859665107
petebacondarwinhttps://github.com/petebacondarwin
gkalpakhttps://github.com/gkalpak
on Dec 11, 2019https://github.com/angular/angular/issues/34138#event-2874681822
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 11, 2019https://github.com/angular/angular/issues/34138#issuecomment-564592502
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Dec 11, 2019https://github.com/angular/angular/issues/34138#issuecomment-564609705
#34353https://github.com/angular/angular/pull/34353
petebacondarwinhttps://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Dec 11, 2019https://github.com/angular/angular/issues/34138#event-2874845481
petebacondarwinhttps://github.com/petebacondarwin
on Dec 12, 2019https://github.com/angular/angular/issues/34138#event-2877041782
fix(ngcc): render UMD imports even if no prior importshttps://github.com/petebacondarwin/angular/commit/eb3c6ec5ea3043d4d3df91ce560e215cc68a627f
https://docs.github.com/articles/closing-issues-via-commit-messages
eb3c6echttps://github.com/petebacondarwin/angular/commit/eb3c6ec5ea3043d4d3df91ce560e215cc68a627f
karahttps://github.com/kara
on Dec 12, 2019https://github.com/angular/angular/issues/34138#event-2878710735
fix(ngcc): render UMD imports even if no prior imports (#34353)https://github.com/angular/angular/commit/c26738df1234e25925d7bd9fe8eca1ebd92fe07e
#34353https://github.com/angular/angular/pull/34353
https://docs.github.com/articles/closing-issues-via-commit-messages
c26738dhttps://github.com/angular/angular/commit/c26738df1234e25925d7bd9fe8eca1ebd92fe07e
karahttps://github.com/kara
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
05c1398https://github.com/angular/angular/commit/05c1398b4dfb903f031656dce3cc58438d1b2121
on Dec 12, 2019https://github.com/angular/angular/issues/34138#event-2878710836
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jan 12, 2020https://github.com/angular/angular/issues/34138#issuecomment-573429678
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jan 12, 2020https://github.com/angular/angular/issues/34138#event-2941330039
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/34138
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/34138
petebacondarwinhttps://github.com/petebacondarwin
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.