Title: Make ZoneAwarePromise spec compliant and compatible with core-js · Issue #33989 · angular/angular · GitHub
Open Graph Title: Make ZoneAwarePromise spec compliant and compatible with core-js · Issue #33989 · angular/angular
X Title: Make ZoneAwarePromise spec compliant and compatible with core-js · Issue #33989 · angular/angular
Description: 🚀 feature request Relevant Package This feature request is for @angular/zone.js Description I'm not an Angular developer so I'm not in much of a position to provide details on the Angular side. I'm a developer working on a webpack applic...
Open Graph Description: 🚀 feature request Relevant Package This feature request is for @angular/zone.js Description I'm not an Angular developer so I'm not in much of a position to provide details on the Angular side. I'm...
X Description: 🚀 feature request Relevant Package This feature request is for @angular/zone.js Description I'm not an Angular developer so I'm not in much of a position to provide details on the Angular s...
Opengraph URL: https://github.com/angular/angular/issues/33989
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Make ZoneAwarePromise spec compliant and compatible with core-js","articleBody":"# 🚀 feature request\r\n\r\n### Relevant Package\r\nThis feature request is for @angular/zone.js\r\n\r\n### Description\r\nI'm not an Angular developer so I'm not in much of a position to provide details on the Angular side. I'm a developer working on a webpack application that uses core-js to provide polyfills and my application is one that other sites can embed in their application.\r\n\r\nThe core-js polyfill does some checks to determine if the system has a spec compliant Promise and if not, it will use its own setting it in the global scope. The ZoneAwarePromise does not pass the core-js checks and as a result gets overridden by core-js with the result being that the Angular application stops functioning.\r\n\r\nMost of the initial responses to this problem is that you should load the core-js application first but in our case that is not an option since we're an external application that is loaded later as an asynchronous embedding.\r\n\r\nThere was an issue file for exactly this in the zone.js repo: https://github.com/angular/zone.js/issues/783 so I'm basically recreating that issue here. That issue was just closed without any actual resolution and then the whole repo was archived when it was merged here.\r\n\r\nThere was a similar question posed in core-js: https://github.com/zloirock/core-js/issues/319 that offers a suggestion for what seems like a simple change that can be made to ZoneAwarePromise that would make it compliant enough to pass the core-js checks.\r\n\r\nThe project that we were causing trouble for was using Angular 7.2.15.\r\n\r\n### Describe the solution you'd like\r\nhttps://github.com/zloirock/core-js/issues/319#issuecomment-317036136\r\n\r\n### Describe alternatives you've considered\r\nIn our webpack application, the solution was to not import the polyfill as part of the webpack configuration but to only do it conditionally if there is no Promise at all:\r\n\r\n```\r\nif (!window.Promise) {\r\n require('core-js/modules/es.promise');\r\n}\r\n```","author":{"url":"https://github.com/TazmanianD","@type":"Person","name":"TazmanianD"},"datePublished":"2019-11-22T16:22:07Z","url":"https://github.com/angular/angular/issues/33989"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:81dcd2bf-3422-f4fa-bd30-d3ae3ef07db1 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 98E6:2270F4:13665FF:19CB6B8:6B012650 |
| html-safe-nonce | e5d37a957106239881768d0da4afe28824dc854c26db096e24d0c4c45ffeffa5 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5OEU2OjIyNzBGNDoxMzY2NUZGOjE5Q0I2Qjg6NkIwMTI2NTAiLCJ2aXNpdG9yX2lkIjoiODcxOTQwNzQwOTQzMDM0MTIwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | b5445ccac7a6d4e73bebd25e17f6e651f2a9781ac6bf7ee4dfaa6a1db57bc3ac |
| hovercard-subject-tag | issue:527290516 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/33989/issue_layout |
| twitter:image | https://opengraph.githubassets.com/0fd825e35a602a95a9d63ffcc4201779b575d19485a1316f21449695986c248a/angular/angular/issues/33989 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/0fd825e35a602a95a9d63ffcc4201779b575d19485a1316f21449695986c248a/angular/angular/issues/33989 |
| og:image:alt | 🚀 feature request Relevant Package This feature request is for @angular/zone.js Description I'm not an Angular developer so I'm not in much of a position to provide details on the Angular side. I'm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | TazmanianD |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width