René's URL Explorer Experiment


Title: ngc does not handle barrel files properly in many situations · Issue #33121 · angular/angular · GitHub

Open Graph Title: ngc does not handle barrel files properly in many situations · Issue #33121 · angular/angular

X Title: ngc does not handle barrel files properly in many situations · Issue #33121 · angular/angular

Description: 🐞 bug report Affected Package The issued is caused by package @angular/compiler-cli Is this a regression? No Description Note: PR #22856 by @jeffora lay the groundwork for proper barrel file support Right now, any path depth with barrel ...

Open Graph Description: 🐞 bug report Affected Package The issued is caused by package @angular/compiler-cli Is this a regression? No Description Note: PR #22856 by @jeffora lay the groundwork for proper barrel file suppor...

X Description: 🐞 bug report Affected Package The issued is caused by package @angular/compiler-cli Is this a regression? No Description Note: PR #22856 by @jeffora lay the groundwork for proper barrel file suppor...

Opengraph URL: https://github.com/angular/angular/issues/33121

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ngc does not handle barrel files properly in many situations","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\nThe issued is caused by package @angular/compiler-cli\r\n\r\n### Is this a regression?\r\nNo\r\n\r\n### Description\r\nNote: PR #22856 by @jeffora lay the groundwork for proper barrel file support\r\n\r\nRight now, any path depth with barrel files fails because `MetadataBundler.resolveModuleName` and a few other methods do not keep track of the parent paths, mostly leading to intermediate paths disappearing.\r\n\r\nWith the following example, no decorator metadata gets added to metadata.json file, and the `MetadataBundler` processes `repro.module` as if it was at `src/repro.module.ts` rather than `src/lib/repro.module.ts` (because `path.dirname(from)` returns `.` for `./lib`, thus losing the path in the process when then joining with `repro.module`).\r\n\r\n\u003cpre>\u003ccode>\r\n// src/public-api.ts\r\nimport * from './lib';\r\n\r\n// src/lib/index.ts\r\nexport {ReproModule} from './repro.module';\r\n\r\n// src/lib/repro.module.ts\r\nimport {NgModule} from '@angular/core';\r\n@NgModule({})\r\nclass ReproModule;\r\nexport {ReproModule};\r\n\u003c/code>\u003c/pre>\r\n\r\nThis is only the case for metadata retrieval, the classes/etc. are properly exported. The metadata.json does not hold any metadata information though.\r\n\r\nWithout barrel files, the metadata.json file is (html tags removed):\r\n\r\n\u003cpre>\u003ccode>\r\n{\r\n    \"__symbolic\": \"module\",\r\n    \"version\": 4,\r\n    \"metadata\": {\r\n        \"ReproService\": {\r\n            \"__symbolic\": \"class\",\r\n            \"decorators\": [{\r\n                \"__symbolic\": \"call\",\r\n                \"expression\": {\r\n                    \"__symbolic\": \"reference\",\r\n                    \"module\": \"@angular/core\",\r\n                    \"name\": \"Injectable\",\r\n                    \"line\": 2,\r\n                    \"character\": 1\r\n                },\r\n                \"arguments\": [{\r\n                    \"providedIn\":\"root\"\r\n                }]\r\n            }],\r\n           \"members\": {\r\n               \"__ctor__\": [{\r\n                   \"__symbolic\": \"constructor\"\r\n               }]\r\n            },\r\n            \"statics\": {\r\n                \"ngInjectableDef\": {}\r\n            }\r\n        },\r\n       ....\r\n}\r\n\u003c/code>\u003c/pre>\r\n\r\nWith barrel files, the metadata.json file is:\r\n\r\n\u003cpre>\u003ccode>\r\n{\r\n    \"__symbolic\": \"module\",\r\n    \"version\": 4,\r\n    \"exports\": [{\r\n        \"from\": \"./repro.service\"\r\n    }, {\r\n        \"from\": \"./repro.component\"\r\n    }, {\r\n        \"from\": \"./repro.module\"\r\n    }],\r\n    \"metadata\": {},\r\n    \"origins\": {},\r\n    \"importAs\": \"repro\"\r\n}\r\n\u003c/code>\u003c/pre>\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003cpre>\u003ccode>\r\ngit clone https://github.com/rraziel/ngc-barrel-repo\r\ncd ngc-barrel-repo; npm i\r\nng build repro\r\ncat dist/repro/repro.metadata.json\r\n\u003c/code>\u003c/pre>\r\n\r\nThe project was created with:\r\n\u003cpre>\u003ccode>\r\nng new ngc-barrel-repro\r\nng generate library repro\r\nadd an index.ts next to repro.module.ts that exports what is exported from public-api.ts\r\nmodify public-api.ts to use index.ts implicitly\r\n\u003c/code>\u003c/pre>\r\n\r\nRelevant files:\r\n- https://github.com/rraziel/ngc-barrel-repo/blob/master/projects/repro/src/public-api.ts\r\n- https://github.com/rraziel/ngc-barrel-repo/blob/master/projects/repro/src/lib/index.ts\r\n\r\n## 🔥 Exception or Error\r\nThe generated *metadata.json file does not contain metadata information (e.g. the NgModule decorator).\r\nMany other issues can also arise depending on how files are imported and generally end up with undefined error messages (undefined module, duplicate undefined keys, etc.).\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 8.3.8\r\nNode: 11.8.0\r\nOS: win32 x64\r\nAngular: 8.2.10\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage                            Version\r\n------------------------------------------------------------\r\n@angular-devkit/architect          0.803.8\r\n@angular-devkit/build-angular      0.803.8\r\n@angular-devkit/build-ng-packagr   0.803.8\r\n@angular-devkit/build-optimizer    0.803.8\r\n@angular-devkit/build-webpack      0.803.8\r\n@angular-devkit/core               8.3.8\r\n@angular-devkit/schematics         8.3.8\r\n@angular/cdk                       8.2.3\r\n@angular/cli                       8.3.8\r\n@ngtools/webpack                   8.3.8\r\n@schematics/angular                8.3.8\r\n@schematics/update                 0.803.8\r\nng-packagr                         5.6.1\r\nrxjs                               6.5.3\r\ntypescript                         3.5.3\r\nwebpack                            4.39.2\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nThis issue makes it very difficult to work with a monorepo (unless going through all the files and manually appending index for all the barrel imports), especially with the current `module undefined` messages as I mostly end up commenting out imports until the build works. Or just adding a console.log with the module name to the bundler code.\r\n","author":{"url":"https://github.com/rraziel","@type":"Person","name":"rraziel"},"datePublished":"2019-10-12T05:00:36Z","url":"https://github.com/angular/angular/issues/33121"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e68a369d-1845-c430-1dab-4f4e423ce437
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idE9A0:7A60E:A2B3DE:D3E621:6B00E5A4
html-safe-nonceb6fcc861dd41d4fb326efd9c5bbb5f7ba53be9ad19e81830851cd3e183551e21
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFOUEwOjdBNjBFOkEyQjNERTpEM0U2MjE6NkIwMEU1QTQiLCJ2aXNpdG9yX2lkIjoiNDI5NTQ0MzI5MTg0MDc2NzM5NyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac7d191ba0ab0dc0e2a384b75d1332b5d443ee703d3578f06db24c429231877e99
hovercard-subject-tagissue:506132820
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/33121/issue_layout
twitter:imagehttps://opengraph.githubassets.com/223a7ee8932931e45de9a760fa5613e8171570c3def0c685e3a8c723dc1b5a11/angular/angular/issues/33121
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/223a7ee8932931e45de9a760fa5613e8171570c3def0c685e3a8c723dc1b5a11/angular/angular/issues/33121
og:image:alt🐞 bug report Affected Package The issued is caused by package @angular/compiler-cli Is this a regression? No Description Note: PR #22856 by @jeffora lay the groundwork for proper barrel file suppor...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerraziel
hostnamegithub.com
expected-hostnamegithub.com
None27088b6977484d0d3321d9a11c907c6d6637b315cfa359ef7952dbf6292f9b14
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release624179fb8b88d26ba5bba08894eb60a1c5a1d93d
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/33121#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F33121
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F33121
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/33121
Reloadhttps://github.com/angular/angular/issues/33121
Reloadhttps://github.com/angular/angular/issues/33121
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/33121
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/33121
ngc does not handle barrel files properly in many situationshttps://github.com/angular/angular/issues/33121#top
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/rraziel
rrazielhttps://github.com/rraziel
on Oct 12, 2019https://github.com/angular/angular/issues/33121#issue-506132820
#22856https://github.com/angular/angular/pull/22856
@jefforahttps://github.com/jeffora
https://github.com/rraziel/ngc-barrel-repo/blob/master/projects/repro/src/public-api.tshttps://github.com/rraziel/ngc-barrel-repo/blob/master/projects/repro/src/public-api.ts
https://github.com/rraziel/ngc-barrel-repo/blob/master/projects/repro/src/lib/index.tshttps://github.com/rraziel/ngc-barrel-repo/blob/master/projects/repro/src/lib/index.ts
https://github.com/rraziel
rrazielhttps://github.com/rraziel
on Oct 12, 2019https://github.com/angular/angular/issues/33121#issuecomment-541285454
@alexeaglehttps://github.com/alexeagle
@alxhubhttps://github.com/alxhub
https://github.com/rraziel
rrazielhttps://github.com/rraziel
on Oct 12, 2019https://github.com/angular/angular/issues/33121#issuecomment-541285615
#23713https://github.com/angular/angular/issues/23713
mheveryhttps://github.com/mhevery
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Oct 14, 2019https://github.com/angular/angular/issues/33121#event-2711173931
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Oct 14, 2019https://github.com/angular/angular/issues/33121#event-2711173961
mheveryhttps://github.com/mhevery
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Nov 12, 2019https://github.com/angular/angular/issues/33121#event-2793363516
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Nov 12, 2019https://github.com/angular/angular/issues/33121#event-2793363585
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Dec 3, 2019https://github.com/angular/angular/issues/33121#event-2850906277
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Dec 3, 2019https://github.com/angular/angular/issues/33121#event-2850906346
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
on Dec 3, 2019https://github.com/angular/angular/issues/33121#event-2850907412
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Dec 3, 2019https://github.com/angular/angular/issues/33121#event-2850907724
alxhubhttps://github.com/alxhub
engine: vehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22engine%3A%20ve%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
fixed by Ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22fixed%20by%20Ivy%22
on May 27, 2020https://github.com/angular/angular/issues/33121#event-3379993509
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on May 27, 2020https://github.com/angular/angular/issues/33121#issuecomment-634933725
@rrazielhttps://github.com/rraziel
#22856https://github.com/angular/angular/pull/22856
https://github.com/rraziel
rrazielhttps://github.com/rraziel
on May 28, 2020https://github.com/angular/angular/issues/33121#issuecomment-635515049
@alxhubhttps://github.com/alxhub
rrazielhttps://github.com/rraziel
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 28, 2020https://github.com/angular/angular/issues/33121#event-3384061272
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 29, 2020https://github.com/angular/angular/issues/33121#issuecomment-651218183
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jun 29, 2020https://github.com/angular/angular/issues/33121#event-3493486288
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/33121
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/33121
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.