Title: Angular 8 -> Angular 9 breaks with ng2-charts · Issue #32748 · angular/angular · GitHub
Open Graph Title: Angular 8 -> Angular 9 breaks with ng2-charts · Issue #32748 · angular/angular
X Title: Angular 8 -> Angular 9 breaks with ng2-charts · Issue #32748 · angular/angular
Description: 🐞 bug report Affected Package ng2-charts https://github.com/valor-software/ng2-charts Is this a regression? Angular 8.2.6 works Angular 9.0.0-next.5 fails Description Everything works as expected with 8.2.6 Upgrading to 9.0.0-next.5 fail...
Open Graph Description: 🐞 bug report Affected Package ng2-charts https://github.com/valor-software/ng2-charts Is this a regression? Angular 8.2.6 works Angular 9.0.0-next.5 fails Description Everything works as expected w...
X Description: 🐞 bug report Affected Package ng2-charts https://github.com/valor-software/ng2-charts Is this a regression? Angular 8.2.6 works Angular 9.0.0-next.5 fails Description Everything works as expected w...
Opengraph URL: https://github.com/angular/angular/issues/32748
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular 8 -> Angular 9 breaks with ng2-charts","articleBody":"\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n`ng2-charts` https://github.com/valor-software/ng2-charts\r\n\r\n\r\n### Is this a regression?\r\nAngular 8.2.6 works\r\nAngular 9.0.0-next.5 fails\r\n\r\n### Description\r\nEverything works as expected with 8.2.6\r\nUpgrading to 9.0.0-next.5 fails to build (Ivy disabled, aot enabled)\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nI created a repository: https://github.com/whyboris/angular-ivy-problem-2\r\n\r\nIt was created with `npm install -g @angular/cli@next` and `ng new angular-ivy-problem-2` which runs. \r\n\r\nBut simply adding `ng2-charts` fails compilation; see PR:\r\nhttps://github.com/whyboris/angular-ivy-problem-2/pull/1/files\r\n\r\nIt is easy to fix, by simply downgrading from angular 9 to angular 8; see PR: \r\nhttps://github.com/whyboris/angular-ivy-problem-2/pull/2/files\r\n\r\nAnother fix is to upgrade from `ng2-charts` version `1.6.0` to latest (`2.3.0`), see PR:\r\nhttps://github.com/whyboris/angular-ivy-problem-2/pull/3/files\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\n\r\nERROR in node_modules/ng2-charts/charts/charts.d.ts:53:22 - error TS-996002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class\r\n\r\n53 export declare class ChartsModule {\r\n ~~~~~~~~~~~~\r\nsrc/app/app.component.html:413:25 - error TS8002: 'ngSwitch' is not a valid property of \u003cdiv>.\r\n\r\n413 \u003cdiv class=\"terminal\" [ngSwitch]=\"selection.value\">\r\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n\r\n src/app/app.component.ts:5:16\r\n 5 templateUrl: './app.component.html',\r\n ~~~~~~~~~~~~~~~~~~~~~~\r\n Error occurs in the template of component AppComponent.\r\nsrc/app/app.component.html:531:1 - error TS8001: 'router-outlet' is not a valid HTML element.\r\n\r\n531 \u003crouter-outlet>\u003c/router-outlet>\r\n ~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~\r\n\r\n src/app/app.component.ts:5:16\r\n 5 templateUrl: './app.component.html',\r\n ~~~~~~~~~~~~~~~~~~~~~~\r\n Error occurs in the template of component AppComponent.\r\n\r\n** Angular Live Development Server is listening on localhost:4200, open your browser on http://localhost:4200/ **\r\nℹ 「wdm」: Failed to compile.\r\nℹ 「wdm」: Compiling...\r\n95% emitting CopyPlugin \r\n ERROR in node_modules/ng2-charts/charts/charts.d.ts(53,22): error TS-996002: Appears in the NgModule.imports of AppModule, but could not be resolved to an NgModule class\r\n src/app/app.component.html(413,25): error TS8002: 'ngSwitch' is not a valid property of \u003cdiv>.\r\n src/app/app.component.html(531,1): error TS8001: 'router-outlet' is not a valid HTML element.\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-next.4\r\nNode: 12.10.0\r\nOS: darwin x64\r\nAngular: 9.0.0-next.6\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.900.0-next.4\r\n@angular-devkit/build-angular 0.900.0-next.4\r\n@angular-devkit/build-optimizer 0.900.0-next.4\r\n@angular-devkit/build-webpack 0.900.0-next.4\r\n@angular-devkit/core 9.0.0-next.4\r\n@angular-devkit/schematics 9.0.0-next.4\r\n@angular/cli 9.0.0-next.4\r\n@ngtools/webpack 9.0.0-next.4\r\n@schematics/angular 9.0.0-next.4\r\n@schematics/update 0.900.0-next.4\r\nrxjs 6.4.0\r\ntypescript 3.5.3\r\nwebpack 4.39.3\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nVery similar to another issue I opened: https://github.com/angular/angular/issues/32729\r\n\r\nI think it's acceptable to expect users of Angular to upgrade external libraries they use (e.g. `ng2-charts`), but I wanted to note this since the original intention behind _Angular 9_ was that it would work out of the box for all users with minimal changes 🤷♂ \r\n\r\nPlease keep up the wonderful work ❤️ 🙇 I love working with Angular and with the Angular team (the few times I have interacted) 🙌 ","author":{"url":"https://github.com/whyboris","@type":"Person","name":"whyboris"},"datePublished":"2019-09-18T17:59:30Z","url":"https://github.com/angular/angular/issues/32748"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:29616690-1826-4144-bc3d-bd85916a3dac |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | ED3E:154D88:ADEFB0:DD9E8E:6B01316D |
| html-safe-nonce | 757eda53d3a0dc1beda883a6a446c6b49767e263e35bf0895a2c89f821dcc2e4 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDNFOjE1NEQ4ODpBREVGQjA6REQ5RThFOjZCMDEzMTZEIiwidmlzaXRvcl9pZCI6IjI1MTIwNzI2NzMyNDk1Mzg0MTMiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 170903d40956ec8250074108a373a0882343f8d98c25ffe30fdaa1365c01f809 |
| hovercard-subject-tag | issue:495372709 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/32748/issue_layout |
| twitter:image | https://opengraph.githubassets.com/9b451e9ea02e6828fa28539b5cb3ac64c71f6299eb132a8ed7a86a2f9654659b/angular/angular/issues/32748 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/9b451e9ea02e6828fa28539b5cb3ac64c71f6299eb132a8ed7a86a2f9654659b/angular/angular/issues/32748 |
| og:image:alt | 🐞 bug report Affected Package ng2-charts https://github.com/valor-software/ng2-charts Is this a regression? Angular 8.2.6 works Angular 9.0.0-next.5 fails Description Everything works as expected w... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | whyboris |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width