René's URL Explorer Experiment


Title: ivy loses query results in abstract @Directive() when CLI rebuilt (file change) · Issue #32416 · angular/angular · GitHub

Open Graph Title: ivy loses query results in abstract @Directive() when CLI rebuilt (file change) · Issue #32416 · angular/angular

X Title: ivy loses query results in abstract @Directive() when CLI rebuilt (file change) · Issue #32416 · angular/angular

Description: 🐞 Bug report Command - [x] serve Description In IVY v9 (see here), we'll need to add abstract @Directive() on abstracts classes we extends that contain Angular stuff (like Input, ViewChild, DI). After add @Directive() on my abstract clas...

Open Graph Description: 🐞 Bug report Command - [x] serve Description In IVY v9 (see here), we'll need to add abstract @Directive() on abstracts classes we extends that contain Angular stuff (like Input, ViewChild, DI). Af...

X Description: 🐞 Bug report Command - [x] serve Description In IVY v9 (see here), we'll need to add abstract @Directive() on abstracts classes we extends that contain Angular stuff (like Input, ViewChild, DI)...

Opengraph URL: https://github.com/angular/angular/issues/32416

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy loses query results in abstract @Directive() when CLI rebuilt (file change)","articleBody":"# 🐞 Bug report\r\n\r\n### Command\r\n```\r\n- [x] serve\r\n```\r\n\r\n### Description\r\nIn IVY v9 ([see here](https://github.com/angular/angular/commit/405515091040759c1e65e79b0dde3ab77e04975e)), we'll need to add abstract `@Directive()` on abstracts classes we extends that contain Angular stuff (like Input, ViewChild, DI).\r\nAfter add `@Directive()` on my abstract class and run `ng serve` everything works well. \r\nBut If I edit abstract directive file and save, browser autoreload but query results are not resolved anymore ?!?! \r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nOne line repro : \r\n`git clone https://github.com/elvisbegovic/issue-ivy-abstract-directive.git && cd issue-ivy-abstract-directive && npm i && ng s`\r\n\r\nOpen browser localhost:4200, open devtools console, you will see consoel without error, viewchild is available.\r\n\r\nEdit or comment anything in [any-abstract-class.ts](https://github.com/elvisbegovic/issue-ivy-abstract-directive/blob/master/src/app/any-abstract-class.ts#L10-L21) file (cli rebuild + autoreload browser) you can see error at runtime that viewchild `this.myList` is undefined.\r\n\r\nGIF:\r\n![ivyrebuild](https://user-images.githubusercontent.com/2789203/64019596-dccf8600-cb2f-11e9-8d0c-83661c5dba21.gif)\r\n\r\n\r\n\r\n## 🔥 Exception or Error\r\nAfter browser auto reload :\r\n\u003cpre>\u003ccode>\r\nERROR TypeError: Cannot read property 'name' of undefined\r\n    at AppComponent.ngOnInit (any-abstract-class.ts:11)\r\n    at AppComponent.ngOnInit (app.component.ts:17)\r\n    at callHook (core.js:7864)\r\n    at callHooks (core.js:7828)\r\n    at executeInitAndCheckHooks (core.js:7769)\r\n    at refreshView (core.js:12199)\r\n    at renderComponentOrTemplate (core.js:12288)\r\n    at tickRootContext (core.js:13648)\r\n    at detectChangesInRootView (core.js:13683)\r\n    at RootViewRef.detectChanges (core.js:15205)\r\n\u003c/code>\u003c/pre>\r\n\r\nIn CLI console : \r\n` ERROR in src/app/app.component.ts(8,5): error TS8001: 'my-list' is not a valid HTML element.`\r\n\r\n## 🌍 Your Environment\r\n\u003cdetails>\r\n\u003csummary>See environment\u003c/summary>\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 9.0.0-next.2\r\nNode: 12.9.1\r\nOS: win32 x64\r\nAngular: 9.0.0-next.4\r\n... animations, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.900.0-next.2\r\n@angular-devkit/build-angular     0.900.0-next.2\r\n@angular-devkit/build-optimizer   0.900.0-next.2\r\n@angular-devkit/build-webpack     0.900.0-next.2\r\n@angular-devkit/core              9.0.0-next.2\r\n@angular-devkit/schematics        9.0.0-next.2\r\n@angular/cli                      9.0.0-next.2\r\n@ngtools/webpack                  9.0.0-next.2\r\n@schematics/angular               9.0.0-next.2\r\n@schematics/update                0.900.0-next.2\r\nrxjs                              6.4.0\r\ntypescript                        3.5.3\r\nwebpack                           4.39.3\r\n\u003c/code>\u003c/pre>\r\n\r\n\u003c/details>\r\n\r\n**Anything else relevant?**\r\nProblem is only when you edit `any-abstract-class.ts` file, if after first build you edit other file = no error.\r\n\r\nIf I add `selector` to Directive and add it to NgModule` declarations[]`, all works as before.\r\n\r\nThis is working in View Engine (jit and aot and without decorating abstract classes) \r\n\r\nMaybe related to https://github.com/angular/angular/issues/31560 and all referenced issues\r\n\r\nMaybe this can live on angular/angular ? ","author":{"url":"https://github.com/elvisbegovic","@type":"Person","name":"elvisbegovic"},"datePublished":"2019-08-30T12:17:21Z","url":"https://github.com/angular/angular/issues/32416"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:ea2d869e-9eb5-d12d-2034-9b4f774459e2
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idECAE:1AE20C:17BF9FA:1E14CF6:6B013946
html-safe-noncec9bba2d5113f6093e4b128f44e637502f605d6cb81777d103be8b9a15ccf94c9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFQ0FFOjFBRTIwQzoxN0JGOUZBOjFFMTRDRjY6NkIwMTM5NDYiLCJ2aXNpdG9yX2lkIjoiMzUxNTgyMTMyMjE5MjEwNzg0NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdcf78ec98965a8626ae7960b8c727a879d5ff4645e505e65b7621efdd4b69c9e
hovercard-subject-tagissue:487455839
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/32416/issue_layout
twitter:imagehttps://opengraph.githubassets.com/df9d49221e988c615ebe626f55886a85fab6adb2cdc8f621ff2155ac926d0bdf/angular/angular/issues/32416
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/df9d49221e988c615ebe626f55886a85fab6adb2cdc8f621ff2155ac926d0bdf/angular/angular/issues/32416
og:image:alt🐞 Bug report Command - [x] serve Description In IVY v9 (see here), we'll need to add abstract @Directive() on abstracts classes we extends that contain Angular stuff (like Input, ViewChild, DI). Af...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameelvisbegovic
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/32416#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F32416
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F32416
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/32416
Reloadhttps://github.com/angular/angular/issues/32416
Reloadhttps://github.com/angular/angular/issues/32416
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/32416
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/32416
ivy loses query results in abstract @Directive() when CLI rebuilt (file change)https://github.com/angular/angular/issues/32416#top
https://github.com/JoostK
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/elvisbegovic
elvisbegovichttps://github.com/elvisbegovic
on Aug 30, 2019https://github.com/angular/angular/issues/32416#issue-487455839
see herehttps://github.com/angular/angular/commit/405515091040759c1e65e79b0dde3ab77e04975e
any-abstract-class.tshttps://github.com/elvisbegovic/issue-ivy-abstract-directive/blob/master/src/app/any-abstract-class.ts#L10-L21
https://user-images.githubusercontent.com/2789203/64019596-dccf8600-cb2f-11e9-8d0c-83661c5dba21.gif
#31560https://github.com/angular/angular/issues/31560
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Aug 30, 2019https://github.com/angular/angular/issues/32416#issuecomment-526581529
petebacondarwinhttps://github.com/petebacondarwin
angular/angular-clihttps://github.com/angular/angular-cli
on Aug 30, 2019https://github.com/angular/angular/issues/32416#event-2597008523
petebacondarwinhttps://github.com/petebacondarwin
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Aug 30, 2019https://github.com/angular/angular/issues/32416#event-2597009157
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 30, 2019https://github.com/angular/angular/issues/32416#event-2597009194
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Aug 30, 2019https://github.com/angular/angular/issues/32416#issuecomment-526583880
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Sep 5, 2019https://github.com/angular/angular/issues/32416#issuecomment-528614113
alxhubhttps://github.com/alxhub
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity2: inconvenienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity2%3A%20inconvenient%22
on Sep 5, 2019https://github.com/angular/angular/issues/32416#event-2612524300
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Sep 5, 2019https://github.com/angular/angular/issues/32416#event-2612524332
https://github.com/elvisbegovic
elvisbegovichttps://github.com/elvisbegovic
on Oct 2, 2019https://github.com/angular/angular/issues/32416#issuecomment-537603717
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Oct 3, 2019https://github.com/angular/angular/issues/32416#issuecomment-537963925
https://github.com/brgrz
brgrzhttps://github.com/brgrz
on Oct 20, 2019https://github.com/angular/angular/issues/32416#issuecomment-544229671
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Oct 30, 2019https://github.com/angular/angular/issues/32416#issuecomment-548120468
angular/packages/compiler-cli/src/ngtsc/scope/src/local.tshttps://github.com/angular/angular/blob/a42057d0f8ea3f8bd7c0afc2b92a29f1800cf787/packages/compiler-cli/src/ngtsc/scope/src/local.ts#L113-L119
a42057dhttps://github.com/angular/angular/commit/a42057d0f8ea3f8bd7c0afc2b92a29f1800cf787
angular/packages/compiler-cli/src/ngtsc/scope/src/local.tshttps://github.com/angular/angular/blob/a42057d0f8ea3f8bd7c0afc2b92a29f1800cf787/packages/compiler-cli/src/ngtsc/scope/src/local.ts#L129-L131
a42057dhttps://github.com/angular/angular/commit/a42057d0f8ea3f8bd7c0afc2b92a29f1800cf787
JoostKhttps://github.com/JoostK
on Oct 31, 2019https://github.com/angular/angular/issues/32416#event-2761157591
JoostKhttps://github.com/JoostK
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Nov 2, 2019https://github.com/angular/angular/issues/32416#event-2765648327
karahttps://github.com/kara
on Nov 12, 2019https://github.com/angular/angular/issues/32416#event-2793158246
fix(ivy): ensure module scope is rebuild on dependent change (#33522)https://github.com/angular/angular/commit/71238a95d977b8dbc5db7ce28e811929e8358d64
#33522https://github.com/angular/angular/pull/33522
https://docs.github.com/articles/closing-issues-via-commit-messages
71238a9https://github.com/angular/angular/commit/71238a95d977b8dbc5db7ce28e811929e8358d64
karahttps://github.com/kara
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
15f8638https://github.com/angular/angular/commit/15f8638b1cbc376a8a769ea0b1e62a8f4613cd31
on Nov 12, 2019https://github.com/angular/angular/issues/32416#event-2793158403
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Dec 13, 2019https://github.com/angular/angular/issues/32416#issuecomment-565497521
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Dec 13, 2019https://github.com/angular/angular/issues/32416#event-2881850351
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/32416
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/32416
JoostKhttps://github.com/JoostK
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.