René's URL Explorer Experiment


Title: Compile errors when using async pipe with enableIvy & strictNullChecks · Issue #32051 · angular/angular · GitHub

Open Graph Title: Compile errors when using async pipe with enableIvy & strictNullChecks · Issue #32051 · angular/angular

X Title: Compile errors when using async pipe with enableIvy & strictNullChecks · Issue #32051 · angular/angular

Description: 🐞 bug report Affected Package @angular/compiler-cli, @angular/angular Is this a regression? Yes, this works when Ivy is not used. Description The problem is the async pipe returns T | null. My understand is Ivy uses code similar to Parti...

Open Graph Description: 🐞 bug report Affected Package @angular/compiler-cli, @angular/angular Is this a regression? Yes, this works when Ivy is not used. Description The problem is the async pipe returns T | null. My unde...

X Description: 🐞 bug report Affected Package @angular/compiler-cli, @angular/angular Is this a regression? Yes, this works when Ivy is not used. Description The problem is the async pipe returns T | null. My unde...

Opengraph URL: https://github.com/angular/angular/issues/32051

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Compile errors when using async pipe with enableIvy & strictNullChecks","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n@angular/compiler-cli, @angular/angular\r\n\r\n\r\n### Is this a regression?\r\n\r\nYes, this works when Ivy is not used.\r\n\r\n\r\n### Description\r\n\r\nThe problem is the async pipe returns T | null. My understand is Ivy uses code similar to Partial\u003cPick\u003cChildComponent, 'prop'>> to check property bindings in templates. That allows undefined, but not null. Similarly, ngForOf doesn't allow null, so that also doesn't work with async.\r\n\r\nThis causes templates that previously compiled without errors to fail.\r\n```\r\n    \u003c!-- Must be built with strictNullChecks && enableIvy to see the errors below -->\r\n    \u003cul>\r\n      \u003c!-- Type 'string[] | null' is not assignable to type 'string[] | Iterable\u003cstring> | undefined' -->\r\n      \u003cli *ngFor=\"let n of array$ | async\">{{n}}\u003c/li>\r\n    \u003c/ul>\r\n    \u003c!-- Type 'number | null' is not assignable to type 'number | undefined' -->\r\n    \u003capp-child [prop]=\"value$ | async\">\u003c/app-child>\r\n```\r\n\r\nWe use ngrx/store, so we use the async pipe a lot, and for the most part the observables from the store will always return a value immediately. But async's return type means we have to deal with the null somehow even if it will never be emitted.\r\n\r\nI've come up with several workarounds, but I don't like any of them very much.  And even if this is seen as behaving as intended, documentation should be updated (e.g. the example in https://angular.io/api/common/NgForOf#local-variables wouldn't work with strictNullChecks && enableIvy).\r\n\r\nWorkarounds:\r\n1) Using non null assertions [prop]=(value$ | async)!\"\r\n\r\n  I don't like this since I don't want developers to get used to throwing it around causally.\r\n\r\n2) Use || to provide a default, *ngFor=\"let i of (array$ | async) || []\"\r\n\r\n  This works okay for the ngFor case, but doesn't work for the prop case if one of the valid values is falsey, or if there is no good default value.\r\n\r\n3) Use ngIf with async, *ngIf=\"value$ | async as value\"\r\n\r\n  This is probably a good choice for the cases where the async pipe would legitimately be null, but is just needlessly cluttering template with ng-contianer or other elements in the cases where the async pipe will never return null.  It also doesn't work when the pipe will return a falsey value.\r\n\r\n4) Create a \"present\" pipe that throws if it's input is null/undefined and converts T | null to just T\r\n\r\n  Alternatively create a currentValue pipe that combines async & present, which could limit the input to Observable\u003cT> (since the other options would just cause it to throw anyway).\r\n\r\n  This works but it makes the template expressions longer, and if it's not built into @angular/angular its more for new devs on the team to understand.\r\n \r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nI've created a repo showing this issue:\r\nhttps://github.com/james-schwartzkopf/test-template/blob/master/src/app/app.component.ts\r\n\r\n## 🔥 Exception or Error\r\nSee Above\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n$ ng --version\r\n\r\n     _                      _                 ____ _     ___\r\n    / \\   _ __   __ _ _   _| | __ _ _ __     / ___| |   |_ _|\r\n   / △ \\ | '_ \\ / _` | | | | |/ _` | '__|   | |   | |    | |\r\n  / ___ \\| | | | (_| | |_| | | (_| | |      | |___| |___ | |\r\n /_/   \\_\\_| |_|\\__, |\\__,_|_|\\__,_|_|       \\____|_____|___|\r\n                |___/\r\n    \r\n\r\nAngular CLI: 8.2.0\r\nNode: 10.15.1\r\nOS: win32 x64\r\nAngular: 8.2.0\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.802.0\r\n@angular-devkit/build-angular     0.802.0\r\n@angular-devkit/build-optimizer   0.802.0\r\n@angular-devkit/build-webpack     0.802.0\r\n@angular-devkit/core              8.2.0\r\n@angular-devkit/schematics        8.2.0\r\n@ngtools/webpack                  8.2.0\r\n@schematics/angular               8.2.0\r\n@schematics/update                0.802.0\r\nrxjs                              6.4.0\r\ntypescript                        3.5.3\r\nwebpack                           4.38.0\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\r\n\u003cpre>\u003ccode>\r\n$ cat ./tsconfig.app.json\r\n{\r\n  \"extends\": \"./tsconfig.json\",\r\n  \"compilerOptions\": {\r\n    \"outDir\": \"./out-tsc/app\",\r\n    \"types\": []\r\n  },\r\n  \"files\": [\r\n    \"src/main.ts\",\r\n    \"src/polyfills.ts\"\r\n  ],\r\n  \"include\": [\r\n    \"src/**/*.d.ts\"\r\n  ],\r\n  \"angularCompilerOptions\": {\r\n    \"enableIvy\": true\r\n  }\r\n}\r\n\r\n\u003c/code>\u003c/pre>\r\n\u003cpre>\u003ccode>\r\n$ cat ./tsconfig.json\r\n{\r\n  \"compileOnSave\": false,\r\n  \"compilerOptions\": {\r\n    \"strictNullChecks\": true,\r\n    \"baseUrl\": \"./\",\r\n    \"outDir\": \"./dist/out-tsc\",\r\n    \"sourceMap\": true,\r\n    \"declaration\": false,\r\n    \"downlevelIteration\": true,\r\n    \"experimentalDecorators\": true,\r\n    \"module\": \"esnext\",\r\n    \"moduleResolution\": \"node\",\r\n    \"importHelpers\": true,\r\n    \"target\": \"es2015\",\r\n    \"typeRoots\": [\r\n      \"node_modules/@types\"\r\n    ],\r\n    \"lib\": [\r\n      \"es2018\",\r\n      \"dom\"\r\n    ]\r\n  },\r\n  \"angularCompilerOptions\": {\r\n    \"fullTemplateTypeCheck\": true,\r\n    \"strictInjectionParameters\": true\r\n  }\r\n}\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/james-schwartzkopf","@type":"Person","name":"james-schwartzkopf"},"datePublished":"2019-08-07T22:42:44Z","url":"https://github.com/angular/angular/issues/32051"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:b90b0a37-93ff-4b6e-7bc2-d427301caf32
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id93D6:1F2D:1AAE6AB:21BCFB2:6B01869C
html-safe-nonce72ed96cfe547542deadd4590aa95afb28309d167b4bfa0682234790a5afaf54e
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5M0Q2OjFGMkQ6MUFBRTZBQjoyMUJDRkIyOjZCMDE4NjlDIiwidmlzaXRvcl9pZCI6IjgyMzkzODk4MTYwMjM2MzAzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac384c79a15e60999fde809d93b708d37b9a5c20b2ed2fc2d2f546ee4e44ccb682
hovercard-subject-tagissue:478170671
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/32051/issue_layout
twitter:imagehttps://opengraph.githubassets.com/d0cd31aadac1c0e247021e83fff9fffdef2871dc5481e804bddd957faf7e0bb9/angular/angular/issues/32051
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/d0cd31aadac1c0e247021e83fff9fffdef2871dc5481e804bddd957faf7e0bb9/angular/angular/issues/32051
og:image:alt🐞 bug report Affected Package @angular/compiler-cli, @angular/angular Is this a regression? Yes, this works when Ivy is not used. Description The problem is the async pipe returns T | null. My unde...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejames-schwartzkopf
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/32051#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F32051
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F32051
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/32051
Reloadhttps://github.com/angular/angular/issues/32051
Reloadhttps://github.com/angular/angular/issues/32051
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests142 (142)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/32051
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/32051
Compile errors when using async pipe with enableIvy & strictNullCheckshttps://github.com/angular/angular/issues/32051#top
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/james-schwartzkopf
james-schwartzkopfhttps://github.com/james-schwartzkopf
on Aug 7, 2019https://github.com/angular/angular/issues/32051#issue-478170671
https://angular.io/api/common/NgForOf#local-variableshttps://angular.io/api/common/NgForOf#local-variables
https://github.com/james-schwartzkopf/test-template/blob/master/src/app/app.component.tshttps://github.com/james-schwartzkopf/test-template/blob/master/src/app/app.component.ts
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Aug 8, 2019https://github.com/angular/angular/issues/32051#event-2541821224
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 8, 2019https://github.com/angular/angular/issues/32051#event-2541821235
alxhubhttps://github.com/alxhub
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Aug 8, 2019https://github.com/angular/angular/issues/32051#event-2544886484
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Aug 8, 2019https://github.com/angular/angular/issues/32051#event-2544886500
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Aug 8, 2019https://github.com/angular/angular/issues/32051#issuecomment-519714163
https://github.com/pshurygin
pshuryginhttps://github.com/pshurygin
on Aug 10, 2019https://github.com/angular/angular/issues/32051#issuecomment-520125763
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Sep 29, 2019https://github.com/angular/angular/issues/32051#issuecomment-536277877
https://github.com/pshurygin
pshuryginhttps://github.com/pshurygin
on Sep 29, 2019https://github.com/angular/angular/issues/32051#issuecomment-536285449
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
on Oct 4, 2019https://github.com/angular/angular/issues/32051#issuecomment-538179848
#31371https://github.com/angular/angular/pull/31371
https://github.com/james-schwartzkopf
james-schwartzkopfhttps://github.com/james-schwartzkopf
on Oct 8, 2019https://github.com/angular/angular/issues/32051#issuecomment-539284960
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Oct 8, 2019https://github.com/angular/angular/issues/32051#issuecomment-539403595
https://github.com/Splaktar
Splaktarhttps://github.com/Splaktar
on Oct 10, 2019https://github.com/angular/angular/issues/32051#issuecomment-540745146
c1bb886https://github.com/angular/angular/commit/c1bb88603ebaf7a4bd5aaf7794e594609046cd2e
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Oct 10, 2019https://github.com/angular/angular/issues/32051#issuecomment-540749078
@Splaktarhttps://github.com/Splaktar
JoostKhttps://github.com/JoostK
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 10, 2019https://github.com/angular/angular/issues/32051#event-2703943079
https://github.com/james-schwartzkopf
james-schwartzkopfhttps://github.com/james-schwartzkopf
on Oct 11, 2019https://github.com/angular/angular/issues/32051#issuecomment-541118262
@inputshttps://github.com/inputs
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Oct 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-543689217
@JoostKhttps://github.com/JoostK
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Oct 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-543713266
@klemenoslajhttps://github.com/klemenoslaj
@pshuryginhttps://github.com/pshurygin
#32051 (comment)https://github.com/angular/angular/issues/32051#issuecomment-536285449
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Oct 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-543757152
@JoostKhttps://github.com/JoostK
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Oct 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-543771520
@klemenoslajhttps://github.com/klemenoslaj
https://github.com/james-schwartzkopf
james-schwartzkopfhttps://github.com/james-schwartzkopf
on Oct 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-543778800
https://github.com/klemenoslaj
klemenoslajhttps://github.com/klemenoslaj
on Oct 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-543792187
@JoostKhttps://github.com/JoostK
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 18, 2019https://github.com/angular/angular/issues/32051#issuecomment-555086182
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Nov 18, 2019https://github.com/angular/angular/issues/32051#event-2808127956
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/32051
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/32051
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.