René's URL Explorer Experiment


Title: Regression Ivy with ComponentFactory · Issue #31785 · angular/angular · GitHub

Open Graph Title: Regression Ivy with ComponentFactory · Issue #31785 · angular/angular

X Title: Regression Ivy with ComponentFactory · Issue #31785 · angular/angular

Description: 🐞 bug report Tbh: I didn't search if this was already known (no idea how I would have found it 😅) Affected Package The issue is caused by package @angular/core Is this a regression? This works without Ivy enabled. Description I was tryin...

Open Graph Description: 🐞 bug report Tbh: I didn't search if this was already known (no idea how I would have found it 😅) Affected Package The issue is caused by package @angular/core Is this a regression? This works with...

X Description: 🐞 bug report Tbh: I didn't search if this was already known (no idea how I would have found it 😅) Affected Package The issue is caused by package @angular/core Is this a regression? This works ...

Opengraph URL: https://github.com/angular/angular/issues/31785

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Regression Ivy with ComponentFactory","articleBody":"# 🐞 bug report\r\n\r\nTbh: I didn't search if this was already known (no idea how I would have found it 😅)\r\n\r\n### Affected Package\r\nThe issue is caused by package @angular/core\r\n\r\n### Is this a regression?\r\n\r\nThis works without Ivy enabled.\r\n\r\n### Description\r\n\r\nI was trying out Angular Ivy in our codebase. One of the last 'problems' that is really blocking seems to be ['ngx-toastr'](https://github.com/scttcper/ngx-toastr).\r\n\r\nThey dynamically add the [toastr component](https://github.com/scttcper/ngx-toastr/blob/master/src/lib/toastr/toast.component.ts) on runtime in the DOM.\r\n\r\n[Link to code that is responsible for this](https://github.com/scttcper/ngx-toastr/blob/db3e8fefe79dd66f2610b057a762bb0e668ab417/src/lib/portal/dom-portal-host.ts#L32)\r\n\r\nWhen switching to Ivy this code doesn't work anymore:\r\n\r\n```\r\nERROR DOMException: Failed to execute 'createElement' on 'Document': The tag name provided ('') is not a valid name. at DefaultDomRenderer2.createElement\r\n```\r\n\r\nAfter some debugging I found out that it's because the code that's responsible for retrieving the selector of a component in Ivy doesn't work: [Link](https://github.com/angular/angular/blob/c845a7b887d1a85a89acfe5c62b8829079130af3/packages/core/src/render3/component_ref.ts#L124)\r\n\r\nIn case of the toast component (see link above) it's ['', 'toast-component', '']. As a result the tag name becomes ''. And that explains the error above.\r\n\r\nI cloned ngx-toastr, changed the component name from `[toast-component]` to `toast-component` (removed the brackets). And everything seems to be working. This of course changes the result from a div with as attribute 'toast-component' to a custom component with as selector 'toast-component'.\r\n\r\nTL;DR: Dynamically generating components on runtime with Ivy doesn't work when using attribute notation.\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\nUse ngx-toastr with Ivy enabled.\r\nIf more time, I'll create a stackblitz.\r\n\r\n## 🔥 Exception or Error\r\n\r\n```\r\nERROR DOMException: Failed to execute 'createElement' on 'Document': The tag name provided ('') is not a valid name. \r\nat DefaultDomRenderer2.createElement (http://localhost:4200/vendor.js:82322:25) \r\nat elementCreate (http://localhost:4200/vendor.js:53703:32) \r\nat ComponentFactory$1.create (http://localhost:4200/vendor.js:67815:13) \r\nat DomPortalHost.attachComponentPortal (http://localhost:4200/vendor.js:94547:41) \r\nat DomPortalHost.attach (http://localhost:4200/vendor.js:94505:21) at OverlayRef.attach (http://localhost:4200/vendor.js:94629:33) \r\nat ToastrService._buildNotification (http://localhost:4200/vendor.js:94955:35) \r\nat ToastrService._preBuildNotification (http://localhost:4200/vendor.js:94921:21) \r\nat ToastrService.success\r\n```\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 8.2.0-next.1\r\nNode: 12.6.0\r\nOS: win32 x64\r\nAngular:\r\n...\r\n\r\nPackage                      Version\r\n------------------------------------------------------\r\n@angular-devkit/architect    0.802.0-next.1\r\n@angular-devkit/core         8.2.0-next.1\r\n@angular-devkit/schematics   8.2.0-next.1\r\n@schematics/angular          8.2.0-next.1\r\n@schematics/update           0.802.0-next.1\r\nrxjs                         6.4.0\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nCauses https://github.com/scttcper/ngx-toastr/issues/686\r\n","author":{"url":"https://github.com/ErazerBrecht","@type":"Person","name":"ErazerBrecht"},"datePublished":"2019-07-22T19:11:06Z","url":"https://github.com/angular/angular/issues/31785"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:6643aa94-3554-2504-45b2-27aded9149da
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC19C:361639:164115C:1DAC484:6B013F04
html-safe-nonced2a059b5ead0c8a78841c131d1716ccc2371903adf27355e70f4f5aa629122bc
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMTlDOjM2MTYzOToxNjQxMTVDOjFEQUM0ODQ6NkIwMTNGMDQiLCJ2aXNpdG9yX2lkIjoiNTkyMzgxMDcxMzk3Mjg1MDQzNiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac86fb68c71b2c9239a5142c084a34c41bfca1cec809162fcd3d10e4f636ae508c
hovercard-subject-tagissue:471264900
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/31785/issue_layout
twitter:imagehttps://opengraph.githubassets.com/2e059d8d099576dce9ecdcf9d4ee9e3262d56f9b4fdf76c75929863f99609540/angular/angular/issues/31785
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/2e059d8d099576dce9ecdcf9d4ee9e3262d56f9b4fdf76c75929863f99609540/angular/angular/issues/31785
og:image:alt🐞 bug report Tbh: I didn't search if this was already known (no idea how I would have found it 😅) Affected Package The issue is caused by package @angular/core Is this a regression? This works with...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameErazerBrecht
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/31785#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31785
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31785
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/31785
Reloadhttps://github.com/angular/angular/issues/31785
Reloadhttps://github.com/angular/angular/issues/31785
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31785
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31785
Regression Ivy with ComponentFactoryhttps://github.com/angular/angular/issues/31785#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/ErazerBrecht
ErazerBrechthttps://github.com/ErazerBrecht
on Jul 22, 2019https://github.com/angular/angular/issues/31785#issue-471264900
'ngx-toastr'https://github.com/scttcper/ngx-toastr
toastr componenthttps://github.com/scttcper/ngx-toastr/blob/master/src/lib/toastr/toast.component.ts
Link to code that is responsible for thishttps://github.com/scttcper/ngx-toastr/blob/db3e8fefe79dd66f2610b057a762bb0e668ab417/src/lib/portal/dom-portal-host.ts#L32
Linkhttps://github.com/angular/angular/blob/c845a7b887d1a85a89acfe5c62b8829079130af3/packages/core/src/render3/component_ref.ts#L124
scttcper/ngx-toastr#686https://github.com/scttcper/ngx-toastr/issues/686
AndrewKushnirhttps://github.com/AndrewKushnir
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Jul 22, 2019https://github.com/angular/angular/issues/31785#event-2501356419
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jul 22, 2019https://github.com/angular/angular/issues/31785#event-2501356438
https://github.com/ErazerBrecht
ErazerBrechthttps://github.com/ErazerBrecht
on Jul 23, 2019https://github.com/angular/angular/issues/31785#issuecomment-514341046
https://github.com/ErazerBrecht/AngularIvyBughttps://github.com/ErazerBrecht/AngularIvyBug
karahttps://github.com/kara
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jul 23, 2019https://github.com/angular/angular/issues/31785#event-2504613763
karahttps://github.com/kara
on Jul 23, 2019https://github.com/angular/angular/issues/31785#event-2504661196
fix(ivy): support attribute selectors in dynamic component creationhttps://github.com/kara/angular/commit/050ef1981c7b92ed643539a6207f9a0956422e5e
https://docs.github.com/articles/closing-issues-via-commit-messages
050ef19https://github.com/kara/angular/commit/050ef1981c7b92ed643539a6207f9a0956422e5e
karahttps://github.com/kara
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Jul 23, 2019https://github.com/angular/angular/issues/31785#event-2504669154
pullhttps://github.com/apps/pull
on Jul 24, 2019https://github.com/angular/angular/issues/31785#event-2505042841
fix(ivy): support attribute selectors in dynamic component creation (a…https://github.com/lisuizhe/angular/commit/b696413a7991ee39dea475b64e9027a17dc61b92
a…https://github.com/angular/angular/pull/31812
https://docs.github.com/articles/closing-issues-via-commit-messages
b696413https://github.com/lisuizhe/angular/commit/b696413a7991ee39dea475b64e9027a17dc61b92
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
b696413https://github.com/angular/angular/commit/b696413a7991ee39dea475b64e9027a17dc61b92
on Jul 24, 2019https://github.com/angular/angular/issues/31785#event-2505044492
https://github.com/ErazerBrecht
ErazerBrechthttps://github.com/ErazerBrecht
on Jul 24, 2019https://github.com/angular/angular/issues/31785#issuecomment-514496129
@karahttps://github.com/kara
sabeersulaimanhttps://github.com/sabeersulaiman
on Sep 6, 2019https://github.com/angular/angular/issues/31785#event-2614103210
fix(ivy): support attribute selectors in dynamic component creation (a…https://github.com/sabeersulaiman/angular/commit/67153c0ca181221b15a1dc62e2955ee0787ae10d
a…https://github.com/angular/angular/pull/31812
https://docs.github.com/articles/closing-issues-via-commit-messages
67153c0https://github.com/sabeersulaiman/angular/commit/67153c0ca181221b15a1dc62e2955ee0787ae10d
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/31785#issuecomment-531545500
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/31785#event-2634531945
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/31785
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/31785
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.