René's URL Explorer Experiment


Title: Custom decorators not working using AoT and Ivy · Issue #31495 · angular/angular · GitHub

Open Graph Title: Custom decorators not working using AoT and Ivy · Issue #31495 · angular/angular

X Title: Custom decorators not working using AoT and Ivy · Issue #31495 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli (I guess) Is this a regression? I had never tried AoT with Ivy Description I have a custom property decorator like this: export function Language(): Prope...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli (I guess) Is this a regression? I had never tried AoT with Ivy Description I have a custom property decorator like...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli (I guess) Is this a regression? I had never tried AoT with Ivy Description I have a custom property decorator like...

Opengraph URL: https://github.com/angular/angular/issues/31495

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Custom decorators not working using AoT and Ivy","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/compiler-cli (I guess)\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> I had never tried AoT with Ivy\r\n\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️--> I have a custom property decorator like this:\r\n```\r\nexport function Language(): PropertyDecorator {\r\n    function DecoratorFactory(target: any): void {\r\n        const targetNgOnInit: () => void = target.ngOnInit;\r\n        function ngOnInit(this: any): void {\r\n            \r\n            // Just for example\r\n            console.log('onInit');\r\n\r\n            if (targetNgOnInit) {\r\n                targetNgOnInit.apply(this);\r\n            }\r\n        }\r\n        target.ngOnInit = ngOnInit;\r\n    }\r\n    return DecoratorFactory;\r\n}\r\n```\r\nused as:\r\n\r\n```\r\n@Language() lang: string;\r\n\r\nngOnInit() {\r\n  // For aot\r\n}\r\n```\r\n\r\n- With AoT compiler, _it works_ (it writes _onInit_ in console)\r\n- If I enable Ivy and disable AoT, _it works_\r\n- _If I enable Ivy and AoT, it doesn't work_\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\r\n[angular-ivy-decorators](https://github.com/robisim74/angular-ivy-decorators)\r\n\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\n## 🔥 Exception or Error\r\nNo errors during compilation or in console. The `ngOnInit `method in decorator function is ignored.\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 8.1.1\r\nNode: 10.14.2\r\nOS: win32 x64\r\nAngular: 8.1.1\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage                           Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect         0.801.1\r\n@angular-devkit/build-angular     0.801.1\r\n@angular-devkit/build-optimizer   0.801.1\r\n@angular-devkit/build-webpack     0.801.1\r\n@angular-devkit/core              8.1.1\r\n@angular-devkit/schematics        8.1.1\r\n@ngtools/webpack                  8.1.1\r\n@schematics/angular               8.1.1\r\n@schematics/update                0.801.1\r\nrxjs                              6.4.0\r\ntypescript                        3.4.5\r\nwebpack                           4.35.2\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\nTried without success also the _next_ version of Angular.\r\n\r\nThanks\r\n","author":{"url":"https://github.com/robisim74","@type":"Person","name":"robisim74"},"datePublished":"2019-07-10T20:31:22Z","url":"https://github.com/angular/angular/issues/31495"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f1b48159-3ee8-8f1d-6e42-2391edda200e
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idED40:2E7EBB:16721FD:1C676F0:6B013102
html-safe-noncebbd413c836a0d2d3e76ad489fbd53a8b2d1bd1add170169847bccfeabc7df7e9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJFRDQwOjJFN0VCQjoxNjcyMUZEOjFDNjc2RjA6NkIwMTMxMDIiLCJ2aXNpdG9yX2lkIjoiNjkxMTI1NTU3MjU3MDUxNzc2MiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacd433cedf6d74a5bcff086249fe78dfc12dd61f9e59571da454259df986c0fc4a
hovercard-subject-tagissue:466505045
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/31495/issue_layout
twitter:imagehttps://opengraph.githubassets.com/5c7b899834a10d7eba14beb1964003cb2bcaa8470004c75eac3fc16d3d59e3ae/angular/angular/issues/31495
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/5c7b899834a10d7eba14beb1964003cb2bcaa8470004c75eac3fc16d3d59e3ae/angular/angular/issues/31495
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli (I guess) Is this a regression? I had never tried AoT with Ivy Description I have a custom property decorator like...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerobisim74
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/31495#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31495
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31495
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/31495
Reloadhttps://github.com/angular/angular/issues/31495
Reloadhttps://github.com/angular/angular/issues/31495
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31495
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31495
Custom decorators not working using AoT and Ivyhttps://github.com/angular/angular/issues/31495#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/robisim74
robisim74https://github.com/robisim74
on Jul 10, 2019https://github.com/angular/angular/issues/31495#issue-466505045
angular-ivy-decoratorshttps://github.com/robisim74/angular-ivy-decorators
Nexthttps://github.com/angular/angular/issues/31495?timeline_page=1
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Jul 10, 2019https://github.com/angular/angular/issues/31495#issuecomment-510225489
https://github.com/robisim74
robisim74https://github.com/robisim74
on Jul 10, 2019https://github.com/angular/angular/issues/31495#issuecomment-510230874
AndrewKushnirhttps://github.com/AndrewKushnir
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Jul 10, 2019https://github.com/angular/angular/issues/31495#event-2473936905
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jul 10, 2019https://github.com/angular/angular/issues/31495#event-2473937031
https://github.com/alexzuza
alexzuzahttps://github.com/alexzuza
on Jul 11, 2019https://github.com/angular/angular/issues/31495#issuecomment-510325857
angular/packages/core/src/render3/definition.tshttps://github.com/angular/angular/blob/58be2ff88400d7dc876d357f8cc3eb01b0912aae/packages/core/src/render3/definition.ts#L264
58be2ffhttps://github.com/angular/angular/commit/58be2ff88400d7dc876d357f8cc3eb01b0912aae
https://user-images.githubusercontent.com/4223314/61022503-295fd600-a3b7-11e9-8e3c-dcc897ecfa9a.png
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Jul 16, 2019https://github.com/angular/angular/issues/31495#issuecomment-512027502
this examplehttp://www.typescriptlang.org/play/?emitDecoratorMetadata=true#code/CYUwxgNghgTiAEYD2A7AzgF3gEXEmUG+AXPFCgJ4DcAUHSAB4AO+WkUaa8AYkkvAG8a8eAAFcyAkRgAKAJTwAZgEsQEYAEJS5anRGZCysPCYwkTEDAwV4AXngYYAVxC0AvkA
alxhubhttps://github.com/alxhub
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jul 16, 2019https://github.com/angular/angular/issues/31495#event-2487698804
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Jul 16, 2019https://github.com/angular/angular/issues/31495#event-2487698824
alxhubhttps://github.com/alxhub
severity2: inconvenienthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity2%3A%20inconvenient%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
on Jul 16, 2019https://github.com/angular/angular/issues/31495#event-2487699011
https://github.com/shadow1349
shadow1349https://github.com/shadow1349
on Jun 12, 2020https://github.com/angular/angular/issues/31495#issuecomment-643064749
https://github.com/tinganho
tinganhohttps://github.com/tinganho
on Jun 12, 2020https://github.com/angular/angular/issues/31495#issuecomment-643128619
https://github.com/ramtob
ramtobhttps://github.com/ramtob
on Jun 14, 2020https://github.com/angular/angular/issues/31495#issuecomment-643725224
https://github.com/khiami
khiamihttps://github.com/khiami
on Jun 27, 2020https://github.com/angular/angular/issues/31495#issuecomment-650516237
https://github.com/hakimio
hakimiohttps://github.com/hakimio
on Jun 27, 2020https://github.com/angular/angular/issues/31495#issuecomment-650522688
@khiamihttps://github.com/khiami
#35464https://github.com/angular/angular/pull/35464
https://github.com/TinyMan
TinyManhttps://github.com/TinyMan
on Jul 3, 2020https://github.com/angular/angular/issues/31495#issuecomment-653474184
@Splaktarhttps://github.com/Splaktar
@pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
https://github.com/wsdt
wsdthttps://github.com/wsdt
on Aug 20, 2020https://github.com/angular/angular/issues/31495#issuecomment-677429572
https://github.com/hakimio
hakimiohttps://github.com/hakimio
on Aug 20, 2020https://github.com/angular/angular/issues/31495#issuecomment-677433239
@wsdthttps://github.com/wsdt
Angular v10.0.5https://github.com/angular/angular/blob/master/CHANGELOG.md#1005-2020-07-22
https://github.com/wsdt
wsdthttps://github.com/wsdt
on Aug 20, 2020https://github.com/angular/angular/issues/31495#issuecomment-677454950
@hakimiohttps://github.com/hakimio
https://github.com/kumaresan-subramani
kumaresan-subramanihttps://github.com/kumaresan-subramani
on Aug 20, 2020https://github.com/angular/angular/issues/31495#issuecomment-677512364
angular/packages/core/src/render3/definition.tshttps://github.com/angular/angular/blob/58be2ff88400d7dc876d357f8cc3eb01b0912aae/packages/core/src/render3/definition.ts#L264
58be2ffhttps://github.com/angular/angular/commit/58be2ff88400d7dc876d357f8cc3eb01b0912aae
https://user-images.githubusercontent.com/4223314/61022503-295fd600-a3b7-11e9-8e3c-dcc897ecfa9a.png
#30818 (comment)https://github.com/angular/angular/issues/30818#issuecomment-543628872
@Splaktarhttps://github.com/Splaktar
#31495 (comment)https://github.com/angular/angular/issues/31495#issuecomment-549873125
#31495 (comment)https://github.com/angular/angular/issues/31495#issuecomment-555233912
@hakimiohttps://github.com/hakimio
https://github.com/hakimio
hakimiohttps://github.com/hakimio
on Aug 20, 2020https://github.com/angular/angular/issues/31495#issuecomment-677520461
@kumaresan-subramanihttps://github.com/kumaresan-subramani
ngx-observable-lifecyclehttps://github.com/cloudnc/ngx-observable-lifecycle
https://github.com/robisim74
robisim74https://github.com/robisim74
on Aug 26, 2020https://github.com/angular/angular/issues/31495#issuecomment-681085656
@hakimiohttps://github.com/hakimio
Angular v10.0.5https://github.com/angular/angular/blob/master/CHANGELOG.md#1005-2020-07-22
robisim74https://github.com/robisim74
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Aug 26, 2020https://github.com/angular/angular/issues/31495#event-3696349737
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 26, 2020https://github.com/angular/angular/issues/31495#issuecomment-699516481
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 26, 2020https://github.com/angular/angular/issues/31495#event-3810904334
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/31495
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/31495
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: lifecycle hookshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20lifecycle%20hooks%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.