René's URL Explorer Experiment


Title: ivy-ngcc doesn't transform UMD bundles correctly · Issue #31394 · angular/angular · GitHub

Open Graph Title: ivy-ngcc doesn't transform UMD bundles correctly · Issue #31394 · angular/angular

X Title: ivy-ngcc doesn't transform UMD bundles correctly · Issue #31394 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as undefined in the transformed UMD bundle....

Open Graph Description: 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as ...

X Description: 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as ...

Opengraph URL: https://github.com/angular/angular/issues/31394

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy-ngcc doesn't transform UMD bundles correctly","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by ivy-ngcc tool\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nno\r\n\r\n### Description\r\n\r\nivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol `Injectable` ends up as undefined in the transformed UMD bundle.\r\n\r\n```\r\n    AriaDescriber.decorators = [\r\n        { type: core.Injectable, args: [{ providedIn: 'root' },] },\r\n    ];\r\n    /** @nocollapse */\r\n    AriaDescriber.ctorParameters = function () { return [\r\n        { type: undefined, decorators: [{ type: core.Inject, args: [common.DOCUMENT,] }] }\r\n    ]; };\r\n    /** @nocollapse */ AriaDescriber.ngInjectableDef = core.ɵɵdefineInjectable({ factory: function AriaDescriber_Factory() { return new AriaDescriber(core.ɵɵinject(common.DOCUMENT)); }, token: AriaDescriber, providedIn: \"root\" });\r\n    return AriaDescriber;\r\n```\r\n\r\nin `node_modules/@angular/cdk/bundles/cdk-a11y.umd.js.__ivy_ngcc_bak` gets transformed to\r\n\r\n```\r\n/*@__PURE__*/ ɵngcc0.ɵsetClassMetadata(AriaDescriber, [{\r\n        type: Injectable,\r\n        args: [{ providedIn: 'root' }]\r\n    }], function () { return [{ type: undefined, decorators: [{\r\n                type: Inject,\r\n                args: [common.DOCUMENT]\r\n            }] }]; }, { _document: [], describe: [], removeDescription: [], ngOnDestroy: [], _createMessageElement: [], _deleteMessageElement: [], _createMessagesContainer: [], _deleteMessagesContainer: [], _removeCdkDescribedByReferenceIds: [], _addMessageReference: [], _removeMessageReference: [], _isElementDescribedByMessage: [], _canBeDescribed: [], _isElementNode: [] });\r\n    return AriaDescriber;\r\n```\r\n\r\nin `node_modules/@angular/cdk/bundles/cdk-a11y.umd.js` where `type: Injectable,` is undefined when run in the browser:\r\n\r\n```\r\nUncaught ReferenceError: Injectable is not defined\r\n```\r\n\r\nI would guess it should be `type: core.Injectable` since `core` is the `@angular/core` UMD dependency.\r\n\r\n`@angular/cdk/bundles/cdk-a11y.umd.js` is just an example but same thing happens in other bundles transformed.\r\n\r\n\r\n## 🔬 Reproduction\r\n\r\nClone the `wassim/ivy` branch of my fork of angular-bazel-example (https://github.com/gregmagolan/angular-bazel-example/tree/wassim/ivy) and run `yarn install`. `ivy-ngcc` is run in the `postinstall` step and you can inspect the resulting transofmed bundles under node_modules.\r\n\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\u003c!-- ✍️--> https://stackblitz.com/...\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\n\u003c!-- If the issue is accompanied by an exception or an error, please share it below: -->\r\n\u003c!-- ✍️-->\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\u003c!-- run `ng version` and paste output below -->\r\n\u003c!-- ✍️-->\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n","author":{"url":"https://github.com/gregmagolan","@type":"Person","name":"gregmagolan"},"datePublished":"2019-07-03T02:10:09Z","url":"https://github.com/angular/angular/issues/31394"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:10606f91-7ea4-91fd-933c-674aa43b8e6f
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idBCD6:3C21B:17A3972:1E3E288:6B012D39
html-safe-nonce2efdedd3a5ca3c1d7592b538566e878bc4fbf10c51b1db6c78b1310a675ea5e8
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0Q2OjNDMjFCOjE3QTM5NzI6MUUzRTI4ODo2QjAxMkQzOSIsInZpc2l0b3JfaWQiOiI4NTAxMjM0NDM1Mjc3MDA4MTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca30375f9bf14480725e51034b3dd632da7a8718a618e97256a7594080c27d3c4
hovercard-subject-tagissue:463509633
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/31394/issue_layout
twitter:imagehttps://opengraph.githubassets.com/c7dd2f437e064a49966d045e1f232e7d5b52dd7946bd45a335c70717447c46e5/angular/angular/issues/31394
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/c7dd2f437e064a49966d045e1f232e7d5b52dd7946bd45a335c70717447c46e5/angular/angular/issues/31394
og:image:alt🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamegregmagolan
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/31394#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31394
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31394
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/31394
Reloadhttps://github.com/angular/angular/issues/31394
Reloadhttps://github.com/angular/angular/issues/31394
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31394
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31394
ivy-ngcc doesn't transform UMD bundles correctlyhttps://github.com/angular/angular/issues/31394#top
https://github.com/JoostK
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
on Jul 3, 2019https://github.com/angular/angular/issues/31394#issue-463509633
https://github.com/gregmagolan/angular-bazel-example/tree/wassim/ivyhttps://github.com/gregmagolan/angular-bazel-example/tree/wassim/ivy
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
comp: ngcchttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ngcc%22
on Jul 3, 2019https://github.com/angular/angular/issues/31394#event-2456141849
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jul 3, 2019https://github.com/angular/angular/issues/31394#event-2456141878
https://github.com/alexzuza
alexzuzahttps://github.com/alexzuza
on Jul 3, 2019https://github.com/angular/angular/issues/31394#issuecomment-507987938
angular/packages/compiler-cli/src/ngtsc/annotations/src/metadata.tshttps://github.com/angular/angular/blob/21835af70cf0535273270be827633471d9ec465d/packages/compiler-cli/src/ngtsc/annotations/src/metadata.ts#L124-L127
21835afhttps://github.com/angular/angular/commit/21835af70cf0535273270be827633471d9ec465d
@alxhubhttps://github.com/alxhub
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Jul 3, 2019https://github.com/angular/angular/issues/31394#issuecomment-508070230
petebacondarwinhttps://github.com/petebacondarwin
on Jul 3, 2019https://github.com/angular/angular/issues/31394#event-2457386235
petebacondarwinhttps://github.com/petebacondarwin
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jul 3, 2019https://github.com/angular/angular/issues/31394#event-2457387080
petebacondarwinhttps://github.com/petebacondarwin
on Jul 5, 2019https://github.com/angular/angular/issues/31394#event-2462341898
fix(ivy): ngcc - render namespaced imported decorators correctlyhttps://github.com/petebacondarwin/angular/commit/8ce247e0eae2ffafac650e1107bfe05062f82dab
https://docs.github.com/articles/closing-issues-via-commit-messages
8ce247ehttps://github.com/petebacondarwin/angular/commit/8ce247e0eae2ffafac650e1107bfe05062f82dab
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Jul 5, 2019https://github.com/angular/angular/issues/31394#issuecomment-508711883
#31426https://github.com/angular/angular/pull/31426
petebacondarwinhttps://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Jul 8, 2019https://github.com/angular/angular/issues/31394#event-2465206436
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
dd664f6https://github.com/angular/angular/commit/dd664f694ccba1d42ef78fda12c4fb1101f8c3c0
on Jul 18, 2019https://github.com/angular/angular/issues/31394#event-2493448398
mheveryhttps://github.com/mhevery
on Jul 18, 2019https://github.com/angular/angular/issues/31394#event-2493448573
fix(ivy): ngcc - render namespaced imported decorators correctly (#31426https://github.com/angular/angular/commit/4e2db39fa1e8fde28206ffdc1a3e58513e164149
#31426https://github.com/angular/angular/pull/31426
https://docs.github.com/articles/closing-issues-via-commit-messages
4e2db39https://github.com/angular/angular/commit/4e2db39fa1e8fde28206ffdc1a3e58513e164149
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
on Jul 19, 2019https://github.com/angular/angular/issues/31394#issuecomment-513095146
@petebacondarwinhttps://github.com/petebacondarwin
@ngrxhttps://github.com/ngrx
gregmagolanhttps://github.com/gregmagolan
on Jul 19, 2019https://github.com/angular/angular/issues/31394#event-2494756490
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Jul 19, 2019https://github.com/angular/angular/issues/31394#issuecomment-513101324
petebacondarwinhttps://github.com/petebacondarwin
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Jul 19, 2019https://github.com/angular/angular/issues/31394#event-2494801074
JoostKhttps://github.com/JoostK
JoostKhttps://github.com/JoostK
petebacondarwinhttps://github.com/petebacondarwin
on Jul 24, 2019https://github.com/angular/angular/issues/31394#event-2506159683
JoostKhttps://github.com/JoostK
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
on Jul 27, 2019https://github.com/angular/angular/issues/31394#event-2514239670
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Jul 27, 2019https://github.com/angular/angular/issues/31394#issuecomment-515683563
#31614https://github.com/angular/angular/pull/31614
JoostKhttps://github.com/JoostK
on Jul 27, 2019https://github.com/angular/angular/issues/31394#event-2514257513
fix(ivy): ngcc - render decorators in UMD and CommonJS bundles correctlyhttps://github.com/JoostK/angular/commit/3ddd6bc76de419455bea7b3d3c15e47a757a8cbc
https://docs.github.com/articles/closing-issues-via-commit-messages
3ddd6bchttps://github.com/JoostK/angular/commit/3ddd6bc76de419455bea7b3d3c15e47a757a8cbc
AndrewKushnirhttps://github.com/AndrewKushnir
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
fc6f481https://github.com/angular/angular/commit/fc6f48185c3a546b130296d3d5dce86fdf334115
on Jul 29, 2019https://github.com/angular/angular/issues/31394#event-2518066963
https://github.com/gregmagolan
gregmagolanhttps://github.com/gregmagolan
on Aug 15, 2019https://github.com/angular/angular/issues/31394#issuecomment-521663189
@ngrxhttps://github.com/ngrx
angular/angular-bazel-example#505https://github.com/angular/angular-bazel-example/pull/505
@petebacondarwinhttps://github.com/petebacondarwin
@JoostKhttps://github.com/JoostK
@alexeaglehttps://github.com/alexeagle
@CaerusKaruhttps://github.com/CaerusKaru
sabeersulaimanhttps://github.com/sabeersulaiman
on Sep 6, 2019https://github.com/angular/angular/issues/31394#event-2614102971
fix(ivy): ngcc - render namespaced imported decorators correctly (ang…https://github.com/sabeersulaiman/angular/commit/433a281d33f5b527de8a6374265ccdaeac871ae1
ang…https://github.com/angular/angular/pull/31426
https://docs.github.com/articles/closing-issues-via-commit-messages
433a281https://github.com/sabeersulaiman/angular/commit/433a281d33f5b527de8a6374265ccdaeac871ae1
fix(ivy): ngcc - render decorators in UMD and CommonJS bundles correc…https://github.com/sabeersulaiman/angular/commit/4e5df1fed7f9dc3fb71f3795a00eb9b04e35d7c3
https://docs.github.com/articles/closing-issues-via-commit-messages
4e5df1fhttps://github.com/sabeersulaiman/angular/commit/4e5df1fed7f9dc3fb71f3795a00eb9b04e35d7c3
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/31394#issuecomment-531553251
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/31394#event-2634580346
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/31394
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/31394
JoostKhttps://github.com/JoostK
state: has PRhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20has%20PR%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.