Title: ivy-ngcc doesn't transform UMD bundles correctly · Issue #31394 · angular/angular · GitHub
Open Graph Title: ivy-ngcc doesn't transform UMD bundles correctly · Issue #31394 · angular/angular
X Title: ivy-ngcc doesn't transform UMD bundles correctly · Issue #31394 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as undefined in the transformed UMD bundle....
Open Graph Description: 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as ...
X Description: 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as ...
Opengraph URL: https://github.com/angular/angular/issues/31394
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy-ngcc doesn't transform UMD bundles correctly","articleBody":"# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by ivy-ngcc tool\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nno\r\n\r\n### Description\r\n\r\nivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol `Injectable` ends up as undefined in the transformed UMD bundle.\r\n\r\n```\r\n AriaDescriber.decorators = [\r\n { type: core.Injectable, args: [{ providedIn: 'root' },] },\r\n ];\r\n /** @nocollapse */\r\n AriaDescriber.ctorParameters = function () { return [\r\n { type: undefined, decorators: [{ type: core.Inject, args: [common.DOCUMENT,] }] }\r\n ]; };\r\n /** @nocollapse */ AriaDescriber.ngInjectableDef = core.ɵɵdefineInjectable({ factory: function AriaDescriber_Factory() { return new AriaDescriber(core.ɵɵinject(common.DOCUMENT)); }, token: AriaDescriber, providedIn: \"root\" });\r\n return AriaDescriber;\r\n```\r\n\r\nin `node_modules/@angular/cdk/bundles/cdk-a11y.umd.js.__ivy_ngcc_bak` gets transformed to\r\n\r\n```\r\n/*@__PURE__*/ ɵngcc0.ɵsetClassMetadata(AriaDescriber, [{\r\n type: Injectable,\r\n args: [{ providedIn: 'root' }]\r\n }], function () { return [{ type: undefined, decorators: [{\r\n type: Inject,\r\n args: [common.DOCUMENT]\r\n }] }]; }, { _document: [], describe: [], removeDescription: [], ngOnDestroy: [], _createMessageElement: [], _deleteMessageElement: [], _createMessagesContainer: [], _deleteMessagesContainer: [], _removeCdkDescribedByReferenceIds: [], _addMessageReference: [], _removeMessageReference: [], _isElementDescribedByMessage: [], _canBeDescribed: [], _isElementNode: [] });\r\n return AriaDescriber;\r\n```\r\n\r\nin `node_modules/@angular/cdk/bundles/cdk-a11y.umd.js` where `type: Injectable,` is undefined when run in the browser:\r\n\r\n```\r\nUncaught ReferenceError: Injectable is not defined\r\n```\r\n\r\nI would guess it should be `type: core.Injectable` since `core` is the `@angular/core` UMD dependency.\r\n\r\n`@angular/cdk/bundles/cdk-a11y.umd.js` is just an example but same thing happens in other bundles transformed.\r\n\r\n\r\n## 🔬 Reproduction\r\n\r\nClone the `wassim/ivy` branch of my fork of angular-bazel-example (https://github.com/gregmagolan/angular-bazel-example/tree/wassim/ivy) and run `yarn install`. `ivy-ngcc` is run in the `postinstall` step and you can inspect the resulting transofmed bundles under node_modules.\r\n\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\u003c!-- ✍️--> https://stackblitz.com/...\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>\r\n\u003c!-- If the issue is accompanied by an exception or an error, please share it below: -->\r\n\u003c!-- ✍️-->\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\u003c!-- run `ng version` and paste output below -->\r\n\u003c!-- ✍️-->\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n","author":{"url":"https://github.com/gregmagolan","@type":"Person","name":"gregmagolan"},"datePublished":"2019-07-03T02:10:09Z","url":"https://github.com/angular/angular/issues/31394"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:10606f91-7ea4-91fd-933c-674aa43b8e6f |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | BCD6:3C21B:17A3972:1E3E288:6B012D39 |
| html-safe-nonce | 2efdedd3a5ca3c1d7592b538566e878bc4fbf10c51b1db6c78b1310a675ea5e8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCQ0Q2OjNDMjFCOjE3QTM5NzI6MUUzRTI4ODo2QjAxMkQzOSIsInZpc2l0b3JfaWQiOiI4NTAxMjM0NDM1Mjc3MDA4MTg1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a30375f9bf14480725e51034b3dd632da7a8718a618e97256a7594080c27d3c4 |
| hovercard-subject-tag | issue:463509633 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/31394/issue_layout |
| twitter:image | https://opengraph.githubassets.com/c7dd2f437e064a49966d045e1f232e7d5b52dd7946bd45a335c70717447c46e5/angular/angular/issues/31394 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/c7dd2f437e064a49966d045e1f232e7d5b52dd7946bd45a335c70717447c46e5/angular/angular/issues/31394 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by ivy-ngcc tool Is this a regression? no Description ivy-ngcc transforms UMD bundles incorrectly. In particular, the symbol Injectable ends up as ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gregmagolan |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width