René's URL Explorer Experiment


Title: Add support for indexing template elements · Issue #31299 · angular/angular · GitHub

Open Graph Title: Add support for indexing template elements · Issue #31299 · angular/angular

X Title: Add support for indexing template elements · Issue #31299 · angular/angular

Description: @alxhub and I recently discussed how best to implement indexing template elements in the Ngtsc indexing module. I'm dumping the key points of that discussion here for future reference and discussion. 🚀 feature request Relevant Package Fo...

Open Graph Description: @alxhub and I recently discussed how best to implement indexing template elements in the Ngtsc indexing module. I'm dumping the key points of that discussion here for future reference and discussio...

X Description: @alxhub and I recently discussed how best to implement indexing template elements in the Ngtsc indexing module. I'm dumping the key points of that discussion here for future reference and discu...

Opengraph URL: https://github.com/angular/angular/issues/31299

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Add support for indexing template elements","articleBody":"@alxhub and I recently discussed how best to implement indexing template elements in the [`Ngtsc` indexing module](./packages/compiler-cli/src/ngtsc/indexer). I'm dumping the key points of that discussion here for future reference and discussion.\r\n\r\n# 🚀 feature request\r\n\r\n### Relevant Package\r\n\r\nFor @angular/compiler-cli, `Ngtsc` indexer module.\r\n\r\n### Description\r\n\r\nThe compiler's indexing module does not currently support indexing HTML elements in templates. We want to add support for that. Initially, the scope of this was\r\n\r\n- Record element selectors used in the template\r\n- Record used directives in the template\r\n\r\nsuch that an indexer could link an element selector to the directive it references, if any. This approach is quite limiting, however, because directive selectors can match on many things beside element selectors, including matching on attributes and implicitly matching on the absence of an attribute. A better approach is\r\n\r\n- Record element selectors used in the template\r\n  - each selector record also includes a record of attributes on the element\r\n  - each selector record also includes a record of used directives on the element\r\n\r\nTo consider the usefulness of this, consider a template like `\u003cmy-comp applied-dir>` that uses the directives `MyComp`, `AppliedDir`, and an implicitly loaded directive `ImplicitDir`. The compiler's indexer module will index the template and record an element identifier that looks something like\r\n\r\n```typescript\r\n{\r\n  name: 'my-comp',\r\n  span: ...,\r\n  attributes: [ { name: 'applied-dir', span: ... } ],\r\n  usedDirectives: [ MyComp, AppliedDir, ImplicitDir ],\r\n}\r\n```\r\n\r\nA source code indexer implementation can then use this information to generate useful references, like xreferencing `my-comp` to the `MyComp` class declaration, `applied-dir` to the `AppliedDir` class declaration, and adding an implicit reference of all three used directives on `my-comp`.\r\n\r\n### Alternatives\r\n\r\n- Do not record attributes separately; pass the entire element tag source code as the element identifier name instead.\r\n  - __advantages__: less work for the compiler's indexing module.\r\n  - __disadvantages__: an indexer implementation now has to write an HTML parser to discern attributes on the element.\r\n- Perform the linking of attributes to the directives that match it in the compiler.\r\n  - __advantages__: less work for an indexer implementation\r\n  - __disadvantages__: directives are applied to an element, not an attribute, so such an implementation would be needlessly complicated. Furthermore, it is not necessarily the job of the compiler's semantic analysis API to make decisions about what spans of text reference one another, especially in ambiguous cases like the one presented here - that should be on the indexer implementation.","author":{"url":"https://github.com/ayazhafiz","@type":"Person","name":"ayazhafiz"},"datePublished":"2019-06-26T21:09:38Z","url":"https://github.com/angular/angular/issues/31299"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:26e721f1-bfea-de11-3c6f-9acd2009cca0
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB562:96DDF:172AA9D:1D58158:6B013523
html-safe-noncee44b3924a015757d5b11ea292882e37f172a5b52a129c4010e41c3c4179ee779
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNTYyOjk2RERGOjE3MkFBOUQ6MUQ1ODE1ODo2QjAxMzUyMyIsInZpc2l0b3JfaWQiOiI2NTQ5NjkyMzA2MzMxNjEyNDUxIiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmac632ec9d007a6cc77adef00468ca6770d7078663becf944130ee949fa3908ad45
hovercard-subject-tagissue:461182837
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/31299/issue_layout
twitter:imagehttps://opengraph.githubassets.com/36833a9f74a8e1615c11f231c7e22c966cc54b04ba5bffc388e309248128fd99/angular/angular/issues/31299
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/36833a9f74a8e1615c11f231c7e22c966cc54b04ba5bffc388e309248128fd99/angular/angular/issues/31299
og:image:alt@alxhub and I recently discussed how best to implement indexing template elements in the Ngtsc indexing module. I'm dumping the key points of that discussion here for future reference and discussio...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameayazhafiz
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/31299#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31299
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F31299
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/31299
Reloadhttps://github.com/angular/angular/issues/31299
Reloadhttps://github.com/angular/angular/issues/31299
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31299
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/31299
Add support for indexing template elementshttps://github.com/angular/angular/issues/31299#top
https://github.com/ayazhafiz
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/ayazhafiz
ayazhafizhttps://github.com/ayazhafiz
on Jun 26, 2019https://github.com/angular/angular/issues/31299#issue-461182837
@alxhubhttps://github.com/alxhub
Ngtsc indexing modulehttps://github.com/angular/angular/issues/packages/compiler-cli/src/ngtsc/indexer
ayazhafizhttps://github.com/ayazhafiz
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Jun 26, 2019https://github.com/angular/angular/issues/31299#event-2442225616
ayazhafizhttps://github.com/ayazhafiz
on Jun 26, 2019https://github.com/angular/angular/issues/31299#event-2442225625
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jun 26, 2019https://github.com/angular/angular/issues/31299#event-2442225653
ayazhafizhttps://github.com/ayazhafiz
on Jun 28, 2019https://github.com/angular/angular/issues/31299#event-2448256710
ayazhafizhttps://github.com/ayazhafiz
on Jun 28, 2019https://github.com/angular/angular/issues/31299#event-2448257268
karahttps://github.com/kara
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
on Jul 9, 2019https://github.com/angular/angular/issues/31299#event-2470850295
https://github.com/ayazhafiz
ayazhafizhttps://github.com/ayazhafiz
on Jul 15, 2019https://github.com/angular/angular/issues/31299#issuecomment-511494229
604d906https://github.com/angular/angular/commit/604d9063c5167189f178849525154c804d925e43
ayazhafizhttps://github.com/ayazhafiz
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 15, 2019https://github.com/angular/angular/issues/31299#event-2483663759
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/31299#issuecomment-531543423
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/31299#event-2634519821
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/31299
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/31299
ayazhafizhttps://github.com/ayazhafiz
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.