René's URL Explorer Experiment


Title: NGCC only transforms top level modules · Issue #30121 · angular/angular · GitHub

Open Graph Title: NGCC only transforms top level modules · Issue #30121 · angular/angular

X Title: NGCC only transforms top level modules · Issue #30121 · angular/angular

Description: @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://localhost:9876/_karma_webpack_/vendor.js:62601:11) at assert...

Open Graph Description: @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://localhost:9876/_karm...

X Description: @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://loca...

Opengraph URL: https://github.com/angular/angular/issues/30121

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NGCC only transforms top level modules","articleBody":"@gkalpak and myself saw the below issue when running tests under ivy\r\n```\r\nError: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'.\r\n    at throwError (http://localhost:9876/_karma_webpack_/vendor.js:62601:11)\r\n    at assertDefined (http://localhost:9876/_karma_webpack_/vendor.js:62595:9)\r\n    at new NgModuleRef$1 (http://localhost:9876/_karma_webpack_/vendor.js:86038:22)\r\n    at NgModuleFactory$1.create (http://localhost:9876/_karma_webpack_/vendor.js:86109:16)\r\n```\r\n\r\nIt seems the issue is that NGCC only transforms top level modules.\r\n\r\nhttps://github.com/angular/angular/blob/00ce9aab5b8d3295b8e570e3fdb5f25f9af5738f/packages/core/testing/src/r3_test_bed_compiler.ts#L551-L557\r\n\r\nwith ngcc the output of it is\r\n```ts\r\n        class CompilerModule {\r\n        }\r\n        CompilerModule.decorators = [\r\n            { type: NgModule, args: [{ providers },] },\r\n        ];\r\n        /** @type {?} */\r\n        const CompilerModuleFactory = new ɵNgModuleFactory(CompilerModule);\r\n        this._injector = CompilerModuleFactory.create(this.platform.injector).injector;\r\n        return this._injector;\r\n```","author":{"url":"https://github.com/alan-agius4","@type":"Person","name":"alan-agius4"},"datePublished":"2019-04-25T17:38:18Z","url":"https://github.com/angular/angular/issues/30121"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:99793d51-8e54-31d4-0d1a-051402b9600c
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAA34:CC1A4:1484200:1A16803:6B01299C
html-safe-nonce388df07ae7ff27cabbe05297fa13902b68548b8187a4e2541fc1ac3b32d39b59
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTM0OkNDMUE0OjE0ODQyMDA6MUExNjgwMzo2QjAxMjk5QyIsInZpc2l0b3JfaWQiOiI5MzYwMzI4NDM0MzQzNzE0ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac63c816b12c3a503ed98fff532779d91bb0781ab73b9476350604f55cf77ea095
hovercard-subject-tagissue:437317840
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/30121/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e816bb8ac6215771e4a102b8328f5bc62ac9e8cc04a3f63cf0e04a7c1e7874d2/angular/angular/issues/30121
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e816bb8ac6215771e4a102b8328f5bc62ac9e8cc04a3f63cf0e04a7c1e7874d2/angular/angular/issues/30121
og:image:alt@gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://localhost:9876/_karm...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealan-agius4
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/30121#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F30121
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F30121
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/30121
Reloadhttps://github.com/angular/angular/issues/30121
Reloadhttps://github.com/angular/angular/issues/30121
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/30121
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/30121
NGCC only transforms top level moduleshttps://github.com/angular/angular/issues/30121#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Apr 25, 2019https://github.com/angular/angular/issues/30121#issue-437317840
@gkalpakhttps://github.com/gkalpak
angular/packages/core/testing/src/r3_test_bed_compiler.tshttps://github.com/angular/angular/blob/00ce9aab5b8d3295b8e570e3fdb5f25f9af5738f/packages/core/testing/src/r3_test_bed_compiler.ts#L551-L557
00ce9aahttps://github.com/angular/angular/commit/00ce9aab5b8d3295b8e570e3fdb5f25f9af5738f
alan-agius4https://github.com/alan-agius4
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Apr 25, 2019https://github.com/angular/angular/issues/30121#event-2300978058
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Apr 25, 2019https://github.com/angular/angular/issues/30121#event-2300978119
karahttps://github.com/kara
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
066ec33https://github.com/angular/angular/commit/066ec33342c371e6a1a11e35a6c0d44f94b1c96a
on May 1, 2019https://github.com/angular/angular/issues/30121#event-2313208316
karahttps://github.com/kara
on May 1, 2019https://github.com/angular/angular/issues/30121#event-2313208439
fix(ivy): allow `R3TestBedCompiler` to work in ngcc-processed apps (#…https://github.com/angular/angular/commit/7cbc69c890462d45ee77716b79e595fd21ada40d
#…https://github.com/angular/angular/pull/28530
7cbc69chttps://github.com/angular/angular/commit/7cbc69c890462d45ee77716b79e595fd21ada40d
BioPhotonhttps://github.com/BioPhoton
on May 21, 2019https://github.com/angular/angular/issues/30121#event-2355185124
fix(ivy): allow `R3TestBedCompiler` to work in ngcc-processed apps (a…https://github.com/BioPhoton/angular/commit/891d16228e790b9e010fd3ff90910d9cd6b7518b
a…https://github.com/angular/angular/pull/28530
891d162https://github.com/BioPhoton/angular/commit/891d16228e790b9e010fd3ff90910d9cd6b7518b
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/30121#issuecomment-531525100
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 15, 2019https://github.com/angular/angular/issues/30121#event-2634403773
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/30121
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/30121
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.