Title: NGCC only transforms top level modules · Issue #30121 · angular/angular · GitHub
Open Graph Title: NGCC only transforms top level modules · Issue #30121 · angular/angular
X Title: NGCC only transforms top level modules · Issue #30121 · angular/angular
Description: @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://localhost:9876/_karma_webpack_/vendor.js:62601:11) at assert...
Open Graph Description: @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://localhost:9876/_karm...
X Description: @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://loca...
Opengraph URL: https://github.com/angular/angular/issues/30121
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NGCC only transforms top level modules","articleBody":"@gkalpak and myself saw the below issue when running tests under ivy\r\n```\r\nError: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'.\r\n at throwError (http://localhost:9876/_karma_webpack_/vendor.js:62601:11)\r\n at assertDefined (http://localhost:9876/_karma_webpack_/vendor.js:62595:9)\r\n at new NgModuleRef$1 (http://localhost:9876/_karma_webpack_/vendor.js:86038:22)\r\n at NgModuleFactory$1.create (http://localhost:9876/_karma_webpack_/vendor.js:86109:16)\r\n```\r\n\r\nIt seems the issue is that NGCC only transforms top level modules.\r\n\r\nhttps://github.com/angular/angular/blob/00ce9aab5b8d3295b8e570e3fdb5f25f9af5738f/packages/core/testing/src/r3_test_bed_compiler.ts#L551-L557\r\n\r\nwith ngcc the output of it is\r\n```ts\r\n class CompilerModule {\r\n }\r\n CompilerModule.decorators = [\r\n { type: NgModule, args: [{ providers },] },\r\n ];\r\n /** @type {?} */\r\n const CompilerModuleFactory = new ɵNgModuleFactory(CompilerModule);\r\n this._injector = CompilerModuleFactory.create(this.platform.injector).injector;\r\n return this._injector;\r\n```","author":{"url":"https://github.com/alan-agius4","@type":"Person","name":"alan-agius4"},"datePublished":"2019-04-25T17:38:18Z","url":"https://github.com/angular/angular/issues/30121"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:99793d51-8e54-31d4-0d1a-051402b9600c |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA34:CC1A4:1484200:1A16803:6B01299C |
| html-safe-nonce | 388df07ae7ff27cabbe05297fa13902b68548b8187a4e2541fc1ac3b32d39b59 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTM0OkNDMUE0OjE0ODQyMDA6MUExNjgwMzo2QjAxMjk5QyIsInZpc2l0b3JfaWQiOiI5MzYwMzI4NDM0MzQzNzE0ODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 63c816b12c3a503ed98fff532779d91bb0781ab73b9476350604f55cf77ea095 |
| hovercard-subject-tag | issue:437317840 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/30121/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e816bb8ac6215771e4a102b8328f5bc62ac9e8cc04a3f63cf0e04a7c1e7874d2/angular/angular/issues/30121 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e816bb8ac6215771e4a102b8328f5bc62ac9e8cc04a3f63cf0e04a7c1e7874d2/angular/angular/issues/30121 |
| og:image:alt | @gkalpak and myself saw the below issue when running tests under ivy Error: ASSERTION ERROR: NgModule 'CompilerModule' is not a subtype of 'NgModuleType'. at throwError (http://localhost:9876/_karm... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | alan-agius4 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width