Title: RFC: AsyncPipe doesn't necessarily need WrappedValue · Issue #29927 · angular/angular · GitHub
Open Graph Title: RFC: AsyncPipe doesn't necessarily need WrappedValue · Issue #29927 · angular/angular
X Title: RFC: AsyncPipe doesn't necessarily need WrappedValue · Issue #29927 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise description of the problem... In WrappedValue do...
Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise descript...
X Description: 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise desc...
Opengraph URL: https://github.com/angular/angular/issues/29927
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"RFC: AsyncPipe doesn't necessarily need WrappedValue","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/common\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️-->\r\nNo, it's likely a design failure from the very beginning.\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️--> A clear and concise description of the problem...\r\n\r\nIn [`WrappedValue`](https://angular.io/api/core/WrappedValue) documentation, it's saying:\r\n\r\n> Indicates that the result of a [`Pipe`](https://angular.io/api/core/Pipe) transformation has changed even though the reference has not changed.\r\n\r\nBut inside [`AsyncPipe`](https://angular.io/api/common/AsyncPipe) whether or not returning an `WrappedValue` is fully based on reference changed or not:\r\n\r\nhttps://github.com/angular/angular/blob/9147092a156203d46cd1c865e06fa72a1e2d4137/packages/common/src/pipes/async_pipe.ts#L106-L111\r\n\r\nIt will only wrap the first changed value into `WrappedValue`, all the subsequent unchanged values will retain unwrapped, even changing the observable reference won't make any effect:\r\n\r\nhttps://stackblitz.com/edit/typescript-bzkarv\r\n\r\nOtherwise, even the same value being re-emitted many times during change detection, it won't be wrapped and no error is reported:\r\n\r\nhttps://stackblitz.com/edit/angular-kqkpym?file=src%2Fapp%2Fapp.component.ts\r\n\r\nI don't know what's the difference if `AsyncPipe` just return the unwrapped value and let the change detector to check it. Please correct me if I am wrong.\r\n\r\nAnd then, what's the meaning of `WrappedValue` as not need by Angular itself?\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\u003c!-- ✍️-->\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\nLinked above.\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>N/A\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>N/A\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n\r\nThe question was found when digging into https://github.com/angular/angular/pull/22305.\r\n","author":{"url":"https://github.com/trotyl","@type":"Person","name":"trotyl"},"datePublished":"2019-04-16T15:04:15Z","url":"https://github.com/angular/angular/issues/29927"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:9d6ef517-0752-a303-ef66-4dcd17a1e25d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C472:24ACB9:1C2D181:24FDEBF:6B014BB5 |
| html-safe-nonce | fba8d4b2f688eec1f54cc42768b82db123a6cbb69b111bf575b0e06de7faaf5f |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDcyOjI0QUNCOToxQzJEMTgxOjI0RkRFQkY6NkIwMTRCQjUiLCJ2aXNpdG9yX2lkIjoiMTY3MTQ3MjkxNDAwNTgzODc3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | fc9a36ef893dcf517ff71d2e08c219065d11defc6b669764f24871a53c18d8f4 |
| hovercard-subject-tag | issue:433832014 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/29927/issue_layout |
| twitter:image | https://opengraph.githubassets.com/eb40a77319ab9c90b267856dbe2a21be965db502a7b7ab2027370c9f68a4ed56/angular/angular/issues/29927 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/eb40a77319ab9c90b267856dbe2a21be965db502a7b7ab2027370c9f68a4ed56/angular/angular/issues/29927 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise descript... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | trotyl |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width