René's URL Explorer Experiment


Title: RFC: AsyncPipe doesn't necessarily need WrappedValue · Issue #29927 · angular/angular · GitHub

Open Graph Title: RFC: AsyncPipe doesn't necessarily need WrappedValue · Issue #29927 · angular/angular

X Title: RFC: AsyncPipe doesn't necessarily need WrappedValue · Issue #29927 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise description of the problem... In WrappedValue do...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise descript...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise desc...

Opengraph URL: https://github.com/angular/angular/issues/29927

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"RFC: AsyncPipe doesn't necessarily need WrappedValue","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/common\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️-->\r\nNo, it's likely a design failure from the very beginning.\r\n\r\n### Description\r\n\r\n\u003c!-- ✍️--> A clear and concise description of the problem...\r\n\r\nIn [`WrappedValue`](https://angular.io/api/core/WrappedValue) documentation, it's saying:\r\n\r\n> Indicates that the result of a [`Pipe`](https://angular.io/api/core/Pipe) transformation has changed even though the reference has not changed.\r\n\r\nBut inside [`AsyncPipe`](https://angular.io/api/common/AsyncPipe) whether or not returning an `WrappedValue` is fully based on reference changed or not:\r\n\r\nhttps://github.com/angular/angular/blob/9147092a156203d46cd1c865e06fa72a1e2d4137/packages/common/src/pipes/async_pipe.ts#L106-L111\r\n\r\nIt will only wrap the first changed value into `WrappedValue`, all the subsequent unchanged values will retain unwrapped, even changing the observable reference won't make any effect:\r\n\r\nhttps://stackblitz.com/edit/typescript-bzkarv\r\n\r\nOtherwise, even the same value being re-emitted many times during change detection, it won't be wrapped and no error is reported:\r\n\r\nhttps://stackblitz.com/edit/angular-kqkpym?file=src%2Fapp%2Fapp.component.ts\r\n\r\nI don't know what's the difference if `AsyncPipe` just return the unwrapped value and let the change detector to check it. Please correct me if I am wrong.\r\n\r\nAnd then, what's the meaning of `WrappedValue` as not need by Angular itself?\r\n\r\n## 🔬 Minimal Reproduction\r\n\u003c!--\r\nPlease create and share minimal reproduction of the issue starting with this template: https://stackblitz.com/fork/angular-issue-repro2\r\n-->\r\n\u003c!-- ✍️-->\r\n\r\n\u003c!--\r\nIf StackBlitz is not suitable for reproduction of your issue, please create a minimal GitHub repository with the reproduction of the issue.\r\nA good way to make a minimal reproduction is to create a new app via `ng new repro-app` and add the minimum possible code to show the problem. \r\nShare the link to the repo below along with step-by-step instructions to reproduce the problem, as well as expected and actual behavior.\r\n\r\nIssues that don't have enough info and can't be reproduced will be closed.\r\n\r\nYou can read more about issue submission guidelines here: https://github.com/angular/angular/blob/master/CONTRIBUTING.md#-submitting-an-issue\r\n-->\r\n\r\nLinked above.\r\n\r\n## 🔥 Exception or Error\r\n\u003cpre>\u003ccode>N/A\r\n\u003c/code>\u003c/pre>\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>N/A\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\n\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n\r\nThe question was found when digging into https://github.com/angular/angular/pull/22305.\r\n","author":{"url":"https://github.com/trotyl","@type":"Person","name":"trotyl"},"datePublished":"2019-04-16T15:04:15Z","url":"https://github.com/angular/angular/issues/29927"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:9d6ef517-0752-a303-ef66-4dcd17a1e25d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC472:24ACB9:1C2D181:24FDEBF:6B014BB5
html-safe-noncefba8d4b2f688eec1f54cc42768b82db123a6cbb69b111bf575b0e06de7faaf5f
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDNDcyOjI0QUNCOToxQzJEMTgxOjI0RkRFQkY6NkIwMTRCQjUiLCJ2aXNpdG9yX2lkIjoiMTY3MTQ3MjkxNDAwNTgzODc3MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacfc9a36ef893dcf517ff71d2e08c219065d11defc6b669764f24871a53c18d8f4
hovercard-subject-tagissue:433832014
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/29927/issue_layout
twitter:imagehttps://opengraph.githubassets.com/eb40a77319ab9c90b267856dbe2a21be965db502a7b7ab2027370c9f68a4ed56/angular/angular/issues/29927
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/eb40a77319ab9c90b267856dbe2a21be965db502a7b7ab2027370c9f68a4ed56/angular/angular/issues/29927
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/common Is this a regression? No, it's likely a design failure from the very beginning. Description A clear and concise descript...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernametrotyl
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/29927#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F29927
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F29927
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/29927
Reloadhttps://github.com/angular/angular/issues/29927
Reloadhttps://github.com/angular/angular/issues/29927
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/29927
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/29927
RFC: AsyncPipe doesn't necessarily need WrappedValuehttps://github.com/angular/angular/issues/29927#top
https://github.com/atscott
area: commonIssues related to APIs in the @angular/common packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Apr 16, 2019https://github.com/angular/angular/issues/29927#issue-433832014
WrappedValuehttps://angular.io/api/core/WrappedValue
Pipehttps://angular.io/api/core/Pipe
AsyncPipehttps://angular.io/api/common/AsyncPipe
angular/packages/common/src/pipes/async_pipe.tshttps://github.com/angular/angular/blob/9147092a156203d46cd1c865e06fa72a1e2d4137/packages/common/src/pipes/async_pipe.ts#L106-L111
9147092https://github.com/angular/angular/commit/9147092a156203d46cd1c865e06fa72a1e2d4137
https://stackblitz.com/edit/typescript-bzkarvhttps://stackblitz.com/edit/typescript-bzkarv
https://stackblitz.com/edit/angular-kqkpym?file=src%2Fapp%2Fapp.component.tshttps://stackblitz.com/edit/angular-kqkpym?file=src%2Fapp%2Fapp.component.ts
#22305https://github.com/angular/angular/pull/22305
https://github.com/mlc-mlapis
mlc-mlapishttps://github.com/mlc-mlapis
on Apr 16, 2019https://github.com/angular/angular/issues/29927#issuecomment-483787196
@trotylhttps://github.com/trotyl
#23933https://github.com/angular/angular/issues/23933
AndrewKushnirhttps://github.com/AndrewKushnir
area: commonIssues related to APIs in the @angular/common packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
on Apr 16, 2019https://github.com/angular/angular/issues/29927#event-2281119428
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Apr 16, 2019https://github.com/angular/angular/issues/29927#event-2281119441
matskohttps://github.com/matsko
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity1: confusinghttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity1%3A%20confusing%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Apr 25, 2019https://github.com/angular/angular/issues/29927#event-2301636266
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Apr 25, 2019https://github.com/angular/angular/issues/29927#event-2301636292
https://github.com/kingecg
kingecghttps://github.com/kingecg
on Jun 27, 2019https://github.com/angular/angular/issues/29927#issuecomment-506105433
atscotthttps://github.com/atscott
on Apr 14, 2020https://github.com/angular/angular/issues/29927#event-3232211206
alxhubhttps://github.com/alxhub
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
49be32chttps://github.com/angular/angular/commit/49be32c9315a5c7ff155c5b88191e504006f595b
on Apr 30, 2020https://github.com/angular/angular/issues/29927#event-3290849126
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 31, 2020https://github.com/angular/angular/issues/29927#issuecomment-636491802
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 31, 2020https://github.com/angular/angular/issues/29927#event-3390743246
profanishttps://github.com/profanis
on Sep 5, 2020https://github.com/angular/angular/issues/29927#event-3732915408
refactor(common): remove WrappedValue from AsyncPipe (angular#36633)https://github.com/profanis/angular/commit/64efb5ec21a3ca3b114321f6ce1eba837b6ce3b7
angular#36633https://github.com/angular/angular/pull/36633
https://docs.github.com/articles/closing-issues-via-commit-messages
64efb5ehttps://github.com/profanis/angular/commit/64efb5ec21a3ca3b114321f6ce1eba837b6ce3b7
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/29927
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/29927
atscotthttps://github.com/atscott
area: commonIssues related to APIs in the @angular/common packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20common%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.