Title: ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders · Issue #29078 · angular/angular · GitHub
Open Graph Title: ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders · Issue #29078 · angular/angular
X Title: ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders · Issue #29078 · angular/angular
Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.js): let Angula...
Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es...
X Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es...
Opengraph URL: https://github.com/angular/angular/issues/29078
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nThe issue is caused by package `@angular/compiler-cli`\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nNo\r\n\r\n\r\n### Description\r\n\r\nTake a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.js):\r\n\r\n```typescript\r\nlet AngularFireModule = AngularFireModule_1 = class AngularFireModule {\r\n static initializeApp(options, nameOrConfig) {\r\n return {\r\n ngModule: AngularFireModule_1,\r\n providers: [\r\n { provide: FirebaseOptionsToken, useValue: options },\r\n { provide: FirebaseNameOrConfigToken, useValue: nameOrConfig }\r\n ]\r\n };\r\n }\r\n};\r\nAngularFireModule = AngularFireModule_1 = __decorate([\r\n NgModule({\r\n providers: [FirebaseAppProvider],\r\n })\r\n], AngularFireModule);\r\nexport { AngularFireModule };\r\n```\r\n\r\n`ivy-ngcc` cannot recognise the `AngularFireModule.initializeApp` and mark it as `ModuleWithProviders`.\r\n\r\nThis is because the current implementation of `ivy-ngcc` which looks for `ts.ClassDeclaration`. Instead, the code above is a variable assignment to `ts.BinaryExpression` which includes `ts.ClassExpression`.\r\n\r\nThere are 2 solutions to this issue:\r\n\r\n1. Make `ivy-ngcc` to able to recognise class declaration like this.\r\n2. Tell library authors to use `angularCompilerOptions.annotationsAs` as `static fields` during packaging.\r\n\r\nMy voice is with solution 2, though.\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nN/A\r\n\r\n## 🔥 Exception or Error\r\nN/A\r\n\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\u003c!-- run `ng version` and paste output below -->\r\n8.0.0-beta.6\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\nThis causes #28603.\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n","author":{"url":"https://github.com/sarunint","@type":"Person","name":"sarunint"},"datePublished":"2019-03-02T21:20:01Z","url":"https://github.com/angular/angular/issues/29078"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:8d6a38f8-0aa6-d26f-aa2f-960069c29845 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | C030:2C4BED:1208720:16F7A02:6B011D66 |
| html-safe-nonce | 2abf70032a67ece699f65fc4ce251a3c9748bbcace65f14f8767f0bad0f46c19 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDMwOjJDNEJFRDoxMjA4NzIwOjE2RjdBMDI6NkIwMTFENjYiLCJ2aXNpdG9yX2lkIjoiNzYwNDQ4MDI5NTI2MDA5MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 1dd5e7658f4c5d092e92e05d7e71a7cfffb06c09809e575cd0f84acbcc12c1ef |
| hovercard-subject-tag | issue:416443384 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/29078/issue_layout |
| twitter:image | https://opengraph.githubassets.com/6e76e207339cff6867449acf41bd68bd7cfa81de760451439dc7096857815eaa/angular/angular/issues/29078 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/6e76e207339cff6867449acf41bd68bd7cfa81de760451439dc7096857815eaa/angular/angular/issues/29078 |
| og:image:alt | 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | sarunint |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width