René's URL Explorer Experiment


Title: ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders · Issue #29078 · angular/angular · GitHub

Open Graph Title: ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders · Issue #29078 · angular/angular

X Title: ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders · Issue #29078 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.js): let Angula...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es...

Opengraph URL: https://github.com/angular/angular/issues/29078

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProviders","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄\r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\nThe issue is caused by package `@angular/compiler-cli`\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\nNo\r\n\r\n\r\n### Description\r\n\r\nTake a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.js):\r\n\r\n```typescript\r\nlet AngularFireModule = AngularFireModule_1 = class AngularFireModule {\r\n    static initializeApp(options, nameOrConfig) {\r\n        return {\r\n            ngModule: AngularFireModule_1,\r\n            providers: [\r\n                { provide: FirebaseOptionsToken, useValue: options },\r\n                { provide: FirebaseNameOrConfigToken, useValue: nameOrConfig }\r\n            ]\r\n        };\r\n    }\r\n};\r\nAngularFireModule = AngularFireModule_1 = __decorate([\r\n    NgModule({\r\n        providers: [FirebaseAppProvider],\r\n    })\r\n], AngularFireModule);\r\nexport { AngularFireModule };\r\n```\r\n\r\n`ivy-ngcc` cannot recognise the `AngularFireModule.initializeApp` and mark it as `ModuleWithProviders`.\r\n\r\nThis is because the current implementation of `ivy-ngcc` which looks for `ts.ClassDeclaration`. Instead, the code above is a variable assignment to `ts.BinaryExpression` which includes `ts.ClassExpression`.\r\n\r\nThere are 2 solutions to this issue:\r\n\r\n1. Make `ivy-ngcc` to able to recognise class declaration like this.\r\n2. Tell library authors to use `angularCompilerOptions.annotationsAs` as `static fields` during packaging.\r\n\r\nMy voice is with solution 2, though.\r\n\r\n\r\n## 🔬 Minimal Reproduction\r\nN/A\r\n\r\n## 🔥 Exception or Error\r\nN/A\r\n\r\n\r\n## 🌍  Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\n\u003c!-- run `ng version` and paste output below -->\r\n8.0.0-beta.6\r\n\r\n\u003c/code>\u003c/pre>\r\n\r\n**Anything else relevant?**\r\n\u003c!-- ✍️Is this a browser specific issue? If so, please specify the browser and version. -->\r\nThis causes #28603.\r\n\u003c!-- ✍️Do any of these matter: operating system, IDE, package manager, HTTP server, ...? If so, please mention it below. -->\r\n","author":{"url":"https://github.com/sarunint","@type":"Person","name":"sarunint"},"datePublished":"2019-03-02T21:20:01Z","url":"https://github.com/angular/angular/issues/29078"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8d6a38f8-0aa6-d26f-aa2f-960069c29845
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idC030:2C4BED:1208720:16F7A02:6B011D66
html-safe-nonce2abf70032a67ece699f65fc4ce251a3c9748bbcace65f14f8767f0bad0f46c19
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDMDMwOjJDNEJFRDoxMjA4NzIwOjE2RjdBMDI6NkIwMTFENjYiLCJ2aXNpdG9yX2lkIjoiNzYwNDQ4MDI5NTI2MDA5MzQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac1dd5e7658f4c5d092e92e05d7e71a7cfffb06c09809e575cd0f84acbcc12c1ef
hovercard-subject-tagissue:416443384
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/29078/issue_layout
twitter:imagehttps://opengraph.githubassets.com/6e76e207339cff6867449acf41bd68bd7cfa81de760451439dc7096857815eaa/angular/angular/issues/29078
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/6e76e207339cff6867449acf41bd68bd7cfa81de760451439dc7096857815eaa/angular/angular/issues/29078
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/compiler-cli Is this a regression? No Description Take a look at this code (taken from https://unpkg.com/@angular/fire@5.1.1/es...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesarunint
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/29078#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F29078
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F29078
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/29078
Reloadhttps://github.com/angular/angular/issues/29078
Reloadhttps://github.com/angular/angular/issues/29078
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/29078
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/29078
ivy-ngcc is unable to recognise AngularFireModule.initializeApp as ModuleWithProvidershttps://github.com/angular/angular/issues/29078#top
https://github.com/petebacondarwin
needsTriagehttps://github.com/angular/angular/milestone/83
https://github.com/sarunint
saruninthttps://github.com/sarunint
on Mar 2, 2019https://github.com/angular/angular/issues/29078#issue-416443384
https://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.jshttps://unpkg.com/@angular/fire@5.1.1/es2015/firebase.app.module.js
#28603https://github.com/angular/angular/issues/28603
AndrewKushnirhttps://github.com/AndrewKushnir
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Mar 2, 2019https://github.com/angular/angular/issues/29078#event-2175967814
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Mar 2, 2019https://github.com/angular/angular/issues/29078#event-2175967817
https://github.com/StephenFluin
StephenFluinhttps://github.com/StephenFluin
on Mar 3, 2019https://github.com/angular/angular/issues/29078#issuecomment-469047620
https://github.com/sarunint
saruninthttps://github.com/sarunint
on Mar 3, 2019https://github.com/angular/angular/issues/29078#issuecomment-469065804
@StephenFluinhttps://github.com/StephenFluin
alxhubhttps://github.com/alxhub
petebacondarwinhttps://github.com/petebacondarwin
on Mar 4, 2019https://github.com/angular/angular/issues/29078#event-2178857814
https://github.com/petebacondarwin
petebacondarwinhttps://github.com/petebacondarwin
on Mar 4, 2019https://github.com/angular/angular/issues/29078#issuecomment-469450076
petebacondarwinhttps://github.com/petebacondarwin
on Apr 2, 2019https://github.com/angular/angular/issues/29078#event-2245538669
fix(ivy): ngcc - properly handle aliases class expressionshttps://github.com/JoostK/angular/commit/901708bf9a11b9b3cf6ee486e70c0c52f4192032
https://docs.github.com/articles/closing-issues-via-commit-messages
901708bhttps://github.com/JoostK/angular/commit/901708bf9a11b9b3cf6ee486e70c0c52f4192032
jasonadenhttps://github.com/jasonaden
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
98f8b0fhttps://github.com/angular/angular/commit/98f8b0f32833a445290dbf131974c8419b054009
on Apr 2, 2019https://github.com/angular/angular/issues/29078#event-2247389143
wKozahttps://github.com/wKoza
on Apr 17, 2019https://github.com/angular/angular/issues/29078#event-2282830613
fix(ivy): ngcc - properly handle aliases class expressions (angular#2…https://github.com/wKoza/angular/commit/a84e8b4e82f8e5a4a2a5f8fa49b5c1ee0241d2b3
angular#2…https://github.com/angular/angular/pull/29119
https://docs.github.com/articles/closing-issues-via-commit-messages
a84e8b4https://github.com/wKoza/angular/commit/a84e8b4e82f8e5a4a2a5f8fa49b5c1ee0241d2b3
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/29078#issuecomment-531518216
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/29078#event-2634361840
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/29078
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/29078
petebacondarwinhttps://github.com/petebacondarwin
needsTriageNo due datehttps://github.com/angular/angular/milestone/83
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.