Title: docs-infra: scroll position restoration improvements · Issue #28332 · angular/angular · GitHub
Open Graph Title: docs-infra: scroll position restoration improvements · Issue #28332 · angular/angular
X Title: docs-infra: scroll position restoration improvements · Issue #28332 · angular/angular
Description: Scroll position restoration was added to the angular.io app in #28037. Here are some possible improvements to consider: Add throttling/debouncing in storing scroll position on scroll here, since it is relatively expensive and the scroll ...
Open Graph Description: Scroll position restoration was added to the angular.io app in #28037. Here are some possible improvements to consider: Add throttling/debouncing in storing scroll position on scroll here, since it...
X Description: Scroll position restoration was added to the angular.io app in #28037. Here are some possible improvements to consider: Add throttling/debouncing in storing scroll position on scroll here, since it...
Opengraph URL: https://github.com/angular/angular/issues/28332
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"docs-infra: scroll position restoration improvements","articleBody":"Scroll position restoration was added to the angular.io app in #28037.\r\nHere are some possible improvements to consider: \r\n\r\n- [x] Add throttling/debouncing in storing scroll position on scroll [here][1], since it is relatively expensive and the `scroll` event can be emitted several times per second. See, also, [this comment][2].\r\n- [x] Document under what circumstances checking for manual scroll restoration support [here][3] may throw.\r\n- [x] Scroll the scroll position retrieved from history state in `sessionStorage` [here][4], to avoid a race-condition with navigating forward/back and immediately reloading. See, also, [this comment][5].\r\n- [x] Remove unnecessary(?) `try/catch` block [here][6]. See, also, [this comment][7].\r\n\r\n[1]: https://github.com/angular/angular/blob/bf6bc41043203502534607ecbbe1a4c526f8e346/aio/src/app/app.component.ts#L343\r\n[2]: https://github.com/angular/angular/pull/28037/files#r250354376.\r\n[3]: https://github.com/angular/angular/blob/bf6bc41043203502534607ecbbe1a4c526f8e346/aio/src/app/shared/scroll.service.ts#L49\r\n[4]: https://github.com/angular/angular/blob/bf6bc41043203502534607ecbbe1a4c526f8e346/aio/src/app/shared/scroll.service.ts#L69\r\n[5]: https://github.com/angular/angular/pull/28037#discussion_r249507542\r\n[6]: https://github.com/angular/angular/blob/bf6bc41043203502534607ecbbe1a4c526f8e346/aio/src/app/shared/scroll.service.ts#L48-L53\r\n[7]: https://github.com/angular/angular/pull/28037#discussion_r250527791","author":{"url":"https://github.com/gkalpak","@type":"Person","name":"gkalpak"},"datePublished":"2019-01-24T10:10:12Z","url":"https://github.com/angular/angular/issues/28332"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:25cf75da-f209-9945-9149-d50eb301a17b |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AA3C:34CAB:130EAF2:185E1C9:6B012822 |
| html-safe-nonce | 690435846e7f67c32ecc275394a9ef12b629435fcb7f32aac1d259af0ad8c8b8 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQTNDOjM0Q0FCOjEzMEVBRjI6MTg1RTFDOTo2QjAxMjgyMiIsInZpc2l0b3JfaWQiOiI4NTI4NDk2MDI3MjIzNzk1NzQ2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 32cfa370474fe9044b32b2453166acd140bca707600c31a59eb5a87a3ef122c5 |
| hovercard-subject-tag | issue:402631946 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/28332/issue_layout |
| twitter:image | https://opengraph.githubassets.com/e00537473ec6b713562539756515e8f1b6a2708fecd5a149987049785702069b/angular/angular/issues/28332 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/e00537473ec6b713562539756515e8f1b6a2708fecd5a149987049785702069b/angular/angular/issues/28332 |
| og:image:alt | Scroll position restoration was added to the angular.io app in #28037. Here are some possible improvements to consider: Add throttling/debouncing in storing scroll position on scroll here, since it... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | gkalpak |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width