Title: ivy: i18n messages identifiers have dots in their name · Issue #28080 · angular/angular · GitHub
Open Graph Title: ivy: i18n messages identifiers have dots in their name · Issue #28080 · angular/angular
X Title: ivy: i18n messages identifiers have dots in their name · Issue #28080 · angular/angular
Description: 🐞 bug report Description ngtsc fails to compile an application using ng-bootstrap because i18n messages have weird identifiers generated by ngcc. For example, in ./node_modules/@ng-bootstrap/ng-bootstrap/fesm5/ng-bootstrap.js after runni...
Open Graph Description: 🐞 bug report Description ngtsc fails to compile an application using ng-bootstrap because i18n messages have weird identifiers generated by ngcc. For example, in ./node_modules/@ng-bootstrap/ng-boo...
X Description: 🐞 bug report Description ngtsc fails to compile an application using ng-bootstrap because i18n messages have weird identifiers generated by ngcc. For example, in ./node_modules/@ng-bootstrap/ng-boo...
Opengraph URL: https://github.com/angular/angular/issues/28080
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"ivy: i18n messages identifiers have dots in their name","articleBody":"# 🐞 bug report\r\n\r\n### Description\r\n\r\n`ngtsc` fails to compile an application using ng-bootstrap because i18n messages have weird identifiers generated by `ngcc`.\r\n\r\nFor example, in `./node_modules/@ng-bootstrap/ng-bootstrap/fesm5/ng-bootstrap.js` after running `ngcc`:\r\n```\r\nconst MSG_EXTERNAL_ngb.alert.close$$FESM5_NG_BOOTSTRAP_JS__15 = goog.getMsg(\"Close\");\r\n```\r\nNote the dots in the name of the constant.\r\n\r\nThat produces after `ng build --aot` in an Ivy app:\r\n\r\n```\r\nERROR in ./node_modules/@ng-bootstrap/ng-bootstrap/fesm5/ng-bootstrap.js 71:22\r\nModule parse failed: Unexpected token (71:22)\r\nYou may need an appropriate loader to handle this file type.\r\n| const _c13 = [\"alert-dismissible\"];\r\n| const _c14 = [\"type\", \"button\", 1, \"close\", 3, \"click\"];\r\n> const MSG_EXTERNAL_ngb.alert.close$$FESM5_NG_BOOTSTRAP_JS__15 = goog.getMsg(\"Close\");\r\n| const _c16 = [\"aria-label\", MSG_EXTERNAL_ngb.alert.close$$FESM5_NG_BOOTSTRAP_JS__15];\r\n| const _c17 = [\"aria-hidden\", \"true\"];\r\n```\r\n\r\n### Is this a regression?\r\n\r\nNo it has been present for a while\r\n\r\n## 🔬 Minimal Reproduction\r\n\r\n```\r\nng new ivy-boostrap --defaults\r\nnpm i --save @ng-bootstrap/ng-bootstrap\r\n$(npm bin)/ivy-ngcc\r\n# if ngcc fails apply https://github.com/angular/angular/pull/28076 manually and rerun\r\n# add NgDropdownModule to AppModule (see above)\r\n# enable ivy to use ngtsc\r\nng build --aot \r\n```\r\n\r\napp.module.ts\r\n```typescript\r\nimport { BrowserModule } from '@angular/platform-browser';\r\nimport { NgModule } from '@angular/core';\r\nimport { NgbDropdownModule } from '@ng-bootstrap/ng-bootstrap';\r\n\r\nimport { AppComponent } from './app.component';\r\n\r\n@NgModule({\r\n declarations: [\r\n AppComponent\r\n ],\r\n imports: [\r\n BrowserModule,\r\n NgbDropdownModule\r\n ],\r\n providers: [],\r\n bootstrap: [AppComponent]\r\n})\r\nexport class AppModule { }\r\n```\r\n## 🔥 Exception or Error\r\n\r\n`ng build --aot` yields:\r\n\u003cpre>\u003ccode>\r\nERROR in ./node_modules/@ng-bootstrap/ng-bootstrap/fesm5/ng-bootstrap.js 71:22\r\nModule parse failed: Unexpected token (71:22)\r\nYou may need an appropriate loader to handle this file type.\r\n| const _c13 = [\"alert-dismissible\"];\r\n| const _c14 = [\"type\", \"button\", 1, \"close\", 3, \"click\"];\r\n> const MSG_EXTERNAL_ngb.alert.close$$FESM5_NG_BOOTSTRAP_JS__15 = goog.getMsg(\"Close\");\r\n| const _c16 = [\"aria-label\", MSG_EXTERNAL_ngb.alert.close$$FESM5_NG_BOOTSTRAP_JS__15];\r\n| const _c17 = [\"aria-hidden\", \"true\"];\r\n\u003c/code>\u003c/pre>\r\n\r\n## 🌍 Your Environment\r\n\r\n**Angular Version:**\r\n\u003cpre>\u003ccode>\r\nAngular CLI: 7.2.0\r\nNode: 10.14.1\r\nOS: darwin x64\r\nAngular: 7.2.0\r\n... animations, cli, common, compiler, compiler-cli, core, forms\r\n... language-service, platform-browser, platform-browser-dynamic\r\n... router\r\n\r\nPackage Version\r\n-----------------------------------------------------------\r\n@angular-devkit/architect 0.12.0\r\n@angular-devkit/build-angular 0.12.0\r\n@angular-devkit/build-optimizer 0.12.0\r\n@angular-devkit/build-webpack 0.12.0\r\n@angular-devkit/core 7.2.0\r\n@angular-devkit/schematics 7.2.0\r\n@ngtools/webpack 7.2.0\r\n@schematics/angular 7.2.0\r\n@schematics/update 0.12.0\r\nrxjs 6.3.3\r\ntypescript 3.2.2\r\nwebpack 4.23.1\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/cexbrayat","@type":"Person","name":"cexbrayat"},"datePublished":"2019-01-11T15:05:06Z","url":"https://github.com/angular/angular/issues/28080"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c7274d56-04dc-11ad-eee6-69b687b82241 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | D100:95C88:1476D0D:1B168C5:6B01254F |
| html-safe-nonce | 7afd18e7117f701fa75dca1c8d643016dda1b7aebd3f00514b9f66e1c28ad92b |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJEMTAwOjk1Qzg4OjE0NzZEMEQ6MUIxNjhDNTo2QjAxMjU0RiIsInZpc2l0b3JfaWQiOiIzNzQzMzY4MDIzODE0MjUxODU1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | 1e0b904459f096ccba7fd7b8d2ab1e9b472929303ea144d3494603eef38a3b84 |
| hovercard-subject-tag | issue:398326006 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/28080/issue_layout |
| twitter:image | https://opengraph.githubassets.com/228f0a58c9e538319fdfe0e94574b0c0f24bbaeb608e39278e307d796a4ac167/angular/angular/issues/28080 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/228f0a58c9e538319fdfe0e94574b0c0f24bbaeb608e39278e307d796a4ac167/angular/angular/issues/28080 |
| og:image:alt | 🐞 bug report Description ngtsc fails to compile an application using ng-bootstrap because i18n messages have weird identifiers generated by ngcc. For example, in ./node_modules/@ng-bootstrap/ng-boo... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | cexbrayat |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width