René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"NavigationExtras when returning URLTree from guard","articleBody":"# 🚀 feature request\r\n\r\n### Relevant Package\r\nThis feature request is for @angular/router\r\n\r\n### Description\r\nIn #26521 (Angular 7.1.0), a feature was introduced that allows returning a `URLTree` from guards in order to initiate a redirect. However, this doesn't seem to allow using `NavigationExtras` such as `skipLocationChange`.\r\n\r\nSince the change in #26521 wasn't just syntax sugar, but is relevant to have predictable behavior when dealing with multiple guards, it should be considered to somehow allow using these options when returning a `URLTree` as well.\r\n\r\n### Describe the solution you'd like\r\nI don't have a really good proposal at this moment apart from next to returning `URLTree` also returning some kind of\r\n\r\n```\r\n// TODO: Find a better name?\r\ninterface NavigationOptions {\r\n  urlTree: URLTree;\r\n  navigationExtras: NavigationExtras;\r\n}\r\n```\r\n\r\nsuch that I could use\r\n\r\n```\r\nclass AwesomeGuard implements CanActivate {\r\n  constructor(private router: Router) {}\r\n\r\n  canActivate(): NavigationOptions | Observable\u003cNavigationOptions\u003e {\r\n    return {\r\n      urlTree: this.router.parseUrl(\"…\"),\r\n      navigationExtras: {\r\n        skipLocationChange: true,\r\n      },\r\n    };\r\n  }\r\n}\r\n```\r\n\r\nI guess the exact typing of the guard would have to be\r\n\r\n```\r\n// Just a placeholder name\r\ntype GuardReturnType = boolean | URLTree | NavigationOptions;\r\n\r\ninterface CanActivate {\r\n  canActivate(route: ActivatedRouteSnapshot, state: RouterStateSnapshot): \r\n    GuardReturnType \r\n    | Promise\u003cGuardReturnType\u003e \r\n    | Observable\u003cGuardReturnType\u003e\r\n}\r\n```\r\n\r\nAdmittedly, the return type of this function is growing increasingly complex with this.\r\n\r\n### Describe alternatives you've considered\r\nPossible options that I don't think would make good solutions would be\r\n\r\n* Returning an array `[URLTree, NavigationExtras]` (this just feels unclean)\r\n* Extending URLTree with the navigationExtras and extend parseUrl to take them as well (this muddies the entire API for a change in a specific location)","author":{"url":"https://github.com/Airblader","@type":"Person","name":"Airblader"},"datePublished":"2018-11-17T21:50:51.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":45},"url":"https://github.com/27148/angular/issues/27148"}