René's URL Explorer Experiment


Title: Testing: inconsistencies between Location and SpyLocation · Issue #27059 · angular/angular · GitHub

Open Graph Title: Testing: inconsistencies between Location and SpyLocation · Issue #27059 · angular/angular

X Title: Testing: inconsistencies between Location and SpyLocation · Issue #27059 · angular/angular

Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/testing Is this a regression? No, I think it never worked. Description The normalize method in the Location class works correctly, when in the SpyLocation class...

Open Graph Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/testing Is this a regression? No, I think it never worked. Description The normalize method in the Location class works ...

X Description: 🐞 bug report Affected Package The issue is caused by package @angular/common/testing Is this a regression? No, I think it never worked. Description The normalize method in the Location class works ...

Opengraph URL: https://github.com/angular/angular/issues/27059

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Testing: inconsistencies between Location and SpyLocation","articleBody":"\u003c!--🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅\r\n\r\nOh hi there! 😄 \r\n\r\nTo expedite issue processing please search open and closed issues before submitting a new one.\r\nExisting issues often contain information about workarounds, resolution, or progress updates.\r\n\r\n🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅🔅-->\r\n\r\n\r\n# 🐞 bug report\r\n\r\n### Affected Package\r\n\u003c!-- Can you pin-point one or more @angular/* packages as the source of the bug? -->\r\n\u003c!-- ✍️edit: --> The issue is caused by package @angular/common/testing\r\n\r\n\r\n\r\n### Is this a regression?\r\n\r\n\u003c!-- Did this behavior use to work in the previous version? -->\r\n\u003c!-- ✍️--> No, I think it never worked.\r\n\r\n\r\n### Description\r\n\r\n- The `normalize` method in the `Location` class works correctly, when in the `SpyLocation` class it always returns `null `(https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L120)\r\n- The `subscribe` method in the `Location` class is fired only on `popstate` event (https://github.com/angular/angular/blob/7.0.3/packages/common/src/location/location.ts#L140), when in the `SpyLocation` class is fired on each navigation (https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L115) \r\n\r\n## 🔥 Exception or Error\r\nThe different behavior breaks the tests.\r\n\r\n## 🌍  Your Environment\r\n**Angular Version:**\r\n```\r\nAngular CLI: 7.0.1\r\nNode: 8.11.1\r\nOS: win32 x64\r\nAngular: 7.0.0\r\n```\r\n\r\n**Anything else relevant?**\r\nThere are unresolved issues related to these inconsistencies: https://github.com/angular/angular/issues/10963 and https://stackoverflow.com/questions/47484775/location-class-from-angular-common-doesnt-work-in-unit-tests\r\n\r\nThanks!\r\n","author":{"url":"https://github.com/robisim74","@type":"Person","name":"robisim74"},"datePublished":"2018-11-12T14:08:52Z","url":"https://github.com/angular/angular/issues/27059"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:cf739ab9-4223-62b2-307e-0fa9e6dc8cc9
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idDEC2:1AE20C:C6A5ED:FC9D1B:6B00FCAA
html-safe-nonce674d3162ee37fab78beabeb0a04deaa4afc680f573fec7b38fc7258af5e5c834
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJERUMyOjFBRTIwQzpDNkE1RUQ6RkM5RDFCOjZCMDBGQ0FBIiwidmlzaXRvcl9pZCI6IjQ3NjMwODk1ODc0MTExNTYxMzgiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac41c152f8d150c536239844c014c654762a2069a62ae53614fb2d285ffa51cf2b
hovercard-subject-tagissue:379792931
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/27059/issue_layout
twitter:imagehttps://opengraph.githubassets.com/0fba13892ad479f0b79a38c5064857fa2e8e8707c640637e5a2bce4e60321400/angular/angular/issues/27059
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/0fba13892ad479f0b79a38c5064857fa2e8e8707c640637e5a2bce4e60321400/angular/angular/issues/27059
og:image:alt🐞 bug report Affected Package The issue is caused by package @angular/common/testing Is this a regression? No, I think it never worked. Description The normalize method in the Location class works ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerobisim74
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/27059#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F27059
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F27059
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/27059
Reloadhttps://github.com/angular/angular/issues/27059
Reloadhttps://github.com/angular/angular/issues/27059
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/27059
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/27059
Testing: inconsistencies between Location and SpyLocationhttps://github.com/angular/angular/issues/27059#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/robisim74
robisim74https://github.com/robisim74
on Nov 12, 2018https://github.com/angular/angular/issues/27059#issue-379792931
https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L120https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L120
https://github.com/angular/angular/blob/7.0.3/packages/common/src/location/location.ts#L140https://github.com/angular/angular/blob/7.0.3/packages/common/src/location/location.ts#L140
https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L115https://github.com/angular/angular/blob/7.0.3/packages/common/testing/src/location_mock.ts#L115
#10963https://github.com/angular/angular/issues/10963
https://stackoverflow.com/questions/47484775/location-class-from-angular-common-doesnt-work-in-unit-testshttps://stackoverflow.com/questions/47484775/location-class-from-angular-common-doesnt-work-in-unit-tests
Nexthttps://github.com/angular/angular/issues/27059?timeline_page=1
AndrewKushnirhttps://github.com/AndrewKushnir
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
on Nov 12, 2018https://github.com/angular/angular/issues/27059#event-1961519754
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Nov 12, 2018https://github.com/angular/angular/issues/27059#event-1961519856
vikermanhttps://github.com/vikerman
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
on Dec 5, 2018https://github.com/angular/angular/issues/27059#event-2005813630
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Dec 5, 2018https://github.com/angular/angular/issues/27059#event-2005814175
https://github.com/yggg
yggghttps://github.com/yggg
on Jun 29, 2019https://github.com/angular/angular/issues/27059#issuecomment-506982165
atscotthttps://github.com/atscott
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
on Jun 4, 2020https://github.com/angular/angular/issues/27059#event-3408369110
https://github.com/ondrasej
ondrasejhttps://github.com/ondrasej
on Jul 25, 2020https://github.com/angular/angular/issues/27059#issuecomment-663900897
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/27059#event-3830236823
dylhunnhttps://github.com/dylhunn
on Aug 16, 2021https://github.com/angular/angular/issues/27059#event-5164222834
fix(router): eagerly update internal state on browser-triggered navig…https://github.com/angular/angular/commit/6449590ec81eff0873af911fb65679b5a77db27b
6449590https://github.com/angular/angular/commit/6449590ec81eff0873af911fb65679b5a77db27b
fix(router): eagerly update internal state on browser-triggered navig…https://github.com/angular/angular/commit/286b2807de61dcd6e24ced5c142fbc6eda9dfbec
286b280https://github.com/angular/angular/commit/286b2807de61dcd6e24ced5c142fbc6eda9dfbec
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
c6a9300https://github.com/angular/angular/commit/c6a93001eb74374b0fbc6aea1286fe1183d21382
on Sep 2, 2021https://github.com/angular/angular/issues/27059#event-5248840926
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 3, 2021https://github.com/angular/angular/issues/27059#issuecomment-932979854
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Oct 3, 2021https://github.com/angular/angular/issues/27059#event-5400009968
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/27059
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/27059
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
area: testingIssues related to Angular testing features, such as TestBedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20testing%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.