René's URL Explorer Experiment


Title: External angular elements don't detect changes of deferred data after first instantiation · Issue #26158 · angular/angular · GitHub

Open Graph Title: External angular elements don't detect changes of deferred data after first instantiation · Issue #26158 · angular/angular

X Title: External angular elements don't detect changes of deferred data after first instantiation · Issue #26158 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or reques...

Opengraph URL: https://github.com/angular/angular/issues/26158

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"External angular elements don't detect changes of deferred data after first instantiation","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nWhen dynamically loading an angular elements custom element from an external source (i.e. not a custom element that is defined in the same angular app, but say from assets or some url), the first time it's rendered, everything works as usual. The second etc. time it's rendered, all data that is set in the component is rendered fine as well, but change detection does not work anymore, so if data is changed by an http request or a timeout, the changes are not displayed.\r\n\r\nTo work around this issue, ChangeDetectorRef has to be injected into the external custom element component and detectChanges has to be called once all data is available.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nThe change detection should work on subsequent instances just as in the first one without manually calling ChangeDetectorRef.detectChanges().\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\ni don't know how to create a multi-project demo on stackblitz, so here's here are the steps to reproduce:\r\n\r\n* create a new angular project with @angular/elements\r\n```\r\nng new custom-element-one --prefix ce1\r\ncd custom-element-one\r\nng add @angular/elements\r\nnpm install @webcomponents/custom-elements --save\r\n```\r\n* modify app.module.ts to register custom element\r\n```\r\nconst element = createCustomElement(AppComponent, { injector: this.injector });\r\ncustomElements.define('custom-element-one', element);\r\n```\r\n* in the component, set some data deferred with http request or setTimeout and make sure it's bound in the template:\r\n```\r\nimport { Component, OnInit } from '@angular/core';\r\n\r\n@Component({\r\n  selector: 'ce1-root',\r\n  templateUrl: './app.component.html',\r\n  styleUrls: ['./app.component.css']\r\n})\r\nexport class AppComponent implements OnInit {\r\n  title = 'custom-element-one';\r\n\r\n  ngOnInit(): void {\r\n    setTimeout(() => this.title = 'custom-element-one updated', 1000);\r\n  }\r\n}\r\n```\r\n* build/concat etc.\r\n* create a new standard angular project and put the output of custom-element-one into assets\r\n* load the custom element using script tag(s), createElement and appendChild similar to this:\r\n```\r\n  appendCustomElementWithUrls(name: string, urls: string[], target: HTMLElement) {\r\n    if (!customElements.get(name)) {\r\n      for (const url of urls) {\r\n        const script = document.createElement('script');\r\n        script.src = url;\r\n        document.head.appendChild(script);\r\n      }\r\n    }\r\n\r\n    const component = document.createElement(name);\r\n    target.appendChild(component);\r\n  }\r\n```\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nExternal custom elements should behave the same if they are added to the DOM once or twice.\r\n\r\nThis works:\r\n```\r\nimport { Component, OnInit, ChangeDetectorRef, Input } from '@angular/core';\r\n\r\n@Component({\r\n  selector: 'ce1-root',\r\n  templateUrl: './app.component.html',\r\n  styleUrls: ['./app.component.css']\r\n})\r\nexport class AppComponent implements OnInit {\r\n  @Input()\r\n  title = 'custom-element-one';\r\n\r\n  constructor(private cd: ChangeDetectorRef) {} // \u003c-- inject ChangeDetectorRef\r\n\r\n  ngOnInit(): void {\r\n    setTimeout(() => {\r\n      this.title = 'custom-element-one updated';\r\n      this.cd.detectChanges(); // \u003c-- call detectChanges to update UI\r\n    }, 1000);\r\n  }\r\n}\r\n```\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.2.3\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 69.0.3497.100\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [x] Firefox version 61.0.1\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [x] Edge version 40.15063.674.0\r\n \r\nFor Tooling issues:\r\n- Node version: v10.4.1\u003c!-- run `node --version` -->\r\n- Platform: Windows 10 \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n\r\ni'll continue looking into this, but since i'm not familiar with the angular code base, any hint on where to start looking would be helpful.","author":{"url":"https://github.com/markusdresch","@type":"Person","name":"markusdresch"},"datePublished":"2018-09-28T11:40:16Z","url":"https://github.com/angular/angular/issues/26158"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:e189271e-663d-6676-36c0-67e70ed4602d
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB194:1DCB8C:17D98E9:1F73956:6B0137CB
html-safe-nonce1df900dcc98708252b4a902c8503d4a4fe342195d3d42edeca6d41198bb64e7d
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTk0OjFEQ0I4QzoxN0Q5OEU5OjFGNzM5NTY6NkIwMTM3Q0IiLCJ2aXNpdG9yX2lkIjoiNDQxODUwNTk0OTM2ODI5ODk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacaf08245ded80078be4b5722da79914470d797035fc27e47bb82ed86bf8340158
hovercard-subject-tagissue:364853849
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/26158/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f26561b284d2d6bf98f29830fab6305d4391c2dbe4ce2fee09e341d4fe43144c/angular/angular/issues/26158
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f26561b284d2d6bf98f29830fab6305d4391c2dbe4ce2fee09e341d4fe43144c/angular/angular/issues/26158
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemarkusdresch
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/26158#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F26158
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F26158
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/26158
Reloadhttps://github.com/angular/angular/issues/26158
Reloadhttps://github.com/angular/angular/issues/26158
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/26158
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/26158
External angular elements don't detect changes of deferred data after first instantiationhttps://github.com/angular/angular/issues/26158#top
https://github.com/markusdresch
markusdreschhttps://github.com/markusdresch
on Sep 28, 2018https://github.com/angular/angular/issues/26158#issue-364853849
https://github.com/remackgeek
remackgeekhttps://github.com/remackgeek
on Sep 28, 2018https://github.com/angular/angular/issues/26158#issuecomment-425490741
#24181https://github.com/angular/angular/issues/24181
#1133https://github.com/angular/zone.js/pull/1133
elements-zone-strategyhttps://www.npmjs.com/package/elements-zone-strategy
https://github.com/markusdresch
markusdreschhttps://github.com/markusdresch
on Oct 1, 2018https://github.com/angular/angular/issues/26158#issuecomment-425853970
@remackgeekhttps://github.com/remackgeek
markusdreschhttps://github.com/markusdresch
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 1, 2018https://github.com/angular/angular/issues/26158#event-1876363532
https://github.com/Hackman-Sanchez
Hackman-Sanchezhttps://github.com/Hackman-Sanchez
on Dec 12, 2018https://github.com/angular/angular/issues/26158#issuecomment-446644592
@remackgeekhttps://github.com/remackgeek
https://github.com/gonadn
gonadnhttps://github.com/gonadn
on Dec 31, 2018https://github.com/angular/angular/issues/26158#issuecomment-450674391
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/26158#issuecomment-531473547
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/26158#event-2634096883
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/26158
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/26158
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.