Title: External angular elements don't detect changes of deferred data after first instantiation · Issue #26158 · angular/angular · GitHub
Open Graph Title: External angular elements don't detect changes of deferred data after first instantiation · Issue #26158 · angular/angular
X Title: External angular elements don't detect changes of deferred data after first instantiation · Issue #26158 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or reques...
Opengraph URL: https://github.com/angular/angular/issues/26158
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"External angular elements don't detect changes of deferred data after first instantiation","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nWhen dynamically loading an angular elements custom element from an external source (i.e. not a custom element that is defined in the same angular app, but say from assets or some url), the first time it's rendered, everything works as usual. The second etc. time it's rendered, all data that is set in the component is rendered fine as well, but change detection does not work anymore, so if data is changed by an http request or a timeout, the changes are not displayed.\r\n\r\nTo work around this issue, ChangeDetectorRef has to be injected into the external custom element component and detectChanges has to be called once all data is available.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nThe change detection should work on subsequent instances just as in the first one without manually calling ChangeDetectorRef.detectChanges().\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\ni don't know how to create a multi-project demo on stackblitz, so here's here are the steps to reproduce:\r\n\r\n* create a new angular project with @angular/elements\r\n```\r\nng new custom-element-one --prefix ce1\r\ncd custom-element-one\r\nng add @angular/elements\r\nnpm install @webcomponents/custom-elements --save\r\n```\r\n* modify app.module.ts to register custom element\r\n```\r\nconst element = createCustomElement(AppComponent, { injector: this.injector });\r\ncustomElements.define('custom-element-one', element);\r\n```\r\n* in the component, set some data deferred with http request or setTimeout and make sure it's bound in the template:\r\n```\r\nimport { Component, OnInit } from '@angular/core';\r\n\r\n@Component({\r\n selector: 'ce1-root',\r\n templateUrl: './app.component.html',\r\n styleUrls: ['./app.component.css']\r\n})\r\nexport class AppComponent implements OnInit {\r\n title = 'custom-element-one';\r\n\r\n ngOnInit(): void {\r\n setTimeout(() => this.title = 'custom-element-one updated', 1000);\r\n }\r\n}\r\n```\r\n* build/concat etc.\r\n* create a new standard angular project and put the output of custom-element-one into assets\r\n* load the custom element using script tag(s), createElement and appendChild similar to this:\r\n```\r\n appendCustomElementWithUrls(name: string, urls: string[], target: HTMLElement) {\r\n if (!customElements.get(name)) {\r\n for (const url of urls) {\r\n const script = document.createElement('script');\r\n script.src = url;\r\n document.head.appendChild(script);\r\n }\r\n }\r\n\r\n const component = document.createElement(name);\r\n target.appendChild(component);\r\n }\r\n```\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nExternal custom elements should behave the same if they are added to the DOM once or twice.\r\n\r\nThis works:\r\n```\r\nimport { Component, OnInit, ChangeDetectorRef, Input } from '@angular/core';\r\n\r\n@Component({\r\n selector: 'ce1-root',\r\n templateUrl: './app.component.html',\r\n styleUrls: ['./app.component.css']\r\n})\r\nexport class AppComponent implements OnInit {\r\n @Input()\r\n title = 'custom-element-one';\r\n\r\n constructor(private cd: ChangeDetectorRef) {} // \u003c-- inject ChangeDetectorRef\r\n\r\n ngOnInit(): void {\r\n setTimeout(() => {\r\n this.title = 'custom-element-one updated';\r\n this.cd.detectChanges(); // \u003c-- call detectChanges to update UI\r\n }, 1000);\r\n }\r\n}\r\n```\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.2.3\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 69.0.3497.100\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [x] Firefox version 61.0.1\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [x] Edge version 40.15063.674.0\r\n \r\nFor Tooling issues:\r\n- Node version: v10.4.1\u003c!-- run `node --version` -->\r\n- Platform: Windows 10 \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n\r\ni'll continue looking into this, but since i'm not familiar with the angular code base, any hint on where to start looking would be helpful.","author":{"url":"https://github.com/markusdresch","@type":"Person","name":"markusdresch"},"datePublished":"2018-09-28T11:40:16Z","url":"https://github.com/angular/angular/issues/26158"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:e189271e-663d-6676-36c0-67e70ed4602d |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | B194:1DCB8C:17D98E9:1F73956:6B0137CB |
| html-safe-nonce | 1df900dcc98708252b4a902c8503d4a4fe342195d3d42edeca6d41198bb64e7d |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCMTk0OjFEQ0I4QzoxN0Q5OEU5OjFGNzM5NTY6NkIwMTM3Q0IiLCJ2aXNpdG9yX2lkIjoiNDQxODUwNTk0OTM2ODI5ODk5IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | af08245ded80078be4b5722da79914470d797035fc27e47bb82ed86bf8340158 |
| hovercard-subject-tag | issue:364853849 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/26158/issue_layout |
| twitter:image | https://opengraph.githubassets.com/f26561b284d2d6bf98f29830fab6305d4391c2dbe4ce2fee09e341d4fe43144c/angular/angular/issues/26158 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/f26561b284d2d6bf98f29830fab6305d4391c2dbe4ce2fee09e341d4fe43144c/angular/angular/issues/26158 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | markusdresch |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width