René's URL Explorer Experiment


Title: Provide an official way to access the module/injector for a route · Issue #25630 · angular/angular · GitHub

Open Graph Title: Provide an official way to access the module/injector for a route · Issue #25630 · angular/angular

X Title: Provide an official way to access the module/injector for a route · Issue #25630 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or request [ ...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or reques...

Opengraph URL: https://github.com/angular/angular/issues/25630

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provide an official way to access the module/injector for a route","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\r\nWhen lazy-loading modules, the router faces the problem of how to inject providers that are registered in the child module from a root service, since providers in lazy-loaded modules are not added to the root injector.\r\n\r\nThe implementation solves this problem by keeping [a reference to the lazy-loaded module](https://github.com/angular/angular/blob/master/packages/router/src/config.ts#L386) in the router config, which it can use to [lookup the child module's injector](https://github.com/angular/angular/blob/master/packages/router/src/pre_activation.ts#L348). However, this capability is kept internal to the router, which prevents apps that have the same requirement from using it.\r\n\r\nNow, consider an app that includes its own DI tokens on lazy-loaded route definitions. E.g.:\r\n\r\n```js\r\n{\r\n  path: '/project/:projectId',\r\n  component: ProjectComponent\r\n  data: {\r\n    breadcrumb: ProjectBreadcrumbProvider\r\n  }\r\n}\r\n```\r\n\r\nIf `ProjectBreadcrumbProvider` is registered in the lazy-loaded module, then a global `BreadcrumbService` in the root module cannot inject it using the root injector. It needs the injector associated with the current route instead, but there is no official way to get hold of it.\r\n\r\n## Expected behavior\r\n\r\nThe Router should provide an official way to access the module/injector for a given `ActivatedRoute`. I would suggest running the same `closestLoadedConfig()` logic eagerly and including the resulting module as a `module` property on each `ActivatedRouteSnapshot` instance.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\r\nApps currently have two options:\r\n\r\n - Replicate the logic from `closestLoadedConfig()` and rely on the internal `_loadedConfig` property. But relying on private APIs is not a good idea, as these could change or be removed in a later version.\r\n - Register these providers in the root scope, rather than the lazy module. But this bloats the root module and defeats the purpose of lazy-loading.\r\n\r\nNeither of these is preferable. An official way to get the module/injector for a given route would solve the problem.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.1.3\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/jonrimmer","@type":"Person","name":"jonrimmer"},"datePublished":"2018-08-23T09:19:59Z","url":"https://github.com/angular/angular/issues/25630"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:381af929-1d45-77eb-2cda-fe4f0f12bb09
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAC00:1EC9BC:8B78CC:B330EF:6B00EC71
html-safe-nonce3c2dacc6fad7b9fae8c3a5f465a44dc4538e3e85a1d00e20fac01b16f7570a24
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzAwOjFFQzlCQzo4Qjc4Q0M6QjMzMEVGOjZCMDBFQzcxIiwidmlzaXRvcl9pZCI6IjY5MzQ1ODk1MTE0MTQzNzc1ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac61644e54391b0fa8d142c6807cecef2397fe535e9a1cef73e6b2ea42abb987ef
hovercard-subject-tagissue:353295698
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/25630/issue_layout
twitter:imagehttps://opengraph.githubassets.com/550a32f0fc7a2436746345af7abeaa8802f7a788ee644fac5224eab78368a36e/angular/angular/issues/25630
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/550a32f0fc7a2436746345af7abeaa8802f7a788ee644fac5224eab78368a36e/angular/angular/issues/25630
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or request [ ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamejonrimmer
hostnamegithub.com
expected-hostnamegithub.com
None4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release9983dd5da06943f833c971dd5b6bc988e2858be5
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/25630#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F25630
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F25630
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/25630
Reloadhttps://github.com/angular/angular/issues/25630
Reloadhttps://github.com/angular/angular/issues/25630
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests140 (140)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/25630
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/25630
Provide an official way to access the module/injector for a routehttps://github.com/angular/angular/issues/25630#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/jonrimmer
jonrimmerhttps://github.com/jonrimmer
on Aug 23, 2018https://github.com/angular/angular/issues/25630#issue-353295698
a reference to the lazy-loaded modulehttps://github.com/angular/angular/blob/master/packages/router/src/config.ts#L386
lookup the child module's injectorhttps://github.com/angular/angular/blob/master/packages/router/src/pre_activation.ts#L348
matskohttps://github.com/matsko
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Aug 23, 2018https://github.com/angular/angular/issues/25630#event-1806363429
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 23, 2018https://github.com/angular/angular/issues/25630#event-1806363500
jasonadenhttps://github.com/jasonaden
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
on Sep 4, 2018https://github.com/angular/angular/issues/25630#event-1826474146
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Sep 4, 2018https://github.com/angular/angular/issues/25630#event-1826474215
angular-robothttps://github.com/apps/angular-robot
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Jun 4, 2021https://github.com/angular/angular/issues/25630#event-4843605001
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 4, 2021https://github.com/angular/angular/issues/25630#issuecomment-854783496
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 25, 2021https://github.com/angular/angular/issues/25630#issuecomment-868527069
communityhttps://angular.io/resources?category=community
packagehttps://angular.io/guide/creating-libraries
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
on Jun 25, 2021https://github.com/angular/angular/issues/25630#event-4940267832
https://github.com/atscott
atscotthttps://github.com/atscott
on Jul 24, 2021https://github.com/angular/angular/issues/25630#issuecomment-885967781
#24069https://github.com/angular/angular/issues/24069
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Jul 24, 2021https://github.com/angular/angular/issues/25630#event-5063488438
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 24, 2021https://github.com/angular/angular/issues/25630#issuecomment-904778541
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Aug 24, 2021https://github.com/angular/angular/issues/25630#event-5201669626
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/25630
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/25630
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.