Title: Provide an official way to access the module/injector for a route · Issue #25630 · angular/angular · GitHub
Open Graph Title: Provide an official way to access the module/injector for a route · Issue #25630 · angular/angular
X Title: Provide an official way to access the module/injector for a route · Issue #25630 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or request [ ...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or reques...
Opengraph URL: https://github.com/angular/angular/issues/25630
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Provide an official way to access the module/injector for a route","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[x] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\r\nWhen lazy-loading modules, the router faces the problem of how to inject providers that are registered in the child module from a root service, since providers in lazy-loaded modules are not added to the root injector.\r\n\r\nThe implementation solves this problem by keeping [a reference to the lazy-loaded module](https://github.com/angular/angular/blob/master/packages/router/src/config.ts#L386) in the router config, which it can use to [lookup the child module's injector](https://github.com/angular/angular/blob/master/packages/router/src/pre_activation.ts#L348). However, this capability is kept internal to the router, which prevents apps that have the same requirement from using it.\r\n\r\nNow, consider an app that includes its own DI tokens on lazy-loaded route definitions. E.g.:\r\n\r\n```js\r\n{\r\n path: '/project/:projectId',\r\n component: ProjectComponent\r\n data: {\r\n breadcrumb: ProjectBreadcrumbProvider\r\n }\r\n}\r\n```\r\n\r\nIf `ProjectBreadcrumbProvider` is registered in the lazy-loaded module, then a global `BreadcrumbService` in the root module cannot inject it using the root injector. It needs the injector associated with the current route instead, but there is no official way to get hold of it.\r\n\r\n## Expected behavior\r\n\r\nThe Router should provide an official way to access the module/injector for a given `ActivatedRoute`. I would suggest running the same `closestLoadedConfig()` logic eagerly and including the resulting module as a `module` property on each `ActivatedRouteSnapshot` instance.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\r\nApps currently have two options:\r\n\r\n - Replicate the logic from `closestLoadedConfig()` and rely on the internal `_loadedConfig` property. But relying on private APIs is not a good idea, as these could change or be removed in a later version.\r\n - Register these providers in the root scope, rather than the lazy module. But this bloats the root module and defeats the purpose of lazy-loading.\r\n\r\nNeither of these is preferable. An official way to get the module/injector for a given route would solve the problem.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.1.3\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/jonrimmer","@type":"Person","name":"jonrimmer"},"datePublished":"2018-08-23T09:19:59Z","url":"https://github.com/angular/angular/issues/25630"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:381af929-1d45-77eb-2cda-fe4f0f12bb09 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | AC00:1EC9BC:8B78CC:B330EF:6B00EC71 |
| html-safe-nonce | 3c2dacc6fad7b9fae8c3a5f465a44dc4538e3e85a1d00e20fac01b16f7570a24 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBQzAwOjFFQzlCQzo4Qjc4Q0M6QjMzMEVGOjZCMDBFQzcxIiwidmlzaXRvcl9pZCI6IjY5MzQ1ODk1MTE0MTQzNzc1ODUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 61644e54391b0fa8d142c6807cecef2397fe535e9a1cef73e6b2ea42abb987ef |
| hovercard-subject-tag | issue:353295698 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/25630/issue_layout |
| twitter:image | https://opengraph.githubassets.com/550a32f0fc7a2436746345af7abeaa8802f7a788ee644fac5224eab78368a36e/angular/angular/issues/25630 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/550a32f0fc7a2436746345af7abeaa8802f7a788ee644fac5224eab78368a36e/angular/angular/issues/25630 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [x] Feature request [ ] Documentation issue or request [ ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | jonrimmer |
| hostname | github.com |
| expected-hostname | github.com |
| None | 4ef498cbabcbe3c50befc7a5b743e7072ee770b4daf0e15e54801180d1fa91fc |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 9983dd5da06943f833c971dd5b6bc988e2858be5 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width