René's URL Explorer Experiment


Title: [elements]: custom element inside a custom element's template throw on destruction · Issue #25525 · angular/angular · GitHub

Open Graph Title: [elements]: custom element inside a custom element's template throw on destruction · Issue #25525 · angular/angular

X Title: [elements]: custom element inside a custom element's template throw on destruction · Issue #25525 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or reques...

Opengraph URL: https://github.com/angular/angular/issues/25525

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[elements]: custom element inside a custom element's template throw on destruction","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWe have 3 custom elements, A , B and C - All are angular components converted to custom elements.\r\n\r\nWe create a new A programatically, with an injector.\r\n\r\nInside A we append HTML code, the code includes markup that will create B. (B doesn't have an injector).\r\n\r\nIn B's template, we have markup to create C.\r\n\r\n---\r\n\r\nStopping here to point out that while C is inside an **angular template** markup and **it is an angular component,** the fact that it's declared as a custom element means that it will be handled by `@angular/elements`.\r\n\r\n---\r\n\r\nNow, **A** was created programatically so we have a reference for it.  \r\nWe remove it (`NgElement.remove()`) which starts the destruction process.\r\n\r\nWhen `@angular/elements` starts the destruction process and error is  thrown:\r\n\r\n**ERROR TypeError: Cannot read property 'nativeNode' of null**\r\n\u003cdetails>\r\n    at removeDebugNodeFromIndex (core.js:5407)\r\n    at DebugRenderer2.push.../../node_modules/@angular/core/fesm5/core.js.DebugRenderer2.destroyNode (core.js:11398)\r\n    at destroyViewNodes (core.js:10613)\r\n    at destroyView (core.js:10601)\r\n    at callWithDebugContext (core.js:11351)\r\n    at Object.debugDestroyView [as destroyView] (core.js:11035)\r\n    at ViewRef_.push.../../node_modules/@angular/core/fesm5/core.js.ViewRef_.destroy (core.js:8868)\r\n    at ComponentRef_.push.../../node_modules/@angular/core/fesm5/core.js.ComponentRef_.destroy (core.js:8705)\r\n    at elements.js:236\r\n    at ZoneDelegate.push.../../node_modules/zone.js/dist/zone.js.ZoneDelegate.invokeTask (zone.js:421)\r\n\u003c/details>\r\n\r\nThe error happens when `@anguar/core` try's to destory C.\r\n\r\nWhat happens is that ` DebugRenderer2.destroyNode()` is called **TWICE** for **C**.\r\nMy guess is that because C is a custom element used inside an angular template both angular and angular/elements invoke a destroy... something like that I guess.\r\n \r\n## Expected behavior\r\nShould not throw...\r\n\r\n> It's worth noting that even if I disable the delay of destruction it stlll throws","author":{"url":"https://github.com/shlomiassaf","@type":"Person","name":"shlomiassaf"},"datePublished":"2018-08-16T17:37:51Z","url":"https://github.com/angular/angular/issues/25525"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8404dc5a-bbef-fcbf-2459-4e9a706b8405
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCCEA:358871:18C26D2:2092D32:6B013BFF
html-safe-nonceacc7e842962ce30eb97238e1fdfa6bed3152541741f9fd02a6e61e9537e2a802
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDQ0VBOjM1ODg3MToxOEMyNkQyOjIwOTJEMzI6NkIwMTNCRkYiLCJ2aXNpdG9yX2lkIjoiNTYzNjAwOTQ5NTI0ODMyMTUzNSIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac316a773a2d0c7ce42575ce9f10183f1858171ed8651e122ff883a1226b1dd55d
hovercard-subject-tagissue:351301819
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/25525/issue_layout
twitter:imagehttps://opengraph.githubassets.com/fe3bb3d1df06813d49bca72639e89dde807c0a08275404945343a70dd6441512/angular/angular/issues/25525
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/fe3bb3d1df06813d49bca72639e89dde807c0a08275404945343a70dd6441512/angular/angular/issues/25525
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameshlomiassaf
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/25525#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F25525
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F25525
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/25525
Reloadhttps://github.com/angular/angular/issues/25525
Reloadhttps://github.com/angular/angular/issues/25525
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/25525
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/25525
[elements]: custom element inside a custom element's template throw on destructionhttps://github.com/angular/angular/issues/25525#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
state: needs more investigationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20needs%20more%20investigation%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/shlomiassaf
shlomiassafhttps://github.com/shlomiassaf
on Aug 16, 2018https://github.com/angular/angular/issues/25525#issue-351301819
jasonadenhttps://github.com/jasonaden
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
on Aug 16, 2018https://github.com/angular/angular/issues/25525#event-1793080338
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Aug 16, 2018https://github.com/angular/angular/issues/25525#event-1793080456
https://github.com/shlomiassaf
shlomiassafhttps://github.com/shlomiassaf
on Aug 16, 2018https://github.com/angular/angular/issues/25525#issuecomment-413649940
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Aug 18, 2018https://github.com/angular/angular/issues/25525#issuecomment-414056436
#21585https://github.com/angular/angular/issues/21585
https://github.com/foureighteen
foureighteenhttps://github.com/foureighteen
on Sep 5, 2018https://github.com/angular/angular/issues/25525#issuecomment-418650571
https://github.com/nvdweem
nvdweemhttps://github.com/nvdweem
on Sep 11, 2018https://github.com/angular/angular/issues/25525#issuecomment-420253567
https://github.com/nikunjkonduru
nikunjkonduruhttps://github.com/nikunjkonduru
on Nov 1, 2018https://github.com/angular/angular/issues/25525#issuecomment-435105111
@trotylhttps://github.com/trotyl
andrewseguinhttps://github.com/andrewseguin
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Dec 4, 2018https://github.com/angular/angular/issues/25525#event-2005754844
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Dec 4, 2018https://github.com/angular/angular/issues/25525#event-2005767487
https://github.com/maxtacco
maxtaccohttps://github.com/maxtacco
on Feb 7, 2019https://github.com/angular/angular/issues/25525#issuecomment-461595414
https://github.com/kevin192291
kevin192291https://github.com/kevin192291
on Mar 12, 2019https://github.com/angular/angular/issues/25525#issuecomment-472177750
https://github.com/thelgevold
thelgevoldhttps://github.com/thelgevold
on Mar 12, 2019https://github.com/angular/angular/issues/25525#issuecomment-472194225
#27631https://github.com/angular/angular/pull/27631
https://github.com/kevin192291
kevin192291https://github.com/kevin192291
on Mar 12, 2019https://github.com/angular/angular/issues/25525#issuecomment-472195351
#27631https://github.com/angular/angular/pull/27631
https://github.com/Dr0drigues
Dr0drigueshttps://github.com/Dr0drigues
on Jul 10, 2019https://github.com/angular/angular/issues/25525#issuecomment-510040390
https://github.com/ai-eye
ai-eyehttps://github.com/ai-eye
on Jul 19, 2019https://github.com/angular/angular/issues/25525#issuecomment-513176195
https://github.com/luiscla27
luiscla27https://github.com/luiscla27
on Dec 27, 2019https://github.com/angular/angular/issues/25525#issuecomment-569324677
#27631https://github.com/angular/angular/pull/27631
@JoostKhttps://github.com/JoostK
this PRhttps://github.com/angular/angular/pull/27631/files
gkalpakhttps://github.com/gkalpak
state: needs more investigationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20needs%20more%20investigation%22
triage #1https://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22triage%20%231%22
on Jun 2, 2020https://github.com/angular/angular/issues/25525#event-3397148767
https://github.com/irekBudzowski
irekBudzowskihttps://github.com/irekBudzowski
on Jun 11, 2020https://github.com/angular/angular/issues/25525#issuecomment-642510850
@gkalpakhttps://github.com/gkalpak
thinghttps://github.com/microsoft/TypeScript/issues/21388#issuecomment-385281089
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/25525#event-3830237201
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Apr 15, 2021https://github.com/angular/angular/issues/25525#issuecomment-820586677
#41565https://github.com/angular/angular/pull/41565
JoostKhttps://github.com/JoostK
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 15, 2021https://github.com/angular/angular/issues/25525#event-4600532891
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 16, 2021https://github.com/angular/angular/issues/25525#issuecomment-841837915
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 16, 2021https://github.com/angular/angular/issues/25525#event-4751142880
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/25525
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/25525
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: elementsIssues related to Angular Elementshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20elements%22
freq2: mediumhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq2%3A%20medium%22
state: needs more investigationhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20needs%20more%20investigation%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.