Title: Scrolling to top on navigation broke expected existing behavior · Issue #25145 · angular/angular · GitHub
Open Graph Title: Scrolling to top on navigation broke expected existing behavior · Issue #25145 · angular/angular
X Title: Scrolling to top on navigation broke expected existing behavior · Issue #25145 · angular/angular
Description: I'm submitting a... [ X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not subm...
Open Graph Description: I'm submitting a... [ X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [...
X Description: I'm submitting a... [ X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or reque...
Opengraph URL: https://github.com/angular/angular/issues/25145
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Scrolling to top on navigation broke expected existing behavior","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ X] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nI'm using navigation to update URL and trigger data reload for pagination, filtering and sorting of data table. On 6.1.0 it scrolls to the top of the page.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nBefore 6.1.0, navigation didn't scroll to top and that was good behavior in my case, since I'm only changing table contents, so logically I don't need to scroll to top, I can just stay where the data table is. There should be an option, by providing some `NavigationExtras` or router scroll settings, to choose if you want to scroll to top, or stay where you were.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\nAny kind of navigation scrolls to top now, there's no specific code for this issue.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nI think there is no reason to not leave an option for things to stay as they were before 6.1.0. Preferably an optional runtime setting. I could implement this in some other way, but I'm not even sure how? Save scroll positions myself and pass them through URL parameters or cookies? Don't use navigation, update URL with `location.go` and use `ngOnChanges()` to update data? Those don't seem like some kind of \"best practices\".\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.1.0\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [ X] Chrome (desktop) version 68.0.3440.75\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 8.11.3 \u003c!-- run `node --version` -->\r\n- Platform: Linux \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/ptrdom","@type":"Person","name":"ptrdom"},"datePublished":"2018-07-26T11:18:01Z","url":"https://github.com/angular/angular/issues/25145"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:546e6d86-46a2-612e-68b2-c5340e9d0885 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 9C36:25291:181F33:1F90F4:6B0161F5 |
| html-safe-nonce | 830995d5f2a281e8678c265a1c31701e86c55f6491f3a1d6a14ce03b807148bc |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5QzM2OjI1MjkxOjE4MUYzMzoxRjkwRjQ6NkIwMTYxRjUiLCJ2aXNpdG9yX2lkIjoiOTA5NTg5MTQxNzgyNTM3MDYxMyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 33bd862b41264d2cce9a89e6a1bd348e6ebf6a136bc9b3b021ed973c12acd264 |
| hovercard-subject-tag | issue:344801809 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/25145/issue_layout |
| twitter:image | https://opengraph.githubassets.com/acf30370f33380c5e3ac7975e81c1b13aef61f7333319e43cb21077492890dfa/angular/angular/issues/25145 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/acf30370f33380c5e3ac7975e81c1b13aef61f7333319e43cb21077492890dfa/angular/angular/issues/25145 |
| og:image:alt | I'm submitting a... [ X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ptrdom |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width