René's URL Explorer Experiment


Title: OnPush change detection doesn't work for outputs emitted from lifecycle callbacks · Issue #24965 · angular/angular · GitHub

Open Graph Title: OnPush change detection doesn't work for outputs emitted from lifecycle callbacks · Issue #24965 · angular/angular

X Title: OnPush change detection doesn't work for outputs emitted from lifecycle callbacks · Issue #24965 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or reques...

Opengraph URL: https://github.com/angular/angular/issues/24965

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"OnPush change detection doesn't work for outputs emitted from lifecycle callbacks","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[X] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\n\r\nThis issue is related to the closed issue https://github.com/angular/angular/issues/24690 for which I managed to create a simple repro case. Complete description follows.\r\n\r\nWhen a component with OnPush change detection subscribes an output of a subcomponent, it works pretty well, unless this subcomponent emits values from the initialization lifecycle callbacks (ngOnInit, ngAfterViewInit). Then, no change detection is performed, and even calling changeDetectorRef.markForCheck() doesn't help. Only calling detectChanges() manually works.\r\n\r\nQuite surprisingly, when the value is emitted from ngOnInit, it is shown in the interpolation strings, but not passed to subcomponents. On the other hand, ngAfterViewInit value is not used at all.\r\n\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\n\r\nIt should work out of the box, without the need to work with change detector manually. If this is not supported for some architectural reason, the documentation should contain a big warning about it.\r\n\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n\r\nI've prepared a git repo here: https://github.com/sebek64/angular-issue-repro\r\n\r\nThe initial commit is a plain angular-cli project. The next commit adds the repro code. Run via \"yarn start\", open the browser, and you should see output like this:\r\n\r\n```\r\nouter component value: \"emitted value from ngOnInit\"\r\ninside subcomponent: \"\"\r\nButton\r\n```\r\n\r\nWhen the button is clicked, the output changes to\r\n\r\n```\r\nouter component value: \"Emitted value from button\"\r\ninside subcomponent: \"Emitted value from button\"\r\nButton\r\n```\r\n\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.0.9\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [X] Chrome (desktop) version 67.0.3396.99\r\n- [X] Firefox version 52.9.0\r\n- Platform:  Linux\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/sebek64","@type":"Person","name":"sebek64"},"datePublished":"2018-07-18T16:25:30Z","url":"https://github.com/angular/angular/issues/24965"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:f13c6dc7-7919-bb95-4fbe-dc4b48b166bd
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB4FC:363D8E:F9D251:1401780:6B00FC03
html-safe-nonce4889a39a20ea9fce8ace660b533ecff8c780e5d6b4d9c82b53b1d088ac122769
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCNEZDOjM2M0Q4RTpGOUQyNTE6MTQwMTc4MDo2QjAwRkMwMyIsInZpc2l0b3JfaWQiOiI4MzM4ODMyMjQyODIyNDEzMzE1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacc73bdcaac0c15a2905cd442c2d0cfeb9b63edd712971ba0cc5f9d328144146ba
hovercard-subject-tagissue:342401920
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/24965/issue_layout
twitter:imagehttps://opengraph.githubassets.com/bee60ce3595d2d14cca32caf37ca51e9d34782be5b1981a9572855b29bff2889/angular/angular/issues/24965
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/bee60ce3595d2d14cca32caf37ca51e9d34782be5b1981a9572855b29bff2889/angular/angular/issues/24965
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [X] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamesebek64
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/24965#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24965
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24965
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/24965
Reloadhttps://github.com/angular/angular/issues/24965
Reloadhttps://github.com/angular/angular/issues/24965
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24965
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24965
OnPush change detection doesn't work for outputs emitted from lifecycle callbackshttps://github.com/angular/angular/issues/24965#top
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/sebek64
sebek64https://github.com/sebek64
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issue-342401920
#24690https://github.com/angular/angular/issues/24690
https://github.com/sebek64/angular-issue-reprohttps://github.com/sebek64/angular-issue-repro
https://github.com/mlc-mlapis
mlc-mlapishttps://github.com/mlc-mlapis
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issuecomment-406003568
@sebek64https://github.com/sebek64
https://stackblitz.comhttps://stackblitz.com
https://github.com/sebek64
sebek64https://github.com/sebek64
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issuecomment-406006000
@mlc-mlapishttps://github.com/mlc-mlapis
https://github.com/sebek64
sebek64https://github.com/sebek64
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issuecomment-406008260
https://stackblitz.com/edit/angular-gitter-egxquqhttps://stackblitz.com/edit/angular-gitter-egxquq
https://github.com/manklu
mankluhttps://github.com/manklu
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issuecomment-406008788
@mlc-mlapishttps://github.com/mlc-mlapis
https://stackblitz.com/github/sebek64/angular-issue-reprohttps://stackblitz.com/github/sebek64/angular-issue-repro
https://github.com/mlc-mlapis
mlc-mlapishttps://github.com/mlc-mlapis
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issuecomment-406009320
@mankluhttps://github.com/manklu
https://github.com/manklu
mankluhttps://github.com/manklu
on Jul 18, 2018https://github.com/angular/angular/issues/24965#issuecomment-406073360
https://github.com/trotyl
trotylhttps://github.com/trotyl
on Jul 19, 2018https://github.com/angular/angular/issues/24965#issuecomment-406151827
https://github.com/sebek64
sebek64https://github.com/sebek64
on Jul 19, 2018https://github.com/angular/angular/issues/24965#issuecomment-406245544
@mankluhttps://github.com/manklu
https://github.com/manklu
mankluhttps://github.com/manklu
on Jul 19, 2018https://github.com/angular/angular/issues/24965#issuecomment-406411800
vicbhttps://github.com/vicb
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Jul 20, 2018https://github.com/angular/angular/issues/24965#event-1745431129
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jul 20, 2018https://github.com/angular/angular/issues/24965#event-1745431209
mheveryhttps://github.com/mhevery
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Jul 31, 2018https://github.com/angular/angular/issues/24965#event-1763947631
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Jul 31, 2018https://github.com/angular/angular/issues/24965#event-1763947675
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
on Mar 15, 2020https://github.com/angular/angular/issues/24965#event-3130257213
atscotthttps://github.com/atscott
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
on Sep 11, 2020https://github.com/angular/angular/issues/24965#event-3757064212
https://github.com/atscott
atscotthttps://github.com/atscott
on Sep 11, 2020https://github.com/angular/angular/issues/24965#issuecomment-691195767
@trotylhttps://github.com/trotyl
#34443https://github.com/angular/angular/pull/34443
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/24965#event-3830237970
https://github.com/atscott
atscotthttps://github.com/atscott
on Apr 15, 2022https://github.com/angular/angular/issues/24965#issuecomment-1099863034
#45612https://github.com/angular/angular/issues/45612
atscotthttps://github.com/atscott
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 15, 2022https://github.com/angular/angular/issues/24965#event-6438754853
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 16, 2022https://github.com/angular/angular/issues/24965#issuecomment-1127858503
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 16, 2022https://github.com/angular/angular/issues/24965#event-6617502187
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/24965
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/24965
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: change detectionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20change%20detection%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.