René's URL Explorer Experiment


Title: Renderer should not clear host contents when using Shadow DOM · Issue #24859 · angular/angular · GitHub

Open Graph Title: Renderer should not clear host contents when using Shadow DOM · Issue #24859 · angular/angular

X Title: Renderer should not clear host contents when using Shadow DOM · Issue #24859 · angular/angular

Description: When using Angular Elements with the new ViewEncapsulation.ShadowDom option, the renderer clears the pre-existing textContent of the selected root node: https://github.com/angular/angular/blob/master/packages/platform-browser/src/dom/dom...

Open Graph Description: When using Angular Elements with the new ViewEncapsulation.ShadowDom option, the renderer clears the pre-existing textContent of the selected root node: https://github.com/angular/angular/blob/mast...

X Description: When using Angular Elements with the new ViewEncapsulation.ShadowDom option, the renderer clears the pre-existing textContent of the selected root node: https://github.com/angular/angular/blob/mast...

Opengraph URL: https://github.com/angular/angular/issues/24859

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Renderer should not clear host contents when using Shadow DOM","articleBody":"When using Angular Elements with the new `ViewEncapsulation.ShadowDom` option, the renderer clears the pre-existing textContent of the selected root node: https://github.com/angular/angular/blob/master/packages/platform-browser/src/dom/dom_renderer.ts#L144\r\n\r\nThis prevents developers from using `\u003cslot>` elements to do runtime content projection, eg\r\n```ts\r\n@Component({\r\n  template: '\u003cslot>\u003c/slot>',\r\n  encapsulation: ViewEncapsulation.Native,\r\n  styles: [ `:host { color: red } `]\r\n})\r\nclass MyComponent {}\r\n```\r\n```html\r\n\u003cmy-component>ProjectedText\u003c/my-component>\r\n```\r\n\r\nThis is the desired behavior when using Angular in \"SPA\" mode, where the app will own the whole DOM, but prevents runtime composition with Elements.\r\n\r\nNormally, this could be handled in the Shadow DOM renderer, but because this selectRootElement() call happens from inside the view services,: https://github.com/angular/angular/blob/master/packages/core/src/view/services.ts#L756\r\nthe *default* renderer is used here, before the component is booted (?), there's no way to know if this is a ShadowDOM component or not, and the default implementation is used.\r\n","author":{"url":"https://github.com/robwormald","@type":"Person","name":"robwormald"},"datePublished":"2018-07-12T18:53:43Z","url":"https://github.com/angular/angular/issues/24859"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:c79fb880-ed5a-fd90-86c2-0eed70afcd94
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idB932:D5AA4:179AFEE:1F6F56F:6B013970
html-safe-nonce3dd0c3c2f257ab4d263c92759e58f4f751ccba4692a8832907d34efdd7fd2eb2
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJCOTMyOkQ1QUE0OjE3OUFGRUU6MUY2RjU2Rjo2QjAxMzk3MCIsInZpc2l0b3JfaWQiOiI0MDY5OTg3MTE0MDEwMzYwMTc2IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmacdc6c4e3d89bc97759b0fb37fed18f012445cf2fcac67dd5d4c12760f23c011d6
hovercard-subject-tagissue:340757538
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/24859/issue_layout
twitter:imagehttps://opengraph.githubassets.com/31b1464fca36f7208a57719c44ec0edffdfd17b3fb81acc52254e5235d0cc1e2/angular/angular/issues/24859
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/31b1464fca36f7208a57719c44ec0edffdfd17b3fb81acc52254e5235d0cc1e2/angular/angular/issues/24859
og:image:altWhen using Angular Elements with the new ViewEncapsulation.ShadowDom option, the renderer clears the pre-existing textContent of the selected root node: https://github.com/angular/angular/blob/mast...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamerobwormald
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/24859#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24859
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24859
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/24859
Reloadhttps://github.com/angular/angular/issues/24859
Reloadhttps://github.com/angular/angular/issues/24859
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24859
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24859
Renderer should not clear host contents when using Shadow DOMhttps://github.com/angular/angular/issues/24859#top
https://github.com/robwormald
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
on Jul 12, 2018https://github.com/angular/angular/issues/24859#issue-340757538
https://github.com/angular/angular/blob/master/packages/platform-browser/src/dom/dom_renderer.ts#L144https://github.com/angular/angular/blob/master/packages/platform-browser/src/dom/dom_renderer.ts#L144
https://github.com/angular/angular/blob/master/packages/core/src/view/services.ts#L756https://github.com/angular/angular/blob/master/packages/core/src/view/services.ts#L756
robwormaldhttps://github.com/robwormald
on Jul 12, 2018https://github.com/angular/angular/issues/24859#event-1731046956
robwormaldhttps://github.com/robwormald
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on Jul 12, 2018https://github.com/angular/angular/issues/24859#event-1731047463
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jul 12, 2018https://github.com/angular/angular/issues/24859#event-1731047548
robwormaldhttps://github.com/robwormald
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Jul 12, 2018https://github.com/angular/angular/issues/24859#event-1731047926
https://github.com/benoitjchevalier
benoitjchevalierhttps://github.com/benoitjchevalier
on Jul 12, 2018https://github.com/angular/angular/issues/24859#issuecomment-404626088
https://stackblitz.com/edit/angular-slot-sd1https://stackblitz.com/edit/angular-slot-sd1
robwormaldhttps://github.com/robwormald
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Jul 12, 2018https://github.com/angular/angular/issues/24859#event-1731374211
https://github.com/robwormald
robwormaldhttps://github.com/robwormald
on Jul 12, 2018https://github.com/angular/angular/issues/24859#issuecomment-404678479
@benoitjchevalierhttps://github.com/benoitjchevalier
mheveryhttps://github.com/mhevery
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
on Aug 14, 2018https://github.com/angular/angular/issues/24859#event-1788979139
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Aug 14, 2018https://github.com/angular/angular/issues/24859#event-1788979307
robwormaldhttps://github.com/robwormald
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Oct 18, 2018https://github.com/angular/angular/issues/24859#event-1913527535
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/24859#issuecomment-531450610
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/24859#event-2633958761
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/24859
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/24859
robwormaldhttps://github.com/robwormald
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.