Title: Some location change events are no longer after router upgrade · Issue #24429 · angular/angular · GitHub
Open Graph Title: Some location change events are no longer after router upgrade · Issue #24429 · angular/angular
X Title: Some location change events are no longer after router upgrade · Issue #24429 · angular/angular
Description: I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code that calls $location.path(...) to change routes...
Open Graph Description: I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code that ca...
X Description: I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code tha...
Opengraph URL: https://github.com/angular/angular/issues/24429
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Some location change events are no longer after router upgrade","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ x ] Regression (a behavior that used to work and stopped working in a new release)\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWe are running a hybrid application and we have some AngularJS code that calls `$location.path(...)` to change routes. This commit https://github.com/angular/angular/commit/c40ae7f7cfb7f498bc142ae267911e07d73baf31 introduced an issue where when our AngularJS code changes its location to an Angular route, Angular never gets notified of this change (`enableTracing: true` shows this as well). If I simply change line 738 in the aforementioned commit (between router version 6.0.0.beta1 and 6.0.0.beta2) to what it was previously:\r\n```typescript\r\nif (this.location.isCurrentPathEqualTo(path) || replaceUrl) {\r\n this.location.replaceState(path);\r\n} else {\r\n this.location.go(path);\r\n}\r\n```\r\nAngular still gets notified correctly of these route changes.\r\n\r\n## Expected behavior\r\nI expect that when `$location.path(...)` is invoked outside of Angular, that Angular still picks up on the location change so the correct components can be loaded.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.0.4\r\n\r\nBrowser:\r\n- [ x ] Chrome (desktop) version 67\r\n \r\nFor Tooling issues:\r\n- Node version: 9.11.1\r\n- Platform: Mac\r\n\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/vincentjames501","@type":"Person","name":"vincentjames501"},"datePublished":"2018-06-11T20:32:00Z","url":"https://github.com/angular/angular/issues/24429"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:abd1cbff-26e5-ac59-4164-3155d9a92fc8 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A622:14F601:21276A5:2A1E0E4:6B015B69 |
| html-safe-nonce | 257f28fb19ededdfd229556e01b96ef412674e0d9bd53eae6ef6a1c23d337219 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjIyOjE0RjYwMToyMTI3NkE1OjJBMUUwRTQ6NkIwMTVCNjkiLCJ2aXNpdG9yX2lkIjoiNzE1MTg5ODQyNzMxOTQ4OTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0= |
| visitor-hmac | a9aa3c79327d494cf6e930691ae2f1cd97424fb27c31574a84445dad1a46c7c5 |
| hovercard-subject-tag | issue:331338977 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/24429/issue_layout |
| twitter:image | https://opengraph.githubassets.com/08e195b67df6602e01119c7278ca87515c77c317b247363f4f07a76467c18434/angular/angular/issues/24429 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/08e195b67df6602e01119c7278ca87515c77c317b247363f4f07a76467c18434/angular/angular/issues/24429 |
| og:image:alt | I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code that ca... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | vincentjames501 |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width