René's URL Explorer Experiment


Title: Some location change events are no longer after router upgrade · Issue #24429 · angular/angular · GitHub

Open Graph Title: Some location change events are no longer after router upgrade · Issue #24429 · angular/angular

X Title: Some location change events are no longer after router upgrade · Issue #24429 · angular/angular

Description: I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code that calls $location.path(...) to change routes...

Open Graph Description: I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code that ca...

X Description: I'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code tha...

Opengraph URL: https://github.com/angular/angular/issues/24429

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Some location change events are no longer after router upgrade","articleBody":"## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ x ] Regression (a behavior that used to work and stopped working in a new release)\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWe are running a hybrid application and we have some AngularJS code that calls `$location.path(...)` to change routes. This commit https://github.com/angular/angular/commit/c40ae7f7cfb7f498bc142ae267911e07d73baf31 introduced an issue where when our AngularJS code changes its location to an Angular route, Angular never gets notified of this change (`enableTracing: true` shows this as well). If I simply change line 738 in the aforementioned commit (between router version 6.0.0.beta1 and 6.0.0.beta2) to what it was previously:\r\n```typescript\r\nif (this.location.isCurrentPathEqualTo(path) || replaceUrl) {\r\n  this.location.replaceState(path);\r\n} else {\r\n  this.location.go(path);\r\n}\r\n```\r\nAngular still gets notified correctly of these route changes.\r\n\r\n## Expected behavior\r\nI expect that when `$location.path(...)` is invoked outside of Angular, that Angular still picks up on the location change so the correct components can be loaded.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.0.4\r\n\r\nBrowser:\r\n- [ x ] Chrome (desktop) version 67\r\n \r\nFor Tooling issues:\r\n- Node version: 9.11.1\r\n- Platform:  Mac\r\n\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/vincentjames501","@type":"Person","name":"vincentjames501"},"datePublished":"2018-06-11T20:32:00Z","url":"https://github.com/angular/angular/issues/24429"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:abd1cbff-26e5-ac59-4164-3155d9a92fc8
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idA622:14F601:21276A5:2A1E0E4:6B015B69
html-safe-nonce257f28fb19ededdfd229556e01b96ef412674e0d9bd53eae6ef6a1c23d337219
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBNjIyOjE0RjYwMToyMTI3NkE1OjJBMUUwRTQ6NkIwMTVCNjkiLCJ2aXNpdG9yX2lkIjoiNzE1MTg5ODQyNzMxOTQ4OTA1IiwicmVnaW9uX2VkZ2UiOiJpYWQiLCJyZWdpb25fcmVuZGVyIjoiaWFkIn0=
visitor-hmaca9aa3c79327d494cf6e930691ae2f1cd97424fb27c31574a84445dad1a46c7c5
hovercard-subject-tagissue:331338977
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/24429/issue_layout
twitter:imagehttps://opengraph.githubassets.com/08e195b67df6602e01119c7278ca87515c77c317b247363f4f07a76467c18434/angular/angular/issues/24429
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/08e195b67df6602e01119c7278ca87515c77c317b247363f4f07a76467c18434/angular/angular/issues/24429
og:image:altI'm submitting a... [ x ] Regression (a behavior that used to work and stopped working in a new release) Current behavior We are running a hybrid application and we have some AngularJS code that ca...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamevincentjames501
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/24429#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24429
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24429
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/24429
Reloadhttps://github.com/angular/angular/issues/24429
Reloadhttps://github.com/angular/angular/issues/24429
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24429
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24429
Some location change events are no longer after router upgradehttps://github.com/angular/angular/issues/24429#top
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/vincentjames501
vincentjames501https://github.com/vincentjames501
on Jun 11, 2018https://github.com/angular/angular/issues/24429#issue-331338977
c40ae7fhttps://github.com/angular/angular/commit/c40ae7f7cfb7f498bc142ae267911e07d73baf31
https://github.com/vincentjames501
vincentjames501https://github.com/vincentjames501
on Jun 11, 2018https://github.com/angular/angular/issues/24429#issuecomment-396403502
#21995https://github.com/angular/angular/issues/21995
#21728https://github.com/angular/angular/pull/21728
gkalpakhttps://github.com/gkalpak
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
on Jun 12, 2018https://github.com/angular/angular/issues/24429#event-1675557830
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Jun 12, 2018https://github.com/angular/angular/issues/24429#event-1675557957
gkalpakhttps://github.com/gkalpak
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
on Jun 12, 2018https://github.com/angular/angular/issues/24429#event-1675558023
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Jun 12, 2018https://github.com/angular/angular/issues/24429#event-1675559089
https://github.com/PikaChokeMe
PikaChokeMehttps://github.com/PikaChokeMe
on Feb 16, 2019https://github.com/angular/angular/issues/24429#issuecomment-464258911
jasonadenhttps://github.com/jasonaden
on Feb 19, 2019https://github.com/angular/angular/issues/24429#event-2150421871
feat(router): add hash-based navigation option to setUpLocationSynchttps://github.com/jasonaden/angular/commit/67c682c71c14533c4fa99f9b0bc8199547851d60
https://docs.github.com/articles/closing-issues-via-commit-messages
67c682chttps://github.com/jasonaden/angular/commit/67c682c71c14533c4fa99f9b0bc8199547851d60
IgorMinarhttps://github.com/IgorMinar
on Feb 20, 2019https://github.com/angular/angular/issues/24429#event-2150518688
feat(router): add hash-based navigation option to setUpLocationSync (#…https://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36
#…https://github.com/angular/angular/pull/28609
https://docs.github.com/articles/closing-issues-via-commit-messages
fc895bahttps://github.com/angular/angular/commit/fc895ba1893d08813f931c8794c7db97782f1c36
IgorMinarhttps://github.com/IgorMinar
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
71d0eebhttps://github.com/angular/angular/commit/71d0eeb966843d372068bf69489da278ff7969fb
on Feb 20, 2019https://github.com/angular/angular/issues/24429#event-2150520668
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/24429#issuecomment-531497684
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 14, 2019https://github.com/angular/angular/issues/24429#event-2634243221
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/24429
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/24429
area: routerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20router%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
regressionIndicates than the issue relates to something that worked in a previous versionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22regression%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.