René's URL Explorer Experiment


Title: add ability to override service worker onPush · Issue #24387 · angular/angular · GitHub

Open Graph Title: add ability to override service worker onPush · Issue #24387 · angular/angular

X Title: add ability to override service worker onPush · Issue #24387 · angular/angular

Description: EDIT(@gkalpak): Related to issue #26413. I'm submitting a... [x] Feature request Current behavior The current service worker displays notifications but not offer interaction options, the ability to send messages back to the app to update...

Open Graph Description: EDIT(@gkalpak): Related to issue #26413. I'm submitting a... [x] Feature request Current behavior The current service worker displays notifications but not offer interaction options, the ability to...

X Description: EDIT(@gkalpak): Related to issue #26413. I'm submitting a... [x] Feature request Current behavior The current service worker displays notifications but not offer interaction options, the abilit...

Opengraph URL: https://github.com/angular/angular/issues/24387

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"add ability to override service worker onPush","articleBody":"_**EDIT**(@gkalpak): Related to issue #26413._\r\n\r\n##\r\n\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[x] Feature request\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nThe current service worker displays notifications but not offer interaction options, the ability to send messages back to the app to update the app state, or consume web push messages arbitrarily shaped or empty data.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nTo override the onPush response of the service worker with my own code. This code would be integrated into the service worker completely replacing the current onPush response when the project is compiled to JavaScript. The code could pass messages to angular services in my project, to allow me to update my app state in response to push messages. The code would responsible for displaying the notification, so that I would have full control over the appearance and behavior (up to what the Web Standard allows).\r\n\r\nMy suggestion would be to allow an angular service implementing an interface (which containing an onPush function) to be passed to the service worker module on registration. The service worker would then call that service instead of its own method on push events. A disadvantage of this solution would that custom service would run in a different context from normal service workers (since it would run in the service worker context, not the window context). This would be surprising to new developers.\r\n\r\nA simpler though perhaps less elegant solution would be to pass a callback function to the service worker module instead of a service.  Or the service worker could expose an observable which could be subscribed to for overriding the default push notification system. I believe that these solutions would also have the context weirdness problem. I am not deeply familiar with the angular code base so I am unsure of how easy to implement or angular in style these particular solutions would be.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\nThe angular service worker support caching really well, likewise for updating the service worker.  It handling of push notifications is lacking; however, even in world where the service worker configuration covers most common things, like navigating to a URL on click or even simple user interaction, there would be a need to integrate code from the app into the behavior of the service worker.\r\n\r\nFor example, to display the new message in the app even if the user is no longer connected to the internet at the time of clicking the notification. (In this hypothetical, the user was connected to the internet when they received the notification, of course) This would avoid the awkward experience of being told there is a new message and seeing the message in the notification and then clicking the notification and being brought to a page which doesn't show the message because the page cannot load it from the server anymore.\r\n\r\nIf we could override the onPush event in the service worker, then the app could add the message to the page at the same time as it displays the notification, thus preventing the user from losing their ability to view it when clicking the notification. \r\n\r\nAn alternative reason for overriding the onPush even is if one needs to consume push events which one doesn't have tight control over the shape of the data inside. For example, if one is using third-party server app to generate the push notifications, or changing the data inside would require making a request to another development team. Additionally the developer could make their app respond to empty notifications which are easier to test and emit from a server.\r\n\r\nAdditionally, the web app notification interface is fairly new and it would be nice if angular let web developers use as poorly supported (or as widely supported) features without having to wait for angular to implement them.\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.0.4\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n- [x] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [x] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 8.11.1\r\n- Platform:  Windows 7\r\n\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/ribbon-otter","@type":"Person","name":"ribbon-otter"},"datePublished":"2018-06-09T00:02:31Z","url":"https://github.com/angular/angular/issues/24387"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:8f68a1a1-2543-f278-0055-446479366e91
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id844A:29AEE8:1321F2C:1985050:6B0125CC
html-safe-nonce7c16356e9efc63d5c192a79525594ad23c425024f0c7ac5d7b59fef7b6c9eb88
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI4NDRBOjI5QUVFODoxMzIxRjJDOjE5ODUwNTA6NkIwMTI1Q0MiLCJ2aXNpdG9yX2lkIjoiNTY3MTM3MDU1Nzk5NjczNzk5NiIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmacdf68708ae41990599029dfdd0ba9e6ea3e5d40752f9b53cdde6175e9614b960c
hovercard-subject-tagissue:330833868
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/24387/issue_layout
twitter:imagehttps://opengraph.githubassets.com/be084cd64517051bd1b19aeeda5552a484bf24ba80b7b030c7595914693e9aae/angular/angular/issues/24387
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/be084cd64517051bd1b19aeeda5552a484bf24ba80b7b030c7595914693e9aae/angular/angular/issues/24387
og:image:altEDIT(@gkalpak): Related to issue #26413. I'm submitting a... [x] Feature request Current behavior The current service worker displays notifications but not offer interaction options, the ability to...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameribbon-otter
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/24387#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24387
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F24387
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/24387
Reloadhttps://github.com/angular/angular/issues/24387
Reloadhttps://github.com/angular/angular/issues/24387
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24387
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/24387
add ability to override service worker onPushhttps://github.com/angular/angular/issues/24387#top
area: service-workerIssues related to the @angular/service-worker packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/ribbon-otter
ribbon-otterhttps://github.com/ribbon-otter
on Jun 9, 2018https://github.com/angular/angular/issues/24387#issue-330833868
@gkalpakhttps://github.com/gkalpak
#26413https://github.com/angular/angular/issues/26413
gkalpakhttps://github.com/gkalpak
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
area: service-workerIssues related to the @angular/service-worker packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
on Jun 11, 2018https://github.com/angular/angular/issues/24387#event-1673330635
ngbothttps://github.com/apps/ngbot
Backloghttps://github.com/angular/angular/milestone/82
on Jun 11, 2018https://github.com/angular/angular/issues/24387#event-1673330774
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Jun 11, 2018https://github.com/angular/angular/issues/24387#issuecomment-396170764
#20756 (comment)https://github.com/angular/angular/issues/20756#issuecomment-386315924
https://github.com/ribbon-otter
ribbon-otterhttps://github.com/ribbon-otter
on Jun 12, 2018https://github.com/angular/angular/issues/24387#issuecomment-396426305
@gkalpakhttps://github.com/gkalpak
#20756 (comment)https://github.com/angular/angular/issues/20756#issuecomment-386315924
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Jun 12, 2018https://github.com/angular/angular/issues/24387#issuecomment-396490032
https://github.com/CharlBest
CharlBesthttps://github.com/CharlBest
on Jul 4, 2018https://github.com/angular/angular/issues/24387#issuecomment-402510552
@gkalpakhttps://github.com/gkalpak
#20756https://github.com/angular/angular/issues/20756
angular-robothttps://github.com/apps/angular-robot
votes requiredhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22votes%20required%22
on Jun 4, 2021https://github.com/angular/angular/issues/24387#event-4843596420
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 4, 2021https://github.com/angular/angular/issues/24387#issuecomment-854782256
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
https://github.com/apps/angular-robot
angular-robothttps://github.com/apps/angular-robot
on Jun 24, 2021https://github.com/angular/angular/issues/24387#issuecomment-867666023
communityhttps://angular.io/resources?category=community
packagehttps://angular.io/guide/creating-libraries
documentationhttps://github.com/angular/angular/blob/e29eb8abfbfdfb793e08ac88e14b7ba6d2ff2136/docs/GITHUB_PROCESS.md#feature-request-process
angular-robothttps://github.com/apps/angular-robot
insufficient voteshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22insufficient%20votes%22
on Jun 24, 2021https://github.com/angular/angular/issues/24387#event-4934843093
https://github.com/alxhub
alxhubhttps://github.com/alxhub
on Apr 14, 2022https://github.com/angular/angular/issues/24387#issuecomment-1099714834
#21197https://github.com/angular/angular/issues/21197
alxhubhttps://github.com/alxhub
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 14, 2022https://github.com/angular/angular/issues/24387#event-6437823239
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 15, 2022https://github.com/angular/angular/issues/24387#issuecomment-1126970814
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on May 15, 2022https://github.com/angular/angular/issues/24387#event-6611514271
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/24387
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/24387
area: service-workerIssues related to the @angular/service-worker packagehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20service-worker%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.