René's URL Explorer Experiment

{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"[testing]: overridePipe forces to redefine the name of the pipe","articleBody":"## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" --\u003e\r\n\u003cpre\u003e\u003ccode\u003e\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting --\u003e\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request =\u003e Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code\u003e\u003c/pre\u003e\r\n\r\n## Current behavior\r\n\r\nCurrently when you want to use `overridePipe` in a test to set `pure` to false for example, you have to also specify the name in the metadata override:\r\n\r\n```typescript\r\nconst fixture = TestBed\r\n      .overridePipe(DisplayNamePipe, { set: { name: 'displayName', pure: false } })\r\n      .createComponent(MenuComponent);\r\n```\r\n\r\nHere the only thing we want to set is the `pure` metadata, but we have to set the `name` also because `MetadataOverride` is defined like this:\r\n\r\n```typescript\r\nexport declare type MetadataOverride\u003cT\u003e = {\r\n    add?: T;\r\n    remove?: T;\r\n    set?: T;\r\n};\r\n```\r\n\r\nAnd the `Pipe` metadata is:\r\n\r\n```typescript\r\nexport interface Pipe {\r\n    name: string;\r\n    pure?: boolean;\r\n}\r\n```\r\n\r\nso the `name` is mandatory.\r\n\r\n## Expected behavior\r\n\r\nWe should not have to set/add/remove the `name` in overridePipe when we want to set/add/remove another property. this is the same with `overrideComponent`, `overrideDirective`, ... But in these all the fiels of the interfaces are (for now) optional.\r\n\r\nWe should be able to write: \r\n\r\n```typescript\r\nconst fixture = TestBed\r\n      .overridePipe(DisplayNamePipe, { set: { pure: false } })\r\n      .createComponent(MenuComponent);\r\n```\r\n\r\n## Environment\r\n\r\n\u003cpre\u003e\u003ccode\u003e\r\nAngular version: 6.0.3\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 8.11\r\n- Platform:  Mac\r\n\r\n\u003c/code\u003e\u003c/pre\u003e\r\n","author":{"url":"https://github.com/cexbrayat","@type":"Person","name":"cexbrayat"},"datePublished":"2018-05-24T14:02:13.000Z","interactionStatistic":{"@type":"InteractionCounter","interactionType":"https://schema.org/CommentAction","userInteractionCount":1},"url":"https://github.com/24102/angular/issues/24102"}