Title: Resolve cancel behavior should be documented clearly · Issue #23659 · angular/angular · GitHub
Open Graph Title: Resolve cancel behavior should be documented clearly · Issue #23659 · angular/angular
X Title: Resolve cancel behavior should be documented clearly · Issue #23659 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [x] Documentation issue or request [ ] Support request => Please do not submi...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [x] Documentation issue or request [ ...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [x] Documentation issue or reques...
Opengraph URL: https://github.com/angular/angular/issues/23659
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Resolve cancel behavior should be documented clearly","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[x] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\u003c!-- Describe how the issue manifests. -->\r\nI am trying to figure out how to cancel a navigation request from a Resolve. For example, if the resolver is requesting data from server and server returns an error, I want to cancel the navigation. Looking at the documentations https://next.angular.io/api/router/Routes, https://next.angular.io/api/router/Resolve and https://next.angular.io/tutorial/toh-pt5, I couldn't find any solution to that.\r\n\r\nAfter searching a lot, I found out that returning empty observable cancels the navigation. But it is not documented anywhere.\r\n\r\n## Expected behavior\r\n\u003c!-- Describe what the desired behavior would be. -->\r\nThe behavior of Resolve should be documented. It should clearly state what happens on error and how to cancel navigation.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\nhttps://stackblitz.com/edit/angular-gitter-r8sesk\r\n* Check the 'okay' router link. Resolver for the url returns a `Observable.of()` value, so navigation to that url works as expected.\r\n* Check the 'error' router link. Resolver for the url returns a `Observable.empty()` value, so navigation to that url does not work.\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\nMake it clearer for users.\r\n\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: v6.0.0-rc.6\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version XX\r\n- [x] Chrome (Android) version XX\r\n- [x] Chrome (iOS) version XX\r\n- [x] Firefox version XX\r\n- [x] Safari (desktop) version XX\r\n- [x] Safari (iOS) version XX\r\n- [x] IE version XX\r\n- [x] Edge version XX","author":{"url":"https://github.com/ienzam","@type":"Person","name":"ienzam"},"datePublished":"2018-05-03T03:34:20Z","url":"https://github.com/angular/angular/issues/23659"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:c32f1ccc-4257-891f-3693-46b96f259577 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | A176:14700E:13CC97D:1921335:6B012589 |
| html-safe-nonce | 99751df76075e5adef9cc36dd1187281e262ab8335b4a64bf7728db031175422 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBMTc2OjE0NzAwRToxM0NDOTdEOjE5MjEzMzU6NkIwMTI1ODkiLCJ2aXNpdG9yX2lkIjoiNDAzNTc2Mzg3ODI5Mjk1NjU1MyIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9 |
| visitor-hmac | 8b0334eb433476780ab4ee4e40896b1654a35b69a3e1b1bcacd18d09d5852d84 |
| hovercard-subject-tag | issue:319778271 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23659/issue_layout |
| twitter:image | https://opengraph.githubassets.com/a844e25254c49ab7e72db24f31c0760ae7c5c9604792be9a07bc6c3e4dd168ca/angular/angular/issues/23659 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/a844e25254c49ab7e72db24f31c0760ae7c5c9604792be9a07bc6c3e4dd168ca/angular/angular/issues/23659 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [x] Documentation issue or request [ ... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | ienzam |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width