René's URL Explorer Experiment


Title: Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effect · Issue #23609 · angular/angular · GitHub

Open Graph Title: Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effect · Issue #23609 · angular/angular

X Title: Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effect · Issue #23609 · angular/angular

Description: I'm submitting a... [X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submi...

Open Graph Description: I'm submitting a... [X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...

X Description: I'm submitting a... [X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or reques...

Opengraph URL: https://github.com/angular/angular/issues/23609

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effect","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003c!-- Check one of the following options with \"x\" -->\r\n\u003cpre>\u003ccode>\r\n[X] Regression (a behavior that used to work and stopped working in a new release)\r\n[ ] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Performance issue\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n[ ] Other... Please describe:\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\nWhen building a library and specifying both `skipTemplateCodegen` and `strictMetadataEmit` to `true`,  and you try to call a method inside the `ngModule` decorate example `RouterModule.forChild([])` this will cause a compilation error `Function calls are not supported in decorators but 'RouterModule' was called.`\r\n\r\nWhen adding `fullTemplateTypeCheck` to `true` the error is not emitted.\r\n\r\nAlso, `@dynamic` seems not to have any effect in this particular case.\r\n\r\n## Expected behavior\r\nNo error emitted, or at least that it can be suppressed with the `@dynamic`. \r\n\r\nI also expect that setting `fullTemplateTypeCheck` doesn't have any effect here as this flag relates more to binding in templates.\r\n\r\n## Minimal reproduction of the problem with instructions\r\nCreate a file example\r\n```ts\r\nimport { NgModule } from '@angular/core';\r\nimport { RouterModule } from '@angular/router';\r\n\r\n@NgModule({\r\n  imports: [\r\n    RouterModule.forChild([])\r\n  ]\r\n})\r\nexport class LibModule { }\r\n```\r\n\r\nHave tsconfig set with the following options;\r\n```\r\n  \"angularCompilerOptions\": {\r\n    \"skipTemplateCodegen\": true,\r\n    \"strictMetadataEmit\": true\r\n  }\r\n```\r\n\r\nWhen transpiling this will emit an error;\r\n```\r\nError during template compile of 'LibModule' Function calls are not supported in decorators but 'RouterModule' was called.\r\n```\r\n\r\nNote when adding `\"fullTemplateTypeCheck\": true` no error is emitted. (Though this is kinda weird as I don't think this shouldn't have any effect)\r\n\r\nReproduction repo: https://github.com/alan-agius4/angular-issue-23609\r\n\r\n\r\n## What is the motivation / use case for changing the behavior?\r\nNo error was emitted in NG 5\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 6.0.0-rc-6\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\u003c/code>\u003c/pre>\r\n\r\nRelated issues:\r\nhttps://github.com/dherges/ng-packagr/issues/822\r\nhttps://github.com/dherges/ng-packagr/issues/778\r\nhttps://github.com/dherges/ng-packagr/issues/727\r\nhttps://github.com/dherges/ng-packagr/issues/765\r\nhttps://github.com/dherges/ng-packagr/issues/767\r\nhttps://github.com/dherges/ng-packagr/issues/885\r\n","author":{"url":"https://github.com/alan-agius4","@type":"Person","name":"alan-agius4"},"datePublished":"2018-04-30T14:25:05Z","url":"https://github.com/angular/angular/issues/23609"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:3a2d5f91-97b1-5e2e-9120-71c2565e3415
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idCD7A:2E124E:B8C5A9:ECDF36:6B00FD49
html-safe-nonce89abae13a0af934b98ec46a4d2b46b4e29b841fde6b0a4c5be397d4f748cf743
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJDRDdBOjJFMTI0RTpCOEM1QTk6RUNERjM2OjZCMDBGRDQ5IiwidmlzaXRvcl9pZCI6Ijc3NjYzNTkzOTc3MTgwOTcyMjUiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmacdd01ce2b6d242777ca47fbb7282d67874ede50cc5584cfaddb43963df10091f0
hovercard-subject-tagissue:318908851
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23609/issue_layout
twitter:imagehttps://opengraph.githubassets.com/e08a796a8c10b4b0ff0fa5e946b6593fa124dea0073bd454983da2344ecca6c2/angular/angular/issues/23609
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/e08a796a8c10b4b0ff0fa5e946b6593fa124dea0073bd454983da2344ecca6c2/angular/angular/issues/23609
og:image:altI'm submitting a... [X] Regression (a behavior that used to work and stopped working in a new release) [ ] Bug report [ ] Performance issue [ ] Feature request [ ] Documentation issue or request [ ...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamealan-agius4
hostnamegithub.com
expected-hostnamegithub.com
Nonee208d86428ec00a57ade75058166297440e8128a01e5287c31a53dc042bbf187
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release7dafd017fb7809a839c443dba08622af38e63c09
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/23609#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23609
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23609
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/23609
Reloadhttps://github.com/angular/angular/issues/23609
Reloadhttps://github.com/angular/angular/issues/23609
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23609
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23609
Function calls are not supported in decorators when fullTemplateTypeCheck is not specified and @dynamic has no effecthttps://github.com/angular/angular/issues/23609#top
P5The team acknowledges the request but does not plan to address it, it remains open for discussionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P5%22
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Apr 30, 2018https://github.com/angular/angular/issues/23609#issue-318908851
https://github.com/alan-agius4/angular-issue-23609https://github.com/alan-agius4/angular-issue-23609
https://github.com/dherges/ng-packagr/issues/822https://github.com/dherges/ng-packagr/issues/822
https://github.com/dherges/ng-packagr/issues/778https://github.com/dherges/ng-packagr/issues/778
https://github.com/dherges/ng-packagr/issues/727https://github.com/dherges/ng-packagr/issues/727
https://github.com/dherges/ng-packagr/issues/765https://github.com/dherges/ng-packagr/issues/765
https://github.com/dherges/ng-packagr/issues/767https://github.com/dherges/ng-packagr/issues/767
https://github.com/dherges/ng-packagr/issues/885https://github.com/dherges/ng-packagr/issues/885
Nexthttps://github.com/angular/angular/issues/23609?timeline_page=1
alan-agius4https://github.com/alan-agius4
on Apr 30, 2018https://github.com/angular/angular/issues/23609#event-1601629293
https://github.com/alan-agius4
alan-agius4https://github.com/alan-agius4
on Apr 30, 2018https://github.com/angular/angular/issues/23609#issuecomment-385505984
https://user-images.githubusercontent.com/17563226/39621267-71854a1a-4f8e-11e8-992e-2941d6f84dd4.png
IgorMinarhttps://github.com/IgorMinar
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
on May 3, 2018https://github.com/angular/angular/issues/23609#event-1608175113
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on May 3, 2018https://github.com/angular/angular/issues/23609#event-1608175200
mheveryhttps://github.com/mhevery
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
freq1: lowhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq1%3A%20low%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on May 3, 2018https://github.com/angular/angular/issues/23609#event-1608815650
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on May 3, 2018https://github.com/angular/angular/issues/23609#event-1608815708
dhergeshttps://github.com/dherges
on May 4, 2018https://github.com/angular/angular/issues/23609#event-1609415441
feat: enable `fullTemplateTypeCheck` (#826)https://github.com/ng-packagr/ng-packagr/commit/83f2cb6fab0b1347aacdb326cd4afb92b68e67c2
#826https://github.com/ng-packagr/ng-packagr/pull/826
83f2cb6https://github.com/ng-packagr/ng-packagr/commit/83f2cb6fab0b1347aacdb326cd4afb92b68e67c2
https://github.com/wardbell
wardbellhttps://github.com/wardbell
on May 5, 2018https://github.com/angular/angular/issues/23609#issuecomment-386837941
https://github.com/dherges
dhergeshttps://github.com/dherges
on May 6, 2018https://github.com/angular/angular/issues/23609#issuecomment-386876693
@wardbellhttps://github.com/wardbell
one example in this reprohttps://github.com/dherges/angular-ngrx-data/commit/96fcbe71e7089ce11e222b0efad3a0ba8404610a
"need for static value resoltion" in the compiler docshttps://github.com/angular/angular/blob/master/packages/compiler/design/architecture.md#need-for-static-value-resolution
strictMetadataEmithttps://angular.io/guide/aot-compiler#strictmetadataemit
https://github.com/wardbell
wardbellhttps://github.com/wardbell
on May 7, 2018https://github.com/angular/angular/issues/23609#issuecomment-386955003
@dhergeshttps://github.com/dherges
wardbellhttps://github.com/wardbell
on May 7, 2018https://github.com/angular/angular/issues/23609#event-1612132894
refactor: NgrxDataModule no longer calls store/effects .forFeaturehttps://github.com/johnpapa/angular-ngrx-data/commit/92b1e6915c6bf59e6ca99efadd6cca964e6ca738
92b1e69https://github.com/johnpapa/angular-ngrx-data/commit/92b1e6915c6bf59e6ca99efadd6cca964e6ca738
breaking changes: update to Angular/RxJS/Ngrx v6 v6.0.0-beta.1 (#147)https://github.com/johnpapa/angular-ngrx-data/commit/9299491bf2e5c66e140b2bc8212699e682ca2cf9
#147https://github.com/johnpapa/angular-ngrx-data/pull/147
9299491https://github.com/johnpapa/angular-ngrx-data/commit/9299491bf2e5c66e140b2bc8212699e682ca2cf9
jelbournhttps://github.com/jelbourn
P3An issue that is relevant to core functions, but does not impede progress. Important, but not urgenthttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P3%22
severity3: brokenhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22severity3%3A%20broken%22
on Oct 1, 2020https://github.com/angular/angular/issues/23609#event-3830298670
https://github.com/aescobar-icc
aescobar-icchttps://github.com/aescobar-icc
on Jan 9, 2021https://github.com/angular/angular/issues/23609#issuecomment-757086844
https://github.com/MickL
MickLhttps://github.com/MickL
on Jan 20, 2021https://github.com/angular/angular/issues/23609#issuecomment-763599167
@alxhubhttps://github.com/alxhub
@alxhubhttps://github.com/alxhub
documentationhttps://angular.io/guide/creating-libraries
@SergeyVolynkinhttps://github.com/SergeyVolynkin
@hitallowhttps://github.com/hitallow
@bh3605https://github.com/bh3605
@antontemchenkohttps://github.com/antontemchenko
@adrian1907https://github.com/adrian1907
https://github.com/SergeyVolynkin
SergeyVolynkinhttps://github.com/SergeyVolynkin
on Jan 20, 2021https://github.com/angular/angular/issues/23609#issuecomment-763730308
https://github.com/TheRealOha
TheRealOhahttps://github.com/TheRealOha
on Mar 31, 2021https://github.com/angular/angular/issues/23609#issuecomment-810945240
@MickLhttps://github.com/MickL
removing prebublishOnly from package.jsonhttps://github.com/angular/angular/issues/37973#issuecomment-656179491
https://github.com/NiklasPor
NiklasPorhttps://github.com/NiklasPor
on May 4, 2021https://github.com/angular/angular/issues/23609#issuecomment-832023389
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on May 14, 2021https://github.com/angular/angular/issues/23609#issuecomment-841201444
JoostKhttps://github.com/JoostK
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on May 14, 2021https://github.com/angular/angular/issues/23609#event-4746684054
https://github.com/SuperITMan
SuperITManhttps://github.com/SuperITMan
on Jun 9, 2021https://github.com/angular/angular/issues/23609#issuecomment-857629463
@JoostKhttps://github.com/JoostK
enableIvyhttps://angular.io/guide/angular-compiler-options#enableivy
https://github.com/NiklasPor
NiklasPorhttps://github.com/NiklasPor
on Jun 9, 2021https://github.com/angular/angular/issues/23609#issuecomment-857640641
@SuperITManhttps://github.com/SuperITMan
compilationModehttps://angular.io/guide/angular-compiler-options#compilationmode
https://github.com/JoostK
JoostKhttps://github.com/JoostK
on Jun 9, 2021https://github.com/angular/angular/issues/23609#issuecomment-857641073
@NiklasPorhttps://github.com/NiklasPor
https://github.com/SuperITMan
SuperITManhttps://github.com/SuperITMan
on Jun 9, 2021https://github.com/angular/angular/issues/23609#issuecomment-857661963
@NiklasPorhttps://github.com/NiklasPor
@JoostKhttps://github.com/JoostK
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 10, 2021https://github.com/angular/angular/issues/23609#issuecomment-877661522
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Jul 10, 2021https://github.com/angular/angular/issues/23609#event-5003369432
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/23609
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/23609
P5The team acknowledges the request but does not plan to address it, it remains open for discussionhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22P5%22
area: compilerIssues related to `ngc`, Angular's template compilerhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20compiler%22
freq3: highhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22freq3%3A%20high%22
state: confirmedhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22state%3A%20confirmed%22
type: bug/fixhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22type%3A%20bug%2Ffix%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.