René's URL Explorer Experiment


Title: `inject` and `directiveInject` need bridging when used with `Component.provides` · Issue #23330 · angular/angular · GitHub

Open Graph Title: `inject` and `directiveInject` need bridging when used with `Component.provides` · Issue #23330 · angular/angular

X Title: `inject` and `directiveInject` need bridging when used with `Component.provides` · Issue #23330 · angular/angular

Description: Currently we generate inject for @Injectable and directiveInject for @Component and @Directive. This works fine since @Injectable declared as part of @NgModule does not need to see anything from the Element Injector Tree. However this do...

Open Graph Description: Currently we generate inject for @Injectable and directiveInject for @Component and @Directive. This works fine since @Injectable declared as part of @NgModule does not need to see anything from th...

X Description: Currently we generate inject for @Injectable and directiveInject for @Component and @Directive. This works fine since @Injectable declared as part of @NgModule does not need to see anything from th...

Opengraph URL: https://github.com/angular/angular/issues/23330

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"`inject` and `directiveInject` need bridging when used with `Component.provides`","articleBody":"Currently we generate `inject` for `@Injectable` and `directiveInject` for `@Component` and `@Directive`. This works fine since `@Injectable` declared as part of `@NgModule` does not need to see anything from the Element Injector Tree.\r\n\r\nHowever this does not work in the case when `@Injectable` is used with `@Component.providers` (or `@Component.viewProviders`) because in that case the `@Injectable` can see into the Element Injector Tree.\r\n\r\n## Possible fixes are:\r\n\r\n### Mark services in `@Component.providers` using `inject` (:thumbsdown:)\r\n\r\nnon-starter as it breaks locality.\r\n\r\n### Have only one `inject` (:thumbsdown:)\r\n\r\nThis would require merging `directiveInject` into `inject`\r\n\r\nPros: \r\n- Easy to implement\r\n\r\nCons:\r\n- `di` will have to know about `render3`\r\n- Breaks tree shaking since any `@Injectable` will be pulling in at least some code of `render3`.\r\n\r\n###  Have `ComponentDefFeature` which would patch `inject` to act like `directiveInject` only when `@Component.providers` are used (:thumbsup:)\r\n\r\nPros:\r\n- Tree shaking works as expected.\r\n- `di` does not need to know about `render3` (needs to have a hook, see *cons*)\r\n\r\nCons:\r\n- `di` has to have a hook into which external `render3` can connect in order to redirect `inject` into `directiveInject`. Since this is a private hook, it should be small cost.\r\n\r\n## Syntax\r\n\r\n```\r\n@Inejctable()\r\nclass SomeService {\r\n  constructor(dep: SomeDep) {}\r\n  static ngInjectableDef = defineInjectable({\r\n   factory: () => new SomeService(inject(SomeDep));\r\n  });\r\n}\r\n\r\n@Component({\r\n  ...,\r\n  provides: [SomeService]\r\n})\r\nclass MyComponent {\r\n  static ngComponentDef = defineCompoent({\r\n    ...,\r\n    provides: [SomeService],\r\n    features: [ComponetProvidersFeature]\r\n  });\r\n}\r\n```\r\n\r\n`ComponetProvidersFeature` would than use some private API to patch the `inject` to go through the `directiveInject` in cases where the factory is called as a consequence of `@Component.providers`.","author":{"url":"https://github.com/mhevery","@type":"Person","name":"mhevery"},"datePublished":"2018-04-11T23:42:23Z","url":"https://github.com/angular/angular/issues/23330"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:bed0fbb4-2b82-a161-5bc2-f8292faf9559
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-idAEAC:33444D:2444122:303AC77:6B0199C0
html-safe-nonce0df95f4785065bd695f4d5c5e0fbf9e8a8a82cba42a5faf182181650ad0fd798
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiJBRUFDOjMzNDQ0RDoyNDQ0MTIyOjMwM0FDNzc6NkIwMTk5QzAiLCJ2aXNpdG9yX2lkIjoiNzI5Nzc0MDIxOTA0MDc2NjQwMCIsInJlZ2lvbl9lZGdlIjoiaWFkIiwicmVnaW9uX3JlbmRlciI6ImlhZCJ9
visitor-hmac1d76296c708bf90ececd60b6b51b57047d7789405219c4a845fa77d5751c7c1f
hovercard-subject-tagissue:313525743
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23330/issue_layout
twitter:imagehttps://opengraph.githubassets.com/f810d6dedff3c23b551aefc005fb8997ad9353c80f9aa4bcf6c4a36e70bf507f/angular/angular/issues/23330
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/f810d6dedff3c23b551aefc005fb8997ad9353c80f9aa4bcf6c4a36e70bf507f/angular/angular/issues/23330
og:image:altCurrently we generate inject for @Injectable and directiveInject for @Component and @Directive. This works fine since @Injectable declared as part of @NgModule does not need to see anything from th...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernamemhevery
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/23330#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23330
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23330
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/23330
Reloadhttps://github.com/angular/angular/issues/23330
Reloadhttps://github.com/angular/angular/issues/23330
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues836 (836)https://github.com/angular/angular/issues
Pull requests143 (143)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23330
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23330
inject and directiveInject need bridging when used with Component.provideshttps://github.com/angular/angular/issues/23330#top
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: dihttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20di%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
Backloghttps://github.com/angular/angular/milestone/82
https://github.com/mhevery
mheveryhttps://github.com/mhevery
on Apr 11, 2018https://github.com/angular/angular/issues/23330#issue-313525743
mheveryhttps://github.com/mhevery
comp: ivyhttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22comp%3A%20ivy%22
on Apr 11, 2018https://github.com/angular/angular/issues/23330#event-1569805924
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
on Apr 11, 2018https://github.com/angular/angular/issues/23330#event-1569805994
mheveryhttps://github.com/mhevery
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
on Apr 11, 2018https://github.com/angular/angular/issues/23330#event-1569806194
ngbothttps://github.com/apps/ngbot
needsTriagehttps://github.com/angular/angular/milestone/83
Backloghttps://github.com/angular/angular/milestone/82
on Apr 11, 2018https://github.com/angular/angular/issues/23330#event-1569806294
IgorMinarhttps://github.com/IgorMinar
on Apr 13, 2018https://github.com/angular/angular/issues/23330#event-1574182034
feat(ivy): support generation of flags for directive injection (#23345)https://github.com/angular/angular/commit/6f213a74f22b9b4188b65d8757b5693e6ec41e0c
#23345https://github.com/angular/angular/pull/23345
6f213a7https://github.com/angular/angular/commit/6f213a74f22b9b4188b65d8757b5693e6ec41e0c
pkozlowski-opensourcehttps://github.com/pkozlowski-opensource
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: dihttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20di%22
on May 9, 2020https://github.com/angular/angular/issues/23330#event-3319270997
https://github.com/mhevery
mheveryhttps://github.com/mhevery
on Nov 18, 2020https://github.com/angular/angular/issues/23330#issuecomment-729299329
mheveryhttps://github.com/mhevery
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Nov 18, 2020https://github.com/angular/angular/issues/23330#event-4008152482
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Dec 19, 2020https://github.com/angular/angular/issues/23330#issuecomment-748496187
automatic conversation locking policyhttps://github.com/angular/angular/blob/8f24bc9443b3872fe095d9f7f77b308a361a13b4/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Dec 19, 2020https://github.com/angular/angular/issues/23330#event-4132598894
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/23330
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/23330
area: coreIssues related to the framework runtimehttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22area%3A%20core%22
core: dihttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22core%3A%20di%22
featureLabel used to distinguish feature request from other issueshttps://github.com/angular/angular/issues?q=state%3Aopen%20label%3A%22feature%22
BacklogNo due datehttps://github.com/angular/angular/milestone/82
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.