Title: Angular service worker stop working after going offline · Issue #23135 · angular/angular · GitHub
Open Graph Title: Angular service worker stop working after going offline · Issue #23135 · angular/angular
X Title: Angular service worker stop working after going offline · Issue #23135 · angular/angular
Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...
Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...
Opengraph URL: https://github.com/angular/angular/issues/23135
X: @github
Domain: github.com
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular service worker stop working after going offline","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\r\nAfter we where offline new lazy assets and datagroup calls are not cached when we come back online.\r\n\r\n## Expected behavior\r\n\r\nNew lazy assets and datagroup calls will be cached when we come back online.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n\r\nhttps://stackblitz.com is not suitetable for a reproduction, cause we need a angular production build.\r\n\r\n1. Create a new angular project with service worker:\r\n\r\n$ ng new ngsw-test --service-worker\r\n\r\n2. Add an asset to the project:\r\n\r\n$ cd ngsw-test/\r\n$ echo \"Just an asset\" > src/assets/test.txt\r\n\r\n3. Build for production\r\n\r\n$ ng build --prod\r\n\r\n4. Serve the production build:\r\n\r\n$ http-server dist/\r\n\r\n5. Visit the Application with chrome:\r\n\r\nhttp://localhost:8080\r\n\r\n6. Request the test asset:\r\n\r\nhttp://localhost:8080/assets/test.txt\r\n\r\nCheck if the asset was cached:\r\n\r\n\r\n\r\nFine! That work's!\r\n\r\n7. Now Clear all site data:\r\n\r\n\r\n\r\n…and visit the applictaion again in a new tab/window.\r\n\r\nThen go to\r\n\r\nhttp://localhost:8080/ngsw/state\r\n\r\n```\r\nNGSW Debug Info:\r\n\r\nDriver state: NORMAL ((nominal))\r\nLatest manifest hash: 93c83124ea864957be27f463285f323a5ba37e0c\r\nLast update check: 6m12s56u\r\n\r\n=== Version 93c83124ea864957be27f463285f323a5ba37e0c ===\r\n\r\nClients: 6c425f61-4e54-46da-a94c-e7e459569501\r\n\r\n=== Idle Task Queue ===\r\nLast update tick: 6m10s928u\r\nLast update run: never\r\nTask queue:\r\n\r\n\r\nDebug log:\r\n\r\n[6m10s927u] TypeError(Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode, TypeError: Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode\r\n at Driver.safeFetch (http://localhost:8080/ngsw-worker.js:2464:37)\r\n at Driver.handleFetch (http://localhost:8080/ngsw-worker.js:1975:25)) Driver.fetch(http://localhost:8080/)\r\n\r\n```\r\n\r\n\r\nThe driver state is normal and we have a TypeError in the log.\r\n\r\n8. Go offline and visit the application\r\n\r\n\r\n\r\n```\r\nNGSW Debug Info:\r\n\r\nDriver state: EXISTING_CLIENTS_ONLY (Degraded due to failed initialization: Manifest fetch failed!\r\nError: Manifest fetch failed!\r\n at Driver.fetchLatestManifest (http://localhost:8080/ngsw-worker.js:2187:19))\r\nLatest manifest hash: 93c83124ea864957be27f463285f323a5ba37e0c\r\nLast update check: 18m6s7u\r\n\r\n=== Version 93c83124ea864957be27f463285f323a5ba37e0c ===\r\n\r\nClients: 6c425f61-4e54-46da-a94c-e7e459569501, efd7e4ed-d75f-40b3-9065-c390a0ae3c22\r\n\r\n=== Idle Task Queue ===\r\nLast update tick: 9m54s265u\r\nLast update run: 9m49s264u\r\nTask queue:\r\n\r\n\r\nDebug log:\r\n\r\n[18m4s878u] TypeError(Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode, TypeError: Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode\r\n at Driver.safeFetch (http://localhost:8080/ngsw-worker.js:2464:37)\r\n at Driver.handleFetch (http://localhost:8080/ngsw-worker.js:1975:25)) Driver.fetch(http://localhost:8080/)\r\n[9m49s262u] TypeError(Failed to fetch, TypeError: Failed to fetch) Driver.fetch(http://localhost:8080/ngsw.json?ngsw-cache-bust=0.8606498338103712)\r\n[9m49s262u] Error(Manifest fetch failed!, Error: Manifest fetch failed!\r\n at Driver.fetchLatestManifest (http://localhost:8080/ngsw-worker.js:2187:19)) Error occurred while updating to manifest (unknown\r\n\r\n```\r\n\r\nThe request for the manifest was failed, because we are offline. This leads to a degraded state 'EXISTING_CLIENTS_ONLY'.\r\n\r\n9. Go online and visit the application.\r\n\r\n\r\n\r\nThe manifest request was now successful.\r\n\r\nBut the driver state is still degraded:\r\n\r\n```\r\nNGSW Debug Info:\r\n\r\nDriver state: EXISTING_CLIENTS_ONLY (Degraded due to failed initialization: Manifest fetch failed!\r\nError: Manifest fetch failed!\r\n at Driver.fetchLatestManifest (http://localhost:8080/ngsw-worker.js:2187:19))\r\nLatest manifest hash: 93c83124ea864957be27f463285f323a5ba37e0c\r\nLast update check: 2m50s917u\r\n…\r\n\r\n```\r\n\r\n10. Request the test asset.\r\n\r\nThe asset was not cached:\r\n\r\n\r\n\r\nA few thoughts on that:\r\n\r\nAfter some debugging I found the method checkForUpdate() in the file driver.ts:\r\n\r\n```typescript\r\nasync checkForUpdate(): Promise\u003cboolean> {\r\n\tlet hash: string = '(unknown)';\r\n\ttry {\r\n\t\tconst manifest = await this.fetchLatestManifest();\r\n\t\thash = hashManifest(manifest);\r\n\t\t// Check whether this is really an update.\r\n\t\tif (this.versions.has(hash)) {\r\n\t\t\treturn false;\r\n\t\t}\r\n\t\tawait this.setupUpdate(manifest, hash);\r\n\t\treturn true;\r\n\t} catch (err) {\r\n\t\tthis.debugger.log(err, `Error occurred while updating to manifest ${hash}`);\r\n\t\tthis.state = DriverReadyState.EXISTING_CLIENTS_ONLY;\r\n\t\tthis.stateMessage = `Degraded due to failed initialization: ${errorToString(err)}`;\r\n\t\treturn false;\r\n\t}\r\n}\r\n\r\n```\r\n\r\nThe call fetchLatestManifest() throws an error in the offline case. Then we came into the catch block, which sets the degraded state. After this we never come back to the normal state. Is this the correct behaviour? Do we really want to switch the state in this way, when we are offline? If the answer is yes, how do we come back to normal state, so that the cache begin to work again.\r\n\r\n\r\n\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\nThe environment of our application has no stable network. Changes between online and offline state are normal. Nevertheless, we need a consistent application.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.2.9\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 65.0.3325.181\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 8.9.1 \u003c!-- run `node --version` -->\r\n- Platform: Windows \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant? Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/klauserber","@type":"Person","name":"klauserber"},"datePublished":"2018-04-03T08:07:44Z","url":"https://github.com/angular/angular/issues/23135"}
| react-profiling | 0 |
| react-import-map | react,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322 |
| route-pattern | /_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format) |
| route-controller | voltron_issues_fragments |
| route-action | issue_layout |
| fetch-nonce | v2:0b9ee68b-2262-1ebb-6d1f-1b155e179680 |
| current-catalog-service-hash | 81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114 |
| request-id | 97BE:FC5BE:127AB01:188F368:6B0121AF |
| html-safe-nonce | ff769071e27ae95cc85b8f4802b312be02c7a4a38d396da1b6619cd25b3573b9 |
| visitor-payload | eyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0JFOkZDNUJFOjEyN0FCMDE6MTg4RjM2ODo2QjAxMjFBRiIsInZpc2l0b3JfaWQiOiI3NDUyOTA4NDYxNDgwNDMxODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ== |
| visitor-hmac | 0dab7f3b92d8219c1f066c8aa4dec26c92888b1f1b91aba4adc7a5633c700f64 |
| hovercard-subject-tag | issue:310734787 |
| github-keyboard-shortcuts | repository,issues,copilot |
| google-site-verification | Apib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I |
| octolytics-url | https://collector.github.com/github/collect |
| analytics-location | / |
| fb:app_id | 1401488693436528 |
| apple-itunes-app | app-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23135/issue_layout |
| twitter:image | https://opengraph.githubassets.com/81280d060deb55fe5a279845693b722966cbcc611a8acbc11e56096aaff4e877/angular/angular/issues/23135 |
| twitter:card | summary_large_image |
| og:image | https://opengraph.githubassets.com/81280d060deb55fe5a279845693b722966cbcc611a8acbc11e56096aaff4e877/angular/angular/issues/23135 |
| og:image:alt | I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P... |
| og:image:width | 1200 |
| og:image:height | 600 |
| og:site_name | GitHub |
| og:type | object |
| og:author:username | klauserber |
| hostname | github.com |
| expected-hostname | github.com |
| None | cc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c |
| turbo-cache-control | no-preview |
| go-import | github.com/angular/angular git https://github.com/angular/angular.git |
| octolytics-dimension-user_id | 139426 |
| octolytics-dimension-user_login | angular |
| octolytics-dimension-repository_id | 24195339 |
| octolytics-dimension-repository_nwo | angular/angular |
| octolytics-dimension-repository_public | true |
| octolytics-dimension-repository_is_fork | false |
| octolytics-dimension-repository_network_root_id | 24195339 |
| octolytics-dimension-repository_network_root_nwo | angular/angular |
| turbo-body-classes | logged-out env-production page-responsive |
| disable-turbo | false |
| browser-stats-url | https://api.github.com/_private/browser/stats |
| browser-errors-url | https://api.github.com/_private/browser/errors |
| release | 8c77c9e8439031ad54c75a250694842892f693e1 |
| ui-target | full |
| theme-color | #1e2327 |
| color-scheme | light dark |
| react-app-name | issues |
Links:
Viewport: width=device-width