René's URL Explorer Experiment


Title: Angular service worker stop working after going offline · Issue #23135 · angular/angular · GitHub

Open Graph Title: Angular service worker stop working after going offline · Issue #23135 · angular/angular

X Title: Angular service worker stop working after going offline · Issue #23135 · angular/angular

Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => Please do not submit support request here...

Open Graph Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...

X Description: I'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request ...

Opengraph URL: https://github.com/angular/angular/issues/23135

X: @github

direct link

Domain: github.com


Hey, it has json ld scripts:
{"@context":"https://schema.org","@type":"DiscussionForumPosting","headline":"Angular service worker stop working after going offline","articleBody":"\u003c!--\r\nPLEASE HELP US PROCESS GITHUB ISSUES FASTER BY PROVIDING THE FOLLOWING INFORMATION.\r\n\r\nISSUES MISSING IMPORTANT INFORMATION MAY BE CLOSED WITHOUT INVESTIGATION.\r\n-->\r\n\r\n## I'm submitting a...\r\n\u003cpre>\u003ccode>\r\n[ ] Regression (a behavior that used to work and stopped working in a new release)\r\n[x] Bug report  \u003c!-- Please search GitHub for a similar issue or PR before submitting -->\r\n[ ] Feature request\r\n[ ] Documentation issue or request\r\n[ ] Support request => Please do not submit support request here, instead see https://github.com/angular/angular/blob/master/CONTRIBUTING.md#question\r\n\u003c/code>\u003c/pre>\r\n\r\n## Current behavior\r\n\r\nAfter we where offline new lazy assets and datagroup calls are not cached when we come back online.\r\n\r\n## Expected behavior\r\n\r\nNew lazy assets and datagroup calls will be cached when we come back online.\r\n\r\n## Minimal reproduction of the problem with instructions\r\n\u003c!--\r\nFor bug reports please provide the *STEPS TO REPRODUCE* and if possible a *MINIMAL DEMO* of the problem via\r\nhttps://stackblitz.com or similar (you can use this template as a starting point: https://stackblitz.com/fork/angular-gitter).\r\n-->\r\n\r\nhttps://stackblitz.com is not suitetable for a reproduction, cause we need a angular production build.\r\n\r\n1. Create a new angular project with service worker:\r\n\r\n$ ng new ngsw-test --service-worker\r\n\r\n2. Add an asset to the project:\r\n\r\n$ cd ngsw-test/\r\n$ echo \"Just an asset\" > src/assets/test.txt\r\n\r\n3. Build for production\r\n\r\n$ ng build --prod\r\n\r\n4. Serve the production build:\r\n\r\n$ http-server dist/\r\n\r\n5. Visit the Application with chrome:\r\n\r\nhttp://localhost:8080\r\n\r\n6. Request the test asset:\r\n\r\nhttp://localhost:8080/assets/test.txt\r\n\r\nCheck if the asset was cached:\r\n\r\n![image](https://user-images.githubusercontent.com/9998995/38234879-8262bfd4-371f-11e8-8e7c-242b1d987700.png)\r\n\r\nFine! That work's!\r\n\r\n7. Now Clear all site data:\r\n\r\n![image](https://user-images.githubusercontent.com/9998995/38234932-ad28a756-371f-11e8-8a1c-7ef06e36ed4c.png)\r\n\r\n…and visit the applictaion again in a new tab/window.\r\n\r\nThen go to\r\n\r\nhttp://localhost:8080/ngsw/state\r\n\r\n```\r\nNGSW Debug Info:\r\n\r\nDriver state: NORMAL ((nominal))\r\nLatest manifest hash: 93c83124ea864957be27f463285f323a5ba37e0c\r\nLast update check: 6m12s56u\r\n\r\n=== Version 93c83124ea864957be27f463285f323a5ba37e0c ===\r\n\r\nClients: 6c425f61-4e54-46da-a94c-e7e459569501\r\n\r\n=== Idle Task Queue ===\r\nLast update tick: 6m10s928u\r\nLast update run: never\r\nTask queue:\r\n\r\n\r\nDebug log:\r\n\r\n[6m10s927u] TypeError(Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode, TypeError: Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode\r\n    at Driver.safeFetch (http://localhost:8080/ngsw-worker.js:2464:37)\r\n    at Driver.handleFetch (http://localhost:8080/ngsw-worker.js:1975:25)) Driver.fetch(http://localhost:8080/)\r\n\r\n```\r\n\r\n\r\nThe driver state is normal and we have a TypeError in the log.\r\n\r\n8. Go offline and visit the application\r\n\r\n![image](https://user-images.githubusercontent.com/9998995/38235095-3d38cd8a-3720-11e8-8f12-26f7ffaaa5e3.png)\r\n\r\n```\r\nNGSW Debug Info:\r\n\r\nDriver state: EXISTING_CLIENTS_ONLY (Degraded due to failed initialization: Manifest fetch failed!\r\nError: Manifest fetch failed!\r\n    at Driver.fetchLatestManifest (http://localhost:8080/ngsw-worker.js:2187:19))\r\nLatest manifest hash: 93c83124ea864957be27f463285f323a5ba37e0c\r\nLast update check: 18m6s7u\r\n\r\n=== Version 93c83124ea864957be27f463285f323a5ba37e0c ===\r\n\r\nClients: 6c425f61-4e54-46da-a94c-e7e459569501, efd7e4ed-d75f-40b3-9065-c390a0ae3c22\r\n\r\n=== Idle Task Queue ===\r\nLast update tick: 9m54s265u\r\nLast update run: 9m49s264u\r\nTask queue:\r\n\r\n\r\nDebug log:\r\n\r\n[18m4s878u] TypeError(Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode, TypeError: Failed to execute 'fetch' on 'ServiceWorkerGlobalScope': 'only-if-cached' can be set only with 'same-origin' mode\r\n    at Driver.safeFetch (http://localhost:8080/ngsw-worker.js:2464:37)\r\n    at Driver.handleFetch (http://localhost:8080/ngsw-worker.js:1975:25)) Driver.fetch(http://localhost:8080/)\r\n[9m49s262u] TypeError(Failed to fetch, TypeError: Failed to fetch) Driver.fetch(http://localhost:8080/ngsw.json?ngsw-cache-bust=0.8606498338103712)\r\n[9m49s262u] Error(Manifest fetch failed!, Error: Manifest fetch failed!\r\n    at Driver.fetchLatestManifest (http://localhost:8080/ngsw-worker.js:2187:19)) Error occurred while updating to manifest (unknown\r\n\r\n```\r\n\r\nThe request for the manifest was failed, because we are offline. This leads to a degraded state 'EXISTING_CLIENTS_ONLY'.\r\n\r\n9. Go online and visit the application.\r\n\r\n![image](https://user-images.githubusercontent.com/9998995/38235203-8d54a0e6-3720-11e8-8a3e-653a413177c8.png)\r\n\r\nThe manifest request was now successful.\r\n\r\nBut the driver state is still degraded:\r\n\r\n```\r\nNGSW Debug Info:\r\n\r\nDriver state: EXISTING_CLIENTS_ONLY (Degraded due to failed initialization: Manifest fetch failed!\r\nError: Manifest fetch failed!\r\n    at Driver.fetchLatestManifest (http://localhost:8080/ngsw-worker.js:2187:19))\r\nLatest manifest hash: 93c83124ea864957be27f463285f323a5ba37e0c\r\nLast update check: 2m50s917u\r\n…\r\n\r\n```\r\n\r\n10. Request the test asset.\r\n\r\nThe asset was not cached:\r\n\r\n![image](https://user-images.githubusercontent.com/9998995/38235254-be944012-3720-11e8-9890-fd135797b4e0.png)\r\n\r\nA few thoughts on that:\r\n\r\nAfter some debugging I found the method checkForUpdate() in the file driver.ts:\r\n\r\n```typescript\r\nasync checkForUpdate(): Promise\u003cboolean> {\r\n\tlet hash: string = '(unknown)';\r\n\ttry {\r\n\t\tconst manifest = await this.fetchLatestManifest();\r\n\t\thash = hashManifest(manifest);\r\n\t\t// Check whether this is really an update.\r\n\t\tif (this.versions.has(hash)) {\r\n\t\t\treturn false;\r\n\t\t}\r\n\t\tawait this.setupUpdate(manifest, hash);\r\n\t\treturn true;\r\n\t} catch (err) {\r\n\t\tthis.debugger.log(err, `Error occurred while updating to manifest ${hash}`);\r\n\t\tthis.state = DriverReadyState.EXISTING_CLIENTS_ONLY;\r\n\t\tthis.stateMessage = `Degraded due to failed initialization: ${errorToString(err)}`;\r\n\t\treturn false;\r\n\t}\r\n}\r\n\r\n```\r\n\r\nThe call fetchLatestManifest() throws an error in the offline case. Then we came into the catch block, which sets the degraded state. After this we never come back to the normal state. Is this the correct behaviour? Do we really want to switch the state in this way, when we are offline? If the answer is yes, how do we come back to normal state, so that the cache begin to work again.\r\n\r\n\r\n\r\n\r\n## What is the motivation / use case for changing the behavior?\r\n\u003c!-- Describe the motivation or the concrete use case. -->\r\n\r\nThe environment of our application has no stable network. Changes between online and offline state are normal. Nevertheless, we need a consistent application.\r\n\r\n## Environment\r\n\r\n\u003cpre>\u003ccode>\r\nAngular version: 5.2.9\r\n\u003c!-- Check whether this is still an issue in the most recent Angular version -->\r\n\r\nBrowser:\r\n- [x] Chrome (desktop) version 65.0.3325.181\r\n- [ ] Chrome (Android) version XX\r\n- [ ] Chrome (iOS) version XX\r\n- [ ] Firefox version XX\r\n- [ ] Safari (desktop) version XX\r\n- [ ] Safari (iOS) version XX\r\n- [ ] IE version XX\r\n- [ ] Edge version XX\r\n \r\nFor Tooling issues:\r\n- Node version: 8.9.1  \u003c!-- run `node --version` -->\r\n- Platform:  Windows \u003c!-- Mac, Linux, Windows -->\r\n\r\nOthers:\r\n\u003c!-- Anything else relevant?  Operating system version, IDE, package manager, HTTP server, ... -->\r\n\u003c/code>\u003c/pre>\r\n","author":{"url":"https://github.com/klauserber","@type":"Person","name":"klauserber"},"datePublished":"2018-04-03T08:07:44Z","url":"https://github.com/angular/angular/issues/23135"}

react-profiling0
react-import-mapreact,react-dom,react-dom/client,react-dom/profiling,react-is,react/compiler-runtime,react/jsx-dev-runtime,react/jsx-runtime,scheduler@b8488ee2c322
route-pattern/_view_fragments/issues/show/:user_id/:repository/:id/issue_layout(.:format)
route-controllervoltron_issues_fragments
route-actionissue_layout
fetch-noncev2:0b9ee68b-2262-1ebb-6d1f-1b155e179680
current-catalog-service-hash81bb79d38c15960b92d99bca9288a9108c7a47b18f2423d0f6438c5b7bcd2114
request-id97BE:FC5BE:127AB01:188F368:6B0121AF
html-safe-nonceff769071e27ae95cc85b8f4802b312be02c7a4a38d396da1b6619cd25b3573b9
visitor-payloadeyJyZWZlcnJlciI6IiIsInJlcXVlc3RfaWQiOiI5N0JFOkZDNUJFOjEyN0FCMDE6MTg4RjM2ODo2QjAxMjFBRiIsInZpc2l0b3JfaWQiOiI3NDUyOTA4NDYxNDgwNDMxODQiLCJyZWdpb25fZWRnZSI6ImlhZCIsInJlZ2lvbl9yZW5kZXIiOiJpYWQifQ==
visitor-hmac0dab7f3b92d8219c1f066c8aa4dec26c92888b1f1b91aba4adc7a5633c700f64
hovercard-subject-tagissue:310734787
github-keyboard-shortcutsrepository,issues,copilot
google-site-verificationApib7-x98H0j5cPqHWwSMm6dNU4GmODRoqxLiDzdx9I
octolytics-urlhttps://collector.github.com/github/collect
analytics-location///voltron/issues_fragments/issue_layout
fb:app_id1401488693436528
apple-itunes-appapp-id=1477376905, app-argument=https://github.com/_view_fragments/issues/show/angular/angular/23135/issue_layout
twitter:imagehttps://opengraph.githubassets.com/81280d060deb55fe5a279845693b722966cbcc611a8acbc11e56096aaff4e877/angular/angular/issues/23135
twitter:cardsummary_large_image
og:imagehttps://opengraph.githubassets.com/81280d060deb55fe5a279845693b722966cbcc611a8acbc11e56096aaff4e877/angular/angular/issues/23135
og:image:altI'm submitting a... [ ] Regression (a behavior that used to work and stopped working in a new release) [x] Bug report [ ] Feature request [ ] Documentation issue or request [ ] Support request => P...
og:image:width1200
og:image:height600
og:site_nameGitHub
og:typeobject
og:author:usernameklauserber
hostnamegithub.com
expected-hostnamegithub.com
Nonecc5dfdd32f62ebd3223cab3af3aa2b268d3605218237326a48a99d1efd89495c
turbo-cache-controlno-preview
go-importgithub.com/angular/angular git https://github.com/angular/angular.git
octolytics-dimension-user_id139426
octolytics-dimension-user_loginangular
octolytics-dimension-repository_id24195339
octolytics-dimension-repository_nwoangular/angular
octolytics-dimension-repository_publictrue
octolytics-dimension-repository_is_forkfalse
octolytics-dimension-repository_network_root_id24195339
octolytics-dimension-repository_network_root_nwoangular/angular
turbo-body-classeslogged-out env-production page-responsive
disable-turbofalse
browser-stats-urlhttps://api.github.com/_private/browser/stats
browser-errors-urlhttps://api.github.com/_private/browser/errors
release8c77c9e8439031ad54c75a250694842892f693e1
ui-targetfull
theme-color#1e2327
color-schemelight dark
react-app-nameissues

Links:

Skip to contenthttps://github.com/angular/angular/issues/23135#start-of-content
https://github.com/
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23135
GitHubRepository hosting, code review, and collaborationhttps://github.com/platform
CopilotAI coding agent for tasks, projects, and automated workhttps://github.com/features/copilot
ActionsCI/CD and automationhttps://github.com/features/actions
Code QualityQuality analysis, fixes, and enforcementhttps://github.com/features/code-quality
CodespacesCloud development environmentshttps://github.com/features/codespaces
Code SecurityVulnerability detection and remediationhttps://github.com/security/advanced-security/code-security
Secret ProtectionSecret scanning and leak preventionhttps://github.com/security/advanced-security/secret-protection
All Featureshttps://github.com/features
Documentationhttps://docs.github.com/en
Traininghttps://learn.github.com/skills
Certificationshttps://learn.github.com/credentials
Build with Copilothttps://github.com/features/ai
Customize Copilothttps://docs.github.com/en/copilot/how-tos/copilot-on-github/customize-copilot/customize-copilot-overview
Integrationshttps://github.com/marketplace
Trending reposhttps://github.com/trending
GitHub Sponsorshttps://github.com/open-source/sponsors
Developer articleshttps://github.com/resources/articles
ChangelogYour source for the latest features, improvements, and fixes across GitHub products, all in one place.https://github.blog/changelog/
Enterpriseshttps://github.com/enterprise
Teamhttps://github.com/team
Startupshttps://github.com/enterprise/startups
Nonprofitshttps://github.com/solutions/industry/nonprofits
Healthcarehttps://github.com/solutions/industry/healthcare
Financial serviceshttps://github.com/solutions/industry/financial-services
Manufacturinghttps://github.com/solutions/industry/manufacturing
Governmenthttps://github.com/solutions/industry/government
See all industrieshttps://github.com/solutions/industry
Why GitHubhttps://github.com/why-github
Customer Storieshttps://github.com/customer-stories
Business insightshttps://github.com/solutions/executive-insights
Trust Centerhttps://github.com/trust-center
GitHub Advanced SecurityEnterprise-grade code securityhttps://github.com/security/advanced-security
Copilot for businessEnterprise-grade AI featureshttps://github.com/features/copilot/copilot-business
Premium SupportEnterprise-grade 24/7 supporthttps://github.com/enterprise/premium-support
Documentationhttps://docs.github.com/en
Resource centerhttps://github.com/resources
Bloghttps://github.blog/
Events & webinarshttps://github.com/resources/events
Community Forumhttps://github.com/orgs/community/discussions
Customer Storieshttps://github.com/customer-stories
Integrationshttps://github.com/marketplace
Customer supporthttps://help.github.com/
Traininghttps://learn.github.com/skills
GitHub Statushttps://www.githubstatus.com/
Abouthttps://github.com/about
Partnershttps://github.com/partners
Changeloghttps://github.blog/changelog/
GitHub UniverseThe event for developers, by developers — talks, workshops, and what’s next for GitHub.https://githubuniverse.com/
Pricinghttps://github.com/pricing
Sign inhttps://github.com/login?return_to=https%3A%2F%2Fgithub.com%2Fangular%2Fangular%2Fissues%2F23135
Sign uphttps://github.com/signup?ref_cta=Sign+up&ref_loc=header+logged+out&ref_page=%2F%3Cuser-name%3E%2F%3Crepo-name%3E%2Fvoltron%2Fissues_fragments%2Fissue_layout&source=header-repo&source_repo=angular%2Fangular
Reloadhttps://github.com/angular/angular/issues/23135
Reloadhttps://github.com/angular/angular/issues/23135
Reloadhttps://github.com/angular/angular/issues/23135
angularhttps://github.com/angular
angularhttps://github.com/angular/angular
Codehttps://github.com/angular/angular
Issues835 (835)https://github.com/angular/angular/issues
Pull requests141 (141)https://github.com/angular/angular/pulls
Discussionshttps://github.com/angular/angular/discussions
Actionshttps://github.com/angular/angular/actions
Projectshttps://github.com/angular/angular/projects
Security and quality40 (40)https://github.com/angular/angular/security
Insightshttps://github.com/angular/angular/insights
https://github.com/angular/angular
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23135
New issuehttps://github.com/login?return_to=https://github.com/angular/angular/issues/23135
Angular service worker stop working after going offlinehttps://github.com/angular/angular/issues/23135#top
https://github.com/klauserber
klauserberhttps://github.com/klauserber
on Apr 3, 2018https://github.com/angular/angular/issues/23135#issue-310734787
https://stackblitz.comhttps://stackblitz.com
http://localhost:8080http://localhost:8080
http://localhost:8080/assets/test.txthttp://localhost:8080/assets/test.txt
https://user-images.githubusercontent.com/9998995/38234879-8262bfd4-371f-11e8-8e7c-242b1d987700.png
https://user-images.githubusercontent.com/9998995/38234932-ad28a756-371f-11e8-8a1c-7ef06e36ed4c.png
http://localhost:8080/ngsw/statehttp://localhost:8080/ngsw/state
https://user-images.githubusercontent.com/9998995/38235095-3d38cd8a-3720-11e8-8f12-26f7ffaaa5e3.png
https://user-images.githubusercontent.com/9998995/38235203-8d54a0e6-3720-11e8-8a3e-653a413177c8.png
https://user-images.githubusercontent.com/9998995/38235254-be944012-3720-11e8-9890-fd135797b4e0.png
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Apr 3, 2018https://github.com/angular/angular/issues/23135#issuecomment-378196042
#22883https://github.com/angular/angular/pull/22883
ae9c25fhttps://github.com/angular/angular/commit/ae9c25ff3dd635115160f107135ddc26f43fac1c
gkalpakhttps://github.com/gkalpak
completedhttps://github.com/angular/angular/issues?q=is%3Aissue%20state%3Aclosed%20archived%3Afalse%20reason%3Acompleted
on Apr 3, 2018https://github.com/angular/angular/issues/23135#event-1553704156
https://github.com/junraemon
junraemonhttps://github.com/junraemon
on Jun 6, 2018https://github.com/angular/angular/issues/23135#issuecomment-395034710
https://github.com/gkalpak
gkalpakhttps://github.com/gkalpak
on Jun 7, 2018https://github.com/angular/angular/issues/23135#issuecomment-395565604
#22883 (comment)https://github.com/angular/angular/pull/22883#issuecomment-386798035
https://github.com/apps/angular-automatic-lock-bot
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/23135#issuecomment-531322196
automatic conversation locking policyhttps://github.com/angular/angular/blob/67d80f/docs/GITHUB_PROCESS.md#conversation-locking
angular-automatic-lock-bothttps://github.com/apps/angular-automatic-lock-bot
on Sep 13, 2019https://github.com/angular/angular/issues/23135#event-2633033371
Sign up for freehttps://github.com/signup?return_to=https://github.com/angular/angular/issues/23135
Sign in to commenthttps://github.com/login?return_to=https://github.com/angular/angular/issues/23135
https://github.com
Termshttps://docs.github.com/site-policy/github-terms/github-terms-of-service
Privacyhttps://docs.github.com/site-policy/privacy-policies/github-privacy-statement
Securityhttps://github.com/security
Statushttps://www.githubstatus.com/
Communityhttps://github.community/
Docshttps://docs.github.com/
Contacthttps://support.github.com?tags=dotcom-footer

Viewport: width=device-width


URLs of crawlers that visited me.